powerbi-visuals-tools 3.4.2 → 4.0.3

package/.vscode/launch.json

@@ -22,8 +22,26 @@
             "name": "pbiviz-start t1",
             "cwd": "${workspaceFolder}\\testGround\\t1",
             "program": "${workspaceFolder}\\bin\\pbiviz.js",
+            "args": [
+                "start"
+            ]
+        },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "pbiviz-start t1 Linux",
+            "cwd": "${workspaceFolder}/testGround/t1",
+            "program": "${workspaceFolder}/bin/pbiviz.js",
             "args": ["start"]
         },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "pbiviz-package t1",
+            "cwd": "${workspaceFolder}\\testGround\\t1",
+            "program": "${workspaceFolder}\\bin\\pbiviz.js",
+            "args": ["package"]
+        },
         {
             "type": "node",
             "request": "launch",

package/Changelog.md

@@ -2,11 +2,31 @@
 
 This page contains information about changes to the PowerBI Visual Tools (pbiviz).
 
+## 4.0.3
+### **⚠ BREAKING CHANGES**
+* Removed polyfills and 'Internet Explorer` browser support
+* Removed `--target` option for `pbiviz-start` and `pbiviz-package` commands
+
+## 4.0.2
+* Fix custom visual package upload to desktop version of PowerBI
+* Removed environment logging in this version 
+* Downgraded "powerbi-visuals-webpack-plugin"
+
+## 4.0.0
+* This release version includes changes from previous betta versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3.
+
+## 3.4.3
+
+* Updated webpack assets compilation
+* Added environment logging for debugging purposes
+* Fixed certificate date verification for different regional settings
+
 ## 3.4.2
 
 * Migrated from `request` lib to node `https` standard method
 * Removed `friendly-errors-webpack-plugin` usage
 * Removed or updated deprecated dependencies
+* Fixed vulnerabilities
 
 ## 3.4.1
 

package/bin/pbiviz-package.js

@@ -39,7 +39,6 @@ let options = process.argv;
 const minAPIversion = config.constants.minAPIversion;
 
 program
-    .option('-t, --target [target]', 'Enable babel loader to compile JS into ES5 standart', 'es5')
     .option('--resources', "Produces a folder containing the pbiviz resource files (js, css, json)", false)
     .option('--no-pbiviz', "Doesn't produce a pbiviz file (must be used in conjunction with resources flag)", false)
     .option('--no-minify', "Doesn't minify the js in the package (useful for debugging)", true)
@@ -76,7 +75,6 @@ VisualPackage.loadVisualPackage(cwd).then((visualPackage) => {
         generatePbiviz: program.pbiviz,
         minifyJS: program.minify,
         minify: program.minify,
-        target: program.target,
         compression: program.compression
     }).then(({ webpackConfig }) => {
         let compiler = webpack(webpackConfig);

package/bin/pbiviz-start.js

@@ -42,7 +42,6 @@ const options = process.argv;
 const minAPIversion = config.constants.minAPIversion;
 
 program
-    .option('-t, --target [target]', 'Enable babel loader to compile JS into ES5 standart')
     .option('-p, --port [port]', 'set the port listening on')
     .option('-m, --mute', 'mute error outputs')
     .option('-d, --drop', 'drop outputs into output folder');
@@ -71,7 +70,6 @@ VisualPackage.loadVisualPackage(cwd).then((visualPackage) => {
         generatePbiviz: false,
         minifyJS: false,
         minify: false,
-        target: typeof program.target === 'undefined' ? "es5" : program.target,
         devServerPort: program.port
     })
         .then(({ webpackConfig }) => {

package/bin/pbiviz.js

@@ -35,6 +35,8 @@ let config = require(confPath);
 let args = process.argv;
 let CertificateTools = require("../lib/CertificateTools");
 
+ConsoleWriter.info(`${npmPackage.name} version - ${npmPackage.version}`);
+
 program
     .version(npmPackage.version)
     .command('new [name]', 'Create a new visual')

package/config.json

@@ -1 +1 @@
-{"templates":{"visuals":"templates/visuals","pbiviz":"templates/pbiviz.json.template","plugin":"templates/plugin.ts.template","package":"templates/package.json.template"},"generate":{"apiVersion":"3.8.0"},"constants":{"minAPIversion":"3.2.0"},"build":{"precompileFolder":".tmp/precompile","dropFolder":".tmp/drop","js":"tmp.visual.js","css":"visual.css","stats":"../../webpack.statistics.html"},"package":{"dropFolder":"dist"},"server":{"root":"webRoot","assetsRoute":"/assets","privateKey":"certs/PowerBICustomVisualTest_private.key","certificate":"certs/PowerBICustomVisualTest_public.crt","pfx":"certs/PowerBICustomVisualTest_public.pfx","port":"8080","passphrase":"29494060387342613"},"visualTemplates":{"circlecard":"https://codeload.github.com/microsoft/powerbi-visuals-circlecard-react/zip/master"}}
+{"templates":{"visuals":"templates/visuals","pbiviz":"templates/pbiviz.json.template","plugin":"templates/plugin.ts.template","package":"templates/package.json.template"},"generate":{"apiVersion":"3.8.0"},"constants":{"minAPIversion":"3.2.0"},"build":{"precompileFolder":".tmp/precompile","dropFolder":".tmp/drop","js":"tmp.visual.js","css":"visual.css","stats":"../../webpack.statistics.html"},"package":{"dropFolder":"dist"},"server":{"root":"webRoot","assetsRoute":"/assets","privateKey":"certs/PowerBICustomVisualTest_private.key","certificate":"certs/PowerBICustomVisualTest_public.crt","pfx":"certs/PowerBICustomVisualTest_public.pfx","port":"8080","passphrase":"9982422364989703"},"visualTemplates":{"circlecard":"https://codeload.github.com/microsoft/powerbi-visuals-circlecard-react/zip/master"}}

package/lib/CertificateTools.js

@@ -56,7 +56,7 @@ async function createCertFile(config, open) {
     const subject = "localhost";
     const keyLength = 2048;
     const algorithm = "sha256";
-    const validPeriod = 180;
+    const validPeriod = 365;
 
     if (typeof open === 'undefined') {
         open = false;
@@ -389,10 +389,8 @@ async function veryfyCertFile(keyPath, certPath, pfxPath, passphrase) {
             if (!fs.existsSync(pfxPath) || !passphrase) {
                 return false;
             }
-            let certStr = await exec(`certutil -p ${passphrase} -dump "${pfxPath}"`);
-            let certStrSplitted = certStr.split('\r\n');
-            let regex = /(?<=: ).*/;
-            endDateStr = regex.exec(certStrSplitted[6]);
+            let certStr = await exec(`powershell.exe (New-Object System.Security.Cryptography.X509Certificates.X509Certificate2('${pfxPath}','${passphrase}')).NotAfter.ToString('yyyy-MM-dd HH:mm:ss')`);
+            endDateStr = certStr.trim();
         }
         // For Linux and Mac/darwin OS:
         else if (os.platform() === "linux" || os.platform() === "darwin") {
@@ -402,8 +400,8 @@ async function veryfyCertFile(keyPath, certPath, pfxPath, passphrase) {
             endDateStr = await exec(`openssl x509 -enddate -noout -in ${certPath} | cut -d = -f 2`);
         }
 
-        let endDate = new Date(Date.parse(endDateStr));
-        verifyCertDate = (endDate - new Date()) > certSafePeriod;
+        let endDate = Date.parse(endDateStr);
+        verifyCertDate = (endDate - Date.now()) > certSafePeriod;
         if (verifyCertDate) {
             ConsoleWriter.info(`Certificate is valid.`);
         } else {

package/lib/WebPackWrap.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const fs = require('fs-extra');
+const os = require('os');
 const path = require('path');
 const webpack = require('webpack');
 const config = require('../config.json');
@@ -14,6 +15,7 @@ const exec = util.promisify(require('child_process').exec);
 const CertificateTools = require("../lib/CertificateTools");
 const visualPlugin = "visualPlugin.ts";
 const lodashCloneDeep = require('lodash.clonedeep');
+const npmPackage = require('../package.json');
 
 class WebPackGenerator {
 
@@ -80,11 +82,14 @@ class WebPackGenerator {
                 directory: path.join(visualPackage.basePath, config.build.dropFolder),
                 publicPath: config.server.assetsRoute
             },
-            https: {
-                key: options.key,
-                cert: options.cert,
-                pfx: options.pfx,
-                passphrase: options.passphrase
+            server: {
+                type: 'https',
+                options: {
+                    key: options.key,
+                    cert: options.cert,
+                    pfx: options.pfx,
+                    passphrase: options.passphrase
+                }
             }
         };
     }
@@ -108,6 +113,16 @@ class WebPackGenerator {
         }
     }
 
+    async getEnvironmentDetails() {
+        let env = {};
+        env.nodeVersion = process.versions.node;
+        env.osPlatform = await os.platform();
+        env.osVersion = await os.version ? os.version() : "undefined";
+        env.osReleaseVersion = await os.release();
+        env.toolsVersion = npmPackage.version;
+        return env;
+    }
+
     async configureCustomVisualsWebpackPlugin(visualPackage, options, tsconfig) {
         let pluginConfiguration = lodashCloneDeep(visualPackage.config);
         //(?=\D*$) - positive look-ahead to find last version symbols and exclude any non-digit symbols after the version.
@@ -127,6 +142,8 @@ class WebPackGenerator {
             await this.installAPIpackage();
         }
 
+        // pluginConfiguration.env = await this.getEnvironmentDetails();
+
         let api = WebPackGenerator.loadAPIPackage(visualPackage);
         pluginConfiguration.apiVersion = api.version;
         pluginConfiguration.capabilitiesSchema = api.schemas.capabilities;
@@ -179,13 +196,12 @@ class WebPackGenerator {
                 new webpack.SourceMapDevToolPlugin({
                     filename: '[file].map',
                     publicPath: `https://localhost:${this.webpackConfig.devServer.port}/assets/`
-                  })
+                })
             );
         }
     }
 
-    setTarget({
-        target = "es5",
+    useLoader({
         fast = false
     }) {
         let tsOptions = {};
@@ -195,62 +211,15 @@ class WebPackGenerator {
                 experimentalWatchApi: false
             };
         }
-        if (target === "es5") {
-            let babelOptions = {
-                "presets": [
-                    [
-                        require.resolve('@babel/preset-env'),
-                        {
-                            "targets": {
-                                "ie": "11"
-                            },
-                            useBuiltIns: "entry",
-                            corejs: 3,
-                            modules: false
-                        }
-                    ]
-                ],
-                plugins: [require.resolve("@babel/plugin-syntax-dynamic-import")],
-                sourceType: "unambiguous",
-                cacheDirectory: path.join(config.build.precompileFolder, "babelCache")
-            };
-
-            this.webpackConfig.module.rules.push({
-                test: /(\.ts)x|\.ts$/,
-                include: /powerbi-visuals-|src|precompile[/\\]visualPlugin.ts/,
-                exclude: [/core-js/],
-                use: [
-                    {
-                        loader: require.resolve('babel-loader'),
-                        options: babelOptions
-                    },
-                    {
-                        loader: require.resolve('ts-loader'),
-                        options: tsOptions
-                    }
-                ]
-            },
+        this.webpackConfig.module.rules.push({
+            test: /(\.ts)x?$/,
+            use: [
                 {
-                    test: /(\.js)x|\.js$/,
-                    exclude: [/core-js/],
-                    use: [
-                        {
-                            loader: require.resolve('babel-loader'),
-                            options: babelOptions
-                        }
-                    ]
-                });
-        } else {
-            this.webpackConfig.module.rules.push({
-                test: /(\.ts)x?$/,
-                use: [
-                    {
-                        loader: require.resolve('ts-loader'),
-                        options: tsOptions
-                    }
-                ]
-            });
-        }
+                    loader: require.resolve('ts-loader'),
+                    options: tsOptions
+                }
+            ]
+        });
     }
 
     async prepareWebPackConfig(visualPackage, options, tsconfig) {
@@ -266,8 +235,7 @@ class WebPackGenerator {
         await this.appendPlugins(options, visualPackage, tsconfig);
         await this.configureDevServer(visualPackage, options.devServerPort);
         await this.configureVisualPlugin(options, tsconfig, visualPackage);
-        this.setTarget({
-            target: options.target,
+        this.useLoader({
             fast: options.fast
         });
 
@@ -292,7 +260,6 @@ class WebPackGenerator {
         generatePbiviz: false,
         minifyJS: true,
         minify: true,
-        target: "es5",
         devServerPort: 8080,
         fast: false,
         compression: 0

package/lib/webpack.config.js

@@ -121,7 +121,7 @@ module.exports = {
         compress: true,
         port: 8080,
         hot: false,
-        https: true,
+        server: 'https',
         headers: {
             "access-control-allow-origin": "*",
             "cache-control": "public, max-age=0"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-tools",
-  "version": "3.4.2",
+  "version": "4.0.3",
   "description": "Command line tool for creating and publishing visuals for Power BI",
   "main": "./lib/VisualPackage.js",
   "scripts": {
@@ -26,24 +26,16 @@
   },
   "homepage": "https://github.com/Microsoft/PowerBI-visuals-tools#readme",
   "dependencies": {
-    "@babel/core": "7.9.0",
-    "@babel/plugin-syntax-dynamic-import": "7.8.3",
-    "@babel/preset-env": "7.9.0",
-    "@babel/runtime": "7.9.2",
-    "@babel/runtime-corejs3": "7.9.2",
     "assert": "^2.0.0",
     "async": "3.2.0",
-    "babel-loader": "^8.1.0",
     "base64-inline-loader": "^2.0.1",
     "browserify-zlib": "^0.2.0",
     "buffer": "^6.0.3",
     "chalk": "3.0.0",
     "commander": "4.1.1",
     "compare-versions": "^3.6.0",
-    "connect": "3.7.0",
     "console-browserify": "^1.2.0",
     "constants-browserify": "^1.0.0",
-    "core-js": "^3.18.1",
     "crypto-browserify": "^3.12.0",
     "css-loader": "^5.2.7",
     "domain-browser": "^4.22.0",
@@ -66,7 +58,6 @@
     "punycode": "^2.1.1",
     "querystring-es3": "^0.2.1",
     "readable-stream": "^3.6.0",
-    "serve-static": "1.14.1",
     "stream-browserify": "^3.0.0",
     "stream-http": "^3.2.0",
     "string_decoder": "^1.3.0",
@@ -83,7 +74,7 @@
     "webpack-dev-server": "^4.1.0"
   },
   "devDependencies": {
-    "eslint": "6.8.0",
+    "eslint": "^7.31.0",
     "jasmine": "3.5.0",
     "jasmine-spec-reporter": "5.0.1",
     "semver": "7.1.3",

package/templates/visuals/default/package.json

@@ -13,13 +13,10 @@
     "lint": "tslint -c tslint.json -p tsconfig.json"
   },
   "dependencies": {
-    "@babel/runtime": "7.6.0",
-    "@babel/runtime-corejs2": "7.6.0",
     "@types/d3": "5.7.2",
     "d3": "5.12.0",
     "powerbi-visuals-utils-dataviewutils": "2.2.1",
-    "powerbi-visuals-api": "~3.8.0",
-    "core-js": "^3.18.1"
+    "powerbi-visuals-api": "~3.8.0"
   },
   "devDependencies": {
     "ts-loader": "6.1.0",

package/templates/visuals/default/src/visual.ts

@@ -25,7 +25,6 @@
 */
 "use strict";
 
-import "core-js/stable";
 import "./../style/visual.less";
 import powerbi from "powerbi-visuals-api";
 import VisualConstructorOptions = powerbi.extensibility.visual.VisualConstructorOptions;

package/templates/visuals/slicer/package.json

@@ -8,13 +8,9 @@
   },
   "dependencies": {
     "d3": "5.10.0",
-    "powerbi-visuals-utils-dataviewutils": "^2.2.1",
-    "core-js": "3.18.1"
+    "powerbi-visuals-utils-dataviewutils": "^2.2.1"
   },
   "devDependencies": {
-    "@babel/polyfill": "^7.4.4",
-    "@babel/runtime": "^7.5.5",
-    "@babel/runtime-corejs2": "^7.5.5",
     "@types/d3": "5.7.2",
     "powerbi-visuals-api": "~3.8.0",
     "tslint": "^5.18.0",

package/templates/visuals/slicer/src/visual.ts

@@ -25,7 +25,6 @@
 */
 "use strict";
 
-import "core-js/stable";
 import "./../style/visual.less";
 import powerbi from "powerbi-visuals-api";
 import VisualConstructorOptions = powerbi.extensibility.visual.VisualConstructorOptions;

package/templates/visuals/table/package.json

@@ -8,14 +8,10 @@
   },
   "dependencies": {
     "d3": "5.10.0",
-    "powerbi-visuals-utils-dataviewutils": "^2.2.1",
-    "core-js": "^3.18.1"
+    "powerbi-visuals-utils-dataviewutils": "^2.2.1"
   },
   "devDependencies": {
     "powerbi-visuals-api": "~3.8.0",
-    "@babel/polyfill": "^7.4.4",
-    "@babel/runtime": "^7.5.5",
-    "@babel/runtime-corejs2": "^7.5.5",
     "@types/d3": "5.7.2",
     "tslint": "^5.18.0",
     "tslint-microsoft-contrib": "^6.2.0",

package/templates/visuals/table/src/visual.ts

@@ -26,7 +26,6 @@
 
 "use strict";
 
-import "core-js/stable";
 import "./../style/visual.less";
 import { select } from "d3-selection";
 import { transpose } from "d3-array";