powerbi-visuals-tools 3.3.2 → 3.4.3

package/.vscode/launch.json

@@ -15,6 +15,58 @@
                 "circlecard",
                 "mynewsample"
             ]
+        },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "pbiviz-start t1",
+            "cwd": "${workspaceFolder}\\testGround\\t1",
+            "program": "${workspaceFolder}\\bin\\pbiviz.js",
+            "args": ["start"]
+        },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "pbiviz-start t1 Linux",
+            "cwd": "${workspaceFolder}/testGround/t1",
+            "program": "${workspaceFolder}/bin/pbiviz.js",
+            "args": ["start"]
+        },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "pbiviz-package t1",
+            "cwd": "${workspaceFolder}\\testGround\\t1",
+            "program": "${workspaceFolder}\\bin\\pbiviz.js",
+            "args": ["package"]
+        },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "pbiviz-new circle",
+            "cwd": "${workspaceFolder}\\testGround",
+            "program": "${workspaceFolder}\\bin\\pbiviz.js",
+            "args": [
+                "new",
+                "-t",
+                "circlecard",
+                "circlecard-sample",
+                "-f"
+            ]
+        },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "test pbiviz-start",
+            "cwd": "${workspaceRoot}",
+            "program": "${workspaceFolder}\\bin\\pbiviz.js",
+            "args": [
+                "new",
+                "-t",
+                "circlecard",
+                "mynewsample",
+                "-f"
+            ]
         }
     ]
 }

package/Changelog.md

@@ -2,139 +2,203 @@
 
 This page contains information about changes to the PowerBI Visual Tools (pbiviz).
 
-# 3.3.2
+## 3.4.3
+
+* Updated webpack assets compilation
+* Added environment logging for debugging purposes
+* Fixed certificate date verification for different regional settings
+
+## 3.4.2
+
+* Migrated from `request` lib to node `https` standard method
+* Removed `friendly-errors-webpack-plugin` usage
+* Removed or updated deprecated dependencies
+* Fixed vulnerabilities
+
+## 3.4.1
+
+* Fixed certificate verification for 'non-english' environment
+
+## 3.4.0
+
+### **⚠ BREAKING CHANGES**
+
+* Removed old API ( 2.6.0 and bellow) templates logic
+* Removed `pbiviz-update` method
+* Removed `--api [version]` flag
+* Migrated to `webpack-dev-server` v4
+
+## 3.3.2
+
 * Extended `"powerbi-visuals-api"` usage up to version 3.2.0 and higher
 
 ## 3.3.1
+
 * Fixed certificate issues
 * Fixed an issue when previous API version was used for a new package build
 
 ## 3.3.0
+
 ### **⚠ BREAKING CHANGES**
+
 * Starting from tools version 3.3.0, it expects usage of ["powerbi-visuals-api": ">=3.8.0"](https://github.com/microsoft/powerbi-visuals-api/blob/master/CHANGELOG.md#382)
+
 ### **Features**
+
 * Added support for CV modal dialog
 
 ## 3.2.2
+
 * Removed npm-force-resolutions package
 
 ## 3.2.1
+
 * Fixed preinstall to prevent instalation failure because of npm-force-resolutions
 * Fixed pbiviz.json dependencies option usage
 
 ## 3.2.0
+
 * Fixed LessCompiler for old visuals
 
 ## 3.1.19
+
 * Fixed webpack Node.js polyfill issue in webpack 5+"
 
 ## 3.1.18
+
 * Removed deprecated packages
 
 ## 3.1.16
+
 * Added visuals compatibility with webpack v5
 * Removed lodash: _.template, ._findindex, .difference
 * Packages update
 
 ## 3.1.15
+
 * Webpack plugin update
 * npm audit package-lock patch
 
 ## 3.1.14
+
 * Fix output library name for debug mode
 
 ## 3.1.12
+
 * Command package rolling back to fix issues with some commands running
 
 ## 3.1.11
-* Packages update. Fixed https://github.com/microsoft/PowerBI-visuals-tools/issues/304
+
+* Packages update. Fixed <https://github.com/microsoft/PowerBI-visuals-tools/issues/304>
 
 ## 3.1.10
+
 * Packages update: Uglify-js is replaced by Terser
 
 ## 3.1.9
+
 * Fix loading the old visual projects
 * Fix loading old [`formattingutils`](https://github.com/microsoft/powerbi-visuals-utils-formattingutils/tree/72a136aca836e60042be35b1cd2ae10a07837ba8) in the old visual projects.
 
 ## 3.1.8
+
 * Update `powerbi-visuals-webpack-plugin` to 2.2.1
 
 ## 3.1.7
+
 * Fix vscode workspace settings template
 * Fix certificate tool error handling
 
 ## 3.1.6
+
 * Fix webpack configureation include regex
 * Templates update
 
 ## 3.1.5
+
 * Templates update
 
 ## 3.1.4
+
 * Packages update
 
 ## 3.1.3
+
 * Remove `@babel/polyfill`
 * Replace `webpack-visualizer-plugin` by `webpack-bundle-analyzer`
 
 ## 3.1.2
-* Add extensions for *.svg *.eot files to `base64-inline-loader` configuration
+
+* Add extensions for *.svg*.eot files to `base64-inline-loader` configuration
 * Exclude `code-js` package to process by Babel
 * Include `@babel/plugin-syntax-dynamic-import` plugin for Babel
 * Update `core-js` package to version 3.x.x.
 
 ## 3.1.1
+
 * Add `base64-inline-loader` to load images
 
 ## pbiviz v3.1.0
+
 * Release. Now Webpack is default builder for Custom Visuals.
 * What’s new in powerbi-visuals-tools v3?
-	* TypeScript v3.0.1 by default
-	* ES6 Modules supported
-	* New versions of D3v5 and other external libraries are supported
-	* Reduced package size
-	* Improved API performance
-* For the full details please check [this article](https://microsoft.github.io/PowerBI-visuals/docs/how-to-guide/migrating-to-powerbi-visuals-tools-3-0/). 
-
-## pbiviz v2.5.0 
+  * TypeScript v3.0.1 by default
+  * ES6 Modules supported
+  * New versions of D3v5 and other external libraries are supported
+  * Reduced package size
+  * Improved API performance
+* For the full details please check [this article](https://microsoft.github.io/PowerBI-visuals/docs/how-to-guide/migrating-to-powerbi-visuals-tools-3-0/).
+
+## pbiviz v2.5.0
+
 * Added Analytics Pane support
 Note: API v2.4.0 skipped as it does not include any public changes
 
 ## pbiviz v2.3.0
+
 * custom visuals now support a landing page
 
 ## pbiviz v2.2.2
+
 * Update package-lock.json to fix vulnerabilities
 
 ## pbiviz v2.2.1
+
 * Deprecated `applySelectionFilter` from `ISelectionManager`
 
 ## pbiviz v3.0.12 Beta
+
 * Compression option for compressing visual package
 * Fix launch webpack build triggering
 * Update powerbi-visuals-webpack-plugin to 2.1.0
 
 ## pbiviz v3.0.11 Beta
-* Add support to import *.css and *.less files
+
+* Add support to import *.css and*.less files
 * Fix reloading capabilities.json
 * Resolve issue of starting dev server after copy certs from global instance
 * Serve old visual project by nodejs server instead webpack dev server
 
 ## pbiviz v3.0.10 Beta
+
 * Resolve dev server certificates from global instance of pbiviz.
 * Replace VisualServer.js by webpack-dev-server
 
 ## pbiviz v3.0.9 Beta
+
 * Set `sourceType` to "unambiguous" for babel configuration
 
 ## pbiviz v3.0.8 Beta
+
 * Update powerbi-visuals-webpack-plugin to 2.0.0
 * Remove minification by babel (remove `babel-preset-minify` package).
 
 ## pbiviz v3.0.7 Beta
+
 * Update powerbi-visuals-webpack-plugin to 1.0.15
 
 ## pbiviz v3.0.6 Beta
+
 * Install the latest patch of `powerbi-visuals-api`
 * The `pbiviz.json` values of visual templates overrides global template values
 * Remove unnecessary `setApiVersion` and `updateApi` from `VisualGenerator`
@@ -142,85 +206,110 @@ Note: API v2.4.0 skipped as it does not include any public changes
 * Update powerbi-visuals-plugin to version 1.0.13
 
 ## pbiviz v3.0.5 Beta
+
 * Prevent using define function in context of module
 
 ## pbiviz v3.0.4 Beta
+
 * Update powerbi-visuals-plugin to version 1.0.11
 
 ## pbiviz v3.0.3 Beta
+
 * Update powerbi-visuals-plugin to version 1.0.10
 * Remove jasmine-node package
 
 ## pbiviz v3.0.2 Beta
+
 * Tools observe changes in `pbiviz.json` and `capabilities.json` files and rebuild the visual.
 * `webpack-visualizer-plugin` replaced by `webpack-bundle-analyzer` to visualize the webpack bundle stats.
 
 ## pbiviz v3.0.1 Beta
+
 * Webpack based tools
 
-## pbiviz v2.0.2 
+## pbiviz v2.0.2
+
 * Skip precompilation for the visual with ES6 modules
 
 ## pbiviz v2.0.1
+
 * Update package.json. Fix package installation
 
 ## pbiviz v2.0.0
+
 * TypeScript external modules support
 
 ## pbiviz v1.12.1
-* Generate certificates on development server starts 
+
+* Generate certificates on development server starts
 
 ## pbiviz v1.11.3
+
 * Resolve PowerShell params issue on Win8.
 
 ## pbiviz v1.11.2
+
 * Resolve PowerShell script launching issue.
 
 ## pbiviz v1.11.1
+
 * Check certificate path in `--install-cert` command.
 
 ## pbiviz v1.11.0
+
 * Added `selectionManager.registerOnSelectCallback()` method for Report Bookmarks support
 
 ## pbiviz v1.10.2
+
 * Added `pbiviz --create-cert` for generating new unique certificate
 
 ## pbiviz v1.10.1
+
 * Increase typescript to 2.3.3 version
 
 ## pbiviz v1.10.0
+
 * Added ILocalizationManager
 * Upgrade dependencies
 * Added Authentication API call support
 
 ## pbiviz v1.9.0
+
 * Added launchUrl API call support
 
 ## pbiviz v1.8.1
+
 * FIX: Localization schema will be ignored if API doesn't support localization
 
 ## pbiviz v1.8.0
+
 * Added new type "fillRule" (gradient) support in capabilities schema
 * Added "rule" property support in capabilities schema for object properties
 * Fixed sub commands help output in "Using:" section
 
 ## pbiviz v1.7.5
-* Return innerHTML method for RHTML visual sample 
+
+* Return innerHTML method for RHTML visual sample
 
 ## pbiviz v1.7.4
+
 * Remove innerHTML method from sample visual
 
 ## pbiviz v1.7.3
-* Added RESJSON support 
+
+* Added RESJSON support
 
 ## pbiviz v1.7.2
+
 * Add name validation to pbiviz new command, restrict usage of symbols in the file visual name.
 
 ## pbiviz v1.7.1
+
 * Added visual name validation
 * Added auto-install npm dependencies
 
 ## pbiviz v1.6.5
+
 * Updated npm dependencies
 * Fixed settings generation
 

package/bin/pbiviz-new.js

@@ -36,8 +36,7 @@ const options = process.argv;
 
 program
     .option('-f, --force', 'force creation (overwrites folder if exists)')
-    .option('-t, --template [template]', 'use a specific template (default, table, slicer, rvisual, rhtml)')
-    .option('--api-version [version]', 'use a specific api version (1.0.0, 1.1.0, 1.2.0, ...)');
+    .option('-t, --template [template]', 'use a specific template (default, table, slicer, rvisual, rhtml)');
 
 for (let i = 0; i < options.length; i++) {
     if (options[i] == '--help' || options[i] == '-h') {
@@ -64,24 +63,16 @@ if (program.force) {
     ConsoleWriter.warn('Running with force flag. Existing files will be overwritten');
 }
 
-if (program.apiVersion && parseFloat(program.apiVersion) < parseFloat('3.2.0')) {
-    ConsoleWriter.error(`Visual creation failed, please use 'powerbi-visuals-api' 3.2.0 or above to build a visual.`);
-    process.exit(9);
-}
-
 let generateOptions = {
     force: program.force,
-    template: program.template,
-    apiVersion: program.apiVersion
+    template: program.template
 };
 
-
 if (config.visualTemplates[generateOptions.template]) {
     new TemplateFetcher({
         force: program.force,
         templateName: generateOptions.template,
-        visualName: visualName,
-        apiVersion: program.apiVersion
+        visualName: visualName
     }).fetch();
 } else {
     VisualPackage.createVisualPackage(cwd, visualName, generateOptions).then(() => {

package/bin/pbiviz-package.js

@@ -26,13 +26,17 @@
 
 "use strict";
 
-let program = require('commander');
-let VisualPackage = require('../lib/VisualPackage');
-let ConsoleWriter = require('../lib/ConsoleWriter');
-let WebPackWrap = require('../lib/WebPackWrap');
+const program = require('commander');
+const compareVersions = require("compare-versions");
+const config = require('../config.json');
+const VisualPackage = require('../lib/VisualPackage');
+const ConsoleWriter = require('../lib/ConsoleWriter');
+const WebPackWrap = require('../lib/WebPackWrap');
 const webpack = require("webpack");
-let CommandHelpManager = require('../lib/CommandHelpManager');
+const CommandHelpManager = require('../lib/CommandHelpManager');
+
 let options = process.argv;
+const minAPIversion = config.constants.minAPIversion;
 
 program
     .option('-t, --target [target]', 'Enable babel loader to compile JS into ES5 standart', 'es5')
@@ -59,9 +63,9 @@ if (!program.pbiviz && !program.resources) {
 }
 
 VisualPackage.loadVisualPackage(cwd).then((visualPackage) => {
-    if (parseFloat(visualPackage.config.apiVersion) < parseFloat('3.2.0')) {
+    if (visualPackage.config.apiVersion && compareVersions.compare(visualPackage.config.apiVersion, minAPIversion, "<")) {
         ConsoleWriter.error(`Package wasn't created, your current API is '${visualPackage.config.apiVersion}'.
-        Please use 'powerbi-visuals-api' 3.2.0 or above to build a visual.`);
+        Please use 'powerbi-visuals-api' ${minAPIversion} or above to build a visual.`);
         process.exit(9);
     }
     ConsoleWriter.info('Building visual...');
@@ -99,7 +103,7 @@ function displayCertificationRules() {
     ConsoleWriter.blank();
     ConsoleWriter.warn("Please, make sure that the visual source code matches to requirements of certification:");
     ConsoleWriter.blank();
-    ConsoleWriter.info("Visual must use API v3.8 and above");
+    ConsoleWriter.info(`Visual must use API v${minAPIversion} and above`);
     ConsoleWriter.info("The project repository must:");
     ConsoleWriter.info("Include package.json and package-lock.json;");
     ConsoleWriter.info("Not include node_modules folder");

package/bin/pbiviz-start.js

@@ -27,6 +27,8 @@
 "use strict";
 
 const program = require('commander');
+const compareVersions = require("compare-versions");
+const config = require('../config.json');
 const VisualPackage = require('../lib/VisualPackage');
 const WebpackDevServer = require("webpack-dev-server");
 const ConsoleWriter = require('../lib/ConsoleWriter');
@@ -36,11 +38,8 @@ const CommandHelpManager = require('../lib/CommandHelpManager');
 const fs = require('fs-extra');
 const path = require('path');
 
-let https = require('https');
-let connect = require('connect');
-let serveStatic = require('serve-static');
-
 const options = process.argv;
+const minAPIversion = config.constants.minAPIversion;
 
 program
     .option('-t, --target [target]', 'Enable babel loader to compile JS into ES5 standart')
@@ -60,13 +59,14 @@ program.parse(options);
 let cwd = process.cwd();
 let server;
 VisualPackage.loadVisualPackage(cwd).then((visualPackage) => {
-    if (parseFloat(visualPackage.config.apiVersion) < parseFloat('3.2.0')) {
+    if (visualPackage.config.apiVersion && compareVersions.compare(visualPackage.config.apiVersion, minAPIversion, "<")) {
         ConsoleWriter.error(`Can't start the visual because of the current API is '${visualPackage.config.apiVersion}'.
-        Please use 'powerbi-visuals-api' 3.2.0 or above to build a visual.`);
+        Please use 'powerbi-visuals-api' ${minAPIversion} or above to build a visual.`);
         throw new Error(`Invalid API version.`);
     }
     new WebPackWrap().applyWebpackConfig(visualPackage, {
         devMode: true,
+        devtool: "source-map",
         generateResources: true,
         generatePbiviz: false,
         minifyJS: false,
@@ -74,13 +74,13 @@ VisualPackage.loadVisualPackage(cwd).then((visualPackage) => {
         target: typeof program.target === 'undefined' ? "es5" : program.target,
         devServerPort: program.port
     })
-        .then(({ webpackConfig, oldProject }) => {
+        .then(({ webpackConfig }) => {
             let compiler = webpack(webpackConfig);
             ConsoleWriter.blank();
             ConsoleWriter.info('Starting server...');
             // webpack dev server serves bundle from disk instead memory
             if (program.drop) {
-                webpackConfig.devServer.before = (app) => {
+                webpackConfig.devServer.onBeforeSetupMiddleware = (devServer) => {
                     let setHeaders = (res) => {
                         Object.getOwnPropertyNames(webpackConfig.devServer.headers)
                             .forEach(property => res.header(property, webpackConfig.devServer.headers[property]));
@@ -96,54 +96,28 @@ VisualPackage.loadVisualPackage(cwd).then((visualPackage) => {
                         'visual.css',
                         'pbiviz.json'
                     ].forEach(asset => {
-                        app.get(`${webpackConfig.devServer.publicPath}/${asset}`, function (req, res) {
+                        devServer.app.get(`${webpackConfig.devServer.publicPath}/${asset}`, function (req, res) {
                             setHeaders(res);
-                            readFile(path.join(webpackConfig.devServer.contentBase, asset), res);
+                            readFile(path.join(webpackConfig.devServer.static.directory, asset), res);
                         });
                     });
                 };
             }
-            // server old project by NodeJS server, need to skip build step
-            if (!oldProject) {
-                server = new WebpackDevServer(compiler, {
-                    ...webpackConfig.devServer,
-                    hot: !program.drop,
-                    writeToDisk: program.drop
-                });
-                server.listen(webpackConfig.devServer.port, () => {
-                    ConsoleWriter.info(`Server listening on port ${webpackConfig.devServer.port}`);
-                });
-            } else {
-                compiler.watch({
-                        aggregateTimeout: 1000, // wait so long for more changes
-                        poll: false, // use polling instead of native watchers
-                        ignored: /node_modules/
-                    },
-                    function (err) {
-                        if (err) {
-                            ConsoleWriter.error('Visual rebuild failed');
-                            ConsoleWriter.error(err);
-                            return;
-                        }
-                        ConsoleWriter.info('Visual rebuild completed');
-                    }
-                );
-                const app = connect();
-                app.use((req, res, next) => {
-                    res.setHeader('Access-Control-Allow-Origin', '*');
-                    next();
-                });
-                app.use(serveStatic(webpackConfig.devServer.contentBase));
-                app.use('/' + webpackConfig.output.publicPath, serveStatic(webpackConfig.devServer.contentBase));
-                server = https.createServer({
-                    pfx: webpackConfig.devServer.https.pfx,
-                    cert: webpackConfig.devServer.https.cert,
-                    key: webpackConfig.devServer.https.key,
-                    passphrase: webpackConfig.devServer.https.passphrase
-                }, app).listen(webpackConfig.devServer, () => {
-                    ConsoleWriter.info(`Server listening on port ${webpackConfig.devServer.port}`);
-                });
-            }
+
+            server = new WebpackDevServer({
+                ...webpackConfig.devServer,
+                client: false,
+                hot: false,
+                devMiddleware: {
+                    writeToDisk: true    
+                }
+            }, compiler);
+
+            (async () => {
+                await server.start();
+                ConsoleWriter.info(`Server listening on port ${webpackConfig.devServer.port}`);
+            })();
+
         })
         .catch(e => {
             ConsoleWriter.error(e.message);

package/bin/pbiviz.js

@@ -41,7 +41,6 @@ program
     .command('info', 'Display info about the current visual')
     .command('start', 'Start the current visual')
     .command('package', 'Package the current visual into a pbiviz file')
-    .command('update [version]', 'Updates the api definitions and schemas in the current visual. Changes the version if specified')
     .option('--install-cert', 'Creates and installs localhost certificate', onOpenCertFile);
 
 //prepend logo to help screen

package/config.json

@@ -1 +1 @@
-{"templates":{"visuals":"templates/visuals","pbiviz":"templates/pbiviz.json.template","plugin":"templates/plugin.ts.template","package":"templates/package.json.template"},"generate":{"apiVersion":"3.8.0"},"build":{"precompileFolder":".tmp/precompile","dropFolder":".tmp/drop","js":"tmp.visual.js","css":"visual.css","stats":"../../webpack.statistics.html"},"package":{"dropFolder":"dist"},"server":{"root":"webRoot","assetsRoute":"/assets","privateKey":"certs/PowerBICustomVisualTest_private.key","certificate":"certs/PowerBICustomVisualTest_public.crt","pfx":"certs/PowerBICustomVisualTest_public.pfx","port":"8080","passphrase":"9163565813320611"},"visualTemplates":{"circlecard":"http://github.com/microsoft/powerbi-visuals-circlecard-react/archive/master.zip"}}
+{"templates":{"visuals":"templates/visuals","pbiviz":"templates/pbiviz.json.template","plugin":"templates/plugin.ts.template","package":"templates/package.json.template"},"generate":{"apiVersion":"3.8.0"},"constants":{"minAPIversion":"3.2.0"},"build":{"precompileFolder":".tmp/precompile","dropFolder":".tmp/drop","js":"tmp.visual.js","css":"visual.css","stats":"../../webpack.statistics.html"},"package":{"dropFolder":"dist"},"server":{"root":"webRoot","assetsRoute":"/assets","privateKey":"certs/PowerBICustomVisualTest_private.key","certificate":"certs/PowerBICustomVisualTest_public.crt","pfx":"certs/PowerBICustomVisualTest_public.pfx","port":"8080","passphrase":"558507214814856"},"visualTemplates":{"circlecard":"https://codeload.github.com/microsoft/powerbi-visuals-circlecard-react/zip/master"}}

package/lib/CertificateTools.js

@@ -56,7 +56,7 @@ async function createCertFile(config, open) {
     const subject = "localhost";
     const keyLength = 2048;
     const algorithm = "sha256";
-    const validPeriod = 180;
+    const validPeriod = 365;
 
     if (typeof open === 'undefined') {
         open = false;
@@ -383,16 +383,14 @@ async function veryfyCertFile(keyPath, certPath, pfxPath, passphrase) {
     let verifyCertDate;
     try {
         let endDateStr;
-        
+
         // For Windows OS:
         if (os.platform() === "win32") {
             if (!fs.existsSync(pfxPath) || !passphrase) {
                 return false;
             }
-            let certStr = await exec(`powershell "certutil -p ${passphrase} -dump ${pfxPath}"`);
-            let regex = /(?<=NotAfter: ).*$/gm;
-            endDateStr = regex.exec(certStr);
-
+            let certStr = await exec(`powershell.exe (New-Object System.Security.Cryptography.X509Certificates.X509Certificate2('${pfxPath}','${passphrase}')).NotAfter.ToString('yyyy-MM-dd HH:mm:ss')`);
+            endDateStr = certStr.trim();
         }
         // For Linux and Mac/darwin OS:
         else if (os.platform() === "linux" || os.platform() === "darwin") {
@@ -402,8 +400,8 @@ async function veryfyCertFile(keyPath, certPath, pfxPath, passphrase) {
             endDateStr = await exec(`openssl x509 -enddate -noout -in ${certPath} | cut -d = -f 2`);
         }
 
-        let endDate = new Date(Date.parse(endDateStr));
-        verifyCertDate = (endDate - new Date()) > certSafePeriod;
+        let endDate = Date.parse(endDateStr);
+        verifyCertDate = (endDate - Date.now()) > certSafePeriod;
         if (verifyCertDate) {
             ConsoleWriter.info(`Certificate is valid.`);
         } else {