poveste 0.8.2 → 0.9.0

package/dist/node/bin.js

@@ -13,17 +13,21 @@ process.env.POVESTE = 'true';
 // and take it away, which Vike does — and a failed build then ran forever with
 // its error already printed (#405).
 //
-// So failure is reported and exited here, deliberately. `exitCode` alone is not
-// enough — teardown does not get every handle back, and after a failed build a
-// `Timeout` and three `MessagePort`s are still open, so waiting for an empty
-// event loop is what hung in the first place. But exiting on the same tick as
-// the error would truncate it: writes to a piped stderr are asynchronous, and a
-// framed compiler error is long.
+// So failure is reported here, the exit code set, and the process forced out if
+// it does not leave on its own. Closing the collection ports (#426) was not
+// enough on its own: a failed build still hangs in the nuxt4 and sveltekit books,
+// holding `FSEventWrap` and `FSReqCallback` handles — watchers nothing closes on
+// the error path. And `dev` and `preview` hold a listening server by design, so
+// for them no amount of leak-fixing would ever let the loop drain.
 //
-// So both: the exit code is set immediately, and the hard exit is a timer that
-// does not itself hold the loop open. A process with nothing leaked exits on its
-// own, flushing normally; one that leaked is cut loose a moment later, by which
-// time the error has been written.
+// The timer is unref'd, so it never fires for a process that ends by itself and
+// costs nothing when there is nothing to force. It is 500ms rather than
+// immediate because exiting on the same tick as `console.error` truncates it:
+// writes to a piped stderr are asynchronous, and a framed compiler error is long.
+//
+// It does mean a leak reads as a clean failure from the outside, so it hides the
+// class of bug #426 was. Removing it again needs those watcher handles closed
+// first, and a guard that measures the resource list rather than the exit code.
 function run(command) {
     return command().then(() => undefined, (error) => {
         console.error(error);

package/dist/node/collect/index.js

@@ -79,18 +79,23 @@ export function useCollectStories(options, ctx) {
         });
     }
     async function executeStoryFile(storyFile) {
+        // The channel belongs to this execution, and nothing used to close it. On a
+        // build that fails, the executions still in flight are abandoned mid-run and
+        // their main-thread ports stay open and listening — enough live handles to
+        // keep the process alive with nothing left to do (#426).
+        let channel;
         try {
-            const { workerPort } = createChannel();
+            channel = createChannel();
             const payload = {
                 root: server.config.root,
                 base: server.config.base,
                 storyFile,
-                port: workerPort,
+                port: channel.workerPort,
                 defineGlobals,
             };
             const { storyData } = await threadPool.run(payload, {
                 transferList: [
-                    workerPort,
+                    channel.workerPort,
                 ],
             });
             if (storyData.length === 0) {
@@ -125,6 +130,9 @@ export function useCollectStories(options, ctx) {
                 throw e;
             }
         }
+        finally {
+            channel?.port.close();
+        }
     }
     async function destroy() {
         await threadPool.destroy();

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "poveste",
   "type": "module",
-  "version": "0.8.2",
+  "version": "0.9.0",
   "description": "Interactive component playgrounds for Vue, Svelte and Nuxt — a maintained, drop-in successor to histoire",
   "author": {
     "name": "Sorin Gitlan"
@@ -98,10 +98,10 @@
     "sirv": "^3.0.0",
     "unhead": "^3.1.0",
     "vite-node": "^6.0.0",
-    "@poveste/app": "^0.8.2",
-    "@poveste/controls": "^0.8.2",
-    "@poveste/shared": "^0.8.2",
-    "@poveste/vendors": "^0.8.2"
+    "@poveste/app": "^0.9.0",
+    "@poveste/controls": "^0.9.0",
+    "@poveste/shared": "^0.9.0",
+    "@poveste/vendors": "^0.9.0"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",