postman-runtime 7.28.4 → 7.29.2

package/lib/requester/core.js

@@ -1,8 +1,9 @@
+/* eslint-disable jsdoc/require-param-type,jsdoc/require-param-description */
 var dns = require('dns'),
     constants = require('constants'),
 
     _ = require('lodash'),
-    uuid = require('uuid/v4'),
+    uuid = require('uuid'),
     sdk = require('postman-collection'),
     urlEncoder = require('postman-url-encoder'),
 
@@ -69,6 +70,10 @@ var dns = require('dns'),
         followRedirect: 'followRedirects',
         followAllRedirects: 'followRedirects',
 
+        // Use an insecure HTTP parser that accepts invalid HTTP headers
+        // Refer: https://nodejs.org/api/cli.html#--insecure-http-parser
+        insecureHTTPParser: 'insecureHTTPParser',
+
         // retain `authorization` header when a redirect happens to a different hostname
         followAuthorizationHeader: 'followAuthorizationHeader',
 
@@ -146,13 +151,13 @@ var dns = require('dns'),
             headers = request.headers;
 
         [
-            {key: 'User-Agent', value: `PostmanRuntime/${version}`},
-            {key: 'Accept', value: '*/*'},
-            {key: 'Cache-Control', value: 'no-cache'},
-            {key: 'Postman-Token', value: uuid()},
-            {key: 'Host', value: options.url && options.url.host},
-            {key: 'Accept-Encoding', value: 'gzip, deflate, br'},
-            {key: 'Connection', value: 'keep-alive'}
+            { key: 'User-Agent', value: `PostmanRuntime/${version}` },
+            { key: 'Accept', value: '*/*' },
+            { key: 'Cache-Control', value: 'no-cache' },
+            { key: 'Postman-Token', value: uuid.v4() },
+            { key: 'Host', value: options.url && options.url.host },
+            { key: 'Accept-Encoding', value: 'gzip, deflate, br' },
+            { key: 'Connection', value: 'keep-alive' }
         ].forEach(function (header) {
             key = header.key.toLowerCase();
 
@@ -168,7 +173,7 @@ var dns = require('dns'),
         });
 
         for (key in systemHeaders) {
-            if (systemHeaders.hasOwnProperty(key)) {
+            if (Object.hasOwnProperty.call(systemHeaders, key)) {
                 // upsert instead of add to replace user-defined headers also
                 headers.upsert({
                     key: key,
@@ -311,11 +316,11 @@ var dns = require('dns'),
      */
     urlParser = function (disableUrlEncoding) {
         return {
-            parse: function (urlToParse) {
+            parse (urlToParse) {
                 return urlEncoder.toNodeUrl(urlToParse, disableUrlEncoding);
             },
 
-            resolve: function (base, relative) {
+            resolve (base, relative) {
                 if (typeof base === STRING) {
                     // @note we parse base URL here to respect `disableUrlEncoding`
                     // option even though resolveNodeUrl() accepts it as a string
@@ -341,7 +346,7 @@ var dns = require('dns'),
         // bail out if property or defaultOpts is not defined
         if (!(property && defaultOpts)) { return; }
 
-        if (protocolProfileBehavior && protocolProfileBehavior.hasOwnProperty(property)) {
+        if (Object.hasOwnProperty.call(protocolProfileBehavior, property)) {
             return protocolProfileBehavior[property];
         }
 
@@ -372,7 +377,7 @@ module.exports = {
      * @param protocolProfileBehavior
      * @returns {{}}
      */
-    getRequestOptions: function (request, defaultOpts, protocolProfileBehavior) {
+    getRequestOptions (request, defaultOpts, protocolProfileBehavior) {
         !defaultOpts && (defaultOpts = {});
         !protocolProfileBehavior && (protocolProfileBehavior = {});
 
@@ -532,7 +537,7 @@ module.exports = {
         });
 
         // Finally, get headers object
-        options.headers = request.getHeaders({enabled: true, sanitizeKeys: true});
+        options.headers = request.getHeaders({ enabled: true, sanitizeKeys: true });
 
         // override URL parser to WhatWG URL parser
         if (useWhatWGUrlParser) {
@@ -579,7 +584,7 @@ module.exports = {
      *
      * @returns {Object}
      */
-    getRequestBody: function (request, protocolProfileBehavior) {
+    getRequestBody (request, protocolProfileBehavior) {
         if (!(request && request.body)) {
             return;
         }
@@ -631,7 +636,7 @@ module.exports = {
         //
         // @note if you'd like to support additional body types beyond formdata, url-encoding, etc, add the same to
         //       the builder module
-        if (!requestBodyBuilders.hasOwnProperty(requestBodyType)) {
+        if (!Object.hasOwnProperty.call(requestBodyBuilders, requestBodyType)) {
             return;
         }
 
@@ -646,7 +651,7 @@ module.exports = {
      * @param requestOptions Options that were used to send the request.
      * @param responseBody Body as a string.
      */
-    jsonifyResponse: function (rawResponse, requestOptions, responseBody) {
+    jsonifyResponse (rawResponse, requestOptions, responseBody) {
         if (!rawResponse) {
             return;
         }
@@ -703,7 +708,7 @@ module.exports = {
      * @param {ArrayBuffer} buffer
      * @returns {String}
      */
-    arrayBufferToString: function (buffer) {
+    arrayBufferToString (buffer) {
         var str = '',
             uArrayVal = new Uint8Array(buffer),
 
@@ -726,7 +731,7 @@ module.exports = {
      * @example
      * ['a', 'b', 'c', 'd'] ====> {a: 'b', c: 'd' }
      */
-    arrayPairsToObject: function (arr) {
+    arrayPairsToObject (arr) {
         if (!_.isArray(arr)) {
             return;
         }
@@ -762,7 +767,7 @@ module.exports = {
      *
      * @returns {Boolean}
      */
-    isAddressRestricted: function (host, networkOptions) {
+    isAddressRestricted (host, networkOptions) {
         return networkOptions.restrictedAddresses &&
             networkOptions.restrictedAddresses[(host && host.toLowerCase())];
     }

package/lib/requester/dry-run.js

@@ -21,11 +21,11 @@ const _ = require('lodash'),
     CONTENT_TYPE_FORMDATA = 'multipart/form-data; boundary=' + CALCULATED_AT_RUNTIME,
 
     CONTENT_TYPE_LANGUAGE = {
-        'html': 'text/html',
-        'text': 'text/plain',
-        'json': 'application/json',
-        'javascript': 'application/javascript',
-        'xml': 'application/xml'
+        html: 'text/html',
+        text: 'text/plain',
+        json: 'application/json',
+        javascript: 'application/javascript',
+        xml: 'application/xml'
     },
 
     BODY_MODE = {
@@ -43,7 +43,7 @@ const _ = require('lodash'),
  * @todo Update Collection SDK isEmpty method to account for this.
  *
  * @private
- * @param {RequestBody} body
+ * @param {RequestBody} body -
  * @returns {Boolean}
  */
 function bodyIsEmpty (body) {
@@ -73,9 +73,9 @@ function bodyIsEmpty (body) {
 /**
  * Add new System header.
  *
- * @param {object} headers
- * @param {String} key
- * @param {String} value
+ * @param {object} headers -
+ * @param {String} key -
+ * @param {String} value -
  */
 function addSystemHeader (headers, key, value) {
     headers.add({
@@ -89,8 +89,8 @@ function addSystemHeader (headers, key, value) {
  * Authorize the given request.
  *
  * @private
- * @param {Request} request
- * @param {Function} callback
+ * @param {Request} request -
+ * @param {Function} callback -
  */
 function setAuthorization (request, callback) {
     authorizeRequest(request, function (err, clonedRequest) {
@@ -158,8 +158,8 @@ function setAuthorization (request, callback) {
  * Adds Content-Type header based on selected request body.
  *
  * @private
- * @param {Request} request
- * @param {Function} callback
+ * @param {Request} request -
+ * @param {Function} callback -
  */
 function setContentType (request, callback) {
     // bail out if body is empty
@@ -201,9 +201,9 @@ function setContentType (request, callback) {
  * Adds Cookie header for the given request url.
  *
  * @private
- * @param {Request} request
- * @param {Object} cookieJar
- * @param {Function} callback
+ * @param {Request} request -
+ * @param {Object} cookieJar -
+ * @param {Function} callback -
  */
 function setCookie (request, cookieJar, callback) {
     // bail out if not a valid instance of CookieJar
@@ -229,11 +229,11 @@ function setCookie (request, cookieJar, callback) {
  * A helper method to dry run the given request instance.
  * It returns the cloned request instance with the system added properties.
  *
- * @param {Request} request
- * @param {Object} options
- * @param {Object} options.cookieJar
- * @param {Object} options.protocolProfileBehavior
- * @param {Function} done
+ * @param {Request} request -
+ * @param {Object} options -
+ * @param {Object} options.cookieJar -
+ * @param {Object} options.protocolProfileBehavior -
+ * @param {Function} done -
  */
 function dryRun (request, options, done) {
     if (!done && typeof options === FUNCTION) {

package/lib/requester/request-wrapper.js

@@ -5,9 +5,9 @@ var _ = require('lodash'),
     /**
      * Sets the Proxy and tunnel to the options
      *
-     * @param request
-     * @param options
-     * @param cb
+     * @param {Object} request -
+     * @param {Object} options -
+     * @param {Function} cb -
      */
     setProxy = function (request, options, cb) {
         var proxyConfig;
@@ -35,9 +35,9 @@ var _ = require('lodash'),
      * Gets the certificate from the options.certificate
      * And appends it with the options provided
      *
-     * @param request
-     * @param options
-     * @param cb
+     * @param {Object} request -
+     * @param {Object} options -
+     * @param {Function} cb -
      */
     setCertificate = function (request, options, cb) {
         var certificate,

package/lib/requester/requester-pool.js

@@ -26,6 +26,7 @@ RequesterPool = function (options, callback) {
         maxResponseSize: _.get(options, 'requester.maxResponseSize'),
         // @todo drop support in v8
         useWhatWGUrlParser: _.get(options, 'requester.useWhatWGUrlParser', false),
+        insecureHTTPParser: _.get(options, 'requester.insecureHTTPParser'),
         followRedirects: _.get(options, 'requester.followRedirects', true),
         followOriginalHttpMethod: _.get(options, 'requester.followOriginalHttpMethod'),
         maxRedirects: _.get(options, 'requester.maxRedirects'),

package/lib/requester/requester.js

@@ -1,7 +1,7 @@
+/* eslint-disable jsdoc/require-param-type,jsdoc/require-param-description */
 var _ = require('lodash'),
     core = require('./core'),
-    Emitter = require('events'),
-    inherits = require('inherits'),
+    EventEmitter = require('events'),
     now = require('performance-now'),
     sdk = require('postman-collection'),
     requests = require('./request-wrapper'),
@@ -111,39 +111,34 @@ var _ = require('lodash'),
         }
 
         return offset;
-    },
+    };
 
-    Requester;
-
-/**
- * Creates a new Requester, which is used to make HTTP(s) requests.
- *
- * @param trace
- * @param options
- * @param {Boolean} [options.keepAlive=true] Optimizes HTTP connections by keeping them alive, so that new requests
- * to the same host are made over the same underlying TCP connection.
- * @param {CookieJar} [options.cookieJar] A cookie jar to use with Node requests.
- * @param {Boolean} [options.strictSSL]
- * @param {Boolean} [options.followRedirects=true] If false, returns a 301/302 as the response code
- * instead of following the redirect
- * @note `options.keepAlive` is only supported in Node.
- * @note `options.cookieJar` is only supported in Node.
- *
- * @constructor
- */
-inherits(Requester = function (trace, options) {
-    this.options = options || {};
-
-    // protect the timeout value from being non-numeric or infinite
-    if (!_.isFinite(this.options.timeout)) {
-        this.options.timeout = undefined;
-    }
+class Requester extends EventEmitter {
+    /**
+     * Creates a new Requester, which is used to make HTTP(s) requests.
+     *
+     * @param trace
+     * @param options
+     * @param {Boolean} [options.keepAlive=true] Optimizes HTTP connections by keeping them alive, so that new requests
+     * to the same host are made over the same underlying TCP connection.
+     * @param {CookieJar} [options.cookieJar] A cookie jar to use with Node requests.
+     * @param {Boolean} [options.strictSSL]
+     * @param {Boolean} [options.followRedirects=true] If false, returns a 301/302 as the response code
+     * instead of following the redirect
+     * @note `options.keepAlive` is only supported in Node.
+     * @note `options.cookieJar` is only supported in Node.
+     */
+    constructor (trace, options) {
+        super();
 
-    this.trace = trace;
-    Requester.super_.call(this);
-}, Emitter);
+        this.trace = trace;
+        this.options = options || {};
 
-_.assign(Requester.prototype, /** @lends Requester.prototype */ {
+        // protect the timeout value from being non-numeric or infinite
+        if (!_.isFinite(this.options.timeout)) {
+            this.options.timeout = undefined;
+        }
+    }
 
     /**
      * Perform an HTTP request.
@@ -153,7 +148,7 @@ _.assign(Requester.prototype, /** @lends Requester.prototype */ {
      * @param {Object} protocolProfileBehavior
      * @param {Function} callback
      */
-    request: function (id, request, protocolProfileBehavior, callback) {
+    request (id, request, protocolProfileBehavior, callback) {
         var self = this,
             hostname,
             cookieJar,
@@ -299,8 +294,8 @@ _.assign(Requester.prototype, /** @lends Requester.prototype */ {
                 // wait for responseStart and cache response callback data
                 _responseEnded = true;
                 _responseData = {
-                    response: response,
-                    history: history
+                    response,
+                    history
                 };
             },
 
@@ -441,7 +436,7 @@ _.assign(Requester.prototype, /** @lends Requester.prototype */ {
 
             onComplete(RESPONSE_END, response, history);
         });
-    },
+    }
 
     /**
      * Removes all current event listeners on the requester, and makes it ready for garbage collection :).
@@ -450,7 +445,7 @@ _.assign(Requester.prototype, /** @lends Requester.prototype */ {
      *
      * @todo - In the future, when the requester manages its own connections etc, close them all here.
      */
-    dispose: function (cb) {
+    dispose (cb) {
         // This is safe for us, because we do not use wait on events. (i.e, no part of Runtime ever waits on
         // any event to occur). We rely on callbacks for that, only choosing to use events as a way of streaming
         // information outside runtime.
@@ -458,9 +453,7 @@ _.assign(Requester.prototype, /** @lends Requester.prototype */ {
 
         _.isFunction(cb) && cb();
     }
-});
 
-_.assign(Requester, /** @lends Requester */ {
     /**
      * Asynchronously create a new requester.
      *
@@ -472,9 +465,9 @@ _.assign(Requester, /** @lends Requester */ {
      * @param callback
      * @returns {*}
      */
-    create: function (trace, options, callback) {
+    static create (trace, options, callback) {
         return callback(null, new Requester(trace, options));
-    },
+    }
 
     /**
      * A helper method to dry run the given request instance.
@@ -488,7 +481,9 @@ _.assign(Requester, /** @lends Requester */ {
      * @param {Object} options.implicitTraceHeader
      * @param {Function} done
      */
-    dryRun
-});
+    static dryRun (request, options, done) {
+        return dryRun(request, options, done);
+    }
+}
 
 module.exports.Requester = Requester;

package/lib/runner/create-item-context.js

@@ -14,12 +14,12 @@ var _ = require('lodash'),
  *
  * @function createItemContext
  *
- * @param {Object} payload
- * @param {Item} payload.item
- * @param {Object} [payload.coords]
- * @param {Object} [defaults]
- * @param {Object} [defaults.replayState]
- * @param {Object} [defaults.coords]
+ * @param {Object} payload -
+ * @param {Item} payload.item -
+ * @param {Object} [payload.coords] -
+ * @param {Object} [defaults] -
+ * @param {Object} [defaults.replayState] -
+ * @param {Object} [defaults.coords] -
  *
  * @returns {ItemContext}
  */