posthog-node 4.3.1 → 4.3.2

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Next
 
+# 4.3.2 - 2024-12-11
+
+1. REVERT: Fix bug where this SDK incorrectly sent `$feature_flag_called` events with null values when using `getFeatureFlagPayload`.
+
 # 4.3.1 - 2024-11-26
 
 1. Fix bug where this SDK incorrectly sent `$feature_flag_called` events with null values when using `getFeatureFlagPayload`.

package/README.md

@@ -2,7 +2,7 @@
 
 Please see the main [PostHog docs](https://www.posthog.com/docs).
 
-Specifically, the [Node.js integration](https://posthog.com/docs/integrate/server/node) details.
+Specifically, the [Node.js docs](https://posthog.com/docs/libraries/node) details.
 
 ## Questions?
 

package/lib/index.cjs.js

@@ -4,7 +4,7 @@ Object.defineProperty(exports, '__esModule', { value: true });
 
 var rusha = require('rusha');
 
-var version = "4.3.1";
+var version = "4.3.2";
 
 var PostHogPersistedProperty;
 (function (PostHogPersistedProperty) {
@@ -2234,70 +2234,44 @@ class PostHog extends PostHogCoreStateless {
   async getFeatureFlagPayload(key, distinctId, matchValue, options) {
     const {
       groups,
-      disableGeoip,
-      onlyEvaluateLocally = false,
+      disableGeoip
+    } = options || {};
+    let {
+      onlyEvaluateLocally,
+      sendFeatureFlagEvents,
       personProperties,
       groupProperties
     } = options || {};
-    const {
-      allPersonProperties,
-      allGroupProperties
-    } = this.addLocalPersonAndGroupProperties(distinctId, groups, personProperties, groupProperties);
-    if (matchValue === undefined) {
+    const adjustedProperties = this.addLocalPersonAndGroupProperties(distinctId, groups, personProperties, groupProperties);
+    personProperties = adjustedProperties.allPersonProperties;
+    groupProperties = adjustedProperties.allGroupProperties;
+    let response = undefined;
+    // Try to get match value locally if not provided
+    if (!matchValue) {
       matchValue = await this.getFeatureFlag(key, distinctId, {
         ...options,
-        onlyEvaluateLocally: true,
-        sendFeatureFlagEvents: false
+        onlyEvaluateLocally: true
       });
     }
-    let response;
-    let payload;
     if (matchValue) {
-      response = matchValue;
-      payload = await this.featureFlagsPoller?.computeFeatureFlagPayloadLocally(key, matchValue);
-    } else {
-      response = undefined;
-      payload = undefined;
+      response = await this.featureFlagsPoller?.computeFeatureFlagPayloadLocally(key, matchValue);
     }
-    // Determine if the payload was evaluated locally
-    const payloadWasLocallyEvaluated = payload !== undefined;
-    // Fetch final flags and payloads either locally or from the remote server
-    let fetchedOrLocalFlags;
-    let fetchedOrLocalPayloads;
-    if (payloadWasLocallyEvaluated || onlyEvaluateLocally) {
-      if (response !== undefined) {
-        fetchedOrLocalFlags = {
-          [key]: response
-        };
-        fetchedOrLocalPayloads = {
-          [key]: payload
-        };
-      } else {
-        fetchedOrLocalFlags = {};
-        fetchedOrLocalPayloads = {};
-      }
-    } else {
-      const fetchedData = await super.getFeatureFlagsAndPayloadsStateless(distinctId, groups, allPersonProperties, allGroupProperties, disableGeoip);
-      fetchedOrLocalFlags = fetchedData.flags || {};
-      fetchedOrLocalPayloads = fetchedData.payloads || {};
+    // set defaults
+    if (onlyEvaluateLocally == undefined) {
+      onlyEvaluateLocally = false;
     }
-    const finalResponse = fetchedOrLocalFlags[key];
-    const finalPayload = fetchedOrLocalPayloads[key];
-    const finalLocallyEvaluated = payloadWasLocallyEvaluated;
-    this.capture({
-      distinctId,
-      event: '$feature_flag_called',
-      properties: {
-        $feature_flag: key,
-        $feature_flag_response: finalResponse,
-        $feature_flag_payload: finalPayload,
-        locally_evaluated: finalLocallyEvaluated,
-        [`$feature/${key}`]: finalResponse
-      },
-      groups,
-      disableGeoip
-    });
-    return finalPayload;
+    if (sendFeatureFlagEvents == undefined) {
+      sendFeatureFlagEvents = true;
+    }
+    // set defaults
+    if (onlyEvaluateLocally == undefined) {
+      onlyEvaluateLocally = false;
+    }
+    const payloadWasLocallyEvaluated = response !== undefined;
+    if (!payloadWasLocallyEvaluated && !onlyEvaluateLocally) {
+      response = await super.getFeatureFlagPayloadStateless(key, distinctId, groups, personProperties, groupProperties, disableGeoip);
+    }
+    return response;
   }
   async isFeatureEnabled(key, distinctId, options) {
     const feat = await this.getFeatureFlag(key, distinctId, options);