posthog-node 4.10.2 → 4.11.0

package/test/posthog-node.spec.ts

@@ -614,7 +614,7 @@ describe('PostHog Node.js', () => {
       )
       expect(mockedFetch).toHaveBeenCalledTimes(1)
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST', body: expect.stringContaining('"geoip_disable":true') })
       )
     })
@@ -647,7 +647,7 @@ describe('PostHog Node.js', () => {
       await waitForPromises()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST' })
       )
 
@@ -656,7 +656,7 @@ describe('PostHog Node.js', () => {
           distinct_id: 'distinct_id',
           event: 'node test event',
           properties: expect.objectContaining({
-            $active_feature_flags: ['feature-1', 'feature-2', 'feature-variant', 'feature-array'],
+            $active_feature_flags: ['feature-1', 'feature-2', 'feature-array', 'feature-variant'],
             '$feature/feature-1': true,
             '$feature/feature-2': true,
             '$feature/feature-array': true,
@@ -672,7 +672,7 @@ describe('PostHog Node.js', () => {
 
       expect(mockedFetch).not.toHaveBeenCalledWith(...anyLocalEvalCall)
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST', body: expect.stringContaining('"geoip_disable":true') })
       )
     })
@@ -732,7 +732,7 @@ describe('PostHog Node.js', () => {
       expect(mockedFetch).toHaveBeenCalledWith(...anyLocalEvalCall)
       // no decide call
       expect(mockedFetch).not.toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST' })
       )
 
@@ -790,7 +790,7 @@ describe('PostHog Node.js', () => {
       expect(mockedFetch).toHaveBeenCalledWith(...anyLocalEvalCall)
       // no decide call
       expect(mockedFetch).not.toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST' })
       )
 
@@ -838,12 +838,12 @@ describe('PostHog Node.js', () => {
       await waitForFlushTimer()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST', body: expect.not.stringContaining('geoip_disable') })
       )
 
       expect(getLastBatchEvents()?.[0].properties).toEqual({
-        $active_feature_flags: ['feature-1', 'feature-2', 'feature-variant', 'feature-array'],
+        $active_feature_flags: ['feature-1', 'feature-2', 'feature-array', 'feature-variant'],
         '$feature/feature-1': true,
         '$feature/feature-2': true,
         '$feature/feature-array': true,
@@ -1091,7 +1091,7 @@ describe('PostHog Node.js', () => {
       ).resolves.toEqual(2)
       expect(mockedFetch).toHaveBeenCalledTimes(1)
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST', body: expect.stringContaining('"geoip_disable":true') })
       )
     })
@@ -1133,7 +1133,7 @@ describe('PostHog Node.js', () => {
       ).resolves.toEqual([1])
       expect(mockedFetch).toHaveBeenCalledTimes(1)
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST', body: expect.stringContaining('"geoip_disable":true') })
       )
     })
@@ -1153,7 +1153,7 @@ describe('PostHog Node.js', () => {
       ).resolves.toEqual(2)
       expect(mockedFetch).toHaveBeenCalledTimes(1)
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST', body: expect.stringContaining('"geoip_disable":true') })
       )
 
@@ -1162,7 +1162,7 @@ describe('PostHog Node.js', () => {
       await expect(posthog.isFeatureEnabled('feature-variant', '123', { disableGeoip: false })).resolves.toEqual(true)
       expect(mockedFetch).toHaveBeenCalledTimes(1)
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({ method: 'POST', body: expect.not.stringContaining('geoip_disable') })
       )
     })
@@ -1176,7 +1176,7 @@ describe('PostHog Node.js', () => {
       jest.runOnlyPendingTimers()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({
           body: JSON.stringify({
             token: 'TEST_API_KEY',
@@ -1206,7 +1206,7 @@ describe('PostHog Node.js', () => {
       jest.runOnlyPendingTimers()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({
           body: JSON.stringify({
             token: 'TEST_API_KEY',
@@ -1237,7 +1237,7 @@ describe('PostHog Node.js', () => {
       jest.runOnlyPendingTimers()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({
           body: JSON.stringify({
             token: 'TEST_API_KEY',
@@ -1261,7 +1261,7 @@ describe('PostHog Node.js', () => {
       jest.runOnlyPendingTimers()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({
           body: JSON.stringify({
             token: 'TEST_API_KEY',
@@ -1281,7 +1281,7 @@ describe('PostHog Node.js', () => {
       jest.runOnlyPendingTimers()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({
           body: JSON.stringify({
             token: 'TEST_API_KEY',
@@ -1303,7 +1303,7 @@ describe('PostHog Node.js', () => {
       jest.runOnlyPendingTimers()
 
       expect(mockedFetch).toHaveBeenCalledWith(
-        'http://example.com/decide/?v=3',
+        'http://example.com/decide/?v=4',
         expect.objectContaining({
           body: JSON.stringify({
             token: 'TEST_API_KEY',

package/test/test-utils.ts

@@ -1,3 +1,26 @@
+import { PostHogV4DecideResponse } from 'posthog-core/src/types'
+
+export const apiImplementationV4 = (decideResponse?: PostHogV4DecideResponse) => {
+  return (url: any): Promise<any> => {
+    if ((url as any).includes('/decide/?v=4')) {
+      return Promise.resolve({
+        status: 200,
+        text: () => Promise.resolve('ok'),
+        json: () => Promise.resolve(decideResponse),
+      }) as any
+    }
+
+    return Promise.resolve({
+      status: 400,
+      text: () => Promise.resolve('ok'),
+      json: () =>
+        Promise.resolve({
+          status: 'ok',
+        }),
+    }) as any
+  }
+}
+
 export const apiImplementation = ({
   localFlags,
   decideFlags,
@@ -68,4 +91,4 @@ export const anyLocalEvalCall = [
   'http://example.com/api/feature_flag/local_evaluation?token=TEST_API_KEY&send_cohorts',
   expect.any(Object),
 ]
-export const anyDecideCall = ['http://example.com/decide/?v=3', expect.any(Object)]
+export const anyDecideCall = ['http://example.com/decide/?v=4', expect.any(Object)]

package/benchmarks/rusha-vs-native.mjs

@@ -1,70 +0,0 @@
-// @ts-check
-
-import { bench, run, summary } from "mitata";
-import { createHash } from "node:crypto"
-import pkg from 'rusha';
-const { createHash: createHashRusha } = pkg;
-
-// eslint-disable-next-line
-const LONG_SCALE = 0xfffffffffffffff
-
-// from https://github.com/PostHog/posthog-js-lite/blob/2baa794708d78d5d10940817c3768e47abe2da99/posthog-node/src/feature-flags.ts#L460-L465
-function _hashRusha(key, distinctId, salt = '') {
-    // rusha is a fast sha1 implementation in pure javascript
-    const sha1Hash = createHashRusha()
-    sha1Hash.update(`${key}.${distinctId}${salt}`)
-    return parseInt(sha1Hash.digest('hex').slice(0, 15), 16) / LONG_SCALE
-}
-
-function _hash(key, distinctId, salt = '') {
-    const sha1Hash = createHash("sha1")
-    sha1Hash.update(`${key}.${distinctId}${salt}`)
-    return parseInt(sha1Hash.digest('hex').slice(0, 15), 16) / LONG_SCALE
-}
-
-summary(() => {
-	bench("_hash with rusha", () => {
-		_hashRusha("test", "user_id")
-	});
-
-	bench("_hash with native", () => {
-		_hash("test", "user_id")
-	});
-});
-
-await run();
-
-
-// !NODE
-// node benchmarks/rusha-vs-native.mjs
-// clk: ~3.99 GHz
-// cpu: AMD Ryzen 7 7700 8-Core Processor
-// runtime: node 22.11.0 (x64-linux)
-
-// benchmark                   avg (min … max) p75   p99    (min … top 1%)
-// ------------------------------------------- -------------------------------
-// _hash with rusha              12.10 µs/iter   7.25 µs █
-//                         (4.66 µs … 1.27 ms) 116.62 µs █▄▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁
-// _hash with native            547.04 ns/iter 435.45 ns █
-//                       (370.08 ns … 3.61 µs)   3.58 µs █▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁
-
-// summary
-//   _hash with native
-//    22.12x faster than _hash with rusha
-
-// !BUN
-// bun benchmarks/rusha-vs-native.mjs 
-// clk: ~5.04 GHz
-// cpu: AMD Ryzen 7 7700 8-Core Processor
-// runtime: bun 1.1.37 (x64-linux)
-
-// benchmark                   avg (min … max) p75   p99    (min … top 1%)
-// ------------------------------------------- -------------------------------
-// _hash with rusha              10.00 µs/iter   4.96 µs  █
-//                         (2.60 µs … 2.78 ms)  45.85 µs ▂█▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁
-// _hash with native            471.82 ns/iter 420.00 ns █
-//                     (370.00 ns … 949.79 µs)   1.99 µs █▆▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁
-
-// summary
-//   _hash with native
-//    21.19x faster than _hash with rusha