posthog-node 4.0.0 → 4.0.1

package/CHANGELOG.md

@@ -1,3 +1,8 @@
+
+# 4.0.1 - 2024-04-25
+
+1. Prevent double JSON parsing of feature flag payloads, which would convert the payload [1] into 1.
+
 # 4.0.0 - 2024-03-18
 
 ## Added

package/lib/index.cjs.js

@@ -4,7 +4,7 @@ Object.defineProperty(exports, '__esModule', { value: true });
 
 var rusha = require('rusha');
 
-var version = "4.0.0";
+var version = "4.0.1";
 
 var PostHogPersistedProperty;
 (function (PostHogPersistedProperty) {
@@ -1157,14 +1157,11 @@ class PostHogCoreStateless {
         if (response === undefined) {
             return null;
         }
-        return this._parsePayload(response);
+        return response;
     }
     async getFeatureFlagPayloadsStateless(distinctId, groups = {}, personProperties = {}, groupProperties = {}, disableGeoip) {
         await this._initPromise;
         const payloads = (await this.getFeatureFlagsAndPayloadsStateless(distinctId, groups, personProperties, groupProperties, disableGeoip)).payloads;
-        if (payloads) {
-            return Object.fromEntries(Object.entries(payloads).map(([k, v]) => [k, this._parsePayload(v)]));
-        }
         return payloads;
     }
     _parsePayload(response) {
@@ -1188,9 +1185,13 @@ class PostHogCoreStateless {
         const decideResponse = await this.getDecide(distinctId, groups, personProperties, groupProperties, extraPayload);
         const flags = decideResponse?.featureFlags;
         const payloads = decideResponse?.featureFlagPayloads;
+        let parsedPayloads = payloads;
+        if (payloads) {
+            parsedPayloads = Object.fromEntries(Object.entries(payloads).map(([k, v]) => [k, this._parsePayload(v)]));
+        }
         return {
             flags,
-            payloads,
+            payloads: parsedPayloads,
         };
     }
     /***
@@ -1543,11 +1544,15 @@ class FeatureFlagsPoller {
     } // Undefined means a loading or missing data issue. Null means evaluation happened and there was no match
 
 
-    if (response === undefined) {
+    if (response === undefined || response === null) {
       return null;
     }
 
-    return response;
+    try {
+      return JSON.parse(response);
+    } catch {
+      return response;
+    }
   }
 
   async getAllFlagsAndPayloads(distinctId, groups = {}, personProperties = {}, groupProperties = {}) {
@@ -1681,7 +1686,7 @@ class FeatureFlagsPoller {
         let matches = false;
 
         if (propertyType === 'cohort') {
-          matches = matchCohort(prop, properties, this.cohorts);
+          matches = matchCohort(prop, properties, this.cohorts, this.debugMode);
         } else {
           matches = matchProperty(prop, properties);
         }
@@ -1937,7 +1942,7 @@ function matchProperty(property, propertyValues) {
   }
 }
 
-function matchCohort(property, propertyValues, cohortProperties) {
+function matchCohort(property, propertyValues, cohortProperties, debugMode = false) {
   const cohortId = String(property.value);
 
   if (!(cohortId in cohortProperties)) {
@@ -1945,10 +1950,10 @@ function matchCohort(property, propertyValues, cohortProperties) {
   }
 
   const propertyGroup = cohortProperties[cohortId];
-  return matchPropertyGroup(propertyGroup, propertyValues, cohortProperties);
+  return matchPropertyGroup(propertyGroup, propertyValues, cohortProperties, debugMode);
 }
 
-function matchPropertyGroup(propertyGroup, propertyValues, cohortProperties) {
+function matchPropertyGroup(propertyGroup, propertyValues, cohortProperties, debugMode = false) {
   if (!propertyGroup) {
     return true;
   }
@@ -1967,7 +1972,7 @@ function matchPropertyGroup(propertyGroup, propertyValues, cohortProperties) {
     // a nested property group
     for (const prop of properties) {
       try {
-        const matches = matchPropertyGroup(prop, propertyValues, cohortProperties);
+        const matches = matchPropertyGroup(prop, propertyValues, cohortProperties, debugMode);
 
         if (propertyGroupType === 'AND') {
           if (!matches) {
@@ -1981,7 +1986,10 @@ function matchPropertyGroup(propertyGroup, propertyValues, cohortProperties) {
         }
       } catch (err) {
         if (err instanceof InconclusiveMatchError) {
-          console.debug(`Failed to compute property ${prop} locally: ${err}`);
+          if (debugMode) {
+            console.debug(`Failed to compute property ${prop} locally: ${err}`);
+          }
+
           errorMatchingLocally = true;
         } else {
           throw err;
@@ -2001,7 +2009,7 @@ function matchPropertyGroup(propertyGroup, propertyValues, cohortProperties) {
         let matches;
 
         if (prop.type === 'cohort') {
-          matches = matchCohort(prop, propertyValues, cohortProperties);
+          matches = matchCohort(prop, propertyValues, cohortProperties, debugMode);
         } else {
           matches = matchProperty(prop, propertyValues);
         }
@@ -2029,7 +2037,10 @@ function matchPropertyGroup(propertyGroup, propertyValues, cohortProperties) {
         }
       } catch (err) {
         if (err instanceof InconclusiveMatchError) {
-          console.debug(`Failed to compute property ${prop} locally: ${err}`);
+          if (debugMode) {
+            console.debug(`Failed to compute property ${prop} locally: ${err}`);
+          }
+
           errorMatchingLocally = true;
         } else {
           throw err;
@@ -2378,11 +2389,7 @@ class PostHog extends PostHogCoreStateless {
       response = await super.getFeatureFlagPayloadStateless(key, distinctId, groups, personProperties, groupProperties, disableGeoip);
     }
 
-    try {
-      return JSON.parse(response);
-    } catch {
-      return response;
-    }
+    return response;
   }
 
   async isFeatureEnabled(key, distinctId, options) {