posthog-node 2.5.1 → 2.5.3

package/lib/posthog-node/src/posthog-node.d.ts

@@ -62,7 +62,7 @@ export declare class PostHog extends PostHogCoreStateless implements PostHogNode
         groupProperties?: Record<string, Record<string, string>>;
         onlyEvaluateLocally?: boolean;
     }): Promise<PosthogFlagsAndPayloadsResponse>;
-    groupIdentify({ groupType, groupKey, properties }: GroupIdentifyMessage): void;
+    groupIdentify({ groupType, groupKey, properties, distinctId }: GroupIdentifyMessage): void;
     reloadFeatureFlags(): Promise<void>;
     shutdown(): void;
     shutdownAsync(): Promise<void>;

package/lib/posthog-node/src/types.d.ts

@@ -13,6 +13,7 @@ export interface GroupIdentifyMessage {
     groupType: string;
     groupKey: string;
     properties?: Record<string | number, any>;
+    distinctId?: string;
 }
 export declare type FeatureFlagCondition = {
     properties: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "posthog-node",
-  "version": "2.5.1",
+  "version": "2.5.3",
   "description": "PostHog Node.js integration",
   "repository": "PostHog/posthog-node",
   "scripts": {

package/src/posthog-node.ts

@@ -102,11 +102,14 @@ export class PostHog extends PostHogCoreStateless implements PostHogNodeV1 {
         const featureVariantProperties: Record<string, string | boolean> = {}
         if (flags) {
           for (const [feature, variant] of Object.entries(flags)) {
-            featureVariantProperties[`$feature/${feature}`] = variant
+            if (variant !== false) {
+              featureVariantProperties[`$feature/${feature}`] = variant
+            }
           }
         }
+        const activeFlags = Object.keys(flags || {}).filter((flag) => flags?.[flag] !== false)
         const flagProperties = {
-          $active_feature_flags: flags ? Object.keys(flags) : undefined,
+          $active_feature_flags: activeFlags || undefined,
           ...featureVariantProperties,
         }
         _capture({ ...properties, $groups: groups, ...flagProperties })
@@ -117,7 +120,12 @@ export class PostHog extends PostHogCoreStateless implements PostHogNodeV1 {
   }
 
   identify({ distinctId, properties }: IdentifyMessageV1): void {
-    super.identifyStateless(distinctId, properties)
+    // Catch properties passed as $set and move them to the top level
+    const personProperties = properties?.$set || properties
+
+    super.identifyStateless(distinctId, {
+      $set: personProperties,
+    })
   }
 
   alias(data: { distinctId: string; alias: string }): void {
@@ -327,8 +335,8 @@ export class PostHog extends PostHogCoreStateless implements PostHogNodeV1 {
     return { featureFlags, featureFlagPayloads }
   }
 
-  groupIdentify({ groupType, groupKey, properties }: GroupIdentifyMessage): void {
-    super.groupIdentifyStateless(groupType, groupKey, properties)
+  groupIdentify({ groupType, groupKey, properties, distinctId }: GroupIdentifyMessage): void {
+    super.groupIdentifyStateless(groupType, groupKey, properties, undefined, distinctId)
   }
 
   async reloadFeatureFlags(): Promise<void> {

package/src/types.ts

@@ -16,6 +16,7 @@ export interface GroupIdentifyMessage {
   groupType: string
   groupKey: string // Unique identifier for the group
   properties?: Record<string | number, any>
+  distinctId?: string // optional distinctId to associate message with a person
 }
 
 export type FeatureFlagCondition = {

package/test/posthog-node.spec.ts

@@ -114,7 +114,27 @@ describe('PostHog Node.js', () => {
           distinct_id: '123',
           event: '$identify',
           properties: {
-            foo: 'bar',
+            $set: {
+              foo: 'bar',
+            },
+          },
+        },
+      ])
+    })
+
+    it('should handle identify mistakenly using $set', async () => {
+      expect(mockedFetch).toHaveBeenCalledTimes(0)
+      posthog.identify({ distinctId: '123', properties: { foo: 'bar', $set: { foo: 'other' } } })
+      jest.runOnlyPendingTimers()
+      const batchEvents = getLastBatchEvents()
+      expect(batchEvents).toMatchObject([
+        {
+          distinct_id: '123',
+          event: '$identify',
+          properties: {
+            $set: {
+              foo: 'other',
+            },
           },
         },
       ])
@@ -214,7 +234,6 @@ describe('PostHog Node.js', () => {
       posthog.groupIdentify({ groupType: 'posthog', groupKey: 'team-1', properties: { analytics: true } })
       jest.runOnlyPendingTimers()
       const batchEvents = getLastBatchEvents()
-      console.log(batchEvents)
       expect(batchEvents).toMatchObject([
         {
           distinct_id: '$posthog_team-1',
@@ -228,6 +247,29 @@ describe('PostHog Node.js', () => {
         },
       ])
     })
+
+    it('should allow passing optional distinctID to identify group', () => {
+      posthog.groupIdentify({
+        groupType: 'posthog',
+        groupKey: 'team-1',
+        properties: { analytics: true },
+        distinctId: '123',
+      })
+      jest.runOnlyPendingTimers()
+      const batchEvents = getLastBatchEvents()
+      expect(batchEvents).toMatchObject([
+        {
+          distinct_id: '123',
+          event: '$groupidentify',
+          properties: {
+            $group_type: 'posthog',
+            $group_key: 'team-1',
+            $group_set: { analytics: true },
+            $lib: 'posthog-node',
+          },
+        },
+      ])
+    })
   })
 
   describe('feature flags', () => {
@@ -236,6 +278,7 @@ describe('PostHog Node.js', () => {
         'feature-1': true,
         'feature-2': true,
         'feature-variant': 'variant',
+        'disabled-flag': false,
       }
 
       const mockFeatureFlagPayloads = {