posthog-node 2.0.0-alpha4 → 2.0.0-alpha7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "posthog-node",
-  "version": "2.0.0-alpha4",
+  "version": "2.0.0-alpha7",
   "description": "PostHog Node.js integration",
   "repository": "PostHog/posthog-node",
   "scripts": {

package/src/posthog-node.ts

@@ -7,12 +7,15 @@ import {
   PostHogFetchResponse,
   PostHogPersistedProperty,
 } from '../../posthog-core/src'
+import { PostHogMemoryStorage } from '../../posthog-core/src/storage-memory'
 import { EventMessageV1, GroupIdentifyMessage, IdentifyMessageV1, PostHogNodeV1 } from './types'
 
-export type PostHogOptions = PosthogCoreOptions
+export type PostHogOptions = PosthogCoreOptions & {
+  persistence?: 'memory'
+}
 
 class PostHog extends PostHogCore {
-  private _memoryStorage: { [key: string]: any | undefined } = {}
+  private _memoryStorage = new PostHogMemoryStorage()
 
   constructor(apiKey: string, options: PostHogOptions = {}) {
     options.captureMode = options?.captureMode || 'json'
@@ -22,11 +25,11 @@ class PostHog extends PostHogCore {
   }
 
   getPersistedProperty(key: PostHogPersistedProperty): any | undefined {
-    return this._memoryStorage[key]
+    return this._memoryStorage.getProperty(key)
   }
 
   setPersistedProperty(key: PostHogPersistedProperty, value: any | null): void {
-    this._memoryStorage[key] = value !== null ? value : undefined
+    return this._memoryStorage.setProperty(key, value)
   }
 
   getSessionId(): string | undefined {
@@ -59,10 +62,14 @@ export class PostHogGlobal implements PostHogNodeV1 {
   }
 
   private reInit(distinctId: string): void {
-    // Remove all state except the queue
-    const queue = this._sharedClient.getPersistedProperty(PostHogPersistedProperty.Queue)
-    this._sharedClient.reset()
-    this._sharedClient.setPersistedProperty(PostHogPersistedProperty.Queue, queue)
+    // Certain properties we want to persist
+    const propertiesToKeep = [PostHogPersistedProperty.Queue, PostHogPersistedProperty.OptedOut]
+
+    for (const key in PostHogPersistedProperty) {
+      if (!propertiesToKeep.includes(key as any)) {
+        this._sharedClient.setPersistedProperty((PostHogPersistedProperty as any)[key], null)
+      }
+    }
     this._sharedClient.setPersistedProperty(PostHogPersistedProperty.DistinctId, distinctId)
   }
 
@@ -111,7 +118,7 @@ export class PostHogGlobal implements PostHogNodeV1 {
     defaultResult?: boolean | undefined,
     groups?: Record<string, string> | undefined
   ): Promise<boolean> {
-    const feat = this.getFeatureFlag(key, distinctId, groups)
+    const feat = await this.getFeatureFlag(key, distinctId, groups)
     return !!feat || defaultResult || false
   }
 

package/test/posthog-node.spec.ts

@@ -17,7 +17,7 @@ const getLastBatchEvents = (): any[] | undefined => {
   return JSON.parse((call[1] as any).body as any).batch
 }
 
-describe('PostHog Core', () => {
+describe('PostHog Node.js', () => {
   let posthog: PostHog
 
   jest.useFakeTimers()
@@ -37,7 +37,7 @@ describe('PostHog Core', () => {
     } as any)
   })
 
-  describe('legacy methods', () => {
+  describe('core methods', () => {
     it('should capture an event to shared queue', async () => {
       expect(mockedUndici.fetch).toHaveBeenCalledTimes(0)
       posthog.capture({ distinctId: '123', event: 'test-event', properties: { foo: 'bar' }, groups: { org: 123 } })
@@ -89,4 +89,49 @@ describe('PostHog Core', () => {
       ])
     })
   })
+
+  describe('feature flags', () => {
+    beforeEach(() => {
+      const mockFeatureFlags = {
+        'feature-1': true,
+        'feature-2': true,
+        'feature-variant': 'variant',
+      }
+
+      mockedUndici.fetch.mockImplementation((url) => {
+        if ((url as any).includes('/decide/')) {
+          return Promise.resolve({
+            status: 200,
+            text: () => Promise.resolve('ok'),
+            json: () =>
+              Promise.resolve({
+                featureFlags: mockFeatureFlags,
+              }),
+          }) as any
+        }
+
+        return Promise.resolve({
+          status: 200,
+          text: () => Promise.resolve('ok'),
+          json: () =>
+            Promise.resolve({
+              status: 'ok',
+            }),
+        }) as any
+      })
+    })
+
+    it('should do getFeatureFlag', async () => {
+      expect(mockedUndici.fetch).toHaveBeenCalledTimes(0)
+      await expect(posthog.getFeatureFlag('feature-variant', '123', { org: '123' })).resolves.toEqual('variant')
+      expect(mockedUndici.fetch).toHaveBeenCalledTimes(1)
+    })
+
+    it('should do isFeatureEnabled', async () => {
+      expect(mockedUndici.fetch).toHaveBeenCalledTimes(0)
+      await expect(posthog.isFeatureEnabled('feature-1', '123', false, { org: '123' })).resolves.toEqual(true)
+      await expect(posthog.isFeatureEnabled('feature-4', '123', false, { org: '123' })).resolves.toEqual(false)
+      expect(mockedUndici.fetch).toHaveBeenCalledTimes(2)
+    })
+  })
 })