postcss-discard-comments 1.2.0 → 1.2.1

package/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.2.1
+
+* Improved performance by iterating the AST in a single pass.
+
 # 1.2.0
 
 * Adds support for user-directed removal of comments, with the `remove`

package/index.js

@@ -27,52 +27,49 @@ module.exports = postcss.plugin('postcss-discard-comments', function (options) {
             return space(b).join(' ');
         }
 
-        css.eachComment(function (comment) {
-            if (remover.canRemove(comment.text)) {
-                comment.removeSelf();
+        css.eachInside(function (node) {
+            if (node.type === 'comment' && remover.canRemove(node.text)) {
+                return node.removeSelf();
             }
-        });
 
-        css.eachDecl(function (decl) {
-            decl.between = replaceComments(decl.between);
-            if (decl._value && decl._value.raw) {
-                var replaced = replaceComments(decl._value.raw);
-                decl._value.raw = decl._value.value = decl.value = replaced;
-            }
-            if (decl._important) {
-                decl._important = replaceComments(decl._important);
-                var b = balanced.matches({
-                    source: decl._important,
-                    open: '/*',
-                    close: '*/'
-                });
-                decl._important = b.length ? decl._important : '!important';
+            if (node.between) {
+                node.between = replaceComments(node.between);
             }
-        });
 
-        css.eachRule(function (rule) {
-            if (rule.between) {
-                rule.between = replaceComments(rule.between);
+            if (node.type === 'decl') {
+                if (node._value && node._value.raw) {
+                    var replaced = replaceComments(node._value.raw);
+                    node._value.raw = node._value.value = node.value = replaced;
+                }
+                if (node._important) {
+                    node._important = replaceComments(node._important);
+                    var b = balanced.matches({
+                        source: node._important,
+                        open: '/*',
+                        close: '*/'
+                    });
+                    node._important = b.length ? node._important : '!important';
+                }
+                return;
             }
-            if (rule._selector && rule._selector.raw) {
-                rule._selector.raw = replaceComments(rule._selector.raw);
+
+            if (node.type === 'rule' && node._selector && node._selector.raw) {
+                node._selector.raw = replaceComments(node._selector.raw);
+                return;
             }
-        });
 
-        css.eachAtRule(function (rule) {
-            if (rule.afterName) {
-                var commentsReplaced = replaceComments(rule.afterName);
-                if (!commentsReplaced.length) {
-                    rule.afterName = commentsReplaced + ' ';
-                } else {
-                    rule.afterName = ' ' + commentsReplaced + ' ';
+            if (node.type === 'atrule') {
+                if (node.afterName) {
+                    var commentsReplaced = replaceComments(node.afterName);
+                    if (!commentsReplaced.length) {
+                        node.afterName = commentsReplaced + ' ';
+                    } else {
+                        node.afterName = ' ' + commentsReplaced + ' ';
+                    }
+                }
+                if (node._params && node._params.raw) {
+                    node._params.raw = replaceComments(node._params.raw);
                 }
-            }
-            if (rule._params && rule._params.raw) {
-                rule._params.raw = replaceComments(rule._params.raw);
-            }
-            if (rule.between) {
-                rule.between = replaceComments(rule.between);
             }
         });
     };

package/package.json

@@ -1,10 +1,9 @@
 {
   "name": "postcss-discard-comments",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Discard comments in your CSS files with PostCSS.",
   "main": "index.js",
   "scripts": {
-    "lint": "jshint index.js lib/commentRemover.js --reporter node_modules/jshint-stylish/stylish.js",
     "test": "tape test.js | tap-spec"
   },
   "keywords": [
@@ -15,10 +14,8 @@
   ],
   "license": "MIT",
   "devDependencies": {
-    "jshint": "^2.6.3",
-    "jshint-stylish": "^1.0.1",
-    "tap-spec": "^2.2.2",
-    "tape": "^3.5.0"
+    "tap-spec": "^4.0.2",
+    "tape": "^4.1.0"
   },
   "homepage": "https://github.com/ben-eb/postcss-discard-comments",
   "author": {
@@ -32,6 +29,6 @@
   },
   "dependencies": {
     "node-balanced": "0.0.14",
-    "postcss": "^4.1.11"
+    "postcss": "^4.1.16"
   }
 }