portable-agent-layer 0.85.5 → 0.85.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "portable-agent-layer",
-  "version": "0.85.5",
+  "version": "0.85.6",
   "description": "PAL — Portable Agent Layer: persistent personal context for AI coding assistants",
   "type": "module",
   "bin": {

package/src/hooks/lib/interaction-preferences.ts

@@ -6,6 +6,7 @@
  */
 
 import { median } from "./interaction-mood";
+import { approvalIsKnown } from "./interaction-reaction";
 
 const MIN_REPLIES_PER_SIDE = 20;
 const MIN_GAP = 0.1;
@@ -20,6 +21,7 @@ interface ReplyFeatures {
 interface ReactedTurn {
   reply: ReplyFeatures | null;
   reaction: string | null;
+  reactionRules?: number;
 }
 
 interface Outcome {
@@ -41,7 +43,9 @@ export interface Split {
 
 function outcomes(events: ReactedTurn[]): Outcome[] {
   return events.flatMap((e) =>
-    e.reply && e.reaction ? [{ reply: e.reply, approved: e.reaction === "approved" }] : []
+    e.reply && e.reaction && approvalIsKnown(e)
+      ? [{ reply: e.reply, approved: e.reaction === "approved" }]
+      : []
   );
 }
 

package/src/hooks/lib/interaction-reaction.ts

@@ -6,7 +6,21 @@
 
 import { extractKeywords, similarity } from "./text-similarity";
 
-export type Reaction = "corrected" | "repeated" | "approved" | "new-topic" | "follow-up";
+export type Reaction =
+  | "corrected"
+  | "repeated"
+  | "approved"
+  | "go-ahead"
+  | "new-topic"
+  | "follow-up";
+
+/** Logged with each reaction, so a log read under older rules is not read with today's meaning. */
+export const REACTION_RULES = 2;
+const GO_AHEAD_SPLIT = 2;
+
+export function approvalIsKnown(turn: { reactionRules?: number }): boolean {
+  return (turn.reactionRules ?? 1) >= GO_AHEAD_SPLIT;
+}
 
 const CORRECTION_RE =
   /^(?:(?:no|nope|wrong)(?:[,.!]|$)|(?:that'?s|this is|it'?s) (?:wrong|not)\b|not what i\b|i said\b|i told you\b|you forgot\b|you missed\b|still (?:broken|failing|wrong)\b|i don'?t see (?:the|your) (?!(?:problem|issue|point|harm|difference|need|reason)\b))/i;
@@ -15,7 +29,10 @@ const CLAIM_DISPUTED_RE =
   /\byou(?:'re| are) (?:partially |partly |completely |totally )?wrong\b|\b(?:isn'?t|wasn'?t|aren'?t|weren'?t) (?:added|included|fixed|pushed|committed|applied|merged)\b/i;
 
 const APPROVAL_RE =
-  /^(?:(?:understood|got it|ok(?:ay)?),?\s+)?(?:good|great|nice|perfect|cool|amazing|awesome|excellent|brilliant|works|it works|thanks|thank you|thx|y+e+s+|yep|yeah|yup|sure|exactly|correct|agreed|lgtm|well done|love it|sounds good|looks good|that'?s it|(?:it|this|that) (?:is|'s) (?:fine|good|great|right))\b/i;
+  /^(?:(?:understood|got it|ok(?:ay)?),?\s+)?(?:good|great|nice|perfect|cool|amazing|awesome|excellent|brilliant|works|it works|thanks|thank you|thx|y+e+s+|yep|yeah|yup|sure|exactly|correct|agreed|lgtm|well done|love it|sounds good|looks good|that'?s it|(?:it|this|that)(?: is|'s) (?:fine|good|great|right))\b/i;
+
+const PRAISE_RE =
+  /\b(?:good|great|nice|perfect|cool|amazing|awesome|excellent|brilliant|works|thanks|thank you|thx|exactly|correct|agreed|lgtm|well done|good job|love it|sounds good|looks (?:good|right)|that'?s it|(?:it|this|that)(?: is|'s) (?:fine|good|great|right))\b/i;
 
 const GO_AHEAD_RE =
   /^(?:go ahead|go|do it|proceed|continue|merge|push|ship|commit|build|start|fix (?:all|them|both)|approved|let'?s (?:see|do|go|build|start|fix|ship)|(?:add|do|fix) (?:it )?(?:pls|please))\b/i;
@@ -51,7 +68,7 @@ function sentences(text: string): string[] {
     .filter(Boolean);
 }
 
-function isApproval(text: string): boolean {
+function isAcceptance(text: string): boolean {
   const trimmed = text.trim();
   if (trimmed.includes("?") || FAILURE_RE.test(trimmed)) return false;
   if (HEDGE_RE.test(trimmed.split(/[.!?\n]/)[0])) return false;
@@ -61,6 +78,11 @@ function isApproval(text: string): boolean {
   return isShortGoAhead(all[0] ?? "") && !HEDGE_RE.test(trimmed);
 }
 
+/** A yes or a go only gives permission to continue; approval judges the work itself. */
+function praisesTheResult(text: string): boolean {
+  return PRAISE_RE.test(text);
+}
+
 /** Word overlap was measured against real messages and does not separate topics; only saying so does. */
 function isNewTopic(text: string): boolean {
   return NEW_TOPIC_RE.test(text.trim());
@@ -69,7 +91,7 @@ function isNewTopic(text: string): boolean {
 export function reactionTo(text: string, previousPrompt: string | undefined): Reaction {
   if (isCorrection(text)) return "corrected";
   if (isRepeat(text, previousPrompt)) return "repeated";
-  if (isApproval(text)) return "approved";
+  if (isAcceptance(text)) return praisesTheResult(text) ? "approved" : "go-ahead";
   if (isNewTopic(text)) return "new-topic";
   return "follow-up";
 }

package/src/hooks/lib/interaction-samples.ts

@@ -21,6 +21,7 @@ export interface ReactionSample {
 const KEPT: Record<Reaction, number> = {
   "follow-up": 150,
   approved: 20,
+  "go-ahead": 20,
   corrected: 20,
   repeated: 20,
   "new-topic": 20,

package/src/hooks/lib/interaction.ts

@@ -26,6 +26,7 @@ import { shorterApprovedMore } from "./interaction-preferences";
 import {
   isCorrection,
   isRepeat,
+  REACTION_RULES,
   type Reaction,
   reactionTo,
 } from "./interaction-reaction";
@@ -51,6 +52,7 @@ export interface TurnEvent extends MoodTurn {
   weekday: string;
   reply: Omit<ReplyShape, "at"> | null;
   reaction: Reaction | null;
+  reactionRules?: number;
   mood?: string;
   hinted?: boolean;
   complied?: boolean;
@@ -129,6 +131,7 @@ function measureTurn(
     corrected: isCorrection(text),
     reply: reply ? replyFeatures(reply) : null,
     reaction: reply ? reactionTo(text, track.lastPrompt) : null,
+    ...(reply && { reactionRules: REACTION_RULES }),
   };
 }
 

package/src/tools/lib/interaction-report.ts

@@ -14,13 +14,14 @@ import {
   type Split,
   splits,
 } from "../../hooks/lib/interaction-preferences";
+import { approvalIsKnown } from "../../hooks/lib/interaction-reaction";
 
 const LABELS = ["short", "long", "fast", "skimming", "friction"] as const;
 
 interface ReplyUnderMood {
   labels: string[];
   words: number;
-  approved: boolean;
+  approved: boolean | null;
   corrected: boolean;
   complied?: boolean;
 }
@@ -52,6 +53,7 @@ export interface InteractionSummary {
   reactions: Record<string, number>;
   hints: Record<string, number>;
   unlogged: number;
+  readBeforeGoAhead: number;
   usual: ReplyStats;
   byLabel: Record<string, ReplyStats>;
   approvals: Approvals;
@@ -81,7 +83,10 @@ function stats(replies: ReplyUnderMood[]): ReplyStats {
   return {
     replies: replies.length,
     medianWords: median(replies.map((r) => r.words)),
-    approvedShare: share(replies, (r) => r.approved),
+    approvedShare: share(
+      replies.filter((r) => r.approved !== null),
+      (r) => r.approved === true
+    ),
     correctedShare: share(replies, (r) => r.corrected),
     followed: {
       checked: replies.filter((r) => r.complied !== undefined).length,
@@ -100,7 +105,7 @@ function repliesUnderMood(events: TurnEvent[]): ReplyUnderMood[] {
       replies.push({
         labels: mood ? mood.split(",") : [],
         words: e.reply.words,
-        approved: e.reaction === "approved",
+        approved: approvalIsKnown(e) ? e.reaction === "approved" : null,
         corrected: e.reaction === "corrected" || e.reaction === "repeated",
         complied: e.complied,
       });
@@ -109,6 +114,11 @@ function repliesUnderMood(events: TurnEvent[]): ReplyUnderMood[] {
   return replies;
 }
 
+function reactionName(e: TurnEvent): string {
+  if (e.reaction === "approved" && !approvalIsKnown(e)) return "approved or go-ahead";
+  return e.reaction ?? "";
+}
+
 /** A turn carries the reply that answered the turn before it, so a filed reply shows up there. */
 function byAgent(events: TurnEvent[]): Record<string, AgentCounts> {
   const agents: Record<string, AgentCounts> = {};
@@ -131,7 +141,8 @@ export function summarize(events: TurnEvent[]): InteractionSummary {
     sessions: new Set(events.map((e) => e.session)).size,
     channels: tally(events.map((e) => e.channel ?? "unknown")),
     agents: byAgent(events),
-    reactions: tally(events.flatMap((e) => (e.reaction ? [e.reaction] : []))),
+    reactions: tally(events.flatMap((e) => (e.reaction ? [reactionName(e)] : []))),
+    readBeforeGoAhead: events.filter((e) => e.reaction && !approvalIsKnown(e)).length,
     hints: tally(hinted.map((e) => e.mood || "back to usual")),
     unlogged: events.filter((e) => e.mood === undefined).length,
     usual: stats(replies.filter((r) => r.labels.length === 0)),
@@ -255,5 +266,10 @@ export function reportLines(summary: InteractionSummary, days: number): string[]
       "",
       `${summary.unlogged} older turns were logged before moods were, and are left out of the comparison.`
     );
+  if (summary.readBeforeGoAhead)
+    lines.push(
+      "",
+      `${summary.readBeforeGoAhead} older replies were read before go-ahead was split from approval, and are left out of the approval figures.`
+    );
   return lines;
 }