portable-agent-layer 0.70.0 → 0.72.0

package/src/tools/relationship-reflect.ts

@@ -13,371 +13,49 @@
  *   bun run tool:reflect -- --dry-run # Preview without writing
  */
 
-import { existsSync, mkdirSync, readdirSync, readFileSync, writeFileSync } from "node:fs";
+import { existsSync, mkdirSync, writeFileSync } from "node:fs";
 import { resolve } from "node:path";
 import { parseArgs } from "node:util";
-import {
-  addEvidence,
-  createOpinion,
-  findSimilarOpinion,
-  readOpinions,
-  saveOpinion,
-  setLastReflectDate,
-} from "../hooks/lib/opinions";
+import { readOpinions, saveOpinion, setLastReflectDate } from "../hooks/lib/opinions";
 import { palHome } from "../hooks/lib/paths";
-import { similarity } from "../hooks/lib/text-similarity";
 import { emit } from "./lib/emit";
+import {
+  consoleLines,
+  formatReport,
+  highConfidenceLines,
+  loadNotes,
+  loadRatings,
+  planPromotions,
+  reportPath,
+} from "./lib/relationship-reflect";
+
+const HELP = `
+RelationshipReflect — Periodic reflection + opinion promotion
 
-// ── Types ──
-
-interface Rating {
-  ts: string;
-  rating: number;
-  context: string;
-  source: "explicit" | "implicit";
-}
-
-interface ParsedNote {
-  type: "W" | "O" | "Session";
-  text: string;
-  confidence?: number;
-  date: string;
-  time: string;
-}
-
-interface OpinionChange {
-  statement: string;
-  action: "created" | "strengthened";
-  oldConfidence?: number;
-  newConfidence: number;
-}
-
-// ── Note Parsing ──
-
-export function loadNotes(daysBack: number): ParsedNote[] {
-  const relationshipDir = resolve(palHome(), "memory", "relationship");
-  if (!existsSync(relationshipDir)) return [];
-
-  const cutoff = new Date();
-  cutoff.setDate(cutoff.getDate() - daysBack);
-  const notes: ParsedNote[] = [];
-
-  for (const monthDir of readdirSync(relationshipDir).sort().reverse()) {
-    if (!/^\d{4}-\d{2}$/.test(monthDir)) continue;
-    const monthPath = resolve(relationshipDir, monthDir);
-
-    let files: string[];
-    try {
-      files = readdirSync(monthPath)
-        .filter((f) => f.endsWith(".md"))
-        .sort()
-        .reverse();
-    } catch {
-      continue;
-    }
-
-    for (const file of files) {
-      const dateStr = file.replace(".md", "");
-      if (new Date(dateStr) < cutoff) continue;
-
-      try {
-        const content = readFileSync(resolve(monthPath, file), "utf-8");
-        let currentTime = "";
-
-        for (const line of content.split("\n")) {
-          const timeMatch = new RegExp(/^## (\d{2}:\d{2})/).exec(line);
-          if (timeMatch) {
-            currentTime = timeMatch[1];
-            continue;
-          }
-
-          // O(c=0.85): text or B(c=0.85): text
-          const obMatch = new RegExp(/^- ([OB])\(c=([\d.]+)\):\s*(.+)$/).exec(line);
-          if (obMatch) {
-            notes.push({
-              type: obMatch[1] as "O" | "Session",
-              confidence: Number.parseFloat(obMatch[2]),
-              text: obMatch[3],
-              date: dateStr,
-              time: currentTime,
-            });
-            continue;
-          }
-
-          // W: text
-          const worldMatch = new RegExp(/^- W:\s*(.+)$/).exec(line);
-          if (worldMatch) {
-            notes.push({
-              type: "W",
-              text: worldMatch[1],
-              date: dateStr,
-              time: currentTime,
-            });
-          }
-        }
-      } catch {
-        // skip
-      }
-    }
-  }
-
-  return notes;
-}
-
-// ── Ratings ──
-
-export function loadRatings(daysBack: number): Rating[] {
-  const ratingsFile = resolve(palHome(), "memory", "signals", "ratings.jsonl");
-  if (!existsSync(ratingsFile)) return [];
-
-  const cutoff = new Date();
-  cutoff.setDate(cutoff.getDate() - daysBack);
-
-  return readFileSync(ratingsFile, "utf-8")
-    .split("\n")
-    .filter((l) => l.trim())
-    .map((l) => {
-      try {
-        return JSON.parse(l) as Rating;
-      } catch {
-        return null;
-      }
-    })
-    .filter(
-      (r): r is Rating => r !== null && new Date(r.ts).getTime() >= cutoff.getTime()
-    );
-}
-
-// ── Opinion Promotion ──
-
-export function promoteToOpinions(notes: ParsedNote[], dryRun: boolean): OpinionChange[] {
-  const changes: OpinionChange[] = [];
-  const opinions = readOpinions();
-
-  const opinionNotes = notes.filter((n) => n.type === "O");
-
-  // Group similar notes together
-  const groups = new Map<string, ParsedNote[]>();
-  for (const note of opinionNotes) {
-    let matched = false;
-    for (const [key, group] of groups) {
-      if (similarity(note.text, key) >= 0.3) {
-        group.push(note);
-        matched = true;
-        break;
-      }
-    }
-    if (!matched) {
-      groups.set(note.text, [note]);
-    }
-  }
-
-  for (const [representative, group] of groups) {
-    const existing = findSimilarOpinion(representative, opinions);
-
-    if (existing) {
-      let updated = existing;
-      for (const note of group) {
-        updated = addEvidence(updated, "supporting", note.text.slice(0, 120));
-      }
-
-      if (updated.confidence !== existing.confidence) {
-        changes.push({
-          statement: existing.statement,
-          action: "strengthened",
-          oldConfidence: existing.confidence,
-          newConfidence: updated.confidence,
-        });
-        if (!dryRun) saveOpinion(updated);
-      }
-    } else if (group.length >= 2) {
-      let opinion = createOpinion(representative, group[0].text.slice(0, 120));
-      for (const note of group.slice(1)) {
-        opinion = addEvidence(opinion, "supporting", note.text.slice(0, 120));
-      }
-      changes.push({
-        statement: representative,
-        action: "created",
-        newConfidence: opinion.confidence,
-      });
-      if (!dryRun) saveOpinion(opinion);
-    }
-  }
-
-  return changes;
-}
-
-// ── Analysis ──
-
-interface OpinionSummary {
-  text: string;
-  occurrences: number;
-  avgConfidence: number;
-  dates: string[];
-}
-
-export function groupNoteOccurrences(notes: ParsedNote[]): OpinionSummary[] {
-  const opNotes = notes.filter((n) => n.type === "O");
-  const groups = new Map<
-    string,
-    { confidences: number[]; dates: string[]; text: string }
-  >();
-
-  for (const note of opNotes) {
-    let matched = false;
-    for (const [key, group] of groups) {
-      if (similarity(note.text, key) >= 0.3) {
-        if (note.confidence !== undefined) group.confidences.push(note.confidence);
-        group.dates.push(note.date);
-        matched = true;
-        break;
-      }
-    }
-    if (!matched) {
-      groups.set(note.text, {
-        text: note.text,
-        confidences: note.confidence !== undefined ? [note.confidence] : [],
-        dates: [note.date],
-      });
-    }
-  }
-
-  return [...groups.values()]
-    .map((g) => ({
-      text: g.text,
-      occurrences: g.dates.length,
-      avgConfidence:
-        g.confidences.length > 0
-          ? g.confidences.reduce((a, b) => a + b, 0) / g.confidences.length
-          : 0,
-      dates: [...new Set(g.dates)],
-    }))
-    .sort((a, b) => b.occurrences - a.occurrences);
-}
-
-function correlateRatings(ratings: Rating[]): string[] {
-  const correlations: string[] = [];
-
-  const lowRatings = ratings.filter((r) => r.rating <= 4);
-  const highRatings = ratings.filter((r) => r.rating >= 7);
-
-  if (lowRatings.length > 0) {
-    const lowContexts = lowRatings
-      .slice(0, 3)
-      .map((r) => `"${r.context.slice(0, 60)}"`)
-      .join(", ");
-    correlations.push(
-      `${lowRatings.length} low ratings (<=4) — common contexts: ${lowContexts}`
-    );
-  }
-  if (highRatings.length > 0) {
-    const highContexts = highRatings
-      .slice(0, 3)
-      .map((r) => `"${r.context.slice(0, 60)}"`)
-      .join(", ");
-    correlations.push(
-      `${highRatings.length} high ratings (>=7) — common contexts: ${highContexts}`
-    );
-  }
-
-  if (ratings.length > 0) {
-    const explicitCount = ratings.filter((r) => r.source === "explicit").length;
-    const implicitCount = ratings.filter((r) => r.source === "implicit").length;
-    correlations.push(`Source mix: ${explicitCount} explicit, ${implicitCount} implicit`);
-  }
-
-  return correlations;
-}
-
-// ── Report ──
-
-export function formatReport(
-  period: string,
-  notes: ParsedNote[],
-  ratings: Rating[],
-  opinionChanges: OpinionChange[]
-): string {
-  const date = new Date().toISOString().slice(0, 10);
-  const avgRating =
-    ratings.length > 0 ? ratings.reduce((s, r) => s + r.rating, 0) / ratings.length : 0;
-  const summaries = groupNoteOccurrences(notes);
-  const worldFacts = notes.filter((n) => n.type === "W").map((n) => n.text);
-  const ratingInsights = correlateRatings(ratings);
-
-  const lines: string[] = [
-    "# Relationship Reflection",
-    "",
-    `**Period:** ${period}`,
-    `**Generated:** ${date}`,
-    `**Notes analyzed:** ${notes.length}`,
-    `**Ratings analyzed:** ${ratings.length}`,
-    `**Average Rating:** ${avgRating.toFixed(1)}/10`,
-    "",
-    "---",
-    "",
-  ];
-
-  if (opinionChanges.length > 0) {
-    lines.push("## Opinion Changes", "");
-    for (const change of opinionChanges) {
-      if (change.action === "created") {
-        lines.push(
-          `- **NEW** (${Math.round(change.newConfidence * 100)}%): ${change.statement}`
-        );
-      } else {
-        lines.push(
-          `- **+** ${Math.round(change.oldConfidence ?? 0 * 100)}% → ${Math.round(change.newConfidence * 100)}%: ${change.statement}`
-        );
-      }
-    }
-    lines.push("");
-  }
-
-  if (summaries.length > 0) {
-    lines.push("## Recurring Opinions", "");
-    for (const op of summaries) {
-      lines.push(
-        `- **${op.text}**`,
-        `  Seen ${op.occurrences}x | Avg confidence: ${op.avgConfidence.toFixed(2)} | Dates: ${op.dates.join(", ")}`,
-        ""
-      );
-    }
-  }
-
-  if (worldFacts.length > 0) {
-    lines.push("## World Facts Observed", "");
-    for (const fact of worldFacts.slice(0, 10)) {
-      lines.push(`- ${fact}`);
-    }
-    lines.push("");
-  }
-
-  if (ratingInsights.length > 0) {
-    lines.push("## Rating Insights", "");
-    for (const insight of ratingInsights) {
-      lines.push(`- ${insight}`);
-    }
-    lines.push("");
-  }
+Reads recent relationship notes and ratings. Promotes recurring
+observations (O type) into tracked opinions with confidence scoring.
 
-  return lines.join("\n");
-}
+Usage:
+  bun run tool:reflect              Reflect on last 7 days (default)
+  bun run tool:reflect -- --month   Reflect on last 30 days
+  bun run tool:reflect -- --dry-run Preview without writing
 
-export function writeReport(report: string, period: string): string {
-  const reflectionDir = resolve(palHome(), "memory", "relationship", "reflections");
-  if (!existsSync(reflectionDir)) mkdirSync(reflectionDir, { recursive: true });
+Output:
+  - Updates memory/relationship/opinions.json (confidence tracking)
+  - Creates reflection report in memory/relationship/reflections/
+`;
 
-  const date = new Date().toISOString().slice(0, 10);
-  const slug = period.toLowerCase().replace(/\s+/g, "-");
-  const filename = `${date}_${slug}-reflection.md`;
-  const filepath = resolve(reflectionDir, filename);
+const relationshipDir = () => resolve(palHome(), "memory", "relationship");
+const ratingsFile = () => resolve(palHome(), "memory", "signals", "ratings.jsonl");
 
+function saveReport(report: string, period: string): string {
+  const dir = resolve(relationshipDir(), "reflections");
+  if (!existsSync(dir)) mkdirSync(dir, { recursive: true });
+  const filepath = reportPath(dir, period);
   writeFileSync(filepath, report, "utf-8");
   return filepath;
 }
 
-// ── CLI ──
-
 function run() {
   const { values } = parseArgs({
     args: Bun.argv.slice(2),
@@ -389,21 +67,7 @@ function run() {
   });
 
   if (values.help) {
-    console.log(`
-RelationshipReflect — Periodic reflection + opinion promotion
-
-Reads recent relationship notes and ratings. Promotes recurring
-observations (O type) into tracked opinions with confidence scoring.
-
-Usage:
-  bun run tool:reflect              Reflect on last 7 days (default)
-  bun run tool:reflect -- --month   Reflect on last 30 days
-  bun run tool:reflect -- --dry-run Preview without writing
-
-Output:
-  - Updates memory/relationship/opinions.json (confidence tracking)
-  - Creates reflection report in memory/relationship/reflections/
-`);
+    console.log(HELP);
     process.exit(0);
   }
 
@@ -411,8 +75,8 @@ Output:
   const period = values.month ? "Monthly" : "Weekly";
   const dryRun = values["dry-run"] ?? false;
 
-  const notes = loadNotes(daysBack);
-  const ratings = loadRatings(daysBack);
+  const notes = loadNotes(relationshipDir(), daysBack);
+  const ratings = loadRatings(ratingsFile(), daysBack);
 
   emit.ok(`Loaded ${notes.length} notes from last ${daysBack} days`);
   emit.ok(`Loaded ${ratings.length} ratings`);
@@ -422,54 +86,26 @@ Output:
     process.exit(0);
   }
 
-  const opinionChanges = promoteToOpinions(notes, dryRun);
-
-  const avgRating =
-    ratings.length > 0 ? ratings.reduce((s, r) => s + r.rating, 0) / ratings.length : 0;
-  emit.ok(`\nAverage Rating: ${avgRating.toFixed(1)}/10`);
+  const plan = planPromotions(notes, readOpinions());
+  if (!dryRun) for (const opinion of plan.toSave) saveOpinion(opinion);
 
-  const summaries = groupNoteOccurrences(notes);
-  emit.ok(`Observations: ${summaries.length} unique`);
-
-  if (opinionChanges.length > 0) {
-    emit.ok("\nOpinion changes:");
-    for (const change of opinionChanges) {
-      if (change.action === "created") {
-        emit.ok(
-          `  + NEW (${Math.round(change.newConfidence * 100)}%) ${change.statement.slice(0, 80)}`
-        );
-      } else {
-        emit.ok(
-          `  ~ ${Math.round(change.oldConfidence ?? 0 * 100)}% → ${Math.round(change.newConfidence * 100)}% ${change.statement.slice(0, 80)}`
-        );
-      }
-    }
-  } else {
-    emit.ok("\nNo opinion changes");
-  }
+  for (const line of consoleLines(notes, ratings, plan.changes)) emit.ok(line);
 
   if (dryRun) {
     emit.data("[DRY RUN] Would write reflection report + update opinions");
-  } else {
-    const report = formatReport(period, notes, ratings, opinionChanges);
-    const filepath = writeReport(report, period);
-    setLastReflectDate(new Date().toISOString().slice(0, 10));
-    emit.receipt(filepath, {
-      period,
-      notes: notes.length,
-      ratings: ratings.length,
-      opinionChanges: opinionChanges.length,
-    });
-
-    const opinions = readOpinions();
-    const high = opinions.filter((o) => o.confidence >= 0.85);
-    if (high.length > 0) {
-      emit.ok("\nHigh-confidence opinions (injected into context):");
-      for (const o of high) {
-        emit.ok(`  [${Math.round(o.confidence * 100)}%] ${o.statement.slice(0, 80)}`);
-      }
-    }
+    return;
   }
+
+  const filepath = saveReport(formatReport(period, notes, ratings, plan.changes), period);
+  setLastReflectDate(new Date().toISOString().slice(0, 10));
+  emit.receipt(filepath, {
+    period,
+    notes: notes.length,
+    ratings: ratings.length,
+    opinionChanges: plan.changes.length,
+  });
+
+  for (const line of highConfidenceLines(readOpinions())) emit.ok(line);
 }
 
 if (import.meta.main) run();