portable-agent-layer 0.63.0 → 0.63.1

package/assets/templates/hooks.copilot.json

@@ -4,33 +4,39 @@
     "sessionStart": [
       {
         "type": "command",
-        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/LoadContext.ts"
+        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/LoadContext.ts",
+        "powershell": "$env:PAL_AGENT='copilot'; bun run {{PKG_ROOT}}/src/hooks/LoadContext.ts"
       }
     ],
     "userPromptSubmitted": [
       {
         "type": "command",
-        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/UserPromptOrchestrator.ts"
+        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/UserPromptOrchestrator.ts",
+        "powershell": "$env:PAL_AGENT='copilot'; bun run {{PKG_ROOT}}/src/hooks/UserPromptOrchestrator.ts"
       }
     ],
     "preToolUse": [
       {
         "type": "command",
-        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/SecurityValidator.ts"
+        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/SecurityValidator.ts",
+        "powershell": "$env:PAL_AGENT='copilot'; bun run {{PKG_ROOT}}/src/hooks/SecurityValidator.ts"
       },
       {
         "type": "command",
-        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/SkillGuard.ts"
+        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/SkillGuard.ts",
+        "powershell": "$env:PAL_AGENT='copilot'; bun run {{PKG_ROOT}}/src/hooks/SkillGuard.ts"
       },
       {
         "type": "command",
-        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/RtkWrap.ts"
+        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/RtkWrap.ts",
+        "powershell": "$env:PAL_AGENT='copilot'; bun run {{PKG_ROOT}}/src/hooks/RtkWrap.ts"
       }
     ],
     "agentStop": [
       {
         "type": "command",
-        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/StopOrchestrator.ts"
+        "bash": "PAL_AGENT=copilot bun run {{PKG_ROOT}}/src/hooks/StopOrchestrator.ts",
+        "powershell": "$env:PAL_AGENT='copilot'; bun run {{PKG_ROOT}}/src/hooks/StopOrchestrator.ts"
       }
     ]
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "portable-agent-layer",
-  "version": "0.63.0",
+  "version": "0.63.1",
   "description": "PAL — Portable Agent Layer: persistent personal context for AI coding assistants",
   "type": "module",
   "bin": {

package/src/cli/index.ts

@@ -80,6 +80,20 @@ function checkTool(cmd: string, versionArgs: string[] = ["--version"]): ToolChec
   return { name: cmd, available: false };
 }
 
+/**
+ * Copilot ships as a VS Code extension as well as a CLI, and the extension puts
+ * no `copilot` binary on PATH — but both read hooks, skills and agents out of
+ * ~/.copilot. Fall back to that directory so PAL's copilot checks still run.
+ */
+function checkCopilot(): ToolCheck {
+  const cli = checkTool("copilot", ["version"]);
+  if (cli.available) return cli;
+  if (existsSync(platform.copilotDir())) {
+    return { name: "copilot", available: true, version: "~/.copilot (no CLI on PATH)" };
+  }
+  return cli;
+}
+
 function detectAgent(): string | null {
   if (checkTool("claude").available) return "claude";
   if (checkTool("opencode").available) return "opencode";
@@ -443,13 +457,18 @@ function checkCopilotInstructionsPresent(): boolean {
 
 // ── Install integrity (Tier 2 doctor checks) ──
 
-/** Recursively collect every `command` or `bash` field value in a hook-config JSON. */
+/** Hook-config keys that carry a shell command: cross-platform and per-shell variants. */
+function isHookCommandField(key: string): boolean {
+  return key === "command" || key === "bash" || key === "powershell";
+}
+
+/** Recursively collect every command-carrying field value in a hook-config JSON. */
 function extractAllHookCommands(obj: unknown, out: string[] = []): string[] {
   if (Array.isArray(obj)) {
     for (const item of obj) extractAllHookCommands(item, out);
   } else if (obj && typeof obj === "object") {
     for (const [k, v] of Object.entries(obj)) {
-      if ((k === "command" || k === "bash") && typeof v === "string") {
+      if (isHookCommandField(k) && typeof v === "string") {
         out.push(v);
       } else {
         extractAllHookCommands(v, out);
@@ -466,14 +485,21 @@ interface HookPrefixCheck {
   firstMissing?: string;
 }
 
-/** Verify every command in an installed hook file starts with `PAL_AGENT=<agent>`. */
+/** True when a hook command sets PAL_AGENT up front, in POSIX or PowerShell syntax. */
+function setsAgentEnvPrefix(cmd: string, agentName: string): boolean {
+  return (
+    cmd.startsWith(`PAL_AGENT=${agentName} `) ||
+    cmd.startsWith(`$env:PAL_AGENT='${agentName}'; `)
+  );
+}
+
+/** Verify every command in an installed hook file sets `PAL_AGENT=<agent>` first. */
 function checkAgentHookPrefix(filePath: string, agentName: string): HookPrefixCheck {
   if (!existsSync(filePath)) return { ok: false, total: 0, missing: 0 };
   try {
     const data = JSON.parse(readFileSync(filePath, "utf-8"));
     const commands = extractAllHookCommands(data.hooks ?? data);
-    const prefix = `PAL_AGENT=${agentName} `;
-    const missing = commands.filter((c) => !c.startsWith(prefix));
+    const missing = commands.filter((c) => !setsAgentEnvPrefix(c, agentName));
     return {
       ok: commands.length > 0 && missing.length === 0,
       total: commands.length,
@@ -701,7 +727,7 @@ function doctor(silent = false): DoctorResult {
   const claude = checkTool("claude");
   const opencode = checkTool("opencode");
   const cursor = checkTool("cursor");
-  const copilot = checkTool("copilot", ["version"]);
+  const copilot = checkCopilot();
   const codex = checkTool("codex");
   const rtk = checkTool("rtk");
   const hasAgent =

package/src/targets/copilot/uninstall.ts

@@ -7,11 +7,11 @@
 import { copyFileSync, existsSync, lstatSync, readlinkSync, unlinkSync } from "node:fs";
 import { resolve } from "node:path";
 import { platform } from "../../hooks/lib/paths";
-import { copilotFilename, getSemiStaticSources } from "../../hooks/lib/semi-static";
 import {
   log,
   readJson,
   removeAgentsFromCopilot,
+  removePalContextFiles,
   removePalDocs,
   removeSkills,
   vscodeSettingsFile,
@@ -49,20 +49,13 @@ if (removedAgents.length > 0) {
 removePalDocs();
 
 // --- Remove ~/.copilot/instructions/pal-*.instructions.md ---
-for (const src of getSemiStaticSources()) {
-  try {
-    unlinkSync(resolve(COPILOT_DIR, "instructions", copilotFilename(src)));
-  } catch {
-    /* gone */
-  }
-}
-// pal-session.instructions.md is written by LoadContext (not a semi-static source)
-try {
-  unlinkSync(resolve(COPILOT_DIR, "instructions", "pal-session.instructions.md"));
-} catch {
-  /* gone */
-}
-log.success("Removed ~/.copilot/instructions/pal-*.instructions.md");
+const removedInstructions = removePalContextFiles(
+  resolve(COPILOT_DIR, "instructions"),
+  ".instructions.md"
+);
+log.success(
+  `Removed ${removedInstructions.length} ~/.copilot/instructions/pal-*.instructions.md`
+);
 
 // --- Backward compat: remove old copilot-instructions.md symlink if present ---
 const legacyPath = resolve(COPILOT_DIR, "copilot-instructions.md");

package/src/targets/cursor/uninstall.ts

@@ -4,15 +4,15 @@
  * Removes PAL skill symlinks.
  */
 
-import { copyFileSync, existsSync, unlinkSync } from "node:fs";
+import { copyFileSync, existsSync } from "node:fs";
 import { resolve } from "node:path";
 import { assets, palPkg, platform } from "../../hooks/lib/paths";
-import { cursorFilename, getSemiStaticSources } from "../../hooks/lib/semi-static";
 import {
   loadCursorHooksTemplate,
   log,
   readJson,
   removeAgentsFromCursor,
+  removePalContextFiles,
   removePalDocs,
   removeSkills,
   removeStatusline,
@@ -73,19 +73,7 @@ if (existsSync(CLI_CONFIG)) {
 removeStatusline("cursor");
 
 // --- Remove ~/.cursor/rules/pal-*.mdc ---
-for (const src of getSemiStaticSources()) {
-  try {
-    unlinkSync(resolve(CURSOR_DIR, "rules", cursorFilename(src)));
-  } catch {
-    /* gone */
-  }
-}
-// Backward compat: remove legacy merged file if present
-try {
-  unlinkSync(resolve(CURSOR_DIR, "rules", "pal-context.mdc"));
-} catch {
-  /* gone */
-}
-log.success("Removed ~/.cursor/rules/pal-*.mdc");
+const removedRules = removePalContextFiles(resolve(CURSOR_DIR, "rules"), ".mdc");
+log.success(`Removed ${removedRules.length} ~/.cursor/rules/pal-*.mdc`);
 
 log.success("Cursor uninstall complete");

package/src/targets/lib.ts

@@ -838,6 +838,29 @@ function ensureSymlink(link: string, target: string, type: "dir" | "junction"):
   symlinkSync(target, link, type);
 }
 
+/**
+ * Remove every `pal-*` context file with the given suffix from a directory.
+ *
+ * Globs rather than iterating getSemiStaticSources(): a slug retired from that
+ * registry keeps its already-written file on disk, and a registry-driven delete
+ * can no longer name it — agents then keep loading retired context forever.
+ * Also catches the legacy pre-split filenames without needing a special case.
+ */
+export function removePalContextFiles(dir: string, suffix: string): string[] {
+  if (!existsSync(dir)) return [];
+  const removed: string[] = [];
+  for (const file of readdirSync(dir)) {
+    if (!file.startsWith("pal-") || !file.endsWith(suffix)) continue;
+    try {
+      unlinkSync(resolve(dir, file));
+      removed.push(file);
+    } catch {
+      /* gone or not ours to remove */
+    }
+  }
+  return removed;
+}
+
 /** Remove PAL skill symlinks from ~/.pal/skills/ and ~/.claude/skills/ */
 export function removeSkills(claudeSkillsDir: string): string[] {
   const skillsDir = assets.skills();