portable-agent-layer 0.115.0 → 0.115.1-canary.1

package/assets/plugins/dark-factory/README.md

@@ -136,11 +136,13 @@ The repo's `CLAUDE.md` is read from your checkout when the task starts, so a rol
 - `"repoInstructions": false` in `.dark-factory.json` leaves out the repo's `CLAUDE.md`.
 - `"userInstructions": false` in `$DARK_FACTORY_HOME/config.json` (`~/.dark-factory/config.json`, optional; a missing file means both parts are on) leaves out your `~/.claude/CLAUDE.md`.
 
-Hooks never run in a role, and neither do your settings or MCP servers.
+Your own hooks never run in a role, and neither do MCP servers. The repo's hooks do run, so a repo `Stop` hook that fails its checks keeps the role working until they pass; the gate stays as the check for repos without hooks.
+
+A role loads the repo's `.claude/settings.json` and `.claude/settings.local.json` from its worktree as Claude Code does, permissions included. Your `~/.claude/settings.json` (or `CLAUDE_CONFIG_DIR`) is passed in `--settings` without `hooks`, `permissions`, `enabledPlugins` and `extraKnownMarketplaces`, so commit attribution and your other preferences apply. Each role call records which of your keys it passed and dropped as a `role_settings` event, without their values.
 
 ## Permissions
 
-- Roles run isolated: `--setting-sources ""`, the plugin from `--plugin-dir`, and their own tool policy from `roles.mjs`, so user hooks and settings don't reach them; only the CLAUDE.md instructions above do.
+- Roles run with `--setting-sources project,local`, the plugin from `--plugin-dir`, and their own tool policy from `roles.mjs`. Your user settings come only through the filtered `--settings` file, so your hooks don't reach them. A repo's `permissions.allow` can widen a role's tools; the role's denies still win.
 - The PO session only needs `"Bash(node *dark-factory*/scripts/*)"`, for example in `.claude/settings.json`:
 
 ```json

package/assets/plugins/dark-factory/scripts/role.mjs

@@ -13,6 +13,7 @@ import {
   userHome,
 } from "./lib.mjs";
 import { policyFor, schemaFor } from "./roles.mjs";
+import { writeRoleSettings } from "./settings.mjs";
 
 export const DEFAULT_TIMEOUT_MS = 30 * 60 * 1000;
 export const ONE_COMMAND_PER_CALL =
@@ -298,6 +299,7 @@ export function claudeInvocation(
     resumeSessionId,
     pluginDir = PLUGIN_ROOT,
     instructionsFile,
+    settingsFile,
   } = {}
 ) {
   const policy = policyFor(role);
@@ -312,7 +314,8 @@ export function claudeInvocation(
       "--output-format",
       "json",
       "--setting-sources",
-      "",
+      "project,local",
+      ...optionalFlag("--settings", settingsFile),
       "--plugin-dir",
       pluginDir,
       ...optionalFlag("--append-system-prompt-file", instructionsFile),
@@ -353,6 +356,7 @@ function attempt(
   try {
     const task = readTask(taskId, env);
     const instructionsFile = writeRoleInstructions(task, env);
+    const settingsFile = writeRoleSettings(task, env);
     const invocation = claudeInvocation(task, role, {
       budgetUsd,
       extraArgs,
@@ -361,6 +365,7 @@ function attempt(
       instructions,
       resumeSessionId,
       instructionsFile,
+      settingsFile,
     });
     const outcome = outcomeFrom(
       taskId,

package/assets/plugins/dark-factory/scripts/settings.mjs

@@ -0,0 +1,62 @@
+import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+import { appendEvent, taskDir, userHome } from "./lib.mjs";
+
+const SETTINGS_FILE = "role-settings.json";
+const KEYS_THAT_BREAK_ISOLATION = [
+  "hooks",
+  "permissions",
+  "enabledPlugins",
+  "extraKnownMarketplaces",
+];
+
+function isPlainObject(value) {
+  return value !== null && typeof value === "object" && !Array.isArray(value);
+}
+
+function readJsonObject(file) {
+  try {
+    const value = JSON.parse(readFileSync(file, "utf8"));
+    return isPlainObject(value) ? value : null;
+  } catch {
+    return null;
+  }
+}
+
+function userSettings(env) {
+  const configDir = env.CLAUDE_CONFIG_DIR || join(userHome(env), ".claude");
+  return readJsonObject(join(configDir, "settings.json")) ?? {};
+}
+
+export function roleSettingsFrom(userSettings) {
+  const kept = Object.fromEntries(
+    Object.entries(userSettings).filter(
+      ([key]) => !KEYS_THAT_BREAK_ISOLATION.includes(key)
+    )
+  );
+  return Object.keys(kept).length > 0 ? kept : null;
+}
+
+function recordRoleSettings(taskId, user, kept, env) {
+  appendEvent(
+    {
+      event: "role_settings",
+      task: taskId,
+      passed: Object.keys(kept ?? {}),
+      dropped: Object.keys(user).filter((key) => KEYS_THAT_BREAK_ISOLATION.includes(key)),
+    },
+    env
+  );
+}
+
+export function writeRoleSettings(task, env = process.env) {
+  const user = userSettings(env);
+  const kept = roleSettingsFrom(user);
+  recordRoleSettings(task.id, user, kept, env);
+  if (kept === null) return null;
+  const dir = taskDir(task.id, env);
+  mkdirSync(dir, { recursive: true });
+  const file = join(dir, SETTINGS_FILE);
+  writeFileSync(file, `${JSON.stringify(kept, null, 2)}\n`, { mode: 0o600 });
+  return file;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "portable-agent-layer",
-  "version": "0.115.0",
+  "version": "0.115.1-canary.1",
   "description": "PAL — Portable Agent Layer: persistent personal context for AI coding assistants",
   "type": "module",
   "bin": {