portable-agent-layer 0.108.0 → 0.109.0

package/src/tools/control-room/ui/dist/index.html

@@ -10,7 +10,7 @@
       rel="stylesheet"
       href="https://fonts.googleapis.com/css2?family=Barlow:wght@400;500;600&family=Barlow+Condensed:wght@400;500;600&display=swap"
     />
-    <script type="module" crossorigin src="/assets/index-mFpXpiBj.js"></script>
+    <script type="module" crossorigin src="/assets/index-D0pEd7Ln.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-DeglMbfS.css">
   </head>
   <body>

package/src/tools/control-room/ui/lib/write.ts

@@ -3,6 +3,8 @@
  * server's own error text, so a refusal reads the same wherever it surfaces.
  */
 
+import type { PageDecision } from "../../relationship";
+
 export async function post(path: string, body: unknown): Promise<string | null> {
   try {
     const res = await fetch(path, {
@@ -46,7 +48,7 @@ export function setAutoUpdate(enabled: boolean) {
   return post("/api/update", { enabled });
 }
 
-export function decideRule(id: string, decision: "approved" | "denied") {
+export function decideRule(id: string, decision: PageDecision) {
   return post("/api/rule", { id, decision });
 }
 

package/src/tools/control-room/ui/screens/relationship.tsx

@@ -3,7 +3,14 @@ import type {
   AdaptationRule,
   TriggerProof,
 } from "../../../../hooks/lib/adaptation-rules";
-import type { ActiveRule, PipelineCandidate, RelationshipView } from "../../relationship";
+import type { OpinionEffect } from "../../../../hooks/lib/correction-rates";
+import type {
+  ActiveRule,
+  DraftRule,
+  PageDecision,
+  PipelineCandidate,
+  RelationshipView,
+} from "../../relationship";
 import { Badge } from "../components/badge";
 import { Button } from "../components/button";
 import { clock } from "../format";
@@ -33,9 +40,14 @@ function Facts({ rows }: { rows: [string, string | undefined][] }) {
   );
 }
 
+function triggerLine(rule: AdaptationRule): string {
+  if (rule.delivery === "always") return "none, an opinion steers every session";
+  return rule.trigger ? `${rule.trigger.side} · /${rule.trigger.pattern}/i` : "none";
+}
+
 function ruleFacts(rule: AdaptationRule): [string, string | undefined][] {
   return [
-    ["trigger", `${rule.trigger.side} · /${rule.trigger.pattern}/i`],
+    ["trigger", triggerLine(rule)],
     ["steering", rule.steering],
     ["check", rule.check],
     ["proof", proofLine(rule.proof)],
@@ -56,43 +68,82 @@ function Evidence({ items }: { items: string[] }) {
 function replacedTrigger(rule: AdaptationRule, active: ActiveRule[]): string | undefined {
   if (!rule.widens) return undefined;
   const target = active.find((r) => r.id === rule.widens);
-  if (!target) return `the trigger of rule ${rule.widens}`;
+  if (!target?.trigger) return `the trigger of rule ${rule.widens}`;
   return `/${target.trigger.pattern}/i`;
 }
 
-function Draft({
-  rule,
-  active,
-  onDecided,
-}: {
-  rule: AdaptationRule;
-  active: ActiveRule[];
-  onDecided: () => void;
-}) {
+function useDecision(id: string, onDecided: () => void) {
   const [error, setError] = useState<string | null>(null);
   const [busy, setBusy] = useState(false);
-  const decide = (decision: "approved" | "denied") => {
+  const decide = (decision: PageDecision) => {
     setBusy(true);
-    void decideRule(rule.id, decision).then((failure) => {
+    void decideRule(id, decision).then((failure) => {
       setBusy(false);
       setError(failure);
       if (!failure) onDecided();
     });
   };
+  return { error, busy, decide };
+}
+
+function Refusal({ error }: { error: string | null }) {
+  if (!error) return null;
+  return (
+    <p className="border-l-2 border-alarm bg-alarm/10 px-3 py-2 text-[12px] text-alarm">
+      {error}
+    </p>
+  );
+}
+
+function offeredDecisions(rule: AdaptationRule): [PageDecision, string][] {
+  if (rule.widens) return [["approved", "Approve"]];
+  const asOpinion: [PageDecision, string][] =
+    rule.kind && !rule.opinionGate ? [["opinion", "Keep as opinion"]] : [];
+  if (rule.offer === "opinion-only") return asOpinion;
+  return [["approved", "Approve as rule"], ...asOpinion];
+}
+
+function offerLine(rule: AdaptationRule): string | undefined {
+  if (rule.offer !== "opinion-only" || rule.opinionGate) return undefined;
+  const why = rule.trigger ? "the trigger did not prove" : "no trigger";
+  return `${why}; keep it as an opinion or deny it`;
+}
+
+function Draft({
+  rule,
+  active,
+  onDecided,
+}: {
+  rule: DraftRule;
+  active: ActiveRule[];
+  onDecided: () => void;
+}) {
+  const { error, busy, decide } = useDecision(rule.id, onDecided);
   return (
     <div className="flex flex-col gap-3 border-t border-divider py-3 first:border-t-0">
       <div className="font-heading text-[15px] font-semibold">{rule.when}</div>
-      <Facts rows={[["replaces", replacedTrigger(rule, active)], ...ruleFacts(rule)]} />
+      <Facts
+        rows={[
+          ["replaces", replacedTrigger(rule, active)],
+          ...ruleFacts(rule),
+          ["kind", rule.kind],
+          ["offer", offerLine(rule)],
+          ["no opinion", rule.gateAdvice],
+        ]}
+      />
       <Evidence items={rule.evidence} />
-      {error && (
-        <p className="border-l-2 border-alarm bg-alarm/10 px-3 py-2 text-[12px] text-alarm">
-          {error}
-        </p>
-      )}
-      <div className="flex gap-3">
-        <Button variant="primary" disabled={busy} onClick={() => decide("approved")}>
-          Approve
-        </Button>
+      <Refusal error={error} />
+      <div className="flex flex-wrap gap-3">
+        {offeredDecisions(rule).map(([decision, label], i) => (
+          <Button
+            key={decision}
+            variant={i === 0 ? "primary" : undefined}
+            disabled={busy}
+            onClick={() => decide(decision)}
+          >
+            {label}
+          </Button>
+        ))}
         <Button disabled={busy} onClick={() => decide("denied")}>
           Deny
         </Button>
@@ -101,18 +152,39 @@ function Draft({
   );
 }
 
-function effectLine(rule: ActiveRule): string {
+function firingLine(rule: ActiveRule): string {
   const { fired, sentBack, judged, correctedAfter } = rule.effect;
   if (fired === 0) return "has not fired yet";
-  const back = rule.trigger.side === "reply" ? `, sent back ${sentBack}` : "";
+  const back = rule.trigger?.side === "reply" ? `, sent back ${sentBack}` : "";
   return `fired ${fired}${back} · corrected after ${correctedAfter} of ${judged} judged`;
 }
 
-function Active({ rule }: { rule: ActiveRule }) {
+function windowsLine({ before, after }: Pick<OpinionEffect, "before" | "after">): string {
+  return `${before.per100.toFixed(1)}/100 before (${before.count} in ${before.turns}) → ${after.per100.toFixed(1)}/100 after (${after.count} in ${after.turns})`;
+}
+
+function effectRows(rule: ActiveRule): [string, string | undefined][] {
+  const opinion = rule.opinionEffect;
+  if (!opinion) return [["effect", firingLine(rule)]];
+  return [
+    ["kind", opinion.kind],
+    ["effect", `${windowsLine(opinion)} · ${opinion.verdict}`],
+    ["other kinds", windowsLine(opinion.control)],
+  ];
+}
+
+function Active({ rule, onDecided }: { rule: ActiveRule; onDecided: () => void }) {
+  const { error, busy, decide } = useDecision(rule.id, onDecided);
   return (
     <div className="flex flex-col gap-2 border-t border-divider py-3 first:border-t-0">
       <div className="font-heading text-[15px] font-semibold">{rule.when}</div>
-      <Facts rows={[...ruleFacts(rule), ["effect", effectLine(rule)]]} />
+      <Facts rows={[...ruleFacts(rule), ...effectRows(rule)]} />
+      <Refusal error={error} />
+      <div>
+        <Button disabled={busy} onClick={() => decide("retired")}>
+          Retire
+        </Button>
+      </div>
     </div>
   );
 }
@@ -230,7 +302,7 @@ export function Relationship() {
         {active.length === 0 ? (
           <Empty>No rule approved yet.</Empty>
         ) : (
-          active.map((rule) => <Active key={rule.id} rule={rule} />)
+          active.map((rule) => <Active key={rule.id} rule={rule} onDecided={reload} />)
         )}
       </Panel>
       <LastDays view={view.data} />