porffor 0.55.26 → 0.55.28

package/compiler/builtins/_internal_object.ts

@@ -188,6 +188,7 @@ export const __Porffor_object_hash = (key: any): i32 => {
 
   // bytestring or string, fnv-1a hash (custom variant)
   // todo/opt: custom wasm simd variant?
+  // todo/opt: pgo for if no hash collisions?
 
   let ptr: i32 = Porffor.wasm`local.get ${key}`;
   const len: i32 = Porffor.wasm.i32.load(key, 0, 0);
@@ -371,15 +372,9 @@ export const __Porffor_object_lookup = (obj: any, target: any, targetHash: i32):
   let ptr: i32 = Porffor.wasm`local.get ${obj}` + 8;
   const endPtr: i32 = ptr + Porffor.wasm.i32.load16_u(obj, 0, 0) * 18;
 
-  let out: boolean = false;
   if (Porffor.wasm`local.get ${target+1}` == Porffor.TYPES.symbol) {
     for (; ptr < endPtr; ptr += 18) {
       const key: i32 = Porffor.wasm.i32.load(ptr, 0, 4);
-      if (key == 0) {
-        if (out) break; // ran out of keys
-        out = true;
-      }
-
       if ((key >>> 30) == 3) { // MSB 1 and 2 set, symbol (unset MSB x2)
         // todo: remove casts once weird bug which breaks unrelated things is fixed (https://github.com/CanadaHonk/porffor/commit/5747f0c1f3a4af95283ebef175cdacb21e332a52)
         if ((key & 0x3FFFFFFF) as symbol == target as symbol) return ptr;
@@ -389,6 +384,11 @@ export const __Porffor_object_lookup = (obj: any, target: any, targetHash: i32):
     for (; ptr < endPtr; ptr += 18) {
       if (Porffor.wasm.i32.load(ptr, 0, 0) == targetHash) {
         const key: i32 = Porffor.wasm.i32.load(ptr, 0, 4);
+
+        // fast path: check if same pointer first
+        if (key == Porffor.wasm`local.get ${target}`) return ptr;
+
+        // slow path: strcmp
         Porffor.wasm`
 local.get ${key}
 i32.const 2147483647

package/compiler/builtins_precompiled.js

@@ -86,9 +86,9 @@ params:[127,127],typedParams:1,returns:[127],returnType:1,
 locals:[127,127,127,127,126,126],localNames:["key","key#type","ptr","len","hash","endPtr","x","shift"],
 }
 this.__Porffor_object_lookup = {
-wasm:(_,{builtin})=>[[32,0],[69],[4,64],[65,127],[15],[26],[11],[32,1],[65,7],[71],[4,64],[32,0],[183],[32,1],[16,builtin('__Porffor_object_underlying')],[33,6],[252,2],[33,0],[32,6],[34,1],[65,7],[71],[4,64],[65,127],[15],[26],[11],[11],[32,0],[65,8],[106],[34,7],[32,0],[47,0,0],[65,18],[108],[106],[33,8],[65,0],[33,9],[32,3],[65,5],[70],[4,64],[3,64],[32,7],[32,8],[72],[4,64],[2,64],[32,7],[40,0,4],[34,10],[69],[4,64],[32,9],[4,64],[12,3],[26],[11],[65,1],[33,9],[11],[32,10],[65,30],[118],[65,3],[70],[4,64],[32,10],[65,255,255,255,255,3],[113],[32,2],[70],[4,64],[32,7],[15],[26],[11],[11],[11],[32,7],[65,18],[106],[33,7],[12,1],[11],[11],[5],[3,64],[32,7],[32,8],[72],[4,64],[32,7],[40,0,0],[32,4],[70],[4,64],[32,7],[40,0,4],[34,10],[65,255,255,255,255,7],[113],[65,195,0],[65,195,1],[32,10],[65,30],[118],[27],[32,2],[32,3],[16,builtin('__Porffor_strcmp')],[4,64],[32,7],[15],[11],[11],[32,7],[65,18],[106],[33,7],[12,1],[11],[11],[11],[65,127],[15]],
+wasm:(_,{builtin})=>[[32,0],[69],[4,64],[65,127],[15],[26],[11],[32,1],[65,7],[71],[4,64],[32,0],[183],[32,1],[16,builtin('__Porffor_object_underlying')],[33,6],[252,2],[33,0],[32,6],[34,1],[65,7],[71],[4,64],[65,127],[15],[26],[11],[11],[32,0],[65,8],[106],[34,7],[32,0],[47,0,0],[65,18],[108],[106],[33,8],[32,3],[65,5],[70],[4,64],[3,64],[32,7],[32,8],[72],[4,64],[32,7],[40,0,4],[34,9],[65,30],[118],[65,3],[70],[4,64],[32,9],[65,255,255,255,255,3],[113],[32,2],[70],[4,64],[32,7],[15],[26],[11],[11],[32,7],[65,18],[106],[33,7],[12,1],[11],[11],[5],[3,64],[32,7],[32,8],[72],[4,64],[32,7],[40,0,0],[32,4],[70],[4,64],[32,7],[40,0,4],[34,9],[32,2],[70],[4,64],[32,7],[15],[26],[11],[32,9],[65,255,255,255,255,7],[113],[65,195,0],[65,195,1],[32,9],[65,30],[118],[27],[32,2],[32,3],[16,builtin('__Porffor_strcmp')],[4,64],[32,7],[15],[11],[11],[32,7],[65,18],[106],[33,7],[12,1],[11],[11],[11],[65,127],[15]],
 params:[127,127,127,127,127,127],typedParams:1,returns:[127],returnType:1,
-locals:[127,127,127,127,127],localNames:["obj","obj#type","target","target#type","targetHash","targetHash#type","#last_type","ptr","endPtr","out","key"],
+locals:[127,127,127,127],localNames:["obj","obj#type","target","target#type","targetHash","targetHash#type","#last_type","ptr","endPtr","key"],
 usedTypes:[5],
 }
 this.__Porffor_object_readValue = {

package/compiler/cyclone.js

@@ -1,6 +1,7 @@
 // cyclone: wasm partial constant evaluator (it is fast and dangerous hence "cyclone")
 import { number, signedLEB128, ieee754_binary64, read_ieee754_binary64, read_signedLEB128 } from './encoding.js';
 import { Opcodes, Valtype } from './wasmSpec.js';
+import './prefs.js';
 
 const f64ToI32Op = {
   [Opcodes.f64_eq]: Opcodes.i32_eq,
@@ -15,8 +16,16 @@ const f64ToI32Op = {
   [Opcodes.f64_div]: Opcodes.i32_div_s,
 };
 
-export default wasm => {
-  let stack = []; // """""stack"""""
+export default ({ name, wasm, locals: _locals, params }) => {
+  let locals = Object.values(_locals);
+  const localValtypes = locals.map(x => x.type);
+
+  const resetLocals = () => {
+    locals = new Array(locals.length).fill(false);
+  };
+  resetLocals();
+
+  let stack = []; // "stack"
   for (let i = 0; i < wasm.length; i++) {
     let op = wasm[i];
     if (!op) continue;
@@ -33,8 +42,13 @@ export default wasm => {
       stack.push({ val, op });
     };
 
+    const peek = () => stack[stack.length - 1]?.val;
+    const popWithoutRemove = () => stack.pop().val;
+
+    // let debugPops = [];
     const pop = () => {
       const popped = stack.pop();
+      // debugPops.unshift({ ...popped, index: wasm.indexOf(popped.op) });
 
       // remove the op
       wasm.splice(wasm.indexOf(popped.op), 1);
@@ -42,12 +56,18 @@ export default wasm => {
 
       return popped.val;
     };
-
     const pop2 = () => [ pop(), pop() ];
 
     const bool = v => v ? 1 : 0;
 
     const replaceOp = newOp => {
+      // console.log(`\x1b[4m${name}\x1b[0m`);
+      // const oldOps = [ ...debugPops, { op, index: i + debugPops.length } ];
+      // for (const x of oldOps) {
+      //   console.log(`\x1b[90m${x.index.toString().padStart(4)} ▌\x1b[0m ${disassemble([ x.op ], undefined, undefined, _locals).slice(0, -1)}${x.val != null ? ` \x1b[2m(${x.val})\x1b[0m` : ''}`);
+      // }
+      // process.stdout.write(`\x1b[s\x1b[${oldOps.length}A\x1b[40C\x1b[2m->\x1b[0m  ${disassemble([ newOp ]).slice(0, -1)}\x1b[u\n`);
+
       op.splice(0, op.length, ...newOp);
     };
     const replaceVal = (val, valtype) => replaceOp(number(val, valtype));
@@ -57,41 +77,41 @@ export default wasm => {
     };
 
     switch (opcode) {
-      case Opcodes.if: {
-        if (stack.length < 1) { empty(); break; }
-        const cond = bool(pop());
-
-        // find else split and end
-        let j = i + 1;
-        let depth = 0, elseStart = 0;
-        for (; j < wasm.length; j++) {
-          const op = wasm[j][0];
-          if (op === Opcodes.if || op === Opcodes.block || op === Opcodes.loop || op === Opcodes.try) depth++;
-          if (op === Opcodes.else && depth === 0) elseStart = j;
-          if (op === Opcodes.end) {
-            depth--;
-            if (depth < 0) break;
-          }
-          if (op === Opcodes.br || op === Opcodes.br_if) wasm[j][1] -= 1;
-        }
-
-        if (cond) {
-          // remove else if it exists, or just remove end
-          if (elseStart) wasm.splice(elseStart, j - elseStart + 1);
-            else wasm.splice(j, 1);
-        } else {
-          // remove truthy conseq and keep else if it exists, or just remove entire thing
-          if (elseStart) {
-            wasm.splice(j, 1); // remove end
-            wasm.splice(i + 1, elseStart - i + 1); // remove truthy conseq
-          } else wasm.splice(i + 1, j - i + 0); // no else, remove entire if
-        }
-
-        // remove this if op
-        wasm.splice(i, 1);
+      // case Opcodes.if: {
+      //   if (stack.length < 1) { empty(); break; }
+      //   const cond = bool(pop());
+
+      //   // find else split and end
+      //   let j = i + 1;
+      //   let depth = 0, elseStart = 0;
+      //   for (; j < wasm.length; j++) {
+      //     const op = wasm[j][0];
+      //     if (op === Opcodes.if || op === Opcodes.block || op === Opcodes.loop || op === Opcodes.try) depth++;
+      //     if (op === Opcodes.else && depth === 0) elseStart = j;
+      //     if (op === Opcodes.end) {
+      //       depth--;
+      //       if (depth < 0) break;
+      //     }
+      //     if (op === Opcodes.br || op === Opcodes.br_if) wasm[j][1] -= 1;
+      //   }
+
+      //   if (cond) {
+      //     // remove else if it exists, or just remove end
+      //     if (elseStart) wasm.splice(elseStart, j - elseStart + 1);
+      //       else wasm.splice(j, 1);
+      //   } else {
+      //     // remove truthy conseq and keep else if it exists, or just remove entire thing
+      //     if (elseStart) {
+      //       wasm.splice(j, 1); // remove end
+      //       wasm.splice(i + 1, elseStart - i + 1); // remove truthy conseq
+      //     } else wasm.splice(i + 1, j - i + 0); // no else, remove entire if
+      //   }
+
+      //   // remove this if op
+      //   wasm.splice(i, 1);
 
-        break;
-      }
+      //   break;
+      // }
 
       case Opcodes.i32_const: {
         const n = read_signedLEB128(op.slice(1));
@@ -448,8 +468,8 @@ export default wasm => {
         break;
       }
 
-      case Opcodes.f64_convert_i32_u:
-      case Opcodes.f64_convert_i32_s: {
+      case Opcodes.f64_convert_i32_s:
+      case Opcodes.f64_convert_i32_u: {
         if (stack.length < 1) { empty(); break; };
         const v = pop();
 
@@ -458,7 +478,8 @@ export default wasm => {
         break;
       }
 
-      case 0xfc02: { // i32_trunc_sat_f64_s
+      case 0xfc02: // i32.trunc_sat_f64_s
+      case 0xfc03: { // i32.trunc_sat_f64_u
         if (stack.length < 1) { empty(); break; }
         const v = pop();
 
@@ -467,20 +488,60 @@ export default wasm => {
         break;
       }
 
-      case 0xfc03: { // i32_trunc_sat_f64_u
+      case Opcodes.drop: {
         if (stack.length < 1) { empty(); break; }
-        const v = pop();
+        pop();
+        break;
+      }
 
-        replaceVal(v, Valtype.i32);
-        push(v);
+      case Opcodes.local_get: {
+        const x = locals[op[1]];
+        if (x === false) {
+          empty();
+        } else {
+          replaceVal(x, localValtypes[op[1]]);
+          push(x);
+        }
         break;
       }
 
-      // case Opcodes.local_tee: {
-      //   if (stack.length < 1) { empty(); break; }
-      //   push(pop());
-      //   break;
-      // }
+      case Opcodes.local_set: {
+        if (stack.length < 1) {
+          locals[op[1]] = false;
+          empty();
+          break;
+        }
+
+        const x = popWithoutRemove();
+        locals[op[1]] = x;
+        break;
+      }
+
+      case Opcodes.local_tee: {
+        if (stack.length < 1) {
+          locals[op[1]] = false;
+          empty();
+          break;
+        }
+
+        const x = pop();
+        locals[op[1]] = x;
+        replaceVal(x, localValtypes[op[1]]);
+        push(x);
+        break;
+      }
+
+      case Opcodes.block:
+      case Opcodes.loop:
+      case Opcodes.try:
+      case Opcodes.if:
+      case Opcodes.else:
+      case Opcodes.catch:
+      case Opcodes.end: {
+        resetLocals();
+        empty();
+        break;
+      }
 
       default: {
         empty();
@@ -500,69 +561,69 @@ export default wasm => {
     // i32.const 1
     // i32.add
     // local.set 7 ;; $i (i32)
-    if (i >= 2 &&
-      ((opcode >= 0xa0 && opcode <= 0xa3) || // main f64 math op
-      (opcode >= 0x61 && opcode <= 0x66)) // main f64 eq op
-    ) {
-      const o2 = wasm[i - 1][0];
-      if (o2 === Opcodes.f64_const) { // f64.const
-        const o3 = wasm[i - 2][0];
-        if (o3 === Opcodes.f64_convert_i32_s || o3 === Opcodes.f64_convert_i32_u) {
-          // remove now unneeded i32 -> f64 convert
-          wasm.splice(i - 2, 1);
-          i--;
-
-          // convert f64.const -> i32.const
-          const n = wasm[i - 1][1];
-          wasm.splice(i - 1, 1, number(n, Valtype.i32));
-
-          // convert math op from f64 to i32
-          wasm[i][0] = f64ToI32Op[wasm[i][0]];
-
-          const nextOp = wasm[i + 1];
-          if (nextOp && opcode >= 0xa0 && opcode <= 0xa3) {
-            if (nextOp[0] === 0xfc && (nextOp[1] === 0x02 || nextOp[1] === 0x03)) {
-              // remove optional unneeded f64 -> i32 convert after
-              wasm.splice(i + 1, 1);
-            } else {
-              // add now needed i32 -> f64 convert after
-              wasm.splice(i + 1, Opcodes.i32_trunc_sat_f64_s);
-            }
-          }
-        }
-      }
-    }
-
-    if ((opcode === 0xfc02 || opcode === 0xfc03) && i >= 3) { // i32.trunc_sat_f64_s/u
-      const o2 = wasm[i - 1][0];
-      if (
-        (o2 >= 0xa0 && o2 <= 0xa3) || // main f64 math op
-        (o2 >= 0x61 && o2 <= 0x66) // main f64 eq op
-      ) {
-        const o3 = wasm[i - 2][0];
-        if (o3 === Opcodes.f64_const) { // f64.const
-          const o4 = wasm[i - 3][0];
-          if (o4 === Opcodes.f64_convert_i32_s || o4 === Opcodes.f64_convert_i32_u) {
-            // remove now unneeded i32 -> f64 convert
-            wasm.splice(i - 3, 1);
-            i--;
-          } else {
-            // add now needed f64 -> i32 convert prior
-            wasm.splice(i - 2, 0, Opcodes.i32_trunc_sat_f64_s);
-            i++;
-          }
-
-          // convert f64.const -> i32.const
-          const n = wasm[i - 2][1];
-          wasm.splice(i - 2, 1, number(n, Valtype.i32));
-
-          // convert math op from f64 to i32
-          wasm[i - 1][0] = f64ToI32Op[wasm[i - 1][0]];
-
-          // remove this now unneeded f64 -> i32 convert
-          wasm.splice(i, 1);
-        }
-      }
-    }
+    // if (i >= 2 &&
+    //   ((opcode >= 0xa0 && opcode <= 0xa3) || // main f64 math op
+    //   (opcode >= 0x61 && opcode <= 0x66)) // main f64 eq op
+    // ) {
+    //   const o2 = wasm[i - 1][0];
+    //   if (o2 === Opcodes.f64_const) { // f64.const
+    //     const o3 = wasm[i - 2][0];
+    //     if (o3 === Opcodes.f64_convert_i32_s || o3 === Opcodes.f64_convert_i32_u) {
+    //       // remove now unneeded i32 -> f64 convert
+    //       wasm.splice(i - 2, 1);
+    //       i--;
+
+    //       // convert f64.const -> i32.const
+    //       const n = wasm[i - 1][1];
+    //       wasm.splice(i - 1, 1, number(n, Valtype.i32));
+
+    //       // convert math op from f64 to i32
+    //       wasm[i][0] = f64ToI32Op[wasm[i][0]];
+
+    //       const nextOp = wasm[i + 1];
+    //       if (nextOp && opcode >= 0xa0 && opcode <= 0xa3) {
+    //         if (nextOp[0] === 0xfc && (nextOp[1] === 0x02 || nextOp[1] === 0x03)) {
+    //           // remove optional unneeded f64 -> i32 convert after
+    //           wasm.splice(i + 1, 1);
+    //         } else {
+    //           // add now needed i32 -> f64 convert after
+    //           wasm.splice(i + 1, Opcodes.i32_trunc_sat_f64_s);
+    //         }
+    //       }
+    //     }
+    //   }
+    // }
+
+    // if ((opcode === 0xfc02 || opcode === 0xfc03) && i >= 3) { // i32.trunc_sat_f64_s/u
+    //   const o2 = wasm[i - 1][0];
+    //   if (
+    //     (o2 >= 0xa0 && o2 <= 0xa3) || // main f64 math op
+    //     (o2 >= 0x61 && o2 <= 0x66) // main f64 eq op
+    //   ) {
+    //     const o3 = wasm[i - 2][0];
+    //     if (o3 === Opcodes.f64_const) { // f64.const
+    //       const o4 = wasm[i - 3][0];
+    //       if (o4 === Opcodes.f64_convert_i32_s || o4 === Opcodes.f64_convert_i32_u) {
+    //         // remove now unneeded i32 -> f64 convert
+    //         wasm.splice(i - 3, 1);
+    //         i--;
+    //       } else {
+    //         // add now needed f64 -> i32 convert prior
+    //         wasm.splice(i - 2, 0, Opcodes.i32_trunc_sat_f64_s);
+    //         i++;
+    //       }
+
+    //       // convert f64.const -> i32.const
+    //       const n = wasm[i - 2][1];
+    //       wasm.splice(i - 2, 1, number(n, Valtype.i32));
+
+    //       // convert math op from f64 to i32
+    //       wasm[i - 1][0] = f64ToI32Op[wasm[i - 1][0]];
+
+    //       // remove this now unneeded f64 -> i32 convert
+    //       wasm.splice(i, 1);
+    //     }
+    //   }
+    // }
   }
 };

package/compiler/disassemble.js

@@ -18,7 +18,7 @@ export default (wasm, name = '', ind = 0, locals = {}, params = [], returns = []
     }
 
     return `(${params.map((x, i) => invValtype[x]).join(', ')}) -> (${returns.map(x => invValtype[x]).join(', ')})`;
-  }
+  };
 
   let out = '', depth = 0;
   if (name) out += `${name}(${ind}) ${makeSignature(params, returns, locals)}\n`;

package/compiler/index.js

@@ -132,9 +132,9 @@ export default (code, module = undefined) => {
 
       for (const x of funcs) {
         const preOps = x.wasm.length;
-        cyclone(x.wasm);
+        cyclone(x);
 
-        console.log(`${x.name}: ${preOps} -> ${x.wasm.length} ops`);
+        if (preOps !== x.wasm.length) console.log(`${x.name}: ${preOps} -> ${x.wasm.length} ops`);
       }
       opt(funcs, globals, pages, tags, exceptions);
 
@@ -144,7 +144,7 @@ export default (code, module = undefined) => {
       console.log(`cyclone size diff: ${oldSize - newSize} bytes (${oldSize} -> ${newSize})\n`);
     } else {
       for (const x of funcs) {
-        cyclone(x.wasm);
+        cyclone(x);
       }
     }
   }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "porffor",
   "description": "An ahead-of-time JavaScript compiler",
-  "version": "0.55.26",
+  "version": "0.55.28",
   "author": "Oliver Medhurst <honk@goose.icu>",
   "license": "MIT",
   "scripts": {},

package/runner/index.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 import fs from 'node:fs';
-globalThis.version = '0.55.26';
+globalThis.version = '0.55.28';
 
 // deno compat
 if (typeof process === 'undefined' && typeof Deno !== 'undefined') {