porffor 0.14.0-320727338 → 0.14.0-3905158d3

package/CONTRIBUTING.md

@@ -198,13 +198,11 @@ Store the character code into the `out` pointer variable, and increment it.
 
 ## Porffor-specific TS notes
 
-- For declaring variables, you must use explicit type annotations currently (eg `let a: number = 1`, not `let a = 1`).
+- For declaring variables, you must use explicit type annotations currently (eg `let a: number = 1`, not `let a = 1`)
 - You might spot `Porffor.fastOr`/`Porffor.fastAnd`, these are non-short circuiting versions of `||`/`&&`, taking any number of conditions as arguments. You shouldn't don't need to use or worry about these.
-- **There are ~no objects, you cannot use them.**
+- **There are ~no objects, you cannot use them/literals.**
 - Attempt to avoid string/array-heavy code and use more variables instead if possible, easier on memory and CPU/perf.
 - Do not set a return type for prototype methods, it can cause errors/unexpected results.
-- You cannot use other functions in the file not exported, or variables not inside the current function.
-- `if (...)` uses a fast truthy implementation which is not spec-compliant as most conditions should be strictly checked. To use spec-compliant behavior, use `if (Boolean(...))`.
 
 <br>
 

package/compiler/2c.js

@@ -119,9 +119,6 @@ const removeBrackets = str => {
 };
 
 export default ({ funcs, globals, tags, data, exceptions, pages }) => {
-  // fix declaring order for c
-  funcs.reverse();
-
   const invOperatorOpcode = Object.values(operatorOpcode).reduce((acc, x) => {
     for (const k in x) {
       acc[x[k]] = k;

package/compiler/builtins/annexb_string.ts

@@ -1,5 +1,4 @@
 // @porf --valtype=i32
-import type {} from './porffor.d.ts';
 
 export const __String_prototype_trimLeft = (_this: string) => {
   return __String_prototype_trimStart(_this);

package/compiler/builtins/array.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 export const __Array_isArray = (x: unknown): boolean =>
   // Porffor.wasm`local.get ${x+1}` == Porffor.TYPES.array;
   Porffor.rawType(x) == Porffor.TYPES.array;
@@ -164,7 +162,7 @@ export const __Array_prototype_filter = (_this: any[], callbackFn: any) => {
   let i: i32 = 0;
   while (i < len) {
     const el: any = _this[i];
-    if (Boolean(callbackFn(el, i++, _this))) out.push(el);
+    if (callbackFn(el, i++, _this)) out.push(el);
   }
 
   return out;
@@ -187,7 +185,7 @@ export const __Array_prototype_find = (_this: any[], callbackFn: any) => {
   let i: i32 = 0;
   while (i < len) {
     const el: any = _this[i];
-    if (Boolean(callbackFn(el, i++, _this))) return el;
+    if (callbackFn(el, i++, _this)) return el;
   }
 };
 
@@ -195,7 +193,7 @@ export const __Array_prototype_findLast = (_this: any[], callbackFn: any) => {
   let i: i32 = _this.length;
   while (i > 0) {
     const el: any = _this[--i];
-    if (Boolean(callbackFn(el, i, _this))) return el;
+    if (callbackFn(el, i, _this)) return el;
   }
 };
 
@@ -203,14 +201,14 @@ export const __Array_prototype_findIndex = (_this: any[], callbackFn: any) => {
   const len: i32 = _this.length;
   let i: i32 = 0;
   while (i < len) {
-    if (Boolean(callbackFn(_this[i], i++, _this))) return i;
+    if (callbackFn(_this[i], i++, _this)) return i;
   }
 };
 
 export const __Array_prototype_findLastIndex = (_this: any[], callbackFn: any) => {
   let i: i32 = _this.length;
   while (i > 0) {
-    if (Boolean(callbackFn(_this[--i], i, _this))) return i;
+    if (callbackFn(_this[--i], i, _this)) return i;
   }
 };
 
@@ -218,7 +216,7 @@ export const __Array_prototype_every = (_this: any[], callbackFn: any) => {
   const len: i32 = _this.length;
   let i: i32 = 0;
   while (i < len) {
-    if (!Boolean(callbackFn(_this[i], i++, _this))) return false;
+    if (!callbackFn(_this[i], i++, _this)) return false;
   }
 
   return true;

package/compiler/builtins/base64.ts

@@ -1,5 +1,4 @@
 // @porf --valtype=i32
-import type {} from './porffor.d.ts';
 
 export const btoa = (input: bytestring): bytestring => {
   const keyStr: bytestring = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';

package/compiler/builtins/boolean.ts

@@ -1,12 +1,10 @@
-import type {} from './porffor.d.ts';
-
 // 20.3.3.2 Boolean.prototype.toString ()
 // https://tc39.es/ecma262/#sec-boolean.prototype.tostring
 export const __Boolean_prototype_toString = (_this: boolean) => {
   // 1. Let b be ? ThisBooleanValue(this value).
   // 2. If b is true, return "true"; else return "false".
   let out: bytestring = '';
-  if (_this) out = 'true';
+  if (_this == true) out = 'true';
     else out = 'false';
 
   return out;

package/compiler/builtins/crypto.ts

@@ -1,5 +1,4 @@
 // @porf --valtype=i32
-import type {} from './porffor.d.ts';
 
 export const __crypto_randomUUID = (): bytestring => {
   let bytes: bytestring = '................';

package/compiler/builtins/date.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 // 21.4.1.3 Day (t)
 // https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-day
 // 1. Return 𝔽(floor(ℝ(t / msPerDay))).

package/compiler/builtins/escape.ts

@@ -1,5 +1,6 @@
 // @porf --valtype=i32
-import type {} from './porffor.d.ts';
+
+import type {} from './porffor';
 
 export const escape = (input: string|bytestring): bytestring => {
   // we have no byte array yet so use bytestring with 0x00 and 0x01 via escape characters

package/compiler/builtins/function.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 export const __Function_prototype_toString = (_this: Function) => {
   // todo: actually use source
   let out: bytestring = 'function () {}';

package/compiler/builtins/int.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 // radix: number|any for rawType check
 // export const parseInt = (input: string|bytestring, radix: number|any): f64 => {
 export const parseInt = (input: string|bytestring, radix: number): f64 => {

package/compiler/builtins/math.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 // todo: use any and Number(x) in all these later
 // todo: specify the rest of this file later
 // todo/perf: make i32 variants later
@@ -19,7 +17,7 @@ export const __Math_exp = (x: number): number => {
   const k: number = Math.floor(x / Math.LN2);
   const r: number = x - k * Math.LN2;
 
-  // Taylor series via Horner's method
+  // Horner's method
   let term: number = r;
   let sum: number = 1 + r;
   let i: number = 2;

package/compiler/builtins/number.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 // radix: number|any for rawType check
 export const __Number_prototype_toString = (_this: number, radix: number|any) => {
   let out: bytestring = '';

package/compiler/builtins/object.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 export const __Object_prototype_toString = (_this: object) => {
   let out: bytestring = '[object Object]';
   return out;

package/compiler/builtins/set.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 // dark wasm magic for dealing with memory, sorry.
 export const __Porffor_allocate = (): number => {
   Porffor.wasm`i32.const 1

package/compiler/builtins/string.ts

@@ -1,5 +1,4 @@
 // @porf --valtype=i32
-import type {} from './porffor.d.ts';
 
 export const __String_fromCharCode = (code: i32) => {
   // todo: support >1 arg

package/compiler/builtins/symbol.ts

@@ -1,5 +1,3 @@
-import type {} from './porffor.d.ts';
-
 export const __Porffor_symbol_descStore = (op: boolean, value: any): any => {
   const ptr: bytestring = '';
 

package/compiler/codegen.js

@@ -668,7 +668,7 @@ const compareStrings = (scope, left, right, bytestrings = false) => {
   ];
 };
 
-const truthy = (scope, wasm, type, intIn = false, intOut = false, forceTruthyMode = undefined) => {
+const truthy = (scope, wasm, type, intIn = false, intOut = false) => {
   if (isIntToFloatOp(wasm[wasm.length - 1])) return [
     ...wasm,
     ...(!intIn && intOut ? [ Opcodes.i32_to_u ] : [])
@@ -703,13 +703,18 @@ const truthy = (scope, wasm, type, intIn = false, intOut = false, forceTruthyMod
       ...(!useTmp ? [] : [ [ Opcodes.local_get, tmp ] ]),
       ...(!intOut || (intIn && intOut) ? [] : [ Opcodes.i32_to_u ])
     ];
-  })(forceTruthyMode ?? Prefs.truthy ?? 'full');
+  })(Prefs.truthy ?? 'full');
 
   return [
     ...wasm,
     ...(!useTmp ? [] : [ [ Opcodes.local_set, tmp ] ]),
 
     ...typeSwitch(scope, type, {
+      // [TYPES.number]: def,
+      // [TYPES.array]: [
+      //   // arrays are always truthy
+      //   ...number(1, intOut ? Valtype.i32 : valtypeBinary)
+      // ],
       [TYPES.string]: [
         ...(!useTmp ? [] : [ [ Opcodes.local_get, tmp ] ]),
         ...(intIn ? [] : [ Opcodes.i32_to_u ]),
@@ -745,6 +750,10 @@ const falsy = (scope, wasm, type, intIn = false, intOut = false) => {
     ...(!useTmp ? [] : [ [ Opcodes.local_set, tmp ] ]),
 
     ...typeSwitch(scope, type, {
+      // [TYPES.array]: [
+      //   // arrays are always truthy
+      //   ...number(0, intOut ? Valtype.i32 : valtypeBinary)
+      // ],
       [TYPES.string]: [
         ...(!useTmp ? [] : [ [ Opcodes.local_get, tmp ] ]),
         ...(intIn ? [] : [ Opcodes.i32_to_u ]),
@@ -2579,7 +2588,6 @@ const generateUnary = (scope, decl) => {
       ];
 
     case '!':
-      // todo/perf: optimize !!
       // !=
       return falsy(scope, generate(scope, decl.argument), getNodeType(scope, decl.argument), false, false);
 
@@ -3839,7 +3847,7 @@ const internalConstrs = {
     generate: (scope, decl) => {
       // todo: boolean object when used as constructor
       const arg = decl.arguments[0] ?? DEFAULT_VALUE;
-      return truthy(scope, generate(scope, arg), getNodeType(scope, arg), false, false, 'full');
+      return truthy(scope, generate(scope, arg), getNodeType(scope, arg));
     },
     type: TYPES.boolean,
     length: 1