poops 1.2.4 → 1.4.0

package/lib/utils/helpers.js

@@ -181,3 +181,33 @@ export function doesFileBelongToPath(filePath, configPaths) {
   }
   return false
 }
+
+// Derive the watch list from every task's `in` path when watch is `true`.
+// File entries (scripts/styles/reactor) resolve to their parent dir so sibling
+// imports still retrigger a rebuild; dir entries (markup/copy/images) are
+// watched as-is. Imports that reach outside a task's own dir aren't covered —
+// use an explicit `watch` array for that. includePaths is skipped on purpose:
+// it defaults to node_modules, which must never be watched.
+export function deriveWatchDirs(config) {
+  const paths = []
+  const collect = (task) => {
+    if (!task) return
+    for (const entry of [].concat(task)) {
+      if (!entry || typeof entry !== 'object') continue
+      if (entry.in) paths.push(...(Array.isArray(entry.in) ? entry.in : [entry.in]))
+      if (entry.component) paths.push(entry.component) // reactor source component
+      const tokenPaths = entry.options && entry.options.tokenPaths
+      if (tokenPaths) paths.push(...[].concat(tokenPaths))
+    }
+  }
+  collect(config.scripts)
+  collect(config.styles)
+  collect(config.reactor)
+  collect(config.markup)
+  collect(config.copy)
+  collect(config.images)
+  // ponytail: extname()-based dir/file split misreads dot-named dirs (rare);
+  // the escape hatch is an explicit watch array.
+  return [...new Set(paths.map((p) => (path.extname(p) ? path.dirname(p) : p)))]
+    .filter((p) => p && p !== '.')
+}

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "poops",
   "description": "Straightforward, no-bullshit bundler for the web.",
-  "version": "1.2.4",
+  "version": "1.4.0",
   "license": "MIT",
   "type": "module",
   "main": "poops.js",
@@ -62,6 +62,8 @@
     "liquidjs": "^10.24.0",
     "livereload": "^0.9.3",
     "marked": "^9.0.3",
+    "marked-github-alerts": "^1.0.1",
+    "marked-github-emoji": "^1.0.2",
     "nunjucks": "^3.2.4",
     "portscanner": "^2.2.0",
     "printstyle": "^1.0.0",

package/poops.js

@@ -3,7 +3,7 @@
 import chokidar from 'chokidar'
 import connect from 'connect'
 import Copy from './lib/copy.js'
-import { pathExists, doesFileBelongToPath } from './lib/utils/helpers.js'
+import { pathExists, doesFileBelongToPath, pathContainsPathSegment, deriveWatchDirs } from './lib/utils/helpers.js'
 import http from 'node:http'
 import os from 'node:os'
 import fs from 'node:fs'
@@ -85,8 +85,6 @@ function setupLiveReloadServer(config) {
 function setupWatchers(config, modules) {
   if (!config.watch) return
 
-  // TODO: think about watching the updates of the config file itself, we can reload the config and recompile everything.
-  // TODO: ability to automatically create a watch list of directories if watch is set to true. The list will be generated from the `in` property of each task.
   // awaitWriteFinish: wait for saves to finish writing before recompiling, so a
   // mid-write (truncated/partial) file is never read. Fixes intermittent broken
   // builds on editor save. Bump thresholds if slow disks flake.
@@ -95,8 +93,19 @@ function setupWatchers(config, modules) {
   // rebuilds. 'add' also covers genuinely new files (e.g. a new markup page).
   // Rebuild branches shared by change/add/deletion: a deletion needs the same
   // rebuilds (a deleted-but-still-imported file must surface the error).
+  // Scripts/styles outputs can land inside a watched dir (e.g. a Shopify
+  // theme's assets/): the compiler's own write must not retrigger that
+  // compiler, or watch loops forever. Zones are the dirs the compilers write
+  // into; only their own extensions are skipped there, so e.g. a hand-edited
+  // .liquid asset in the same dir still rebuilds markup.
+  const outputZones = [config.scripts, config.styles].flat()
+    .filter((entry) => entry && entry.out)
+    .map((entry) => (path.extname(entry.out) ? path.dirname(entry.out) : entry.out))
+    .filter((zone) => zone && zone !== '.')
+  const isBuildOutput = (file) => outputZones.some((zone) => pathContainsPathSegment(file, zone))
+
   const rebuild = (file) => {
-    if (/(\.m?jsx?|\.tsx?)$/i.test(file)) {
+    if (/(\.m?jsx?|\.tsx?)$/i.test(file) && !isBuildOutput(file)) {
       modules.scripts.compile().catch(err => console.error(err))
 
       if (modules.reactor.belongsToReactor(file)) {
@@ -108,7 +117,7 @@ function setupWatchers(config, modules) {
         }).catch(err => console.error(err))
       }
     }
-    if (/(\.sass|\.scss|\.css)$/i.test(file)) {
+    if (/(\.sass|\.scss|\.css)$/i.test(file) && !isBuildOutput(file)) {
       modules.styles.compile().then(() => modules.postcss.compile()).catch(err => console.error(err))
     }
     if (/(\.html|\.xml|\.rss|\.atom|\.njk|\.liquid|\.md)$/i.test(file)) {
@@ -240,7 +249,9 @@ if (!pathExists(configPath)) {
 // Load poops.json
 const config = JSON.parse(fs.readFileSync(configPath, 'utf-8'))
 
-if (config.watch) {
+if (config.watch === true) {
+  config.watch = deriveWatchDirs(config)
+} else if (config.watch) {
   config.watch = Array.isArray(config.watch) ? config.watch : [config.watch]
 }