polygram 0.6.15 → 0.7.0

package/polygram.js

@@ -32,6 +32,9 @@ const { parseBotArg, parseDbArg, filterConfigToBot } = require('./lib/config-sco
 const { createStore: createPairingsStore, parseTtl: parsePairingTtl } = require('./lib/pairings');
 const { transcribe: transcribeVoice, isVoiceAttachment } = require('./lib/voice');
 const { createStreamer } = require('./lib/stream-reply');
+const { chunkMarkdownText } = require('./lib/telegram-chunk');
+const { deliverReplies } = require('./lib/deliver');
+const { announce, shouldAnnounce } = require('./lib/announces');
 const { isAbortRequest } = require('./lib/abort-detector');
 const { startTyping } = require('./lib/typing-indicator');
 const { redactBotToken } = require('./lib/net-errors');
@@ -786,6 +789,9 @@ function errorReplyText(err) {
   if (/Process (exited|killed)/i.test(msg)) {
     return '💥 Something crashed on my end. Try again.';
   }
+  if (/error_during_execution/i.test(msg)) {
+    return '💥 Something went wrong mid-stream. Try again.';
+  }
   const reason = msg.split('\n')[0].slice(0, 120);
   return `Hit a snag: ${reason || 'unknown error'}. Try resending.`;
 }
@@ -906,22 +912,6 @@ function parseResponse(text) {
   return { text: trimmed, sticker: null, stickerLabel: null, reaction: null };
 }
 
-// ─── Reply chunking ─────────────────────────────────────────────────
-
-function chunkText(text, maxLen = TG_MAX_LEN) {
-  if (text.length <= maxLen) return [text];
-  const chunks = [];
-  let remaining = text;
-  while (remaining.length > 0) {
-    if (remaining.length <= maxLen) { chunks.push(remaining); break; }
-    let splitAt = remaining.lastIndexOf('\n', maxLen);
-    if (splitAt < maxLen * 0.3) splitAt = maxLen;
-    chunks.push(remaining.slice(0, splitAt));
-    remaining = remaining.slice(splitAt).replace(/^\n/, '');
-  }
-  return chunks;
-}
-
 // ─── Cron/IPC send ─────────────────────────────────────────────────
 
 // Allowlist of Telegram Bot API methods external callers (cron) may invoke.
@@ -1660,11 +1650,18 @@ async function handleMessage(sessionKey, chatId, msg, bot) {
   });
 
   const botCfg = config.bot || {};
+  // 0.7.0: per-chat / per-bot link-preview opt-out (port from OpenClaw).
+  // chat-level wins over bot-level. Default (both undefined) preserves
+  // Telegram's native auto-preview behavior.
+  const linkPreview = chatConfig.linkPreview != null
+    ? chatConfig.linkPreview
+    : botCfg.linkPreview;
   const outMetaBase = {
     source: 'bot-reply-stream',
     botName: BOT_NAME,
     model: chatConfig.model,
     effort: chatConfig.effort,
+    ...(linkPreview === false ? { linkPreview: false } : {}),
   };
 
   // Streaming is unconditional as of 0.4.0 — matches OpenClaw's model and
@@ -1707,6 +1704,21 @@ async function handleMessage(sessionKey, chatId, msg, bot) {
         throw err;
       }
     },
+    deleteMessage: async (messageId) => {
+      // 0.7.0: route preview-discard through tg() so the action is
+      // visible in the events log and gets the same retry/network
+      // protections as other API calls. Failure is non-fatal: stale
+      // bubble at chat top is acceptable when the actual reply has
+      // already been redelivered as fresh chunks.
+      try {
+        await tg(bot, 'deleteMessage', {
+          chat_id: chatId, message_id: messageId,
+        }, { source: 'bot-reply-stream-discard', botName: BOT_NAME });
+      } catch (err) {
+        console.error(`[${label}] discard preview failed: ${err.message}`);
+        throw err;
+      }
+    },
     minChars: botCfg.streamMinChars,
     throttleMs: botCfg.streamThrottleMs,
     logger: { error: (m) => console.error(`[${label}] ${m}`) },
@@ -1761,7 +1773,16 @@ async function handleMessage(sessionKey, chatId, msg, bot) {
     if (result.error) {
       console.error(`[${label}] Error (${elapsed}s):`, result.error);
       reactor.setState('ERROR');
-      if (!result.text) { markReplied(); return; }
+      // 0.6.16: pre-fix, silently markReplied()+return — the user got an
+      // error reaction emoji on their message but no actual reply text,
+      // AND 'replied' status meant boot replay didn't re-dispatch on next
+      // boot. Worst-case: shutdown-killed turn (e.g. polygram upgrade
+      // mid-stream) → user sends "yes", sees 🤯, gets no answer ever,
+      // the row is silently lost. Promote to a thrown error so
+      // dispatchHandleMessage's catch correctly distinguishes shutdown
+      // (→ 'replay-pending', boot replay retries) from runtime failure
+      // (→ 'failed', user gets an apology with retry hint).
+      if (!result.text) throw new Error(result.error);
     } else {
       // Clear the progress reaction instead of stamping 👍 — the reply
       // bubble itself is the "done" signal and a permanent thumbs-up on
@@ -1770,34 +1791,89 @@ async function handleMessage(sessionKey, chatId, msg, bot) {
       reactor.clear().catch(() => {});
     }
 
-    if (!result.text || result.text === 'NO_REPLY') { markReplied(); return; }
+    // 0.7.0: empty-response fallback (port from OpenClaw —
+    // EMPTY_RESPONSE_FALLBACK at reply-CdjLMJxg.js:40323). When
+    // Claude finishes WITHOUT producing any text (e.g. only tool
+    // calls, or aborted before writing the assistant message), send
+    // a placeholder so the user doesn't see silence with no reaction.
+    // NO_REPLY is an explicit "stay silent" signal from the agent —
+    // those still markReplied silently.
+    if (result.text === 'NO_REPLY') { markReplied(); return; }
+    if (!result.text) {
+      try {
+        await tg(bot, 'sendMessage', {
+          chat_id: chatId,
+          text: 'No response generated. Please try again.',
+          ...(threadId && { message_thread_id: threadId }),
+          reply_parameters: { message_id: msg.message_id, allow_sending_without_reply: true },
+        }, { ...outMetaBase, source: 'empty-response-fallback' });
+      } catch (err) {
+        console.error(`[${label}] empty-response fallback send failed: ${err.message}`);
+      }
+      logEvent('telegram-empty-response-fallback', {
+        chat_id: chatId, msg_id: msg.message_id, bot: BOT_NAME,
+      });
+      markReplied();
+      return;
+    }
 
     const parsed = parseResponse(result.text);
     const outMeta = { ...outMetaBase, sessionId: result.sessionId, costUsd: result.cost };
 
-    // Streamed text path: finalise the live-edit and, if the full response
-    // overflows Telegram's 4096 cap, send remainder as follow-up chunks.
+    // 0.7.0 streamed text path: OpenClaw's preview-becomes-final flow.
+    //
+    //   1. flushDraft() — drain any pending throttled edit so the
+    //      bubble's visible state is up-to-date before deciding.
+    //   2. finalize(parsed.text) — try to bring the bubble to the
+    //      final body. Returns rich result describing whether the
+    //      preview can stand as the final reply.
+    //   3a. finalEditOk:true        → preview IS final, done.
+    //   3b. overflow OR !finalEditOk → discard preview, redeliver via
+    //      deliverReplies(chunkMarkdownText(...)). This is the path
+    //      that fixes msg-10794: if the live bubble couldn't render
+    //      the full body (size or parse error), we delete it cleanly
+    //      and send the proper chunks fresh at chat bottom — no
+    //      content lost, no stranded edit-failure bubble.
     if (parsed.text) {
+      await streamer.flushDraft();
       const fin = await streamer.finalize(parsed.text);
       if (fin.streamed) {
-        if (parsed.text.length > TG_MAX_LEN) {
-          const rest = parsed.text.slice(TG_MAX_LEN - 3);
-          for (const chunk of chunkText(rest)) {
-            try {
-              await tg(bot, 'sendMessage', {
-                chat_id: chatId, text: chunk,
-                ...(threadId && { message_thread_id: threadId }),
-              }, outMeta);
-            } catch (err) {
-              console.error(`[${label}] overflow sendMessage failed: ${err.message}`);
-            }
-          }
+        if (fin.finalEditOk) {
+          // Preview was successfully edited to the final text.
+          // No follow-up messages needed.
+          console.log(`[${label}] ${elapsed}s | ${result.text.length} chars | streamed | ${chatConfig.model}/${chatConfig.effort} | $${result.cost?.toFixed(4) || '?'}`);
+          markReplied();
+          return;
         }
-        console.log(`[${label}] ${elapsed}s | ${result.text.length} chars | streamed | ${chatConfig.model}/${chatConfig.effort} | $${result.cost?.toFixed(4) || '?'}`);
+        // Preview can't hold the final body (overflow OR last edit
+        // failed even after our HTML→plain fallback). Delete it and
+        // send the body as proper chunks.
+        try { await streamer.discard(); }
+        catch (err) { console.error(`[${label}] discard failed: ${err.message}`); }
+        const chunks = chunkMarkdownText(parsed.text, TG_MAX_LEN);
+        const r = await deliverReplies({
+          bot,
+          send: (b, method, params, m) => tg(b, method, params, m),
+          chatId,
+          threadId,
+          chunks,
+          replyToMessageId: msg.message_id,
+          meta: outMeta,
+          logger: { error: (m) => console.error(`[${label}] ${m}`) },
+        });
+        const reason = fin.overflow ? 'overflow' : 'edit-failed';
+        logEvent('telegram-stream-redeliver', {
+          chat_id: chatId, msg_id: msg.message_id,
+          reason, chunks: chunks.length,
+          delivered: r.sent.length, failed: r.failed.length,
+          bot: BOT_NAME,
+        });
+        console.log(`[${label}] ${elapsed}s | ${result.text.length} chars | streamed-redeliver(${reason}, ${chunks.length} chunks) | ${chatConfig.model}/${chatConfig.effort} | $${result.cost?.toFixed(4) || '?'}`);
         markReplied();
         return;
       }
-      // Not streamed (response too short) — fall through to normal path.
+      // Not streamed (response too short — never crossed minChars).
+      // Fall through to the normal send path below.
     }
 
     if (parsed.reaction) {
@@ -1817,19 +1893,20 @@ async function handleMessage(sessionKey, chatId, msg, bot) {
         console.error(`[${label}] sendSticker failed: ${err.message}`);
       });
     } else if (parsed.text) {
-      const chunks = chunkText(parsed.text);
-      for (let i = 0; i < chunks.length; i++) {
-        const params = {
-          chat_id: chatId, text: chunks[i],
-          ...(threadId && { message_thread_id: threadId }),
-        };
-        if (i === 0) params.reply_parameters = { message_id: msg.message_id };
-        try {
-          await tg(bot, 'sendMessage', params, outMeta);
-        } catch (err) {
-          console.error(`[${label}] sendMessage failed (chunk ${i + 1}/${chunks.length}): ${err.message}`);
-        }
-      }
+      // 0.7.0: use markdown-aware chunker + deliverReplies primitive.
+      // The old chunkText was newline/byte-only; chunkMarkdownText also
+      // respects code-fence boundaries (closes + reopens across chunks).
+      const chunks = chunkMarkdownText(parsed.text, TG_MAX_LEN);
+      await deliverReplies({
+        bot,
+        send: (b, method, params, m) => tg(b, method, params, m),
+        chatId,
+        threadId,
+        chunks,
+        replyToMessageId: msg.message_id,
+        meta: outMeta,
+        logger: { error: (m) => console.error(`[${label}] ${m}`) },
+      });
     }
 
     console.log(`[${label}] ${elapsed}s | ${result.text.length} chars | ${chatConfig.model}/${chatConfig.effort} | $${result.cost?.toFixed(4) || '?'}`);
@@ -2468,6 +2545,38 @@ async function main() {
       const head = entry.pendingQueue?.[0];
       const r = head?.context?.reactor;
       if (r) r.setState(classifyToolName(toolName));
+      // 0.7.0 (Phase J): opt-in subagent announce. When Claude uses
+      // the Task tool to spawn a subagent, post a brief informational
+      // message to the chat so the user knows a heavier turn is in
+      // progress. Off by default (per-bot or per-chat
+      // `announceSubagents: true` opts in). Per-chat debounce 30s
+      // prevents announce-storms in tool-heavy turns.
+      const chatCfg = config.chats[entry.chatId] || {};
+      const optIn = chatCfg.announceSubagents != null
+        ? chatCfg.announceSubagents
+        : config.bot?.announceSubagents;
+      if (toolName === 'Task' && optIn === true) {
+        if (shouldAnnounce(entry.chatId)) {
+          announce({
+            send: (b, method, params, m) => tg(b, method, params, m),
+            bot, chatId: entry.chatId,
+            threadId: head?.context?.threadId ?? null,
+            text: '🤖 Spawning subagent…',
+            meta: { botName: BOT_NAME, source: 'subagent-announce' },
+            logger: { error: (m) => console.error(`[${entry.label}] ${m}`) },
+          });
+        }
+      }
+    },
+    // 0.7.0 (Phase F): each new top-level assistant message gets its
+    // own bubble. When Claude emits text, then tool_use, then more
+    // text in a NEW assistant message (typical of tool-heavy turns),
+    // the previous bubble's content stays visible as a "thinking out
+    // loud" intermediate; the new message starts fresh below.
+    onAssistantMessageStart: (sessionKey, entry) => {
+      const head = entry.pendingQueue?.[0];
+      const s = head?.context?.streamer;
+      if (s) s.forceNewMessage();
     },
     // Fires after a graceful /model or /effort drain has actually
     // swapped to the new settings. Post a confirmation back to the