poly-weaver 0.12.2 → 0.12.4

package/dist/user/host-curate-prompt.js

@@ -7,10 +7,11 @@ import { noteFocus } from "../text-editing/kill-ring.js";
 import { clipToWidth, tagFor, userAddedTag, wrapToWidth, } from "./curate-prompt.js";
 import { buildPlanPane } from "./plan-pane.js";
 import { buildIssuesArtifactPane, issueMetaToken } from "./issues-pane.js";
-import { buildSplitSurface, computeSplitMetrics, SPLIT_COLLAPSE_AT_COLS, } from "./split-surface.js";
+import { buildSplitSurface, computeSplitMetrics, sideBySidePaneRegion, SPLIT_COLLAPSE_AT_COLS, } from "./split-surface.js";
 import { renderShortcutHints } from "./shortcut-hints.js";
 import { OffscreenController, } from "../offscreen/controller.js";
 import { composeIssueInquiry } from "./issue-inquiry.js";
+import { createSelectableDocumentPane, } from "./selectable-doc-pane.js";
 import { AttachmentManager } from "../paste-image/attachment-manager.js";
 import { ALT_V_PASTE_IMAGE_HINT, handleBracketedPaste, handleImagePasteIntent, PASTING_IMAGE_HINT, } from "../paste-image/intents.js";
 import { applyEditingBufferEvent, applyEditInsertedText, bufferFromText, emptyBuffer, finalizeEditText, renderMultilineEditor, } from "./feedback-editing.js";
@@ -64,6 +65,8 @@ export class HostBackedCuratePrompt {
             userAdded: [],
             editing: undefined,
             planScrollTop: 0,
+            issueScrollTop: 0,
+            issueScrollPinnedToCursor: true,
             nextCycle: issues.map(() => 0),
         };
         const parser = new EmacsInputParser();
@@ -114,6 +117,7 @@ export class HostBackedCuratePrompt {
                 if (!editing)
                     return;
                 state.editing = undefined;
+                state.issueScrollPinnedToCursor = true;
                 if (editing.target.kind === "reviewer-revise" &&
                     !state.comments[editing.target.index]) {
                     state.decisions[editing.target.index] = "keep";
@@ -127,6 +131,7 @@ export class HostBackedCuratePrompt {
                     state.comments[i] = text.length > 0 ? text : undefined;
                     if (!state.comments[i])
                         state.decisions[i] = "keep";
+                    state.issueScrollPinnedToCursor = true;
                     return;
                 }
                 if (editing.target.kind === "user-edit") {
@@ -138,12 +143,14 @@ export class HostBackedCuratePrompt {
                         state.userAdded.splice(i, 1);
                         clampCursor(issues.length, state);
                     }
+                    state.issueScrollPinnedToCursor = true;
                     return;
                 }
                 if (text.length > 0) {
                     state.userAdded.push(text);
                     state.cursor = issues.length + state.userAdded.length - 1;
                 }
+                state.issueScrollPinnedToCursor = true;
                 clampCursor(issues.length, state);
             };
             const submitEdit = () => {
@@ -170,6 +177,7 @@ export class HostBackedCuratePrompt {
                 });
             };
             const openReviewerEditor = (index, text = "") => {
+                state.issueScrollPinnedToCursor = true;
                 state.editing = {
                     target: { kind: "reviewer-revise", index },
                     buffer: bufferFromText(text),
@@ -178,6 +186,7 @@ export class HostBackedCuratePrompt {
                 };
             };
             const openUserAddEditor = () => {
+                state.issueScrollPinnedToCursor = true;
                 state.editing = {
                     target: { kind: "user-add" },
                     buffer: emptyBuffer(),
@@ -191,6 +200,7 @@ export class HostBackedCuratePrompt {
                 editing.transientHint = outcome.hint ?? null;
                 if (outcome.inserted !== undefined)
                     applyEditInsertedText(editing, outcome.inserted);
+                state.issueScrollPinnedToCursor = true;
                 this.host.scheduleParentUiRender();
             };
             const launchEditPasteIntent = (editing, task) => {
@@ -248,6 +258,7 @@ export class HostBackedCuratePrompt {
                         if (event.type === "ctrl-j") {
                             dirty = applyEditingBufferEvent(state.editing, { type: "newline" }) || dirty;
                             dirty = true;
+                            state.issueScrollPinnedToCursor = true;
                             continue;
                         }
                         if (event.type === "arrow") {
@@ -261,10 +272,14 @@ export class HostBackedCuratePrompt {
                                     type: event.direction === "up" ? "ctrl-p" : "ctrl-n",
                                 }) || dirty;
                             }
+                            if (dirty)
+                                state.issueScrollPinnedToCursor = true;
                             continue;
                         }
                         if (isTextBufferEvent(event)) {
                             dirty = applyEditingBufferEvent(state.editing, event) || dirty;
+                            if (dirty)
+                                state.issueScrollPinnedToCursor = true;
                             continue;
                         }
                         continue;
@@ -285,12 +300,14 @@ export class HostBackedCuratePrompt {
                             state.cursor = (state.cursor - 1 + total) % total;
                             if (state.cursor < issues.length)
                                 state.nextCycle[state.cursor] = 0;
+                            state.issueScrollPinnedToCursor = true;
                             dirty = true;
                         }
                         else if (event.direction === "down") {
                             state.cursor = (state.cursor + 1) % total;
                             if (state.cursor < issues.length)
                                 state.nextCycle[state.cursor] = 0;
+                            state.issueScrollPinnedToCursor = true;
                             dirty = true;
                         }
                         continue;
@@ -341,6 +358,7 @@ export class HostBackedCuratePrompt {
                                 attachments: new AttachmentManager(),
                                 transientHint: null,
                             };
+                            state.issueScrollPinnedToCursor = true;
                             dirty = true;
                         }
                         else {
@@ -358,6 +376,7 @@ export class HostBackedCuratePrompt {
                         if (next === "revise") {
                             openReviewerEditor(state.cursor);
                         }
+                        state.issueScrollPinnedToCursor = true;
                         dirty = true;
                         continue;
                     }
@@ -398,6 +417,7 @@ export class HostBackedCuratePrompt {
                             if (event.text.toLowerCase() === "d") {
                                 state.userAdded.splice(state.cursor - issues.length, 1);
                                 clampCursor(issues.length, state);
+                                state.issueScrollPinnedToCursor = true;
                                 dirty = true;
                             }
                             continue;
@@ -416,6 +436,7 @@ export class HostBackedCuratePrompt {
                         if (openedEditor) {
                             openReviewerEditor(state.cursor);
                         }
+                        state.issueScrollPinnedToCursor = true;
                         if (state.decisions[state.cursor] !== prev || openedEditor)
                             dirty = true;
                     }
@@ -424,6 +445,7 @@ export class HostBackedCuratePrompt {
                     this.host.scheduleParentUiRender();
                 return finished;
             };
+            const selectionPanes = createCurateSelectionPanes(verdict, plan, state, context, () => this.host.getLayout(), () => offscreenController);
             const baseMode = {
                 getSurface: () => {
                     const layout = this.host.getLayout();
@@ -431,6 +453,15 @@ export class HostBackedCuratePrompt {
                     const rows = Math.max(1, layout.childRows);
                     return buildSurface(verdict, plan, state, cols, rows, context, offscreenController);
                 },
+                selectionRegionAt: (column, row) => {
+                    const layout = this.host.getLayout();
+                    const cols = Math.max(20, layout.columns);
+                    const rows = Math.max(1, layout.childRows);
+                    return curateSelectionRegionAt(column, row, cols, rows);
+                },
+                selectionTargetAt: (column, row) => selectionPanes.selectionTargetAt(column, row),
+                docSurfaceSelectionPlacementAt: (column, row) => selectionPanes.placementAt(column, row),
+                docSurfaceSelectionPlacements: () => selectionPanes.placements(),
                 onEvents: (keys) => {
                     processEvents(parser.mapKeys(keys));
                     return true;
@@ -488,15 +519,7 @@ function navigableCount(issueCount, state) {
 function clampCursor(issueCount, state) {
     state.cursor = Math.max(0, Math.min(state.cursor, navigableCount(issueCount, state) - 1));
 }
-function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive, issueInquiry) {
-    const pinnedHint = clipToWidth(globalHintText, width);
-    const scrollRows = Math.max(0, rows - 1);
-    if (scrollRows === 0) {
-        return {
-            lines: [pinnedHint],
-            cursor: { row: 0, col: 0 },
-        };
-    }
+function buildIssueListRows(verdict, state, width, citationLive, issueInquiry) {
     const issues = verdict.issues;
     const lines = [];
     const n = issues.length;
@@ -508,9 +531,6 @@ function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive
         }
     }
     lines.push("");
-    // Every navigable row gets an explicit anchor so scrolling and prompt
-    // cursor placement work for reviewer issues, user-added rows, and the
-    // trailing add row uniformly.
     const rowStarts = [];
     const rowEnds = [];
     let editorRow;
@@ -543,8 +563,6 @@ function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive
             if (metaToken) {
                 const lastIdx = lines.length - 1;
                 const lastVis = visibleLength(lines[lastIdx]);
-                // Append meta to the last rendered row if it fits with a separating
-                // space; otherwise put it on a new indented row.
                 if (lastVis + 1 + metaWidth <= width) {
                     lines[lastIdx] = `${lines[lastIdx]} ${metaToken}`;
                 }
@@ -553,7 +571,6 @@ function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive
                 }
             }
         }
-        // Inline revise row(s).
         if (state.decisions[i] === "revise") {
             const prefix = "  └─ Revise: ";
             const reviseAvail = Math.max(1, width - visibleLength(prefix));
@@ -631,29 +648,43 @@ function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive
     for (const l of wrapToWidth(renderShortcutHints(curateHelpTokens(state, issues.length, citationLive, issueInquiry)), width)) {
         lines.push(l);
     }
+    return { lines, rowStarts, rowEnds, editorRow, editorCol };
+}
+function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive, issueInquiry) {
+    const pinnedHint = clipToWidth(globalHintText, width);
+    const scrollRows = Math.max(0, rows - 1);
+    if (scrollRows === 0) {
+        return {
+            lines: [pinnedHint],
+            cursor: { row: 0, col: 0 },
+        };
+    }
+    const { lines, rowStarts, rowEnds, editorRow, editorCol } = buildIssueListRows(verdict, state, width, citationLive, issueInquiry);
     const activeStart = rowStarts[state.cursor] ?? 0;
     const activeEndExclusive = rowEnds[state.cursor] ?? lines.length;
     // Prefer to show the entire active block; if it is taller than `rows`,
     // fall back to the editor row (when editing) or the header row.
-    let scrollTop = 0;
     const total = lines.length;
+    let scrollTop = Math.min(Math.max(0, state.issueScrollTop), Math.max(0, total - scrollRows));
     if (total > scrollRows) {
-        // Default: anchor to the start of the active issue.
-        scrollTop = activeStart;
-        // If the block fits and there is room above, pull the window up so we
-        // also include some preceding context rather than leaving blank rows
-        // below.
-        if (activeEndExclusive - scrollTop < scrollRows) {
-            scrollTop = Math.max(0, total - scrollRows);
-            if (scrollTop > activeStart)
-                scrollTop = activeStart;
-        }
-        // If editing, prefer keeping the editor row visible.
-        if (editorRow !== undefined) {
-            if (editorRow < scrollTop)
-                scrollTop = editorRow;
-            if (editorRow >= scrollTop + scrollRows)
-                scrollTop = editorRow - scrollRows + 1;
+        if (state.issueScrollPinnedToCursor) {
+            // Default: anchor to the start of the active issue.
+            scrollTop = activeStart;
+            // If the block fits and there is room above, pull the window up so we
+            // also include some preceding context rather than leaving blank rows
+            // below.
+            if (activeEndExclusive - scrollTop < scrollRows) {
+                scrollTop = Math.max(0, total - scrollRows);
+                if (scrollTop > activeStart)
+                    scrollTop = activeStart;
+            }
+            // If editing, prefer keeping the editor row visible.
+            if (editorRow !== undefined) {
+                if (editorRow < scrollTop)
+                    scrollTop = editorRow;
+                if (editorRow >= scrollTop + scrollRows)
+                    scrollTop = editorRow - scrollRows + 1;
+            }
         }
         // Clamp.
         if (scrollTop < 0)
@@ -661,6 +692,7 @@ function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive
         if (scrollTop + scrollRows > total)
             scrollTop = total - scrollRows;
     }
+    state.issueScrollTop = scrollTop;
     let cursorRow;
     let cursorCol;
     if (editorRow !== undefined) {
@@ -674,13 +706,9 @@ function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive
     }
     // Slice / pad to exactly `scrollRows`; the global hint row is pinned below
     // this scrollable issue window.
-    if (scrollTop > 0) {
-        lines.splice(0, scrollTop);
-    }
-    while (lines.length < scrollRows)
-        lines.push("");
-    if (lines.length > scrollRows)
-        lines.splice(scrollRows, lines.length - scrollRows);
+    const visibleLines = lines.slice(scrollTop, scrollTop + scrollRows);
+    while (visibleLines.length < scrollRows)
+        visibleLines.push("");
     if (cursorRow < 0)
         cursorRow = 0;
     if (cursorRow >= scrollRows)
@@ -689,9 +717,9 @@ function buildLeftPane(verdict, state, width, rows, globalHintText, citationLive
         cursorCol = 0;
     if (cursorCol >= width)
         cursorCol = Math.max(0, width - 1);
-    lines.push(pinnedHint);
+    visibleLines.push(pinnedHint);
     return {
-        lines: lines.map((l) => clipToWidth(l, width)),
+        lines: visibleLines.map((l) => clipToWidth(l, width)),
         cursor: { row: cursorRow, col: cursorCol },
     };
 }
@@ -719,6 +747,174 @@ function computeNarrowPlanRows(rows) {
     // visible.
     return Math.max(3, Math.floor((rows - 1) / 2));
 }
+function computeCurateCollapsedLayout(rows) {
+    const visibleRows = Math.max(1, rows);
+    const planRows = computeNarrowPlanRows(visibleRows);
+    return {
+        planRows,
+        planEnd: Math.min(planRows, visibleRows),
+        separatorRow: planRows + 1,
+        bodyStart: planRows + 2,
+        bodyEnd: visibleRows,
+    };
+}
+function curateSelectionRegionAt(column, row, cols, rows) {
+    if (column < 1 || column > cols || row < 1 || row > rows)
+        return null;
+    const geometry = curateSelectionGeometry(cols, rows);
+    if (pointInRegion(column, row, geometry.plan?.region))
+        return geometry.plan.region;
+    if (pointInRegion(column, row, geometry.issueList?.region)) {
+        return geometry.issueList.region;
+    }
+    if (pointInRegion(column, row, geometry.issueChrome))
+        return geometry.issueChrome;
+    const split = computeSplitMetrics({ cols, rows, collapseAt: COLLAPSE_AT_COLS });
+    if (!split.collapsed && geometry.issueChrome === undefined) {
+        return sideBySidePaneRegion(column, rows, split);
+    }
+    return null;
+}
+function curateSelectionGeometry(cols, rows) {
+    const split = computeSplitMetrics({ cols, rows, collapseAt: COLLAPSE_AT_COLS });
+    if (!split.collapsed) {
+        const issueRows = Math.max(0, rows - 1);
+        return {
+            plan: {
+                region: {
+                    rowStart: 1,
+                    rowEnd: rows,
+                    colStart: split.leftWidth + 2,
+                    colEnd: cols,
+                },
+                width: split.rightWidth,
+                visibleRows: rows,
+            },
+            issueList: issueRows > 0
+                ? {
+                    region: { rowStart: 1, rowEnd: issueRows, colStart: 1, colEnd: split.leftWidth },
+                    width: split.leftWidth,
+                    visibleRows: issueRows,
+                }
+                : undefined,
+            issueChrome: issueRows < rows
+                ? { rowStart: issueRows + 1, rowEnd: rows, colStart: 1, colEnd: split.leftWidth }
+                : undefined,
+        };
+    }
+    const layout = computeCurateCollapsedLayout(rows);
+    const issueRows = Math.max(0, layout.bodyEnd - layout.bodyStart + 1);
+    const issueListRows = Math.max(0, issueRows - 1);
+    return {
+        plan: layout.planEnd >= 1
+            ? {
+                region: { rowStart: 1, rowEnd: layout.planEnd, colStart: 1, colEnd: cols },
+                width: cols,
+                visibleRows: layout.planEnd,
+            }
+            : undefined,
+        issueList: issueListRows > 0
+            ? {
+                region: {
+                    rowStart: layout.bodyStart,
+                    rowEnd: layout.bodyStart + issueListRows - 1,
+                    colStart: 1,
+                    colEnd: cols,
+                },
+                width: cols,
+                visibleRows: issueListRows,
+            }
+            : undefined,
+        issueChrome: issueRows > issueListRows
+            ? { rowStart: layout.bodyStart + issueListRows, rowEnd: layout.bodyEnd, colStart: 1, colEnd: cols }
+            : undefined,
+    };
+}
+function createCurateSelectionPanes(verdict, plan, state, context, getLayout, getController) {
+    const current = () => {
+        const layout = getLayout();
+        const cols = Math.max(20, layout.columns);
+        const rows = Math.max(1, layout.childRows);
+        return { cols, rows, geometry: curateSelectionGeometry(cols, rows) };
+    };
+    const issueLines = (width, planWidth) => {
+        const controller = getController();
+        const issueInquiry = (context.offscreen?.slots ?? []).map((slot) => ({
+            binding: slot.binding,
+            ready: controller?.isIssueInquiryReady(slot.binding) ?? true,
+        }));
+        const citationLive = !state.editing &&
+            state.cursor < verdict.issues.length &&
+            findCitationTargets(verdict.issues[state.cursor]?.citations, buildCuratePlanPane(plan, planWidth).sources).length > 0;
+        return buildIssueListRows(verdict, state, width, citationLive, issueInquiry).lines;
+    };
+    const planPane = createSelectableDocumentPane({
+        lines: () => {
+            const { geometry } = current();
+            return geometry.plan ? buildCuratePlanPane(plan, geometry.plan.width).lines : [];
+        },
+        getScrollTop: () => state.planScrollTop,
+        setScrollTop: (value) => {
+            const { geometry } = current();
+            const pane = geometry.plan;
+            if (!pane)
+                return;
+            const max = Math.max(0, buildCuratePlanPane(plan, pane.width).lines.length - pane.visibleRows);
+            state.planScrollTop = Math.min(max, Math.max(0, Math.trunc(value)));
+        },
+        getViewportRows: () => current().geometry.plan?.visibleRows ?? 1,
+    });
+    const issuePane = createSelectableDocumentPane({
+        lines: () => {
+            const { geometry } = current();
+            const planWidth = geometry.plan?.width ?? geometry.issueList?.width ?? 1;
+            return geometry.issueList ? issueLines(geometry.issueList.width, planWidth) : [];
+        },
+        getScrollTop: () => state.issueScrollTop,
+        setScrollTop: (value) => {
+            const { geometry } = current();
+            const pane = geometry.issueList;
+            if (!pane)
+                return;
+            const planWidth = geometry.plan?.width ?? pane.width;
+            const max = Math.max(0, issueLines(pane.width, planWidth).length - pane.visibleRows);
+            state.issueScrollTop = Math.min(max, Math.max(0, Math.trunc(value)));
+        },
+        getViewportRows: () => current().geometry.issueList?.visibleRows ?? 1,
+        onManualScroll: () => {
+            state.issueScrollPinnedToCursor = false;
+        },
+    });
+    const placements = () => {
+        const { geometry } = current();
+        const result = [];
+        if (geometry.plan &&
+            buildCuratePlanPane(plan, geometry.plan.width).lines.length > geometry.plan.visibleRows) {
+            result.push({ region: geometry.plan.region, pane: planPane });
+        }
+        if (geometry.issueList) {
+            const planWidth = geometry.plan?.width ?? geometry.issueList.width;
+            if (issueLines(geometry.issueList.width, planWidth).length > geometry.issueList.visibleRows) {
+                result.push({ region: geometry.issueList.region, pane: issuePane });
+            }
+        }
+        return result;
+    };
+    return {
+        selectionTargetAt: (column, row) => placements().some((placement) => pointInRegion(column, row, placement.region))
+            ? "parent-doc-surface"
+            : null,
+        placementAt: (column, row) => placements().find((placement) => pointInRegion(column, row, placement.region)),
+        placements,
+    };
+}
+function pointInRegion(column, row, region) {
+    return !!region &&
+        column >= region.colStart &&
+        column <= region.colEnd &&
+        row >= region.rowStart &&
+        row <= region.rowEnd;
+}
 function buildSurface(verdict, plan, state, cols, rows, context, offscreenController) {
     const split = computeSplitMetrics({ cols, rows, collapseAt: COLLAPSE_AT_COLS });
     const primaryReady = offscreenController?.isIssueInquiryReady("primary") ?? true;
@@ -735,7 +931,7 @@ function buildSurface(verdict, plan, state, cols, rows, context, offscreenContro
         // Narrow stack: plan on top, divider rule, issues below. Both panes are
         // independently scrollable (plan via PageUp/PageDown/Home/End/wheel,
         // issues via Up/Down cursor movement).
-        const planRows = computeNarrowPlanRows(rows);
+        const { planRows } = computeCurateCollapsedLayout(rows);
         const issueRows = Math.max(1, rows - 1 - planRows);
         const right = buildRightPane(verdict, plan, state, cols, planRows);
         const left = buildLeftPane(verdict, state, cols, issueRows, hint, citationLive, issueInquiry);