polendina 3.3.2 → 3.3.3

package/test/fixtures/mocha-failure/package.json

@@ -1,19 +1,5 @@
 {
   "name": "fixture-mocha-failure",
   "version": "1.0.0",
-  "description": "test fixture",
-  "main": "index.js",
-  "scripts": {
-    "test": "mocha test-*.js"
-  },
-  "author": "Rod <rod@vagg.org> (http://r.va.gg/)",
-  "license": "Apache-2.0",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/rvagg/polendina.git"
-  },
-  "devDependencies": {
-    "chai": "^6.0.1",
-    "mocha": "^12.0.2"
-  }
+  "private": true
 }

package/test/fixtures/mocha-failure-esm/package.json

@@ -1,20 +1,6 @@
 {
   "name": "fixture-mocha-failure",
   "version": "1.0.0",
-  "description": "test fixture",
-  "main": "index.js",
-  "type": "module",
-  "scripts": {
-    "test": "mocha test-*.js"
-  },
-  "author": "Rod <rod@vagg.org> (http://r.va.gg/)",
-  "license": "Apache-2.0",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/rvagg/polendina.git"
-  },
-  "devDependencies": {
-    "chai": "^6.0.1",
-    "mocha": "^12.0.2"
-  }
+  "private": true,
+  "type": "module"
 }

package/test/fixtures/tape/package.json

@@ -1,18 +1,5 @@
 {
   "name": "fixture-tape",
   "version": "1.0.0",
-  "description": "test fixture",
-  "main": "index.js",
-  "scripts": {
-    "test": "tape test.js"
-  },
-  "author": "Rod <rod@vagg.org> (http://r.va.gg/)",
-  "license": "Apache-2.0",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/rvagg/polendina.git"
-  },
-  "devDependencies": {
-    "tape": "^5.6.3"
-  }
+  "private": true
 }

package/test/fixtures/tape-esm/package.json

@@ -1,19 +1,6 @@
 {
   "name": "fixture-tape",
   "version": "1.0.0",
-  "description": "test fixture",
-  "main": "index.js",
-  "type": "module",
-  "scripts": {
-    "test": "tape test.js"
-  },
-  "author": "Rod <rod@vagg.org> (http://r.va.gg/)",
-  "license": "Apache-2.0",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/rvagg/polendina.git"
-  },
-  "devDependencies": {
-    "tape": "^5.6.3"
-  }
+  "private": true,
+  "type": "module"
 }

package/test/fixtures/tape-failure/package.json

@@ -1,18 +1,5 @@
 {
   "name": "fixture-tape-failure",
   "version": "1.0.0",
-  "description": "test fixture",
-  "main": "index.js",
-  "scripts": {
-    "test": "tape test.js"
-  },
-  "author": "Rod <rod@vagg.org> (http://r.va.gg/)",
-  "license": "Apache-2.0",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/rvagg/polendina.git"
-  },
-  "devDependencies": {
-    "tape": "^5.6.3"
-  }
+  "private": true
 }

package/test/fixtures/tape-failure-esm/package.json

@@ -1,19 +1,6 @@
 {
   "name": "fixture-tape-failure",
   "version": "1.0.0",
-  "description": "test fixture",
-  "main": "index.js",
-  "type": "module",
-  "scripts": {
-    "test": "tape test.js"
-  },
-  "author": "Rod <rod@vagg.org> (http://r.va.gg/)",
-  "license": "Apache-2.0",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/rvagg/polendina.git"
-  },
-  "devDependencies": {
-    "tape": "^5.6.3"
-  }
+  "private": true,
+  "type": "module"
 }

package/test/fixtures/webpack-merge/package.json

@@ -1,18 +1,5 @@
 {
   "name": "fixture-webpack-merge",
   "version": "1.0.0",
-  "description": "test fixture",
-  "main": "index.js",
-  "scripts": {
-    "test": "node test.js"
-  },
-  "author": "Rod <rod@vagg.org> (http://r.va.gg/)",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/rvagg/polendina.git"
-  },
-  "license": "Apache-2.0",
-  "devDependencies": {
-    "chai": "^6.0.1"
-  }
+  "private": true
 }

package/test/setup.js

@@ -0,0 +1,96 @@
+// Mocha global fixtures. Packs polendina and installs it into temporary
+// consumer directories outside the repository, one per test runner, each with
+// only the frameworks that runner's fixtures import at the versions in
+// test/consumer/package.json, then copies test/fixtures in. npm hoists polendina's dependencies into each consumer's node_modules,
+// the layout a real install has and one the fixtures cannot produce from
+// inside this tree. Keeping the runners apart means no runner's dependency
+// tree can shadow or nest another's.
+//
+// Tests find the consumers through POLENDINA_CONSUMERS, a JSON object of
+// name to directory. Set POLENDINA_KEEP_CONSUMERS to leave them behind.
+
+import fs from 'fs'
+import os from 'os'
+import path from 'path'
+import { exec } from 'child_process'
+import { fileURLToPath } from 'url'
+
+const __dirname = fileURLToPath(path.dirname(import.meta.url))
+const root = path.join(__dirname, '..')
+const puppeteerVersion = JSON.parse(fs.readFileSync(path.join(root, 'node_modules/puppeteer/package.json'))).version
+const template = JSON.parse(fs.readFileSync(path.join(__dirname, 'consumer/package.json'))).devDependencies
+
+// consumer name to the packages it installs alongside polendina; a bare name
+// takes its version range from test/consumer/package.json, name@range pins one
+const variants = {
+  mocha: ['mocha', 'chai'],
+  mocha11: ['mocha@11', 'chai'],
+  tape: ['tape'],
+  bare: ['chai']
+}
+
+const consumers = {}
+
+function dependency (pkg) {
+  const at = pkg.indexOf('@', 1)
+  if (at > 0) {
+    return [pkg.slice(0, at), pkg.slice(at + 1)]
+  }
+  if (!template[pkg]) {
+    throw new Error(`${pkg} is not in test/consumer/package.json`)
+  }
+  return [pkg, template[pkg]]
+}
+
+function sh (command, cwd) {
+  return new Promise((resolve, reject) => {
+    const env = { ...process.env, PUPPETEER_SKIP_DOWNLOAD: '1' }
+    exec(command, { cwd, env }, (err, stdout, stderr) => {
+      if (err) {
+        return reject(new Error(`${command}\n${stderr}`))
+      }
+      resolve(stdout.toString())
+    })
+  })
+}
+
+async function installConsumer (name, tarball, packages) {
+  const dir = await fs.promises.mkdtemp(path.join(os.tmpdir(), `polendina-consumer-${name}-`))
+  const pkg = {
+    name: `polendina-consumer-${name}`,
+    private: true,
+    devDependencies: {
+      polendina: `file:${tarball}`,
+      puppeteer: puppeteerVersion,
+      ...Object.fromEntries(packages.map(dependency))
+    }
+  }
+  await fs.promises.writeFile(path.join(dir, 'package.json'), JSON.stringify(pkg, null, 2))
+  await fs.promises.cp(path.join(__dirname, 'fixtures'), path.join(dir, 'fixtures'), {
+    recursive: true,
+    filter: (src) => path.basename(src) !== 'node_modules'
+  })
+  await sh('npm install --no-audit --no-fund --no-package-lock --prefer-offline', dir)
+  return dir
+}
+
+export async function mochaGlobalSetup () {
+  const packDir = await fs.promises.mkdtemp(path.join(os.tmpdir(), 'polendina-pack-'))
+  const [{ filename }] = JSON.parse(await sh(`npm pack --json --pack-destination "${packDir}"`, root))
+  const tarball = path.join(packDir, filename)
+  await Promise.all(Object.entries(variants).map(async ([name, packages]) => {
+    consumers[name] = await installConsumer(name, tarball, packages)
+  }))
+  await fs.promises.rm(packDir, { recursive: true, force: true })
+  process.env.POLENDINA_CONSUMERS = JSON.stringify(consumers)
+}
+
+export async function mochaGlobalTeardown () {
+  if (process.env.POLENDINA_KEEP_CONSUMERS) {
+    console.log('Keeping consumers:', consumers)
+    return
+  }
+  for (const dir of Object.values(consumers)) {
+    await fs.promises.rm(dir, { recursive: true, force: true })
+  }
+}

package/test/test-bare-async.js

@@ -1,15 +1,11 @@
 /* globals describe it */
 
 import assert from 'assert'
-import path from 'path'
-import { fileURLToPath } from 'url'
 import { runCli } from './common.js'
 
-const __dirname = fileURLToPath(path.dirname(import.meta.url))
-
 for (const type of ['cjs', 'esm']) {
-  const bareAsyncFixture = path.join(__dirname, `fixtures/bare-async${type === 'esm' ? '-esm' : ''}`)
-  const bareAsyncFailureFixture = path.join(__dirname, `fixtures/bare-async-failure${type === 'esm' ? '-esm' : ''}`)
+  const bareAsyncFixture = `bare-async${type === 'esm' ? '-esm' : ''}`
+  const bareAsyncFailureFixture = `bare-async-failure${type === 'esm' ? '-esm' : ''}`
 
   describe(`basic bare-async (${type})`, function () {
     this.timeout(60000)
@@ -27,7 +23,7 @@ testing bare fixture subdir
 `
 
     it('should run in page', async () => {
-      const { stdout, stderr, code } = await runCli(bareAsyncFixture, '--runner=bare-async')
+      const { stdout, stderr, code } = await runCli('bare', bareAsyncFixture, ['--runner=bare-async'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -41,7 +37,7 @@ testing bare fixture subdir
     })
 
     it('should run in worker', async () => {
-      const { stdout, stderr, code } = await runCli(bareAsyncFixture, '--runner=bare-async --worker --page=false')
+      const { stdout, stderr, code } = await runCli('bare', bareAsyncFixture, ['--runner=bare-async', '--worker', '--page=false'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -55,7 +51,7 @@ testing bare fixture subdir
     })
 
     it('should run in serviceworker', async () => {
-      const { stdout, stderr, code } = await runCli(bareAsyncFixture, '--runner=bare-async --serviceworker --page=false')
+      const { stdout, stderr, code } = await runCli('bare', bareAsyncFixture, ['--runner=bare-async', '--serviceworker', '--page=false'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -69,7 +65,7 @@ testing bare fixture subdir
     })
 
     it('should run in page, worker and serviceworker', async () => {
-      const { stdout, stderr, code } = await runCli(bareAsyncFixture, '--runner=bare-async --worker --serviceworker')
+      const { stdout, stderr, code } = await runCli('bare', bareAsyncFixture, ['--runner=bare-async', '--worker', '--serviceworker'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -111,7 +107,7 @@ testing bare fixture
     const expectedStderr = 'AssertionError: faily mcfailface'
 
     it('should fail in page', async () => {
-      let { stdout, stderr, code } = await runCli(bareAsyncFailureFixture, '--runner=bare-async')
+      let { stdout, stderr, code } = await runCli('bare', bareAsyncFailureFixture, ['--runner=bare-async'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
@@ -124,7 +120,7 @@ testing bare fixture
     })
 
     it('should fail in worker', async () => {
-      let { stdout, stderr, code } = await runCli(bareAsyncFailureFixture, '--runner=bare-async --worker --page=false')
+      let { stdout, stderr, code } = await runCli('bare', bareAsyncFailureFixture, ['--runner=bare-async', '--worker', '--page=false'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'in worker')
@@ -137,7 +133,7 @@ testing bare fixture
     })
 
     it('should fail in serviceworker', async () => {
-      let { stdout, stderr, code } = await runCli(bareAsyncFailureFixture, '--runner=bare-async --serviceworker --page=false')
+      let { stdout, stderr, code } = await runCli('bare', bareAsyncFailureFixture, ['--runner=bare-async', '--serviceworker', '--page=false'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
@@ -150,7 +146,7 @@ testing bare fixture
     })
 
     it('should fail in page and not run in worker', async () => {
-      let { stdout, stderr, code } = await runCli(bareAsyncFailureFixture, '--runner=bare-async --worker')
+      let { stdout, stderr, code } = await runCli('bare', bareAsyncFailureFixture, ['--runner=bare-async', '--worker'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'not in worker')

package/test/test-bare-sync.js

@@ -1,15 +1,11 @@
 /* globals describe it */
 
 import assert from 'assert'
-import path from 'path'
-import { fileURLToPath } from 'url'
 import { runCli } from './common.js'
 
-const __dirname = fileURLToPath(path.dirname(import.meta.url))
-
 for (const type of ['cjs', 'esm']) {
-  const bareSyncFixture = path.join(__dirname, `fixtures/bare-sync${type === 'esm' ? '-esm' : ''}`)
-  const bareSyncFailureFixture = path.join(__dirname, `fixtures/bare-sync-failure${type === 'esm' ? '-esm' : ''}`)
+  const bareSyncFixture = `bare-sync${type === 'esm' ? '-esm' : ''}`
+  const bareSyncFailureFixture = `bare-sync-failure${type === 'esm' ? '-esm' : ''}`
 
   describe(`basic bare-sync (${type})`, function () {
     this.timeout(60000)
@@ -23,7 +19,7 @@ testing bare fixture subdir
 `
 
     it('should run in page', async () => {
-      const { stdout, stderr, code } = await runCli(bareSyncFixture, '--runner=bare-sync')
+      const { stdout, stderr, code } = await runCli('bare', bareSyncFixture, ['--runner=bare-sync'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -37,7 +33,7 @@ testing bare fixture subdir
     })
 
     it('should run in worker', async () => {
-      const { stdout, stderr, code } = await runCli(bareSyncFixture, '--runner=bare-sync --worker --page=false')
+      const { stdout, stderr, code } = await runCli('bare', bareSyncFixture, ['--runner=bare-sync', '--worker', '--page=false'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -51,7 +47,7 @@ testing bare fixture subdir
     })
 
     it('should run in serviceworker', async () => {
-      const { stdout, stderr, code } = await runCli(bareSyncFixture, '--runner=bare-sync --serviceworker --page=false')
+      const { stdout, stderr, code } = await runCli('bare', bareSyncFixture, ['--runner=bare-sync', '--serviceworker', '--page=false'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -65,7 +61,7 @@ testing bare fixture subdir
     })
 
     it('should run in page, worker and serviceworker', async () => {
-      const { stdout, stderr, code } = await runCli(bareSyncFixture, '--runner=bare-sync --worker --serviceworker')
+      const { stdout, stderr, code } = await runCli('bare', bareSyncFixture, ['--runner=bare-sync', '--worker', '--serviceworker'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -105,7 +101,7 @@ testing bare fixture
     const expectedStderr = 'AssertionError: faily mcfailface'
 
     it('should fail in page', async () => {
-      let { stdout, stderr, code } = await runCli(bareSyncFailureFixture, '--runner=bare-sync')
+      let { stdout, stderr, code } = await runCli('bare', bareSyncFailureFixture, ['--runner=bare-sync'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
@@ -118,7 +114,7 @@ testing bare fixture
     })
 
     it('should fail in worker', async () => {
-      let { stdout, stderr, code } = await runCli(bareSyncFailureFixture, '--runner=bare-sync --worker --page=false')
+      let { stdout, stderr, code } = await runCli('bare', bareSyncFailureFixture, ['--runner=bare-sync', '--worker', '--page=false'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'in worker')
@@ -131,7 +127,7 @@ testing bare fixture
     })
 
     it('should fail in serviceworker', async () => {
-      let { stdout, stderr, code } = await runCli(bareSyncFailureFixture, '--runner=bare-sync --serviceworker --page=false')
+      let { stdout, stderr, code } = await runCli('bare', bareSyncFailureFixture, ['--runner=bare-sync', '--serviceworker', '--page=false'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
@@ -144,7 +140,7 @@ testing bare fixture
     })
 
     it('should fail in page and not run in worker', async () => {
-      let { stdout, stderr, code } = await runCli(bareSyncFailureFixture, '--runner=bare-sync --worker')
+      let { stdout, stderr, code } = await runCli('bare', bareSyncFailureFixture, ['--runner=bare-sync', '--worker'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = stdout.replace(/^ +at .*\n/gm, '') // stack traces
       const expected = expectedTemplate.replace(/WORKER/, 'not in worker')

package/test/test-mocha.js

@@ -1,37 +1,37 @@
 /* globals describe it */
 
 import assert from 'assert'
-import path from 'path'
-import { fileURLToPath } from 'url'
 import { runCli } from './common.js'
 
-const __dirname = fileURLToPath(path.dirname(import.meta.url))
-
 function removeTimings (stdout) {
   return stdout.replace(/\(\d+ms\)/g, '(Xms)')
 }
 
-for (const type of ['cjs', 'esm']) {
-  const mochaFixture = path.join(__dirname, `fixtures/mocha${type === 'esm' ? '-esm' : ''}`)
-  const mochaFailureFixture = path.join(__dirname, `fixtures/mocha-failure${type === 'esm' ? '-esm' : ''}`)
+// the consumers to run against, with the spec reporter's pass symbol, which
+// differs by major in the browser bundle
+const ticks = { mocha: '\u2714', mocha11: '\u2705' }
+
+for (const [consumerName, type] of Object.keys(ticks).flatMap((c) => ['cjs', 'esm'].map((t) => [c, t]))) {
+  const mochaFixture = `mocha${type === 'esm' ? '-esm' : ''}`
+  const mochaFailureFixture = `mocha-failure${type === 'esm' ? '-esm' : ''}`
 
-  describe(`basic mocha (${type})`, function () {
+  describe(`basic mocha (${type}, ${consumerName})`, function () {
     this.timeout(60000)
     const expectedTemplate = `
   test suite 1
-    ✔ test case 1
-    ✔ test case 2
+    ${ticks[consumerName]} test case 1
+    ${ticks[consumerName]} test case 2
 
   test suite 2 - worker
-    ✔ is WORKER
+    ${ticks[consumerName]} is WORKER
 
   test suite 3
-    ✔ test case 1
-    ✔ test case 2
+    ${ticks[consumerName]} test case 1
+    ${ticks[consumerName]} test case 2
 `
 
     it('should run in page', async () => {
-      const { stdout, stderr, code } = await runCli(mochaFixture)
+      const { stdout, stderr, code } = await runCli(consumerName, mochaFixture, [])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -45,7 +45,7 @@ for (const type of ['cjs', 'esm']) {
     })
 
     it('should run in worker', async () => {
-      const { stdout, stderr, code } = await runCli(mochaFixture, '--worker --page=false')
+      const { stdout, stderr, code } = await runCli(consumerName, mochaFixture, ['--worker', '--page=false'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -59,7 +59,7 @@ for (const type of ['cjs', 'esm']) {
     })
 
     it('should run in serviceworker', async () => {
-      const { stdout, stderr, code } = await runCli(mochaFixture, '--serviceworker --page=false')
+      const { stdout, stderr, code } = await runCli(consumerName, mochaFixture, ['--serviceworker', '--page=false'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -73,7 +73,7 @@ for (const type of ['cjs', 'esm']) {
     })
 
     it('should run in page, worker and serviceworker', async () => {
-      const { stdout, stderr, code } = await runCli(mochaFixture, '--worker --serviceworker')
+      const { stdout, stderr, code } = await runCli(consumerName, mochaFixture, ['--worker', '--serviceworker'])
       if (code !== 0) {
         console.error(stderr)
       }
@@ -102,11 +102,11 @@ for (const type of ['cjs', 'esm']) {
     })
   })
 
-  describe(`failing mocha (${type})`, function () {
+  describe(`failing mocha (${type}, ${consumerName})`, function () {
     this.timeout(60000)
     const expectedTemplate = `
   test suite 1 - worker
-    ✔ is WORKER
+    ${ticks[consumerName]} is WORKER
 
   test suite 2 - failing
     1) should fail
@@ -121,7 +121,7 @@ for (const type of ['cjs', 'esm']) {
 `
 
     it('should fail in page', async () => {
-      let { stdout, code } = await runCli(mochaFailureFixture)
+      let { stdout, code } = await runCli(consumerName, mochaFailureFixture, [])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = removeTimings(stdout)
       const expected = expectedTemplate.replace(/WORKER/, 'not in worker')
@@ -133,7 +133,7 @@ for (const type of ['cjs', 'esm']) {
     })
 
     it('should fail in worker', async () => {
-      let { stdout, code } = await runCli(mochaFailureFixture, '--worker --page=false')
+      let { stdout, code } = await runCli(consumerName, mochaFailureFixture, ['--worker', '--page=false'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = removeTimings(stdout)
       const expected = expectedTemplate.replace(/WORKER/, 'in worker')
@@ -145,7 +145,7 @@ for (const type of ['cjs', 'esm']) {
     })
 
     it('should fail in serviceworker', async () => {
-      let { stdout, code } = await runCli(mochaFailureFixture, '--serviceworker --page=false')
+      let { stdout, code } = await runCli(consumerName, mochaFailureFixture, ['--serviceworker', '--page=false'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = removeTimings(stdout)
       const expected = expectedTemplate.replace(/WORKER/, 'in serviceworker')
@@ -157,7 +157,7 @@ for (const type of ['cjs', 'esm']) {
     })
 
     it('should fail in page and not run in worker', async () => {
-      let { stdout, code } = await runCli(mochaFailureFixture, '--worker')
+      let { stdout, code } = await runCli(consumerName, mochaFailureFixture, ['--worker'])
       assert.strictEqual(code, 1, 'exited with non-zero exit code')
       stdout = removeTimings(stdout)
       const expected = expectedTemplate.replace(/WORKER/, 'not in worker')