poe-code 3.0.337 → 3.0.338

package/dist/index.js

@@ -53828,6 +53828,8 @@ function parseReviewDiff(diffText) {
         status: "modified",
         hunks: [],
         reviewableLines: [],
+        leftLineSet: /* @__PURE__ */ new Set(),
+        rightContextLineSet: /* @__PURE__ */ new Set(),
         reviewableLineSet: /* @__PURE__ */ new Set()
       };
       continue;
@@ -53880,11 +53882,13 @@ function parseReviewDiff(diffText) {
     }
     if (line.startsWith("-") && !line.startsWith("---")) {
       currentHunk.lines.push({ side: "LEFT", line: oldLine, text: line });
+      currentFile.leftLineSet.add(oldLine);
       oldLine += 1;
       continue;
     }
     if (line.startsWith(" ")) {
       currentHunk.lines.push({ side: "RIGHT", line: newLine, text: line });
+      currentFile.rightContextLineSet.add(newLine);
       currentFile.reviewableLineSet.add(newLine);
       oldLine += 1;
       newLine += 1;
@@ -53902,6 +53906,8 @@ function parseReviewDiff(diffText) {
     files: publicFiles,
     fileOrder: new Map(publicFiles.map((file, index) => [file.path, index])),
     reviewableLinesByPath: new Map(files.map((file) => [file.path, file.reviewableLineSet])),
+    leftLinesByPath: new Map(files.map((file) => [file.path, file.leftLineSet])),
+    rightContextLinesByPath: new Map(files.map((file) => [file.path, file.rightContextLineSet])),
     rendered: publicFiles.map(renderReviewFile).join("\n\n")
   };
 }
@@ -53909,20 +53915,35 @@ function validateInlineComments(comments, context) {
   const accepted = [];
   const seen = /* @__PURE__ */ new Set();
   for (const comment of comments) {
-    const path176 = comment.path.trim();
+    const path176 = comment.path;
     const body = comment.body.trim();
-    if (!path176 || !body || !Number.isInteger(comment.line) || comment.line < 1) {
+    if (path176.length === 0 || !body || !Number.isInteger(comment.line) || comment.line < 1) {
       throw new Error("Inline review comments require path, positive line, and body.");
     }
+    if (comment.side === "LEFT") {
+      throw new Error(
+        `Inline comment target ${path176}:${comment.line} is a left-side diff target; only right-side comments are supported.`
+      );
+    }
     if (!context.reviewableLinesByPath.get(path176)?.has(comment.line)) {
       throw new Error(
         `Inline comment target ${path176}:${comment.line} is not a valid right-side diff target.`
       );
     }
+    if (!comment.side && context.leftLinesByPath.get(path176)?.has(comment.line) && context.rightContextLinesByPath.get(path176)?.has(comment.line)) {
+      throw new Error(
+        `Inline comment target ${path176}:${comment.line} is ambiguous; specify side RIGHT to target the right-side diff line.`
+      );
+    }
     const key2 = `${path176}\0${comment.line}\0${body}`;
     if (!seen.has(key2)) {
       seen.add(key2);
-      accepted.push({ path: path176, line: comment.line, body });
+      accepted.push({
+        path: path176,
+        line: comment.line,
+        ...comment.side ? { side: comment.side } : {},
+        body
+      });
     }
   }
   accepted.sort((left, right) => {
@@ -54101,7 +54122,7 @@ var init_github_api = __esm({
 // packages/github-review/src/pr-url.ts
 function parseUrl2(value) {
   try {
-    return new URL(value);
+    return new URL(value.trim());
   } catch {
     return null;
   }
@@ -54121,6 +54142,9 @@ function parsePathPart(value) {
     return null;
   }
 }
+function formatPullRequestUrl(ref) {
+  return `https://${ref.host}/${encodeURIComponent(ref.owner)}/${encodeURIComponent(ref.repo)}/pull/${ref.number}`;
+}
 function parseGitHubPullRequestRef(prUrl) {
   const parsed = parseUrl2(prUrl);
   if (!parsed || parsed.protocol !== "https:" || !parsed.hostname || parsed.username || parsed.password) {
@@ -54136,20 +54160,20 @@ function parseGitHubPullRequestRef(prUrl) {
   if (!owner || !repo || !Number.isSafeInteger(number) || number <= 0) {
     return null;
   }
-  return {
+  const ref = {
     host: parsed.host.toLowerCase(),
     owner,
     repo,
-    number,
-    url: prUrl
+    number
   };
+  return { ...ref, url: formatPullRequestUrl(ref) };
 }
 function canonicalPullRequestUrl(prUrl) {
   const ref = parseGitHubPullRequestRef(prUrl);
   if (!ref) {
     return prUrl;
   }
-  return `https://${ref.host}/${encodeURIComponent(ref.owner)}/${encodeURIComponent(ref.repo)}/pull/${ref.number}`;
+  return ref.url;
 }
 var init_pr_url = __esm({
   "packages/github-review/src/pr-url.ts"() {
@@ -54212,12 +54236,13 @@ function parseJson2(stdout, action) {
   }
 }
 function ghPrView(prUrl, fields, options = {}) {
-  requirePullRequestRef(prUrl);
+  const ref = requirePullRequestRef(prUrl);
+  const canonicalPrUrl = ref.url;
   const requestedFields = dedupe([...fields]);
-  const result = runGh(["pr", "view", prUrl, "--json", requestedFields.join(",")], options);
+  const result = runGh(["pr", "view", canonicalPrUrl, "--json", requestedFields.join(",")], options);
   if (result.code === 0) {
     const parsed2 = parseJsonRecord(result.stdout, "gh pr view");
-    parsed2.url ??= prUrl;
+    parsed2.url ??= canonicalPrUrl;
     return parsed2;
   }
   const availableFields = parseGhAvailableFields(result.stderr);
@@ -54225,17 +54250,20 @@ function ghPrView(prUrl, fields, options = {}) {
   if (fallbackFields.length === 0 || fallbackFields.length === requestedFields.length) {
     throw new Error(result.stderr.trim() || result.stdout.trim() || "gh pr view failed");
   }
-  const fallback = runGh(["pr", "view", prUrl, "--json", fallbackFields.join(",")], options);
+  const fallback = runGh(
+    ["pr", "view", canonicalPrUrl, "--json", fallbackFields.join(",")],
+    options
+  );
   if (fallback.code !== 0) {
     throw new Error(fallback.stderr.trim() || fallback.stdout.trim() || "gh pr view failed");
   }
   const parsed = parseJsonRecord(fallback.stdout, "gh pr view");
-  parsed.url ??= prUrl;
+  parsed.url ??= canonicalPrUrl;
   return parsed;
 }
 function ghPrDiff(prUrl, options = {}) {
-  requirePullRequestRef(prUrl);
-  return runGhOrThrow(["pr", "diff", prUrl], options);
+  const ref = requirePullRequestRef(prUrl);
+  return runGhOrThrow(["pr", "diff", ref.url], options);
 }
 function ghApiJson(prUrl, args, payload, options = {}) {
   const ref = requirePullRequestRef(prUrl);
@@ -54408,18 +54436,21 @@ function reviewEndpoint(prUrl) {
   }
   return `repos/${ref.owner}/${ref.repo}/pulls/${ref.number}/reviews`;
 }
-function validateReviewComments(comments) {
-  for (const comment of comments) {
-    if (!comment.path.trim()) {
+function normalizeReviewComments(comments) {
+  return comments.map((comment) => {
+    const path176 = comment.path.trim();
+    const body = comment.body.trim();
+    if (!path176) {
       throw new Error("Review comment path must be non-empty.");
     }
     if (!Number.isSafeInteger(comment.line) || comment.line <= 0) {
       throw new Error("Review comment line must be a positive integer.");
     }
-    if (!comment.body.trim()) {
+    if (!body) {
       throw new Error("Review comment body must be non-empty.");
     }
-  }
+    return { path: path176, line: comment.line, body };
+  });
 }
 function submissionFromResponse(response) {
   return {
@@ -54432,8 +54463,7 @@ function submitPullRequestReview(input) {
   if (!REVIEW_DECISIONS.has(input.decision)) {
     throw new Error(`Invalid pull request review decision: ${input.decision}`);
   }
-  const comments = input.comments ?? [];
-  validateReviewComments(comments);
+  const comments = normalizeReviewComments(input.comments ?? []);
   const response = ghApiJson(
     prUrl,
     ["--method", "POST", reviewEndpoint(prUrl)],
@@ -54531,9 +54561,30 @@ function isAtOrAfter(value, since) {
   if (!value) return false;
   return new Date(value).getTime() >= new Date(since).getTime();
 }
-function createdAt(record, kind) {
+function rawCreatedAt(record, kind) {
   return kind === "review_body" ? text4(record, "submitted_at") ?? text4(record, "created_at") : text4(record, "created_at") ?? text4(record, "submitted_at");
 }
+function createdAt(record, kind) {
+  const value = rawCreatedAt(record, kind);
+  if (!value) {
+    return null;
+  }
+  const timestamp = new Date(value);
+  if (Number.isNaN(timestamp.getTime())) {
+    throw new Error(`Invalid GitHub review-history ${kind} timestamp: ${value}`);
+  }
+  return timestamp.toISOString();
+}
+function dedupeRepos(repos) {
+  const deduped = /* @__PURE__ */ new Map();
+  for (const repo of repos) {
+    const key2 = repo.toLowerCase();
+    if (!deduped.has(key2)) {
+      deduped.set(key2, repo);
+    }
+  }
+  return [...deduped.values()];
+}
 async function* fetchReviewHistory(options) {
   if (!options.username.trim()) {
     throw new Error("GitHub review-history username is required.");
@@ -54541,7 +54592,7 @@ async function* fetchReviewHistory(options) {
   if (options.maxComments !== void 0 && (!Number.isInteger(options.maxComments) || options.maxComments < 1)) {
     throw new Error("Review-history maxComments must be a positive integer.");
   }
-  const repos = [...new Set(options.repos)];
+  const repos = dedupeRepos(options.repos);
   for (const repo of repos) {
     if (!validRepo(repo)) {
       throw new Error(`Invalid GitHub repository name: ${repo}`);
@@ -138111,7 +138162,7 @@ var init_package2 = __esm({
   "package.json"() {
     package_default2 = {
       name: "poe-code",
-      version: "3.0.337",
+      version: "3.0.338",
       description: "CLI tool to configure Poe API for developer workflows.",
       type: "module",
       main: "./dist/index.js",