pocketbase-zod-schema 0.3.0 → 0.3.2

package/dist/index.cjs

@@ -488,6 +488,45 @@ function extractFieldMetadata(description) {
   }
   return null;
 }
+var MAX_FILE_SIZE_BYTES = 8 * 1024 * 1024 * 1024;
+function parseByteSizeToBytes(value, context) {
+  let bytes;
+  if (typeof value === "number") {
+    if (!Number.isFinite(value)) {
+      throw new Error(`${context}: maxSize must be a finite number of bytes`);
+    }
+    bytes = Math.round(value);
+  } else {
+    const trimmed = value.trim();
+    const match = /^(\d+(?:\.\d+)?)\s*([KMG])$/i.exec(trimmed);
+    if (!match) {
+      throw new Error(`${context}: maxSize string must be like "10K", "5M", or "1G" (case-insensitive)`);
+    }
+    const amount = Number(match[1]);
+    const unit = match[2].toUpperCase();
+    if (!Number.isFinite(amount)) {
+      throw new Error(`${context}: maxSize must be a valid number`);
+    }
+    const multiplier = unit === "K" ? 1024 : unit === "M" ? 1024 * 1024 : 1024 * 1024 * 1024;
+    bytes = Math.round(amount * multiplier);
+  }
+  if (bytes < 0) {
+    throw new Error(`${context}: maxSize must be >= 0`);
+  }
+  if (bytes > MAX_FILE_SIZE_BYTES) {
+    throw new Error(`${context}: maxSize cannot exceed 8G (${MAX_FILE_SIZE_BYTES} bytes)`);
+  }
+  return bytes;
+}
+function normalizeFileFieldOptions(options, context) {
+  if (!options) return options;
+  if (options.maxSize === void 0) return options;
+  return {
+    ...options,
+    // PocketBase expects bytes; normalize any human-friendly inputs to bytes here.
+    maxSize: parseByteSizeToBytes(options.maxSize, context)
+  };
+}
 function BoolField() {
   const metadata = {
     [FIELD_METADATA_KEY]: {
@@ -610,11 +649,14 @@ function SelectField(values, options) {
   return enumSchema.describe(JSON.stringify(metadata));
 }
 function FileField(options) {
-  const schema = zod.z.instanceof(File);
+  const schema = zod.z.preprocess((val) => {
+    return val instanceof File ? val.name || "" : val;
+  }, zod.z.string());
+  const normalizedOptions = normalizeFileFieldOptions(options, "FileField");
   const metadata = {
     [FIELD_METADATA_KEY]: {
       type: "file",
-      options: options || {}
+      options: normalizedOptions || {}
     }
   };
   return schema.describe(JSON.stringify(metadata));
@@ -625,17 +667,24 @@ function FilesField(options) {
       throw new Error("FilesField: minSelect cannot be greater than maxSelect");
     }
   }
-  let schema = zod.z.array(zod.z.instanceof(File));
+  let baseArraySchema = zod.z.array(zod.z.string());
   if (options?.minSelect !== void 0) {
-    schema = schema.min(options.minSelect);
+    baseArraySchema = baseArraySchema.min(options.minSelect);
   }
   if (options?.maxSelect !== void 0) {
-    schema = schema.max(options.maxSelect);
+    baseArraySchema = baseArraySchema.max(options.maxSelect);
   }
+  const schema = zod.z.preprocess((val) => {
+    if (Array.isArray(val)) {
+      return val.map((item) => item instanceof File ? item.name || "" : item);
+    }
+    return val;
+  }, baseArraySchema);
+  const normalizedOptions = normalizeFileFieldOptions(options, "FilesField");
   const metadata = {
     [FIELD_METADATA_KEY]: {
       type: "file",
-      options: options || {}
+      options: normalizedOptions || {}
     }
   };
   return schema.describe(JSON.stringify(metadata));
@@ -2497,7 +2546,7 @@ var SchemaAnalyzer = class {
 var SNAPSHOT_VERSION = "1.0.0";
 function resolveCollectionIdToName(collectionId) {
   if (collectionId === "_pb_users_auth_") {
-    return "Users";
+    return "users";
   }
   const nameMatch = collectionId.match(/app\.findCollectionByNameOrId\s*\(\s*["']([^"']+)["']\s*\)/);
   if (nameMatch) {
@@ -2505,6 +2554,39 @@ function resolveCollectionIdToName(collectionId) {
   }
   return collectionId;
 }
+function extractFieldOptions2(pbField) {
+  const options = {};
+  if (pbField.options && typeof pbField.options === "object") {
+    Object.assign(options, pbField.options);
+  }
+  const directOptionKeys = [
+    "min",
+    "max",
+    "pattern",
+    "noDecimal",
+    // text/number fields
+    "values",
+    "maxSelect",
+    // select fields
+    "mimeTypes",
+    "maxSize",
+    "thumbs",
+    "protected",
+    // file fields
+    "onCreate",
+    "onUpdate",
+    // autodate fields
+    "exceptDomains",
+    "onlyDomains"
+    // email/url fields
+  ];
+  for (const key of directOptionKeys) {
+    if (pbField[key] !== void 0) {
+      options[key] = pbField[key];
+    }
+  }
+  return options;
+}
 function convertPocketBaseCollection(pbCollection) {
   const fields = [];
   const systemFieldNames = ["id", "created", "updated", "collectionId", "collectionName", "expand"];
@@ -2522,23 +2604,19 @@ function convertPocketBaseCollection(pbCollection) {
         type: pbField.type,
         required: pbField.required || false
       };
-      field.options = pbField.options ? { ...pbField.options } : {};
-      if (pbField.type === "select") {
-        if (pbField.values && Array.isArray(pbField.values)) {
-          field.options.values = pbField.values;
-        } else if (pbField.options?.values && Array.isArray(pbField.options.values)) {
-          field.options.values = pbField.options.values;
-        }
-      }
+      field.options = extractFieldOptions2(pbField);
       if (pbField.type === "relation") {
         const collectionId = pbField.collectionId || pbField.options?.collectionId || "";
-        const collectionName = resolveCollectionIdToName(collectionId);
+        const collectionName = resolveCollectionIdToName(collectionId || "");
         field.relation = {
           collection: collectionName,
           cascadeDelete: pbField.cascadeDelete ?? pbField.options?.cascadeDelete ?? false,
           maxSelect: pbField.maxSelect ?? pbField.options?.maxSelect,
           minSelect: pbField.minSelect ?? pbField.options?.minSelect
         };
+        delete field.options.maxSelect;
+        delete field.options.minSelect;
+        delete field.options.cascadeDelete;
       }
       const hasOnlyValues = Object.keys(field.options).length === 1 && field.options.values !== void 0;
       if (Object.keys(field.options).length === 0) {
@@ -2552,17 +2630,21 @@ function convertPocketBaseCollection(pbCollection) {
     type: pbCollection.type || "base",
     fields
   };
+  if (pbCollection.id) {
+    schema.id = pbCollection.id;
+  }
   if (pbCollection.indexes && Array.isArray(pbCollection.indexes)) {
     schema.indexes = pbCollection.indexes;
   }
-  const rules = {};
-  if (pbCollection.listRule !== void 0) rules.listRule = pbCollection.listRule;
-  if (pbCollection.viewRule !== void 0) rules.viewRule = pbCollection.viewRule;
-  if (pbCollection.createRule !== void 0) rules.createRule = pbCollection.createRule;
-  if (pbCollection.updateRule !== void 0) rules.updateRule = pbCollection.updateRule;
-  if (pbCollection.deleteRule !== void 0) rules.deleteRule = pbCollection.deleteRule;
-  if (pbCollection.manageRule !== void 0) rules.manageRule = pbCollection.manageRule;
-  if (Object.keys(rules).length > 0) {
+  const hasAnyRule = pbCollection.listRule !== void 0 || pbCollection.viewRule !== void 0 || pbCollection.createRule !== void 0 || pbCollection.updateRule !== void 0 || pbCollection.deleteRule !== void 0 || pbCollection.manageRule !== void 0;
+  if (hasAnyRule) {
+    const rules = {};
+    if (pbCollection.listRule !== void 0) rules.listRule = pbCollection.listRule;
+    if (pbCollection.viewRule !== void 0) rules.viewRule = pbCollection.viewRule;
+    if (pbCollection.createRule !== void 0) rules.createRule = pbCollection.createRule;
+    if (pbCollection.updateRule !== void 0) rules.updateRule = pbCollection.updateRule;
+    if (pbCollection.deleteRule !== void 0) rules.deleteRule = pbCollection.deleteRule;
+    if (pbCollection.manageRule !== void 0) rules.manageRule = pbCollection.manageRule;
     schema.rules = rules;
     schema.permissions = { ...rules };
   }
@@ -3312,17 +3394,19 @@ var CollectionIdRegistry = class {
   }
   /**
    * Generates a unique collection ID for a given collection name
-   * Special case: Returns constant "_pb_users_auth_" for users collection
    * Retries up to 10 times if collision occurs (extremely rare)
+   * Special case: returns "_pb_users_auth_" for users collection
    *
-   * @param collectionName - The name of the collection
+   * @param collectionName - The name of the collection (optional)
    * @returns A unique collection ID
    * @throws Error if unable to generate unique ID after max attempts
    */
   generate(collectionName) {
     if (collectionName && collectionName.toLowerCase() === "users") {
       const usersId = "_pb_users_auth_";
-      this.register(usersId);
+      if (!this.has(usersId)) {
+        this.register(usersId);
+      }
       return usersId;
     }
     const maxAttempts = 10;
@@ -3506,18 +3590,49 @@ function compareFieldConstraints(currentField, previousField) {
   }
   return changes;
 }
+function normalizeOptionValue(key, value, fieldType) {
+  if (key === "maxSelect" && value === 1 && (fieldType === "select" || fieldType === "file")) {
+    return void 0;
+  }
+  if (key === "maxSize" && value === 0 && fieldType === "file") {
+    return void 0;
+  }
+  if (fieldType === "file") {
+    if (key === "mimeTypes" && Array.isArray(value) && value.length === 0) {
+      return void 0;
+    }
+    if (key === "thumbs" && Array.isArray(value) && value.length === 0) {
+      return void 0;
+    }
+    if (key === "protected" && value === false) {
+      return void 0;
+    }
+  }
+  if (fieldType === "autodate") {
+    if (key === "onCreate" && value === true) {
+      return void 0;
+    }
+    if (key === "onUpdate" && value === false) {
+      return void 0;
+    }
+  }
+  return value;
+}
 function compareFieldOptions(currentField, previousField) {
   const changes = [];
   const currentOptions = currentField.options || {};
   const previousOptions = previousField.options || {};
   const allKeys = /* @__PURE__ */ new Set([...Object.keys(currentOptions), ...Object.keys(previousOptions)]);
+  const fieldType = currentField.type;
   for (const key of allKeys) {
     const currentValue = currentOptions[key];
     const previousValue = previousOptions[key];
-    if (currentValue === void 0 && previousValue === void 0) {
+    const normalizedCurrent = normalizeOptionValue(key, currentValue, fieldType);
+    const normalizedPrevious = normalizeOptionValue(key, previousValue, fieldType);
+    if (normalizedCurrent === void 0 && normalizedPrevious === void 0) {
       continue;
     }
-    if (!areValuesEqual(currentValue, previousValue)) {
+    if (!areValuesEqual(normalizedCurrent, normalizedPrevious)) {
       changes.push({
         property: `options.${key}`,
         oldValue: previousValue,
@@ -3527,7 +3642,7 @@ function compareFieldOptions(currentField, previousField) {
   }
   return changes;
 }
-function compareRelationConfigurations(currentField, previousField) {
+function compareRelationConfigurations(currentField, previousField, collectionIdToName) {
   const changes = [];
   const currentRelation = currentField.relation;
   const previousRelation = previousField.relation;
@@ -3539,8 +3654,8 @@ function compareRelationConfigurations(currentField, previousField) {
   }
   const normalizeCollection = (collection) => {
     if (!collection) return collection;
-    if (collection === "_pb_users_auth_") {
-      return "Users";
+    if (collectionIdToName && collectionIdToName.has(collection)) {
+      return collectionIdToName.get(collection);
     }
     const nameMatch = collection.match(/app\.findCollectionByNameOrId\s*\(\s*["']([^"']+)["']\s*\)/);
     if (nameMatch) {
@@ -3550,13 +3665,11 @@ function compareRelationConfigurations(currentField, previousField) {
   };
   const normalizedCurrent = normalizeCollection(currentRelation.collection);
   const normalizedPrevious = normalizeCollection(previousRelation.collection);
-  if (normalizedCurrent !== normalizedPrevious) {
+  if (normalizedCurrent.toLowerCase() !== normalizedPrevious.toLowerCase()) {
     changes.push({
       property: "relation.collection",
-      oldValue: normalizedPrevious,
-      // Use normalized value for clarity
-      newValue: normalizedCurrent
-      // Use normalized value for clarity
+      oldValue: previousRelation.collection,
+      newValue: currentRelation.collection
     });
   }
   if (currentRelation.cascadeDelete !== previousRelation.cascadeDelete) {
@@ -3566,14 +3679,20 @@ function compareRelationConfigurations(currentField, previousField) {
       newValue: currentRelation.cascadeDelete
     });
   }
-  if (currentRelation.maxSelect !== previousRelation.maxSelect) {
+  const normalizeMax = (val) => val === 1 ? null : val;
+  const currentMax = normalizeMax(currentRelation.maxSelect);
+  const previousMax = normalizeMax(previousRelation.maxSelect);
+  if (currentMax != previousMax) {
     changes.push({
       property: "relation.maxSelect",
       oldValue: previousRelation.maxSelect,
       newValue: currentRelation.maxSelect
     });
   }
-  if (currentRelation.minSelect !== previousRelation.minSelect) {
+  const normalizeMin = (val) => val === 0 ? null : val;
+  const currentMin = normalizeMin(currentRelation.minSelect);
+  const previousMin = normalizeMin(previousRelation.minSelect);
+  if (currentMin != previousMin) {
     changes.push({
       property: "relation.minSelect",
       oldValue: previousRelation.minSelect,
@@ -3582,7 +3701,7 @@ function compareRelationConfigurations(currentField, previousField) {
   }
   return changes;
 }
-function detectFieldChanges(currentField, previousField) {
+function detectFieldChanges(currentField, previousField, collectionIdToName) {
   const changes = [];
   const typeChange = compareFieldTypes(currentField, previousField);
   if (typeChange) {
@@ -3591,7 +3710,7 @@ function detectFieldChanges(currentField, previousField) {
   changes.push(...compareFieldConstraints(currentField, previousField));
   changes.push(...compareFieldOptions(currentField, previousField));
   if (currentField.type === "relation" && previousField.type === "relation") {
-    changes.push(...compareRelationConfigurations(currentField, previousField));
+    changes.push(...compareRelationConfigurations(currentField, previousField, collectionIdToName));
   }
   return changes;
 }
@@ -3602,7 +3721,7 @@ function compareIndexes(currentIndexes = [], previousIndexes = []) {
   const indexesToRemove = previousIndexes.filter((idx) => !currentSet.has(idx));
   return { indexesToAdd, indexesToRemove };
 }
-function compareRules(currentRules, previousRules) {
+function compareRules(currentRules, previousRules, currentPermissions, previousPermissions) {
   const updates = [];
   const ruleTypes = [
     "listRule",
@@ -3613,8 +3732,8 @@ function compareRules(currentRules, previousRules) {
     "manageRule"
   ];
   for (const ruleType of ruleTypes) {
-    const currentValue = currentRules?.[ruleType] ?? null;
-    const previousValue = previousRules?.[ruleType] ?? null;
+    const currentValue = currentRules?.[ruleType] ?? currentPermissions?.[ruleType] ?? null;
+    const previousValue = previousRules?.[ruleType] ?? previousPermissions?.[ruleType] ?? null;
     if (currentValue !== previousValue) {
       updates.push({
         ruleType,
@@ -3641,7 +3760,7 @@ function comparePermissions(currentPermissions, previousPermissions) {
   }
   return changes;
 }
-function compareCollectionFields(currentCollection, previousCollection, config) {
+function compareCollectionFields(currentCollection, previousCollection, config, collectionIdToName) {
   let fieldsToAdd = findNewFields(currentCollection.fields, previousCollection.fields);
   const fieldsToRemove = findRemovedFields(currentCollection.fields, previousCollection.fields);
   const fieldsToModify = [];
@@ -3651,7 +3770,7 @@ function compareCollectionFields(currentCollection, previousCollection, config)
   }
   const matchedFields = matchFieldsByName(currentCollection.fields, previousCollection.fields);
   for (const [currentField, previousField] of matchedFields) {
-    const changes = detectFieldChanges(currentField, previousField);
+    const changes = detectFieldChanges(currentField, previousField, collectionIdToName);
     if (changes.length > 0) {
       fieldsToModify.push({
         fieldName: currentField.name,
@@ -3663,14 +3782,20 @@ function compareCollectionFields(currentCollection, previousCollection, config)
   }
   return { fieldsToAdd, fieldsToRemove, fieldsToModify };
 }
-function buildCollectionModification(currentCollection, previousCollection, config) {
+function buildCollectionModification(currentCollection, previousCollection, config, collectionIdToName) {
   const { fieldsToAdd, fieldsToRemove, fieldsToModify } = compareCollectionFields(
     currentCollection,
     previousCollection,
-    config
+    config,
+    collectionIdToName
   );
   const { indexesToAdd, indexesToRemove } = compareIndexes(currentCollection.indexes, previousCollection.indexes);
-  const rulesToUpdate = compareRules(currentCollection.rules, previousCollection.rules);
+  const rulesToUpdate = compareRules(
+    currentCollection.rules,
+    previousCollection.rules,
+    currentCollection.permissions,
+    previousCollection.permissions
+  );
   const permissionsToUpdate = comparePermissions(currentCollection.permissions, previousCollection.permissions);
   return {
     collection: currentCollection.name,
@@ -3687,6 +3812,14 @@ function hasChanges(modification) {
   return modification.fieldsToAdd.length > 0 || modification.fieldsToRemove.length > 0 || modification.fieldsToModify.length > 0 || modification.indexesToAdd.length > 0 || modification.indexesToRemove.length > 0 || modification.rulesToUpdate.length > 0 || modification.permissionsToUpdate.length > 0;
 }
 function aggregateChanges(currentSchema, previousSnapshot, config) {
+  const collectionIdToName = /* @__PURE__ */ new Map();
+  if (previousSnapshot) {
+    for (const [name, collection] of previousSnapshot.collections) {
+      if (collection.id) {
+        collectionIdToName.set(collection.id, name);
+      }
+    }
+  }
   const collectionsToCreate = findNewCollections(currentSchema, previousSnapshot);
   const collectionsToDelete = findRemovedCollections(currentSchema, previousSnapshot);
   const filteredCollectionsToCreate = collectionsToCreate.filter(
@@ -3710,7 +3843,7 @@ function aggregateChanges(currentSchema, previousSnapshot, config) {
   const collectionsToModify = [];
   const matchedCollections = matchCollectionsByName(currentSchema, previousSnapshot);
   for (const [currentCollection, previousCollection] of matchedCollections) {
-    const modification = buildCollectionModification(currentCollection, previousCollection, config);
+    const modification = buildCollectionModification(currentCollection, previousCollection, config, collectionIdToName);
     if (hasChanges(modification)) {
       collectionsToModify.push(modification);
     }
@@ -4111,7 +4244,7 @@ function formatValue(value) {
     return JSON.stringify(value).replace(/","/g, '", "');
   }
   if (typeof value === "object") {
-    const entries = Object.entries(value).map(([k, v]) => `${k}: ${formatValue(v)}`).join(", ");
+    const entries = Object.entries(value).filter(([_k, v]) => v !== void 0).map(([k, v]) => `${k}: ${formatValue(v)}`).join(", ");
     return `{ ${entries} }`;
   }
   return String(value);
@@ -4280,6 +4413,9 @@ function getSystemFields() {
 function generateCollectionCreation(collection, varName = "collection", isLast = false, collectionIdMap) {
   const lines = [];
   lines.push(`  const ${varName} = new Collection({`);
+  if (collection.id) {
+    lines.push(`    id: ${formatValue(collection.id)},`);
+  }
   lines.push(`    name: "${collection.name}",`);
   lines.push(`    type: "${collection.type}",`);
   const permissionsCode = generateCollectionPermissions(collection.permissions);
@@ -4402,11 +4538,9 @@ function generateFieldModification(collectionName, modification, varName, isLast
 function generateFieldDeletion(collectionName, fieldName, varName, isLast = false) {
   const lines = [];
   const collectionVar = varName || `collection_${collectionName}_${fieldName}`;
-  const fieldVar = `${collectionVar}_field`;
   lines.push(`  const ${collectionVar} = app.findCollectionByNameOrId("${collectionName}");`);
-  lines.push(`  const ${fieldVar} = ${collectionVar}.fields.getByName("${fieldName}");`);
   lines.push(``);
-  lines.push(`  ${collectionVar}.fields.remove(${fieldVar}.id);`);
+  lines.push(`  ${collectionVar}.fields.removeByName("${fieldName}");`);
   lines.push(``);
   lines.push(isLast ? `  return app.save(${collectionVar});` : `  app.save(${collectionVar});`);
   return lines.join("\n");
@@ -4523,7 +4657,27 @@ function generateOperationUpMigration(operation, collectionIdMap) {
     const varName = `collection_${collectionName}`;
     lines.push(generateCollectionDeletion(collectionName, varName, true));
   }
-  return lines.join("\n");
+  let code = lines.join("\n");
+  const hasReturnStatement = /return\s+app\.(save|delete)\(/m.test(code);
+  if (!hasReturnStatement) {
+    const savePattern = /^(\s*)app\.save\((\w+)\);$/gm;
+    const deletePattern = /^(\s*)app\.delete\((\w+)\);$/gm;
+    const saveMatches = [...code.matchAll(savePattern)];
+    const deleteMatches = [...code.matchAll(deletePattern)];
+    const allMatches = [
+      ...saveMatches.map((m) => ({ match: m, type: "save", index: m.index })),
+      ...deleteMatches.map((m) => ({ match: m, type: "delete", index: m.index }))
+    ].sort((a, b) => b.index - a.index);
+    if (allMatches.length > 0) {
+      const lastMatch = allMatches[0];
+      if (lastMatch.type === "save") {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.save(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      } else {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.delete(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      }
+    }
+  }
+  return code;
 }
 function generateOperationDownMigration(operation, collectionIdMap) {
   const lines = [];
@@ -4608,7 +4762,27 @@ function generateOperationDownMigration(operation, collectionIdMap) {
       lines.push(generateCollectionCreation(collection, varName, true, collectionIdMap));
     }
   }
-  return lines.join("\n");
+  let code = lines.join("\n");
+  const hasReturnStatement = /return\s+app\.(save|delete)\(/m.test(code);
+  if (!hasReturnStatement) {
+    const savePattern = /^(\s*)app\.save\((\w+)\);$/gm;
+    const deletePattern = /^(\s*)app\.delete\((\w+)\);$/gm;
+    const saveMatches = [...code.matchAll(savePattern)];
+    const deleteMatches = [...code.matchAll(deletePattern)];
+    const allMatches = [
+      ...saveMatches.map((m) => ({ match: m, type: "save", index: m.index })),
+      ...deleteMatches.map((m) => ({ match: m, type: "delete", index: m.index }))
+    ].sort((a, b) => b.index - a.index);
+    if (allMatches.length > 0) {
+      const lastMatch = allMatches[0];
+      if (lastMatch.type === "save") {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.save(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      } else {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.delete(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      }
+    }
+  }
+  return code;
 }
 function generateUpMigration(diff) {
   const lines = [];
@@ -4706,20 +4880,23 @@ function generateUpMigration(diff) {
     lines.push(``);
   }
   let code = lines.join("\n");
-  const savePattern = /^(\s*)app\.save\((\w+)\);$/gm;
-  const deletePattern = /^(\s*)app\.delete\((\w+)\);$/gm;
-  const saveMatches = [...code.matchAll(savePattern)];
-  const deleteMatches = [...code.matchAll(deletePattern)];
-  const allMatches = [
-    ...saveMatches.map((m) => ({ match: m, type: "save", index: m.index })),
-    ...deleteMatches.map((m) => ({ match: m, type: "delete", index: m.index }))
-  ].sort((a, b) => b.index - a.index);
-  if (allMatches.length > 0) {
-    const lastMatch = allMatches[0];
-    if (lastMatch.type === "save") {
-      code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.save(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
-    } else {
-      code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.delete(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+  const hasReturnStatement = /return\s+app\.(save|delete)\(/m.test(code);
+  if (!hasReturnStatement) {
+    const savePattern = /^(\s*)app\.save\((\w+)\);$/gm;
+    const deletePattern = /^(\s*)app\.delete\((\w+)\);$/gm;
+    const saveMatches = [...code.matchAll(savePattern)];
+    const deleteMatches = [...code.matchAll(deletePattern)];
+    const allMatches = [
+      ...saveMatches.map((m) => ({ match: m, type: "save", index: m.index })),
+      ...deleteMatches.map((m) => ({ match: m, type: "delete", index: m.index }))
+    ].sort((a, b) => b.index - a.index);
+    if (allMatches.length > 0) {
+      const lastMatch = allMatches[0];
+      if (lastMatch.type === "save") {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.save(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      } else {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.delete(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      }
     }
   }
   return code;
@@ -4836,20 +5013,23 @@ function generateDownMigration(diff) {
     lines.push(``);
   }
   let code = lines.join("\n");
-  const savePattern = /^(\s*)app\.save\((\w+)\);$/gm;
-  const deletePattern = /^(\s*)app\.delete\((\w+)\);$/gm;
-  const saveMatches = [...code.matchAll(savePattern)];
-  const deleteMatches = [...code.matchAll(deletePattern)];
-  const allMatches = [
-    ...saveMatches.map((m) => ({ match: m, type: "save", index: m.index })),
-    ...deleteMatches.map((m) => ({ match: m, type: "delete", index: m.index }))
-  ].sort((a, b) => b.index - a.index);
-  if (allMatches.length > 0) {
-    const lastMatch = allMatches[0];
-    if (lastMatch.type === "save") {
-      code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.save(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
-    } else {
-      code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.delete(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+  const hasReturnStatement = /return\s+app\.(save|delete)\(/m.test(code);
+  if (!hasReturnStatement) {
+    const savePattern = /^(\s*)app\.save\((\w+)\);$/gm;
+    const deletePattern = /^(\s*)app\.delete\((\w+)\);$/gm;
+    const saveMatches = [...code.matchAll(savePattern)];
+    const deleteMatches = [...code.matchAll(deletePattern)];
+    const allMatches = [
+      ...saveMatches.map((m) => ({ match: m, type: "save", index: m.index })),
+      ...deleteMatches.map((m) => ({ match: m, type: "delete", index: m.index }))
+    ].sort((a, b) => b.index - a.index);
+    if (allMatches.length > 0) {
+      const lastMatch = allMatches[0];
+      if (lastMatch.type === "save") {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.save(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      } else {
+        code = code.substring(0, lastMatch.match.index) + lastMatch.match[1] + "return app.delete(" + lastMatch.match[2] + ");" + code.substring(lastMatch.match.index + lastMatch.match[0].length);
+      }
     }
   }
   return code;