pob 9.8.0 → 9.9.0

package/CHANGELOG.md

@@ -3,6 +3,27 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [9.9.0](https://github.com/christophehurpeau/pob/compare/pob@9.8.0...pob@9.9.0) (2021-12-18)
+
+
+### Bug Fixes
+
+* update mem-fs ([8fdf8f7](https://github.com/christophehurpeau/pob/commit/8fdf8f79768ac0ca6e0326e629834657e2992c71))
+* **pob:** ci testing check fix ([c8eb2cd](https://github.com/christophehurpeau/pob/commit/c8eb2cdf000766699e5590aebcc55e1c23d15700))
+* coverage is a documentation ([cfde873](https://github.com/christophehurpeau/pob/commit/cfde8733ef340dd097143acb66e9acd87e69fbbe))
+* defaults for readJSON5 method ([2a213b5](https://github.com/christophehurpeau/pob/commit/2a213b545be5e653b4f0a279983ea4cfeaacaa11))
+* update legacy yarn2 to node-modules ([d543e5e](https://github.com/christophehurpeau/pob/commit/d543e5ede8273f16fb0416424671c2d1d7c60c73))
+
+
+### Features
+
+* always use yarn workspaces commands ([83945e0](https://github.com/christophehurpeau/pob/commit/83945e0a2ee07c52ecd1a105e1e7b9749f91b712))
+* **deps:** update dependency eslint to v8.5.0 ([#1069](https://github.com/christophehurpeau/pob/issues/1069)) ([46d8538](https://github.com/christophehurpeau/pob/commit/46d85381f97fbd55e424ca8b6f1fc0138900ff7f))
+
+
+
+
+
 # [9.8.0](https://github.com/christophehurpeau/pob/compare/pob@9.7.4...pob@9.8.0) (2021-12-12)
 
 

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -69,7 +69,7 @@ export default class CoreCIGenerator extends Generator {
         this.destinationPath('.github/workflows/push.yml'),
         {
           packageManager: this.options.packageManager,
-          testing: this.options.testing && !!pkg.scripts.test,
+          testing: this.options.testing && !!pkg.scripts && !!pkg.scripts.test,
           checks: !!pkg.scripts && !!pkg.scripts.checks,
           documentation: this.options.documentation,
           build: this.options.build,

package/lib/generators/lib/PobLibGenerator.js

@@ -254,7 +254,9 @@ export default class PobLibGenerator extends Generator {
 
     // must be after testing
     this.composeWith('pob:common:format-lint', {
-      documentation: !!this.pobjson.documentation,
+      documentation:
+        !!this.pobjson.documentation ||
+        !!(this.pobjson.testing && this.pobjson.testing.codecov),
       testing: this.pobjson.testing,
       packageManager: this.options.packageManager,
       yarnNodeLinker: this.options.yarnNodeLinker,

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -228,11 +228,6 @@ export default class PobMonorepoGenerator extends Generator {
       packagePaths: JSON.stringify(packagePaths),
     });
 
-    // packageUtils.addOrRemoveScripts(pkg, this.pobLernaConfig.documentation, {
-    //   'generate:test-coverage':
-    //     'lerna run --parallel --ignore "*-example" generate:test-coverage',
-    // });
-
     if (this.pobLernaConfig.documentation) {
       pkg.scripts.build = `${
         pkg.scripts.build ? `${pkg.scripts.build} && ` : ''

package/lib/generators/monorepo/lerna/MonorepoLernaGenerator.js

@@ -154,8 +154,6 @@ export default class MonorepoLernaGenerator extends Generator {
 
     const monorepoConfig = this.config.get('monorepo');
     const packageManager = this.npm ? 'npm' : 'yarn';
-    const useYarnWorkspacesCommand =
-      pkg.name === 'pob-monorepo' || pkg.name === 'nightingale-monorepo'; // this.options.packageManager === 'yarn';
 
     packageUtils.addScripts(pkg, {
       lint: `${packageManager} run lint:prettier && ${packageManager} run lint:eslint`,
@@ -174,7 +172,7 @@ export default class MonorepoLernaGenerator extends Generator {
           ? `NODE_OPTIONS=--max_old_space_size=4096 eslint --report-unused-disable-directives --resolve-plugins-relative-to . --quiet . --ignore-pattern ${pkg.workspaces.join(
               ',',
             )} && yarn workspaces foreach --parallel -Av run lint:eslint`
-          : 'lerna run --stream lint:eslint',
+          : 'npm run lint:eslint --workspaces',
     });
 
     this.fs.copyTpl(
@@ -193,16 +191,10 @@ export default class MonorepoLernaGenerator extends Generator {
     );
 
     packageUtils.addOrRemoveScripts(pkg, withBabel, {
-      build: `${
-        useYarnWorkspacesCommand
-          ? 'yarn workspaces foreach --parallel --topological-dev -Av run'
-          : 'lerna run --stream'
-      } build`,
-      watch: `${
-        useYarnWorkspacesCommand
-          ? 'yarn workspaces foreach --parallel --exclude "*-example" -Av run'
-          : 'lerna run --parallel --ignore "*-example"'
-      } watch`,
+      build:
+        'yarn workspaces foreach --parallel --topological-dev -Av run build',
+      watch:
+        'yarn workspaces foreach --parallel --exclude "*-example" -Av run watch',
     });
 
     // packageUtils.addOrRemoveScripts(pkg, withTypescript, {

package/lib/generators/pob/PobBaseGenerator.js

@@ -82,7 +82,7 @@ export default class PobBaseGenerator extends Generator {
 
     if ('yarn2' in config) {
       if (config.yarn2) {
-        config.yarnNodeLinker = 'pnp';
+        config.yarnNodeLinker = 'node-modules';
       }
       delete config.yarn2;
     }

package/lib/pob.js

@@ -1,12 +1,10 @@
 #!/usr/bin/env node
 
-import { execSync, spawnSync } from 'child_process';
+import { spawnSync } from 'child_process';
 import fs, { existsSync, writeFileSync, readFileSync } from 'fs';
 import path from 'path';
 import argv from 'minimist-argv';
-// import updateNotifier from 'update-notifier';
 import yeoman from 'yeoman-environment';
-// import pkg from '../package.json';
 import PobAppGenerator from './generators/app/PobAppGenerator.js';
 import CommonBabelGenerator from './generators/common/babel/CommonBabelGenerator.js';
 import CommonLintGenerator from './generators/common/format-lint/CommonLintGenerator.js';
@@ -39,7 +37,6 @@ import { __dirname } from './pob-dirname.cjs';
 const printUsage = () => {
   console.error('Usage: pob [monorepo] [lib|app|init]');
   console.error('       pob [monorepo] update [--force]');
-  console.error('       pob monorepo convert-npm');
   console.error('       pob add <packageName>');
 };
 
@@ -60,8 +57,6 @@ if (argv.version) {
   process.exit(0);
 }
 
-// updateNotifier({ pkg }).notify();
-
 const env = yeoman.createEnv();
 
 env.on('error', (err) => {
@@ -250,16 +245,6 @@ if (action === 'add') {
   process.exit(0);
 }
 
-if (monorepo && action === 'convert-npm') {
-  execSync('sed -i \'/"npmClient": "yarn",/d\' ./lerna.json', {
-    stdio: 'inherit',
-  });
-  execSync('npm install packages/*', { stdio: 'inherit' });
-  execSync('yarn lerna link convert', { stdio: 'inherit' });
-  execSync('rm -Rf yarn.lock packages/*/yarn.lock', { stdio: 'inherit' });
-  process.exit(0);
-}
-
 const updateOnly = action === 'update';
 const init = action === 'init';
 const type = updateOnly || init ? null : action;

package/lib/utils/json5.js

@@ -1,7 +1,7 @@
 import JSON5 from 'json5';
 
 export function readJSON5(fs, destinationPath, defaults) {
-  const content = fs.read(destinationPath, null);
+  const content = fs.read(destinationPath, { defaults: null });
   if (content === null) return defaults;
   return JSON5.parse(content);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "9.8.0",
+  "version": "9.9.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -48,7 +48,7 @@
     "@pob/sort-object": "^4.0.1",
     "@pob/sort-pkg": "^4.0.1",
     "@yarnpkg/parsers": "2.5.0-rc.6",
-    "eslint": "8.4.1",
+    "eslint": "8.5.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^6.0.0",
@@ -57,16 +57,15 @@
     "json5": "^2.2.0",
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
-    "mem-fs": "1.2.0",
-    "mem-fs-editor": "8.1.2",
+    "mem-fs": "2.2.1",
+    "mem-fs-editor": "9.3.0",
     "minimist-argv": "^1.1.0",
     "parse-author": "^2.0.0",
-    "pob-dependencies": "6.3.3",
+    "pob-dependencies": "6.4.0",
     "prettier": "2.5.1",
     "semver": "^7.3.4",
-    "update-notifier": "^5.0.1",
     "yeoman-environment": "^3.5.1",
     "yeoman-generator": "^5.4.0"
   },
-  "gitHead": "1c94efb8acec1f95aeeea9b673c22c56497b9fcd"
+  "gitHead": "7f9d0b3c9e18734e5761e61dc09e89f3542b973b"
 }