pob 9.12.1 → 9.12.2

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.12.2](https://github.com/christophehurpeau/pob/compare/pob@9.12.1...pob@9.12.2) (2022-01-02)
+
+
+### Bug Fixes
+
+* **pob:** stop ci testing on node 14 on app projects ([c775697](https://github.com/christophehurpeau/pob/commit/c77569741136dc3feefcdc61f666092751be944c))
+
+
+
+
+
 ## [9.12.1](https://github.com/christophehurpeau/pob/compare/pob@9.12.0...pob@9.12.1) (2022-01-02)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -157,6 +157,7 @@ export default class PobAppGenerator extends Generator {
       codecov: false,
       ci: this.appConfig.ci,
       packageManager: this.options.packageManager,
+      isApp: true,
     });
 
     this.composeWith('pob:common:format-lint', {

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -125,10 +125,6 @@ export default class CommonBabelGenerator extends Generator {
           validate: (versions) => versions.length > 0,
           default: nodeVersions,
           choices: [
-            {
-              name: '12 (Maintenance LTS)',
-              value: '12',
-            },
             {
               name: '14 (Maintenance LTS)',
               value: '14',

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -48,6 +48,12 @@ export default class CommonTestingGenerator extends Generator {
       defaults: 'yarn',
       desc: 'yarn or npm',
     });
+
+    this.option('isApp', {
+      type: Boolean,
+      required: true,
+      desc: 'is app',
+    });
   }
 
   default() {
@@ -60,6 +66,7 @@ export default class CommonTestingGenerator extends Generator {
         documentation: this.options.documentation,
         codecov: this.options.codecov,
         packageManager: this.options.packageManager,
+        isApp: this.options.isApp,
       });
     } else {
       this.composeWith('pob:core:ci', {

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -54,6 +54,12 @@ export default class CoreCIGenerator extends Generator {
       required: true,
       desc: 'Include documentation generation',
     });
+
+    this.option('isApp', {
+      type: Boolean,
+      required: true,
+      desc: 'is app',
+    });
   }
 
   default() {
@@ -75,6 +81,7 @@ export default class CoreCIGenerator extends Generator {
           build: this.options.build,
           typescript: this.options.typescript,
           codecov: this.options.codecov,
+          supportsNode14: !this.options.isApp,
         },
       );
     } else {

package/lib/generators/core/ci/templates/github-action-node-workflow.yml.ejs

@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [<% if (supportsNode14) { -%>14.x, <% } -%>16.x]
 
     steps:
       - uses: actions/checkout@v2

package/lib/generators/core/git/CoreGitGenerator.js

@@ -13,6 +13,12 @@ export default class CoreGitGenerator extends Generator {
       defaults: '',
       desc: 'Should create the repo on github',
     });
+
+    this.option('isApp', {
+      type: String,
+      required: true,
+      desc: 'is app',
+    });
   }
 
   async initializing() {
@@ -94,6 +100,7 @@ export default class CoreGitGenerator extends Generator {
         shouldCreate: !this.originUrl,
         gitHostAccount: this.gitHostAccount,
         repoName: this.repoName,
+        isApp: this.options.isApp,
       });
     }
   }

package/lib/generators/core/git/generators/github/CoreGitGithubGenerator.js

@@ -15,14 +15,18 @@ const gh = got.extend({
   },
 });
 
-const configureProtectionRule = async (owner, repo) => {
+const configureProtectionRule = async (owner, repo, isApp) => {
   for (const branch of ['main', 'master']) {
     try {
       await gh.put(`repos/${owner}/${repo}/branches/${branch}/protection`, {
         json: {
           required_status_checks: {
             strict: false,
-            contexts: ['build (14.x)', 'build (16.x)', 'reviewflow'],
+            contexts: [
+              !isApp && 'build (14.x)',
+              'build (16.x)',
+              'reviewflow',
+            ].filter(Boolean),
           },
           enforce_admins: false, // true,
           required_pull_request_reviews: null,
@@ -67,6 +71,12 @@ export default class CoreGitGithubGenerator extends Generator {
       desc: 'repo name',
     });
 
+    this.option('isApp', {
+      type: String,
+      required: true,
+      desc: 'is app',
+    });
+
     if (!GITHUB_TOKEN && process.env.CI !== 'true') {
       throw new Error(
         'Missing POB_GITHUB_TOKEN. Create one with https://github.com/settings/tokens/new?scopes=repo&description=POB%20Generator and add it in your env variables.',
@@ -137,7 +147,7 @@ export default class CoreGitGithubGenerator extends Generator {
           cwd,
         });
 
-        configureProtectionRule(owner, repo);
+        configureProtectionRule(owner, repo, this.options.isApp);
 
         // await gh.put(`/repos/${owner}/${repo}/topics`, {
         //   names: pkg.keywords,
@@ -162,7 +172,7 @@ export default class CoreGitGithubGenerator extends Generator {
         },
       });
 
-      configureProtectionRule(owner, repo);
+      configureProtectionRule(owner, repo, this.options.isApp);
     }
   }
 }

package/lib/generators/lib/PobLibGenerator.js

@@ -250,6 +250,7 @@ export default class PobLibGenerator extends Generator {
       codecov: this.pobjson.testing && this.pobjson.testing.codecov,
       ci: this.pobjson.testing && this.pobjson.testing.ci,
       packageManager: this.options.packageManager,
+      isApp: false,
     });
 
     // must be after testing

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -193,6 +193,7 @@ export default class PobMonorepoGenerator extends Generator {
       codecov: this.pobLernaConfig.testing && this.pobLernaConfig.codecov,
       ci: this.pobLernaConfig.ci,
       packageManager: this.options.packageManager,
+      isApp: this.options.isAppProject,
     });
 
     this.composeWith('pob:common:format-lint', {

package/lib/generators/pob/PobBaseGenerator.js

@@ -165,7 +165,9 @@ export default class PobBaseGenerator extends Generator {
     });
 
     if (!this.inLerna) {
-      this.composeWith('pob:core:git');
+      this.composeWith('pob:core:git', {
+        isApp: this.projectConfig.type === 'app',
+      });
     } else {
       if (this.fs.exists('.git-hooks')) this.fs.delete('.git-hooks');
       if (this.fs.exists('git-hooks')) this.fs.delete('git-hooks');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "9.12.1",
+  "version": "9.12.2",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -61,11 +61,11 @@
     "mem-fs-editor": "9.4.0",
     "minimist-argv": "^1.1.0",
     "parse-author": "^2.0.0",
-    "pob-dependencies": "6.6.1",
+    "pob-dependencies": "6.6.2",
     "prettier": "2.5.1",
     "semver": "^7.3.4",
     "yeoman-environment": "^3.5.1",
     "yeoman-generator": "^5.4.0"
   },
-  "gitHead": "9a3b1d4e78444d3be10d8d96e1586294dcab302c"
+  "gitHead": "a24cc6360630314a3ed2ea8fd2cc0c5f02e300ce"
 }