pob 9.1.0 → 9.3.1

package/CHANGELOG.md

@@ -3,6 +3,53 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.3.1](https://github.com/christophehurpeau/pob/compare/pob@9.3.0...pob@9.3.1) (2021-12-11)
+
+**Note:** Version bump only for package pob
+
+
+
+
+
+# [9.3.0](https://github.com/christophehurpeau/pob/compare/pob@9.2.1...pob@9.3.0) (2021-12-11)
+
+
+### Bug Fixes
+
+* **pob:** newline in ci workflow ([78652a1](https://github.com/christophehurpeau/pob/commit/78652a1a412e04ab63fdb5ca7139e86f6e6a3dad))
+
+
+### Features
+
+* **pob:** ci build ([1d1e76b](https://github.com/christophehurpeau/pob/commit/1d1e76b64e81fb08f3c1ea4de26363d162c9a15f))
+* **pob:** typescript dom condition ([eecb027](https://github.com/christophehurpeau/pob/commit/eecb027d4415a20dfcc5612082d9b6ee3ad6a205))
+
+
+
+
+
+## [9.2.1](https://github.com/christophehurpeau/pob/compare/pob@9.2.0...pob@9.2.1) (2021-12-11)
+
+
+### Bug Fixes
+
+* bring back @babel/core as dev dependency ([9aa52ec](https://github.com/christophehurpeau/pob/commit/9aa52ecf895ac28d216e4957028bb8366c278f00))
+
+
+
+
+
+# [9.2.0](https://github.com/christophehurpeau/pob/compare/pob@9.1.0...pob@9.2.0) (2021-12-11)
+
+
+### Features
+
+* **pob:** force global eslint and fix remove plugins on non monorepo ([9c04867](https://github.com/christophehurpeau/pob/commit/9c0486700355e27981f0e1a73d05663a6c1bb16b))
+
+
+
+
+
 # [9.1.0](https://github.com/christophehurpeau/pob/compare/pob@9.0.0...pob@9.1.0) (2021-12-11)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -129,6 +129,7 @@ export default class PobAppGenerator extends Generator {
     this.composeWith('pob:common:typescript', {
       enable: babel,
       builddefs: false,
+      dom: browser,
       jsx,
       updateOnly: this.options.updateOnly,
       baseUrl: (() => {

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -321,7 +321,10 @@ export default class CommonBabelGenerator extends Generator {
 
     /* dependencies */
 
-    packageUtils.addOrRemoveDevDependencies(pkg, useBabel, ['pob-babel']);
+    packageUtils.addOrRemoveDevDependencies(pkg, useBabel, [
+      '@babel/core',
+      'pob-babel',
+    ]);
 
     if (pkg.dependencies && pkg.dependencies['pob-babel']) {
       // update pob-babel in alp-dev
@@ -337,7 +340,6 @@ export default class CommonBabelGenerator extends Generator {
     ]);
 
     packageUtils.removeDevDependencies(pkg, [
-      '@babel/core',
       'rollup',
       'babel-preset-env', // now @babel/preset-env
       'babel-preset-jsdoc',

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -186,11 +186,11 @@ export default class CommonLintGenerator extends Generator {
       inLerna.pobConfig.project &&
       inLerna.pobConfig.project.type;
 
-    if (
-      globalEslint &&
-      !((inLerna && inLerna.root) || this.options.monorepo) &&
-      (rootPackageManager !== 'yarn' || rootYarnNodeLinker === 'node-modules')
-    ) {
+    if (this.options.monorepo && !globalEslint) {
+      throw new Error('Please enable global eslint');
+    }
+
+    if (globalEslint && !((inLerna && inLerna.root) || this.options.monorepo)) {
       packageUtils.removeDevDependencies(
         pkg,
         [
@@ -227,10 +227,7 @@ export default class CommonLintGenerator extends Generator {
         ['eslint'],
       );
       const shouldHavePluginsDependencies =
-        !globalEslint ||
-        !inLerna ||
-        (rootPackageManager === 'yarn' &&
-          rootYarnNodeLinker !== 'node-modules');
+        rootPackageManager === 'yarn' && rootYarnNodeLinker !== 'node-modules';
 
       if (
         !pkg.name.startsWith('eslint-config') &&

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -48,6 +48,7 @@ export default class CommonTestingGenerator extends Generator {
       this.composeWith('pob:core:ci', {
         enable: this.options.ci,
         testing: this.options.testing,
+        build: this.options.typescript,
         typescript: this.options.typescript,
         documentation: this.options.documentation,
         codecov: this.options.codecov,

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -20,6 +20,12 @@ export default class CommonTypescriptGenerator extends Generator {
       desc: 'enable jsx with typescript',
     });
 
+    this.option('dom', {
+      type: Boolean,
+      defaults: true,
+      desc: 'enable dom with typescript',
+    });
+
     this.option('baseUrl', {
       type: String,
       defaults: '',
@@ -57,7 +63,7 @@ export default class CommonTypescriptGenerator extends Generator {
     const tsconfigPath = this.destinationPath('tsconfig.json');
     const tsconfigBuildPath = this.destinationPath('tsconfig.build.json');
     if (this.options.enable) {
-      const { jsx } = this.options;
+      const { jsx, dom } = this.options;
       let composite;
       let monorepoPackageNames;
       let monorepoPackageSrcPaths;
@@ -108,6 +114,7 @@ export default class CommonTypescriptGenerator extends Generator {
           monorepoPackageNames,
           monorepoPackageSrcPaths,
           jsx,
+          dom,
           baseUrl: this.options.baseUrl,
         },
       );

package/lib/generators/common/typescript/templates/tsconfig.json.ejs

@@ -13,7 +13,7 @@
 
     "target": "esnext",                       /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */
     "module": "esnext",                       /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
-    "lib": ["dom", "esnext"],                 /* Polyfills are imported either by babel or with polyfill.io */
+    "lib": [<%- dom ? '"dom", ' : '' %>"esnext"],                 /* Polyfills are imported either by babel or with polyfill.io */
     <%= jsx ? '' : '// ' %>"jsx": "preserve",                     /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */
     "isolatedModules": true,                  /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
 

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -13,6 +13,12 @@ export default class CoreCIGenerator extends Generator {
       desc: 'enable ci',
     });
 
+    this.option('build', {
+      type: Boolean,
+      defaults: true,
+      desc: 'enable build',
+    });
+
     this.option('typescript', {
       type: Boolean,
       defaults: true,
@@ -66,6 +72,7 @@ export default class CoreCIGenerator extends Generator {
           testing: this.options.testing && !!pkg.scripts.test,
           checks: !!pkg.scripts && !!pkg.scripts.checks,
           documentation: this.options.documentation,
+          build: this.options.build,
           typescript: this.options.typescript,
           codecov: this.options.codecov,
         },

package/lib/generators/core/ci/templates/github-action-node-workflow.yml.ejs

@@ -54,6 +54,12 @@ jobs:
       - name: Checks
         run: <%= packageManager %> run checks
 
+<% } -%>
+<% if (build) { -%>
+      - name: Build
+        run: yarn run build
+        if: startsWith(matrix.node-version, '16.')
+
 <% } -%>
       - name: Prettier
         run: <%= packageManager %> run lint:prettier

package/lib/generators/lib/PobLibGenerator.js

@@ -221,9 +221,12 @@ export default class PobLibGenerator extends Generator {
 
     const withBabel = babelEnvs.length > 0;
     const jsx = withBabel && pkg.pob.jsx === true;
+    const browser =
+      withBabel && babelEnvs.some((env) => env.target === 'browser');
 
     this.composeWith('pob:common:typescript', {
       enable: withBabel,
+      dom: browser,
       jsx,
       updateOnly: this.options.updateOnly,
       baseUrl: './src',

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -196,6 +196,7 @@ export default class PobMonorepoGenerator extends Generator {
 
     this.composeWith('pob:core:ci', {
       enable: this.pobLernaConfig.ci,
+      build: this.pobLernaConfig.typescript,
       typescript: this.pobLernaConfig.typescript,
       testing: this.pobLernaConfig.testing,
       codecov: this.pobLernaConfig.codecov,

package/lib/utils/package.js

@@ -80,8 +80,9 @@ const internalRemoveDependencies = (pkg, type, dependencyKeys) => {
   internalRemoveFromObject(pkg, type, dependencyKeys);
 };
 
-const getVersionFromDependencyName = (dependency) =>
-  pobDependencies[dependency];
+const getVersionFromDependencyName = (dependency) => {
+  return pobDependencies[dependency];
+};
 
 const internalAddDependencies = (pkg, type, dependencies, cleaned, prefix) => {
   const ignoreDependencies =

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "9.1.0",
+  "version": "9.3.1",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -63,12 +63,12 @@
     "mem-fs-editor": "8.1.2",
     "minimist-argv": "^1.1.0",
     "parse-author": "^2.0.0",
-    "pob-dependencies": "^6.0.1",
+    "pob-dependencies": "^6.0.5",
     "prettier": "2.5.1",
     "semver": "^7.3.4",
     "update-notifier": "^5.0.1",
     "yeoman-environment": "^3.5.1",
     "yeoman-generator": "^5.4.0"
   },
-  "gitHead": "be649f7d438a93be34f177ee53a339e12bbe8e7b"
+  "gitHead": "af56a72ee2ebe57624d26c15689b9ab54ffe13d0"
 }