pob 40.8.0 → 40.9.0

package/lib/generators/app/PobAppGenerator.js

@@ -8,6 +8,7 @@ import inMonorepo from "../../utils/inMonorepo.js";
 import removeLegacyGeneratedDocs from "../../utils/legacyGeneratedDocs.js";
 import { nodeAppTypes } from "../../utils/nodeApps.js";
 import * as packageUtils from "../../utils/package.js";
+import { getPackageEnvs } from "../../utils/packageEnvs.js";
 import { detectStorybookReactNative } from "../../utils/storybook.js";
 import { appIgnorePaths } from "./ignorePaths.js";
 
@@ -236,7 +237,7 @@ export default class PobAppGenerator extends Generator {
       this.composeWith("pob:common:husky", {});
     }
 
-    const envs = (pkg.pob && (pkg.pob.babelEnvs || pkg.pob.envs)) || [];
+    const envs = getPackageEnvs(pkg.pob) || [];
     const babel =
       envs.length > 0 || appsWithTypescript.includes(this.appConfig.type);
     const typescript = babel || pkg.pob?.typescript;

package/lib/generators/common/e2e/CommonE2eGenerator.js

@@ -20,8 +20,12 @@ export default class CommonE2eGenerator extends Generator {
 
     packageUtils.addOrRemoveDevDependencies(pkg, this.options.enable, [
       "@playwright/test",
-      "playwright",
     ]);
+    packageUtils.addOrRemoveDevDependencies(
+      pkg,
+      this.options.enable || packageUtils.hasVitestBrowserPlaywright(pkg),
+      ["playwright"],
+    );
 
     packageUtils.addOrRemoveScripts(pkg, this.options.enable, {
       // keeps the browsers added by hand, like webkit for iPhone projects

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -112,6 +112,20 @@ export default class CommonTestingGenerator extends Generator {
       description:
         "Disable git cache. See https://yarnpkg.com/features/caching#offline-mirror.",
     });
+
+    this.option("playwrightBrowserTestingPath", {
+      type: String,
+      default: "",
+      description:
+        "path of a package running vitest browser tests, to install playwright browsers in ci",
+    });
+
+    this.option("mongodbBinaryCacheKeyFile", {
+      type: String,
+      default: "",
+      description:
+        "file pinning the mongodb-memory-server binary version, to cache the binary in ci",
+    });
   }
 
   prompting() {
@@ -139,6 +153,8 @@ export default class CommonTestingGenerator extends Generator {
         isApp: this.options.isApp,
         splitJobs: this.options.splitCIJobs,
         onlyLatestLTS: this.options.onlyLatestLTS,
+        playwrightBrowserTestingPath: this.options.playwrightBrowserTestingPath,
+        mongodbBinaryCacheKeyFile: this.options.mongodbBinaryCacheKeyFile,
       });
     } else {
       this.composeWith("pob:core:ci", {
@@ -222,11 +238,13 @@ export default class CommonTestingGenerator extends Generator {
       },
     );
 
+    const withVitestBrowser = packageUtils.hasVitestBrowserPlaywright(pkg);
+
     if (!this.options.enable || (globalTesting && !enableForMonorepo)) {
       packageUtils.removeDevDependencies(pkg, [
         "jest",
         "@types/jest",
-        "vitest",
+        ...(withVitestBrowser ? [] : ["vitest"]),
         "@vitest/coverage-v8",
       ]);
 
@@ -321,11 +339,15 @@ export default class CommonTestingGenerator extends Generator {
       this.options.enable &&
       (enableForMonorepo || !globalTesting) &&
       testRunner === "vitest";
+    packageUtils.addOrRemoveDevDependencies(
+      pkg,
+      isVitestUsed || withVitestBrowser,
+      ["vitest"],
+    );
     packageUtils.addOrRemoveDevDependencies(pkg, isVitestUsed, [
-      "vitest",
       "@vitest/coverage-v8",
     ]);
-    if (isVitestUsed) {
+    if (isVitestUsed || withVitestBrowser) {
       packageUtils.addDevDependencies(pkg, ["vite"]);
     }
 

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -2,6 +2,7 @@ import fs from "node:fs";
 import Generator from "yeoman-generator";
 import { latestLTS, maintenanceLTS } from "../../../utils/nodeVersions.js";
 import * as packageUtils from "../../../utils/package.js";
+import { getEntryEnvs, getPackageEnvs } from "../../../utils/packageEnvs.js";
 import { packageManagerRun } from "../../../utils/packageManagerUtils.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
 
@@ -341,17 +342,15 @@ export default class CommonTranspilerGenerator extends Generator {
 
     let envs = pkg.pob.babelEnvs || pkg.pob.envs;
 
-    const envsWithDefault =
-      pkg.pob.bundler === false
-        ? []
-        : envs || [
-            {
-              target: "node",
-              version: "22",
-            },
-          ];
+    const getEntryEnvsWithDefault = (entry) =>
+      pkg.pob.bundler === false ? [] : getEntryEnvs(entry, envs);
+
+    const indexEntry =
+      (pkg.pob.entries ?? ["index"]).find(
+        (entry) => (typeof entry === "string" ? entry : entry.name) === "index",
+      ) ?? "index";
 
-    const esAllBrowserEnv = envsWithDefault.find(
+    const esAllBrowserEnv = getEntryEnvsWithDefault(indexEntry).find(
       (env) =>
         env.target === "browser" &&
         env.version === undefined &&
@@ -403,15 +402,17 @@ export default class CommonTranspilerGenerator extends Generator {
               : `./${this.options.buildDirectory}/definitions/${entryDistName}.d.ts`,
         };
 
+        const entryEnvs = getEntryEnvsWithDefault(entryWithOptionalExt);
+
         const defaultNodeEnv =
           withBabel || (withTypescript && pkg.pob?.typescript !== "check-only")
-            ? envsWithDefault.find((env) => env.target === "node")
+            ? entryEnvs.find((env) => env.target === "node")
             : undefined;
 
         const defaultNodeEnvVersion = defaultNodeEnv && defaultNodeEnv.version;
 
-        if (envsWithDefault) {
-          envsWithDefault.forEach(
+        if (entryEnvs) {
+          entryEnvs.forEach(
             ({
               target,
               version,
@@ -656,7 +657,7 @@ export default class CommonTranspilerGenerator extends Generator {
   async writing() {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const entries = pkg.pob.entries || ["index"];
-    const envs = pkg.pob.envs || pkg.pob.babelEnvs;
+    const envs = getPackageEnvs(pkg.pob);
 
     const hasTargetBrowser =
       envs && envs.some((env) => env.target === "browser");

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -7,6 +7,7 @@ import {
 import inMonorepo from "../../../utils/inMonorepo.js";
 import { latestLTS, maintenanceLTS } from "../../../utils/nodeVersions.js";
 import * as packageUtils from "../../../utils/package.js";
+import { getPackageEnvs } from "../../../utils/packageEnvs.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
 
 export default class CommonTypescriptGenerator extends Generator {
@@ -169,7 +170,7 @@ export default class CommonTypescriptGenerator extends Generator {
     }
 
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
-    const envs = pkg.pob?.envs || [
+    const envs = getPackageEnvs(pkg.pob) || [
       {
         target: "node",
         version: `${maintenanceLTS}`,
@@ -421,6 +422,14 @@ export default class CommonTypescriptGenerator extends Generator {
             ...(this.options.storybook
               ? [".storybook/*.ts", ".storybook/*.tsx"]
               : []),
+            // the web storybook rendered by vitest browser tests
+            ...(existsSync(this.destinationPath(".storybook-web"))
+              ? [".storybook-web/*.ts", ".storybook-web/*.tsx"]
+              : []),
+            // generated by react-native-css: types the className props
+            ...(existsSync(this.destinationPath("nativewind-env.d.ts"))
+              ? ["nativewind-env.d.ts"]
+              : []),
           ],
           node: withNode,
           presets,

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -4,6 +4,7 @@ import inMonorepo from "../../../utils/inMonorepo.js";
 import { latestLTS, maintenanceLTS } from "../../../utils/nodeVersions.js";
 import {
   packageManagerExec,
+  packageManagerExecWithCwd,
   packageManagerRun,
 } from "../../../utils/packageManagerUtils.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
@@ -104,6 +105,20 @@ export default class CoreCIGenerator extends Generator {
       description:
         "Disable git cache. See https://yarnpkg.com/features/caching#offline-mirror.",
     });
+
+    this.option("playwrightBrowserTestingPath", {
+      type: String,
+      default: "",
+      description:
+        "path of a package running vitest browser tests, to install playwright browsers",
+    });
+
+    this.option("mongodbBinaryCacheKeyFile", {
+      type: String,
+      default: "",
+      description:
+        "file pinning the mongodb-memory-server binary version, to cache the binary",
+    });
   }
 
   async default() {
@@ -155,6 +170,15 @@ export default class CoreCIGenerator extends Generator {
               inMonorepo.pobConfig?.project?.type === "lib",
             nodeLatestMajorVersion: latestLTS,
             nodeMaintenanceMajorVersion: maintenanceLTS,
+            installPlaywrightBrowserCommand: this.options
+              .playwrightBrowserTestingPath
+              ? packageManagerExecWithCwd(
+                  this.options.packageManager,
+                  this.options.playwrightBrowserTestingPath,
+                  "playwright install --with-deps chromium",
+                )
+              : "",
+            mongodbBinaryCacheKeyFile: this.options.mongodbBinaryCacheKeyFile,
             packageManagerRun: (script, packagePath) => {
               return packageManagerRun(
                 this.options.packageManager,

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -202,6 +202,19 @@ jobs:
       - name: Build
         run: <%= packageManagerRun("build") %>
 <% } -%>
+<% if (installPlaywrightBrowserCommand) { -%>
+
+      - name: Install Playwright chromium
+        run: <%- installPlaywrightBrowserCommand %>
+<% } -%>
+<% if (mongodbBinaryCacheKeyFile) { -%>
+
+      - name: Cache mongod binary
+        uses: actions/cache@v6
+        with:
+          path: ~/.cache/mongodb-binaries
+          key: mongod-${{ runner.os }}-${{ hashFiles('<%= mongodbBinaryCacheKeyFile %>') }}
+<% } -%>
 
 <% if (codecov) { -%>
       - name: Test

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -88,6 +88,19 @@ jobs:
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
         run: <%= packageManagerExec('repository-check-dirty') %>
 <% } -%>
+<% if ((codecov || testing) && installPlaywrightBrowserCommand) { -%>
+
+      - name: Install Playwright chromium
+        run: <%- installPlaywrightBrowserCommand %>
+<% } -%>
+<% if ((codecov || testing) && mongodbBinaryCacheKeyFile) { -%>
+
+      - name: Cache mongod binary
+        uses: actions/cache@v6
+        with:
+          path: ~/.cache/mongodb-binaries
+          key: mongod-${{ runner.os }}-${{ hashFiles('<%= mongodbBinaryCacheKeyFile %>') }}
+<% } -%>
 <% if (codecov) { -%>
 
       - name: Generate Test Coverage

package/lib/generators/core/npm/CoreNpmGenerator.js

@@ -79,7 +79,11 @@ export default class CoreNpmGenerator extends Generator {
           });
         }
 
-        pkg.files = [...files].filter(Boolean);
+        const exclusions = (pkg.files ?? []).filter((file) =>
+          file.startsWith("!"),
+        );
+
+        pkg.files = [...files, ...exclusions].filter(Boolean);
       }
     } else {
       delete pkg.files;

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -23,6 +23,7 @@ import {
   buildTopologicalOrderBatches,
   discoverWorkspaces,
   getWorkspaceName,
+  isMonorepoPublishable,
 } from "../../utils/workspaceUtils.js";
 import { copyAndFormatTpl } from "../../utils/writeAndFormat.js";
 
@@ -266,6 +267,11 @@ export default class PobMonorepoGenerator extends Generator {
           : detectStorybookReactNative(allPackages),
       },
     ]);
+    // set by hand in .yo-rc.json, never prompted
+    if (storedConfig?.mongodbBinaryCacheKeyFile) {
+      this.pobMonorepoConfig.mongodbBinaryCacheKeyFile =
+        storedConfig.mongodbBinaryCacheKeyFile;
+    }
     this.pobMonorepoConfig.packageNames = this.packageNames;
     this.config.set("monorepo", this.pobMonorepoConfig);
     this.config.delete("pob-config");
@@ -334,6 +340,12 @@ export default class PobMonorepoGenerator extends Generator {
       isApp: this.options.isAppProject,
       onlyLatestLTS: this.options.onlyLatestLTS,
       splitCIJobs,
+      playwrightBrowserTestingPath:
+        this.packageLocations.find((location, index) =>
+          packageUtils.hasVitestBrowserPlaywright(this.packages[index]),
+        ) ?? "",
+      mongodbBinaryCacheKeyFile:
+        this.pobMonorepoConfig.mongodbBinaryCacheKeyFile ?? "",
     });
 
     const e2eTestingPath = e2eTesting === "." ? "" : `/${e2eTesting}`;
@@ -420,7 +432,10 @@ export default class PobMonorepoGenerator extends Generator {
     this.composeWith("pob:common:release", {
       enable: true,
       packageManager: this.options.packageManager,
-      enablePublish: !this.options.isAppProject,
+      enablePublish: isMonorepoPublishable({
+        isAppProject: this.options.isAppProject,
+        packages: this.packages,
+      }),
       build: hasRootBuild,
       isMonorepo: true,
       ci: this.pobMonorepoConfig.ci,

package/lib/utils/package.js

@@ -19,6 +19,15 @@ export const hasReact = (pkg) =>
     (pkg.peerDependencies && pkg.peerDependencies.react)
   );
 
+/**
+ * A package running vitest browser tests (a storybook rendered in a browser)
+ * declares vitest and playwright itself, whatever the test runner of the root.
+ */
+export const hasVitestBrowserPlaywright = (pkg) =>
+  [pkg.dependencies, pkg.devDependencies].some(
+    (dependencies) => dependencies?.["@vitest/browser-playwright"],
+  );
+
 export const sort = function sort(pkg) {
   return sortPkg(pkg);
 };

package/lib/utils/packageEnvs.js

@@ -0,0 +1,28 @@
+const defaultEnvs = [{ target: "node", version: "22" }];
+
+/**
+ * The envs an entry is built for, resolved like @pob/rollup-esbuild does: the
+ * entry's own envs, else the package envs, else node.
+ */
+export const getEntryEnvs = (entry, packageEnvs) =>
+  (typeof entry === "object" && entry.envs) || packageEnvs || defaultEnvs;
+
+const envKey = (env) =>
+  JSON.stringify([env.target, env.version ?? null, env.formats ?? null]);
+
+/**
+ * The envs a package is built for: its envs, or the union of the envs of its
+ * entries when only the entries declare them. Undefined when none is declared.
+ */
+export const getPackageEnvs = (pob) => {
+  if (!pob) return undefined;
+  if (pob.babelEnvs || pob.envs) return pob.babelEnvs || pob.envs;
+
+  const entriesEnvs = (pob.entries ?? []).flatMap((entry) =>
+    typeof entry === "object" && entry.envs ? entry.envs : [],
+  );
+  if (entriesEnvs.length === 0) return undefined;
+
+  const envsByKey = new Map(entriesEnvs.map((env) => [envKey(env), env]));
+  return [...envsByKey.values()];
+};

package/lib/utils/packageEnvs.test.js

@@ -0,0 +1,48 @@
+import { describe, expect, it } from "vitest";
+import { getEntryEnvs, getPackageEnvs } from "./packageEnvs.js";
+
+const node24 = { target: "node", version: "24", omitVersionInFileName: true };
+const browser = { target: "browser" };
+
+describe("getEntryEnvs", () => {
+  it("uses the envs of the entry", () => {
+    expect(getEntryEnvs({ name: "git", envs: [node24] }, [browser])).toEqual([
+      node24,
+    ]);
+  });
+
+  it("falls back to the envs of the package", () => {
+    expect(getEntryEnvs("index", [browser])).toEqual([browser]);
+    expect(getEntryEnvs({ name: "index" }, [browser])).toEqual([browser]);
+  });
+
+  it("falls back to node", () => {
+    expect(getEntryEnvs("index", undefined)).toEqual([
+      { target: "node", version: "22" },
+    ]);
+  });
+});
+
+describe("getPackageEnvs", () => {
+  it("returns the envs of the package", () => {
+    expect(getPackageEnvs({ envs: [node24], entries: ["index"] })).toEqual([
+      node24,
+    ]);
+  });
+
+  it("returns the union of the envs of the entries", () => {
+    expect(
+      getPackageEnvs({
+        entries: [
+          { name: "index", envs: [node24, browser] },
+          { name: "git", envs: [node24] },
+        ],
+      }),
+    ).toEqual([node24, browser]);
+  });
+
+  it("returns undefined when no env is declared", () => {
+    expect(getPackageEnvs({ entries: ["index"] })).toBeUndefined();
+    expect(getPackageEnvs(undefined)).toBeUndefined();
+  });
+});

package/lib/utils/workspaceUtils.js

@@ -25,6 +25,13 @@ export const getWorkspaceName = (workspace) => {
 export const getNewPackagePath = (workspaces, packageName) =>
   `${workspaces[0].replace(/\/\*$/, "")}/${packageName.replace(/^@[^/]+\//, "")}`;
 
+/**
+ * A monorepo publishes to npm when it is not an app, or when an app monorepo
+ * has public workspaces, such as a cli shipped for npx.
+ */
+export const isMonorepoPublishable = ({ isAppProject, packages }) =>
+  !isAppProject || packages.some((pkg) => !pkg.private);
+
 export const discoverWorkspaces = async (rootPath) => {
   const rootPackageJSONPath = path.join(rootPath, "package.json");
   if (!fs.existsSync(rootPackageJSONPath)) {

package/lib/utils/workspaceUtils.test.js

@@ -7,8 +7,41 @@ import {
   buildTopologicalOrderBatches,
   discoverWorkspaces,
   getNewPackagePath,
+  isMonorepoPublishable,
 } from "./workspaceUtils.js";
 
+describe("isMonorepoPublishable", () => {
+  it("publishes a lib monorepo", () => {
+    expect(
+      isMonorepoPublishable({
+        isAppProject: false,
+        packages: [{ name: "a", private: true }],
+      }),
+    ).toBe(true);
+  });
+
+  it("publishes an app monorepo with a public workspace", () => {
+    expect(
+      isMonorepoPublishable({
+        isAppProject: true,
+        packages: [{ name: "server", private: true }, { name: "cli" }],
+      }),
+    ).toBe(true);
+  });
+
+  it("does not publish an app monorepo whose workspaces are all private", () => {
+    expect(
+      isMonorepoPublishable({
+        isAppProject: true,
+        packages: [
+          { name: "server", private: true },
+          { name: "web", private: true },
+        ],
+      }),
+    ).toBe(false);
+  });
+});
+
 describe("getNewPackagePath", () => {
   it("creates a scoped package in the workspaces directory", () => {
     expect(getNewPackagePath(["packages/*"], "@scope/foo")).toBe(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "40.8.0",
+  "version": "40.9.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/vitest",
   "keywords": [
     "skeleton"
@@ -31,11 +31,11 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@pob/codemods": "0.18.3",
-    "@pob/eslint-config": "68.4.0",
-    "@pob/eslint-config-typescript-react": "68.5.0",
-    "@pob/sort-object": "11.3.1",
-    "@pob/sort-pkg": "13.3.1",
+    "@pob/codemods": "0.19.0",
+    "@pob/eslint-config": "68.5.0",
+    "@pob/eslint-config-typescript-react": "68.6.0",
+    "@pob/sort-object": "11.4.0",
+    "@pob/sort-pkg": "13.4.0",
     "@yeoman/adapter": "5.1.1",
     "eslint": "10.14.0",
     "findup-sync": "^5.0.0",
@@ -48,21 +48,21 @@
     "mem-fs": "6.0.0",
     "mem-fs-editor": "12.1.0",
     "minimist": "1.2.8",
-    "oxfmt": "0.75.0",
+    "oxfmt": "0.78.0",
     "parse-author": "2.0.0",
-    "pob-dependencies": "28.7.0",
-    "semver": "7.8.5",
+    "pob-dependencies": "28.8.0",
+    "semver": "7.8.6",
     "typescript": "npm:@typescript/typescript6@6.0.2",
     "validate-npm-package-name": "^8.0.0",
     "yeoman-environment": "8.5.1",
     "yeoman-generator": "10.3.0"
   },
   "devDependencies": {
-    "@pob/root": "28.7.0",
+    "@pob/root": "28.8.0",
     "@types/node": "24.19.1",
     "@typescript/native": "npm:typescript@7.0.2",
     "@yeoman/types": "1.13.1",
-    "tsrs": "0.20.1-ts7.1.0-beta"
+    "tsrs": "0.24.0-ts7.1.0-beta"
   },
   "engines": {
     "node": "^24.22.1 || >=26.13.0"