pob 38.5.0 → 38.7.0

package/lib/generators/app/PobAppGenerator.js

@@ -1,7 +1,9 @@
 import { execSync } from "node:child_process";
 import { platform } from "node:process";
 import Generator from "yeoman-generator";
+import { removeFromGitIndex } from "../../utils/git.js";
 import inMonorepo from "../../utils/inMonorepo.js";
+import removeLegacyGeneratedDocs from "../../utils/legacyGeneratedDocs.js";
 import * as packageUtils from "../../utils/package.js";
 import { appIgnorePaths } from "./ignorePaths.js";
 
@@ -172,6 +174,7 @@ export default class PobAppGenerator extends Generator {
     }
 
     const buildDirectory = this.appConfig.distribute ? "dist" : "build";
+    this.buildDirectory = buildDirectory;
     const isAppLibrary =
       this.appConfig.type === "node-library" ||
       this.appConfig.type === "untranspiled-library";
@@ -332,7 +335,7 @@ export default class PobAppGenerator extends Generator {
         this.appConfig.testing &&
         pkg.name !== "yarn-plugin-conventional-version",
       enablePublish: false,
-      withBabel: babel,
+      build: typescript === true && this.appConfig.type !== "expo",
       isMonorepo: false,
       ci: this.options.ci,
       disableYarnGitCache: this.options.disableYarnGitCache,
@@ -361,7 +364,6 @@ export default class PobAppGenerator extends Generator {
       testing: this.appConfig.testing,
       withBabel: babel,
       paths: ignorePaths.join("\n"),
-      buildInGit: false,
       buildDirectory,
     });
 
@@ -395,9 +397,11 @@ export default class PobAppGenerator extends Generator {
 
     if (platform !== "win32") {
       execSync(
-        `rm -Rf ${["lib-*", "coverage", "docs", "dist"].filter(Boolean).join(" ")}`,
+        `rm -Rf ${["lib-*", "coverage", "generated-docs", "dist"].filter(Boolean).join(" ")}`,
       );
     }
+
+    removeLegacyGeneratedDocs((path) => this.destinationPath(path));
   }
 
   writing() {
@@ -436,6 +440,20 @@ export default class PobAppGenerator extends Generator {
 
     this.fs.writeJSON(this.destinationPath("package.json"), pkg);
 
+    this.composeWith("pob:core:node", {
+      // only apps using pob:common:transpiler target latest LTS in engines
+      onlyLatestLTS:
+        this.appConfig.type === "node" ||
+        this.appConfig.type === "node-library" ||
+        this.appConfig.type === "alp-node",
+    });
     this.composeWith("pob:core:sort-package");
   }
+
+  end() {
+    // the build output is no longer committed: remove it from git, keeping it on disk.
+    if (this.buildDirectory) {
+      removeFromGitIndex(this.destinationPath(), this.buildDirectory);
+    }
+  }
 }

package/lib/generators/app/ignorePaths.js

@@ -12,7 +12,10 @@ export const appIgnorePaths = {
     ].filter(Boolean),
   vite: (config) => ["/dist"],
   "vite-with-server": (config) => ["/dist"],
-  node: (config) => (config.distribute ? [] : ["/build"]),
+  node: (config) => {
+    if (!config.distribute) return ["/build"];
+    return config.buildInGit ? [] : ["/dist"];
+  },
   "node-library": (config) => ["/build"],
   "untranspiled-library": (config) => [],
   "alp-node": (config) => ["/build"],

package/lib/generators/common/e2e/CommonE2eGenerator.js

@@ -25,7 +25,7 @@ export default class CommonE2eGenerator extends Generator {
 
     packageUtils.addOrRemoveScripts(pkg, this.options.enable, {
       "test:e2e:prepare": "playwright install chromium",
-      "test:e2e": "playwright test",
+      "test:e2e": "playwright test -c e2e/playwright.config.ts",
     });
 
     return writeAndFormatJson(

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -4,12 +4,27 @@ import { quoteArg } from "../../../utils/execUtils.js";
 import inMonorepo from "../../../utils/inMonorepo.js";
 import * as packageUtils from "../../../utils/package.js";
 import {
+  packageManagerExecWithCwd,
   packageManagerRun,
-  packageManagerRunWithCwd,
 } from "../../../utils/packageManagerUtils.js";
-import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
+import {
+  copyAndFormatTpl,
+  writeAndFormatJson,
+} from "../../../utils/writeAndFormat.js";
 import { appIgnorePaths } from "../../app/ignorePaths.js";
 
+// same as the base ignores of @pob/eslint-config: ignorePatterns are not
+// inherited through "extends"
+const oxlintBaseIgnorePatterns = [
+  ".yarn",
+  "**/dist/",
+  "**/build/",
+  "**/coverage/",
+  "**/.next/",
+  "**/.tamagui/",
+  "**/*.d.ts",
+];
+
 export default class CommonFormatLintGenerator extends Generator {
   constructor(args, opts) {
     super(args, opts);
@@ -148,6 +163,7 @@ export default class CommonFormatLintGenerator extends Generator {
         : babelEnvs.length > 0;
     const useTypescript = this.options.typescript;
     const hasReact = useTypescript && packageUtils.hasReact(pkg);
+    const useAppConfig = hasReact && this.options.isApp;
     const useNode = !useBabel || babelEnvs.some((env) => env.target === "node");
     const useNodeOnly =
       (!useBabel && !useTypescript) ||
@@ -399,7 +415,7 @@ export default class CommonFormatLintGenerator extends Generator {
 
           return [
             useNode ? "...pobConfig.configs.node" : "...pobConfig.configs.base",
-            this.options.isApp && "...pobConfig.configs.app",
+            useAppConfig && "...pobConfig.configs.app",
             pkg.dependencies?.["react-native-web"] &&
               '...pobTypescriptConfigReact.configs["react-native-web"]',
           ];
@@ -446,6 +462,8 @@ export default class CommonFormatLintGenerator extends Generator {
     );
     this.fs.delete(invalidEslintConfigPath);
 
+    const oxlintConfigPath = this.destinationPath(".oxlintrc.json");
+
     if (!inMonorepo || inMonorepo.root) {
       const rootIgnorePaths = this.options.rootIgnorePaths
         .split("\n")
@@ -453,12 +471,8 @@ export default class CommonFormatLintGenerator extends Generator {
       const getRootIgnorePatterns = () => {
         const ignorePatterns = new Set();
 
-        if (useTypescript) {
-          ignorePatterns.add("*.d.ts");
-        }
-
         if (inMonorepo && inMonorepo.root && this.options.documentation) {
-          ignorePatterns.add("/docs");
+          ignorePatterns.add("/generated-docs");
         }
 
         if ((!inMonorepo || !inMonorepo.root) && useTypescript) {
@@ -514,8 +528,49 @@ export default class CommonFormatLintGenerator extends Generator {
             },
             */
       }
+
+      // keeps existing options, only enforces the shared config and ignores.
+      // ignorePatterns are fully owned by the generator: merging with existing
+      // ones would never remove stale patterns
+      const oxlintConfig = this.fs.readJSON(oxlintConfigPath, {});
+      const oxlintExtends = oxlintConfig.extends || [];
+      const pobOxlintConfigPath = (name) =>
+        `./node_modules/@pob/eslint-config/oxlint/${name}.json`;
+      await writeAndFormatJson(this.fs, oxlintConfigPath, {
+        ...oxlintConfig,
+        extends: [
+          pobOxlintConfigPath("base"),
+          // type-aware rules: oxlint fails without tsgolint, even in a
+          // project without TypeScript files
+          useTypescript && pobOxlintConfigPath("typescript"),
+          // overrides of typescript.json, like the matching eslint configs
+          // (configs.app, configs.allowUnsafe, ...). Only app is known here:
+          // the others are kept when added by hand.
+          ...(useTypescript
+            ? [
+                "app",
+                "allow-implicit-return-type",
+                "allow-unsafe",
+                "allow-unsafe-as-warn",
+              ]
+                .filter(
+                  (name) =>
+                    (name === "app" && useAppConfig) ||
+                    oxlintExtends.includes(pobOxlintConfigPath(name)),
+                )
+                .map(pobOxlintConfigPath)
+            : []),
+          ...oxlintExtends.filter(
+            (value) => !value.includes("@pob/eslint-config/"),
+          ),
+        ].filter(Boolean),
+        ignorePatterns: [
+          ...new Set([...oxlintBaseIgnorePatterns, ...ignorePatterns]),
+        ],
+      });
     } else {
       this.fs.delete(eslintConfigPath);
+      this.fs.delete(oxlintConfigPath);
     }
 
     // see monorepo/lerna/index.js
@@ -524,9 +579,12 @@ export default class CommonFormatLintGenerator extends Generator {
 
       packageUtils.addScripts(pkg, {
         "lint:eslint": globalEslint
-          ? `${packageManagerRunWithCwd(this.options.packageManager, "../..", "eslint")} ${args} ${quoteArg(path.relative("../..", "."))}`
+          ? `${packageManagerExecWithCwd(this.options.packageManager, "../..", "eslint")} ${args} ${quoteArg(path.relative("../..", "."))}`
           : `eslint ${args} .`,
-        lint: `${
+        "lint:oxlint": globalEslint
+          ? `${packageManagerExecWithCwd(this.options.packageManager, "../..", "oxlint")} ${args} ${quoteArg(path.relative("../..", "."))}`
+          : `oxlint ${args}`,
+        lint: `${packageManagerRun(this.options.packageManager, "lint:oxlint")} && ${
           useTypescript && !composite ? "tsc && " : ""
         }${packageManagerRun(this.options.packageManager, "lint:eslint")}`,
       });

package/lib/generators/common/format-lint/templates/oxfmtrc.jsonc.ejs

@@ -4,7 +4,7 @@
   "sortPackageJson": { "sortScripts": true },
   "ignorePatterns": [
 <% if (documentation) { -%>
-    "/docs",
+    "/generated-docs",
 <% } -%>
 <% if (packageManager === 'yarn' && inRoot) { -%>
     "/.yarnrc.yml",

package/lib/generators/common/release/CommonReleaseGenerator.js

@@ -23,19 +23,13 @@ export default class CommonReleaseGenerator extends Generator {
       description: "If publish on npm is enabled",
     });
 
-    this.option("withBabel", {
+    this.option("build", {
       type: Boolean,
-      required: false,
-      default: undefined,
-      description: "Babel enabled.",
+      required: true,
+      description:
+        "If there is a build script. The build output is not necessarily committed, it must be built before publishing.",
     });
 
-    this.option("withTypescript", {
-      type: Boolean,
-      required: false,
-      default: undefined,
-      description: "Typescript enabled.",
-    });
     this.option("isMonorepo", {
       type: Boolean,
       default: false,
@@ -82,6 +76,7 @@ export default class CommonReleaseGenerator extends Generator {
         {
           packageManager: this.options.packageManager,
           enablePublish: this.options.enablePublish,
+          build: this.options.build,
           disableYarnGitCache: this.options.disableYarnGitCache,
           isMonorepo: this.options.isMonorepo,
           isMonorepoIndependent:
@@ -89,6 +84,7 @@ export default class CommonReleaseGenerator extends Generator {
             (!pkg.version || pkg.version === "0.0.0"),
           nodeLatestMajorVersion: latestLTS,
           packageManagerExec,
+          packageManagerRun,
         },
       );
     } else {
@@ -110,9 +106,8 @@ export default class CommonReleaseGenerator extends Generator {
       packageUtils.addScripts(pkg, {
         preversion: [
           packageManagerRun(this.options.packageManager, "lint"),
-          this.options.withBabel ||
-            (this.options.withTypescript &&
-              packageManagerRun(this.options.packageManager, "build")),
+          this.options.build &&
+            packageManagerRun(this.options.packageManager, "build"),
           "repository-check-dirty",
         ]
           .filter(Boolean)

package/lib/generators/common/release/templates/workflow-release.yml.ejs

@@ -83,6 +83,11 @@ jobs:
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile
 <% } -%>
+<% if (build) { -%>
+
+      - name: Build
+        run: <%= packageManagerRun(packageManager, 'build') %>
+<% } -%>
 
       - name: New version (dry run)
         if: github.ref == 'refs/heads/main' && inputs.dry-run

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -267,7 +267,7 @@ export default class CommonTestingGenerator extends Generator {
           const experimentalTestCoverage = true;
           return [
             experimentalTestCoverage && coverage === "generate"
-              ? "mkdir -p docs && "
+              ? "mkdir -p generated-docs && "
               : "",
             `TZ=UTC ${
               coverage && !experimentalTestCoverage
@@ -281,7 +281,7 @@ export default class CommonTestingGenerator extends Generator {
               this.options.typescript
                 ? `${tsTestLoaderOption ? `${tsTestLoaderOption} ` : ""}`
                 : ""
-            }${this.fs.exists("src/test-setup.ts") ? "--import ./src/test-setup.ts " : ""}--test${experimentalTestCoverage && coverage ? ` --experimental-test-coverage${coverage === "generate" ? " --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=docs/coverage.lcov" : ""} --test-coverage-include="${this.options.srcDirectory}/**/*.ts"` : ""} '${this.options.monorepo ? `${workspacesPattern}/*/` : ""}${`${
+            }${this.fs.exists("src/test-setup.ts") ? "--import ./src/test-setup.ts " : ""}--test${experimentalTestCoverage && coverage ? ` --experimental-test-coverage${coverage === "generate" ? " --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=generated-docs/coverage.lcov" : ""} --test-coverage-include="${this.options.srcDirectory}/**/*.ts"` : ""} '${this.options.monorepo ? `${workspacesPattern}/*/` : ""}${`${
               hasTestFolder
                 ? "test/*"
                 : `${this.options.srcDirectory}/**/*.test`

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -1,5 +1,4 @@
 import fs from "node:fs";
-import semver from "semver";
 import Generator from "yeoman-generator";
 import { latestLTS, maintenanceLTS } from "../../../utils/nodeVersions.js";
 import * as packageUtils from "../../../utils/package.js";
@@ -285,9 +284,6 @@ export default class CommonTranspilerGenerator extends Generator {
       ["alp-rollup-plugin-config"],
     );
 
-    /* engines */
-    // TODO move from CommonBabelGenerator
-
     /* side effects */
 
     if (this.options.isApp && !this.options.isAppLibrary) {
@@ -660,86 +656,10 @@ export default class CommonTranspilerGenerator extends Generator {
     const entries = pkg.pob.entries || ["index"];
     const envs = pkg.pob.envs || pkg.pob.babelEnvs;
 
-    const hasTargetNode = envs && envs.some((env) => env.target === "node");
     const hasTargetBrowser =
       envs && envs.some((env) => env.target === "browser");
 
-    if (!pkg.engines) pkg.engines = {};
-
-    if (hasTargetNode || !envs) {
-      const minNodeVersion = envs
-        ? Math.min(
-            ...envs
-              .filter((env) => env.target === "node")
-              .map((env) => env.version),
-          )
-        : (() =>
-            this.options.onlyLatestLTS
-              ? `${latestLTS}`
-              : `${maintenanceLTS}`)();
-
-      switch (String(minNodeVersion)) {
-        case "4":
-        case "6":
-        case "8":
-        case "10":
-        case "12":
-        case "14":
-        case "16":
-        case "18":
-        case "20":
-        case "22":
-          if (
-            envs ||
-            !pkg.engines.node ||
-            !pkg.engines.node.startsWith(">=24")
-          ) {
-            pkg.engines.node = ">=22.18.0";
-          }
-          break;
-        case "24":
-          if (
-            envs ||
-            !pkg.engines.node ||
-            !pkg.engines.node.startsWith(">=26")
-          ) {
-            pkg.engines.node = ">=24.14.1";
-          }
-          break;
-        case "26":
-          pkg.engines.node = ">=26.0.0";
-          break;
-        default:
-          throw new Error(`Invalid min node version: ${minNodeVersion}`);
-      }
-
-      if (pkg.dependencies && pkg.dependencies["@types/node"]) {
-        pkg.dependencies["@types/node"] = `>=${minNodeVersion}.0.0`;
-      }
-      if (
-        pkg.devDependencies &&
-        pkg.devDependencies["@types/node"] &&
-        !semver.satisfies(
-          pkg.devDependencies["@types/node"],
-          `>=${minNodeVersion}.0.0`,
-        )
-      ) {
-        pkg.devDependencies["@types/node"] = `>=${minNodeVersion}.0.0`;
-      }
-    } else {
-      packageUtils.removeDependencies(pkg, ["@types/node"]);
-      packageUtils.removeDevDependencies(pkg, ["@types/node"]);
-
-      // Supports oldest current or active LTS version of node
-      const minVersion = this.options.onlyLatestLTS ? "24.14.1" : "22.18.0";
-
-      if (
-        !pkg.engines.node ||
-        semver.lt(semver.minVersion(pkg.engines.node), minVersion)
-      ) {
-        pkg.engines.node = `>=${minVersion}`;
-      }
-    }
+    // engines.node and @types/node are handled by pob:core:node
 
     this.fs.delete("rollup.config.js");
     if (

package/lib/generators/common/typescript/templates/tsconfig.tools.json.ejs

@@ -8,6 +8,7 @@
     "scripts/**/*.ts",
     "scripts/**/*.mts",
     "scripts/**/*.cts",
+    "*.config.js",
     "*.config.ts",
     "*.config.mts",
     "*.config.cts"

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -200,16 +200,10 @@ export default class CoreCIGenerator extends Generator {
         this.destinationPath(".github/workflows/gh-pages.yml"),
         {
           packageManager: this.options.packageManager,
-          packageManagerRun: (script, packagePath) => {
-            return packageManagerRun(
-              this.options.packageManager,
-              "docs:build",
-              packagePath,
-            );
-          },
           disableYarnGitCache: this.options.disableYarnGitCache,
           testing: this.options.testing,
           testRunner: this.options.testRunner,
+          build: this.options.build,
           typedoc: this.options.documentation && this.options.typescript,
           nodeLatestMajorVersion: latestLTS,
         },

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -45,6 +45,11 @@ jobs:
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile
 <% } -%>
+<% if (build) { -%>
+
+      - name: Build
+        run: <%= packageManager %> run build
+<% } -%>
 
 <% if (typedoc) { -%>
       - name: Run tsc for tsc cache
@@ -55,10 +60,10 @@ jobs:
 <% } -%>
 
       - name: Create nojekyll
-        run: touch docs/.nojekyll
+        run: touch generated-docs/.nojekyll
 
       - name: Deploy
         uses: peaceiris/actions-gh-pages@v4
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
-          publish_dir: ./docs
+          publish_dir: ./generated-docs

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -138,6 +138,11 @@ jobs:
 <% } else { -%>
         run: npm ci
 <% } -%>
+<% if (build) { -%>
+
+      - name: Build
+        run: <%= packageManagerRun("build") %>
+<% } -%>
 
       - name: Format
         run: <%= packageManagerRun("format:check") %>
@@ -147,6 +152,9 @@ jobs:
         run: <%= packageManagerRun("tsc") %>
 <% } -%>
 
+      - name: Oxlint
+        run: <%= packageManagerRun("lint:oxlint") %>
+
       - name: Eslint
         run: <%= packageManagerRun("lint:eslint") %>
 <% if (testing) { -%>
@@ -196,6 +204,11 @@ jobs:
       - name: Install Dependencies
         run: pnpm install --frozen-lockfile
 <% } -%>
+<% if (build) { -%>
+
+      - name: Build
+        run: <%= packageManagerRun("build") %>
+<% } -%>
 
 <% if (codecov) { -%>
       - name: Test
@@ -267,6 +280,11 @@ jobs:
 <% } else { -%>
         run: npm ci
 <% } -%>
+<% if (build) { -%>
+
+      - name: Build
+        run: <%= packageManagerRun("build") %>
+<% } -%>
 
       - name: E2E testing
         run: <%= packageManagerRun("test:e2e", e2eTesting) %>

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -64,7 +64,6 @@ jobs:
 <% if (build) { -%>
       - name: Build
         run: <%= packageManager %> run build
-        if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
 
 <% } -%>
       - name: Format
@@ -77,6 +76,10 @@ jobs:
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
 <% } -%>
 
+      - name: Oxlint
+        run: <%= packageManager %> run lint:oxlint
+        if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
+
       - name: Eslint
         run: <%= packageManager %> run lint:eslint
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
@@ -99,7 +102,7 @@ jobs:
         with:
           fail_ci_if_error: true
           token: ${{ secrets.CODECOV_TOKEN }}
-          files: ./docs/coverage.lcov
+          files: ./generated-docs/coverage.lcov
           disable_search: true
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.') && github.actor != 'dependabot[bot]'
 <% } else if (testing) { -%>

package/lib/generators/core/git/generators/github/CoreGitGithubGenerator.js

@@ -1,10 +1,30 @@
 /* eslint-disable camelcase */
 
+import { spawnSync } from "node:child_process";
+import * as os from "node:os";
 import Generator from "yeoman-generator";
 import { ciContexts } from "../../../ci/CoreCIGenerator.js";
 // const packageUtils = require('../../../../../utils/package');
 
-const GITHUB_TOKEN = process.env.POB_GITHUB_TOKEN;
+const readTokenFromKeychain = () => {
+  if (process.platform !== "darwin") return undefined;
+  const result = spawnSync(
+    "security",
+    [
+      "find-generic-password",
+      "-s",
+      "pob-github-token",
+      "-a",
+      os.userInfo().username,
+      "-w",
+    ],
+    { encoding: "utf8" },
+  );
+  if (result.status !== 0) return undefined;
+  return result.stdout.trim() || undefined;
+};
+
+const GITHUB_TOKEN = process.env.POB_GITHUB_TOKEN || readTokenFromKeychain();
 
 const postJson = (url, jsonBody) =>
   fetch(`https://api.github.com/${url}`, {
@@ -121,7 +141,7 @@ export default class CoreGitGithubGenerator extends Generator {
 
     if (!GITHUB_TOKEN && process.env.CI !== "true") {
       console.warn(
-        "Missing POB_GITHUB_TOKEN. Create one with https://github.com/settings/tokens/new?scopes=repo&description=POB%20Generator and add it in your env variables.",
+        'Missing POB_GITHUB_TOKEN. Create one with https://github.com/settings/tokens/new?scopes=repo&description=POB%20Generator and add it in your env variables, or store it in the macOS keychain with: security add-generic-password -s pob-github-token -a "$USER" -w',
       );
     }
   }

package/lib/generators/core/gitignore/CoreGitignoreGenerator.js

@@ -46,13 +46,6 @@ export default class CoreGitignoreGenerator extends Generator {
       description: "Typescript use.",
     });
 
-    this.option("buildInGit", {
-      type: Boolean,
-      required: false,
-      default: true,
-      description: "Build is saved in git.",
-    });
-
     this.option("buildDirectory", {
       type: String,
       required: false,
@@ -88,7 +81,6 @@ export default class CoreGitignoreGenerator extends Generator {
         withBabel,
         typescript: withBabel || this.options.typescript,
         paths: this.options.paths,
-        buildInGit: this.options.buildInGit,
         playwright: this.options.playwright,
       });
     }

package/lib/generators/core/gitignore/templates/gitignore.ejs

@@ -8,7 +8,9 @@ yarn-debug.log*
 yarn-error.log*
 <% } -%>
 <% if (paths) { -%>
+<% if (root) { -%>
 
+<% } -%>
 <%= paths %>
 <% } -%>
 <% if (root) { -%>
@@ -20,17 +22,17 @@ yarn-error.log*
 !/.vscode
 *.sublime-project
 *.sublime-workspace
-<% if (documentation) { -%>
+<% if (documentation || testing) { -%>
 
-# generated documentation directory
-/docs
+# generated documentation and coverage output
+/generated-docs
 <% } -%>
 <% if (testing) { -%>
 
 # default coverage directory
 /coverage
 <% } -%>
-<% if (typescript && buildInGit) { -%>
+<% if (typescript) { -%>
 
 # Typescript
 *.tsbuildinfo

package/lib/generators/core/node/CoreNodeGenerator.js

@@ -0,0 +1,24 @@
+import Generator from "yeoman-generator";
+import { updateNodeEngines } from "../../../utils/nodeEngines.js";
+
+export default class CoreNodeGenerator extends Generator {
+  constructor(args, opts) {
+    super(args, opts);
+
+    this.option("onlyLatestLTS", {
+      type: Boolean,
+      required: false,
+      default: false,
+      description: "only support latest LTS version of node",
+    });
+  }
+
+  writing() {
+    const pkg = this.fs.readJSON(this.destinationPath("package.json"));
+
+    updateNodeEngines(pkg, { onlyLatestLTS: this.options.onlyLatestLTS });
+
+    // no formatting needed, pob:core:sort-package runs after and formats
+    this.fs.writeJSON(this.destinationPath("package.json"), pkg);
+  }
+}