pob 38.4.0 → 38.6.0

package/lib/utils/nodeEngines.test.js

@@ -0,0 +1,168 @@
+import { describe, expect, it } from "vitest";
+import {
+  resolveEnginesNode,
+  updateNodeEngines,
+  updateTypesNodeFromEngines,
+} from "./nodeEngines.js";
+
+describe("updateTypesNodeFromEngines", () => {
+  it("updates devDependencies when lower than engines min major", () => {
+    const pkg = {
+      engines: { node: ">=24.14.1" },
+      devDependencies: { "@types/node": "22.5.0" },
+    };
+    updateTypesNodeFromEngines(pkg);
+    expect(pkg.devDependencies["@types/node"]).toBe(">=24.0.0");
+  });
+
+  it("keeps devDependencies with the same major", () => {
+    const pkg = {
+      engines: { node: ">=24.14.1" },
+      devDependencies: { "@types/node": "24.13.3" },
+    };
+    updateTypesNodeFromEngines(pkg);
+    expect(pkg.devDependencies["@types/node"]).toBe("24.13.3");
+  });
+
+  it("never lowers devDependencies", () => {
+    const pkg = {
+      engines: { node: ">=22.18.0" },
+      devDependencies: { "@types/node": "24.13.3" },
+    };
+    updateTypesNodeFromEngines(pkg);
+    expect(pkg.devDependencies["@types/node"]).toBe("24.13.3");
+  });
+
+  it("updates a devDependencies range", () => {
+    const pkg = {
+      engines: { node: ">=24.14.1" },
+      devDependencies: { "@types/node": ">=22.0.0" },
+    };
+    updateTypesNodeFromEngines(pkg);
+    expect(pkg.devDependencies["@types/node"]).toBe(">=24.0.0");
+  });
+
+  it("normalizes dependencies", () => {
+    const pkg = {
+      engines: { node: ">=22.18.0" },
+      dependencies: { "@types/node": ">=24.0.0" },
+    };
+    updateTypesNodeFromEngines(pkg);
+    expect(pkg.dependencies["@types/node"]).toBe(">=22.0.0");
+  });
+
+  it("does not add @types/node", () => {
+    const pkg = { engines: { node: ">=24.14.1" }, devDependencies: {} };
+    updateTypesNodeFromEngines(pkg);
+    expect(pkg.devDependencies["@types/node"]).toBeUndefined();
+  });
+
+  it("does nothing without a parseable engines.node", () => {
+    const pkg = {
+      engines: { node: "lts/*" },
+      devDependencies: { "@types/node": "22.5.0" },
+    };
+    updateTypesNodeFromEngines(pkg);
+    expect(pkg.devDependencies["@types/node"]).toBe("22.5.0");
+
+    const pkgWithoutEngines = { devDependencies: { "@types/node": "22.5.0" } };
+    updateTypesNodeFromEngines(pkgWithoutEngines);
+    expect(pkgWithoutEngines.devDependencies["@types/node"]).toBe("22.5.0");
+  });
+
+  it.each(["workspace:*", "catalog:", "npm:types-node@22.5.0"])(
+    "keeps unparseable version %s",
+    (version) => {
+      const pkg = {
+        engines: { node: ">=24.14.1" },
+        devDependencies: { "@types/node": version },
+      };
+      updateTypesNodeFromEngines(pkg);
+      expect(pkg.devDependencies["@types/node"]).toBe(version);
+    },
+  );
+});
+
+describe("resolveEnginesNode", () => {
+  it.each([
+    ["18", ">=22.18.0"],
+    ["22", ">=22.18.0"],
+    ["24", ">=24.14.1"],
+    ["26", ">=26.0.0"],
+  ])("resolves min major %s from envs", (minMajor, expected) => {
+    expect(resolveEnginesNode(">=22.18.0", minMajor, true)).toBe(expected);
+  });
+
+  it("throws on an unsupported min major", () => {
+    expect(() => resolveEnginesNode(">=22.18.0", "25", true)).toThrow(
+      "Invalid min node version: 25",
+    );
+  });
+
+  it("migrates >=22.11.x", () => {
+    expect(resolveEnginesNode(">=22.11.0", "22", false)).toBe(">=22.18.0");
+  });
+
+  it("raises a lower engines.node without envs", () => {
+    expect(resolveEnginesNode(">=18.0.0", "22", false)).toBe(">=22.18.0");
+  });
+
+  it("keeps a higher engines.node without envs", () => {
+    expect(resolveEnginesNode(">=26.0.0", "22", false)).toBe(">=26.0.0");
+  });
+
+  it("lets envs lower engines.node", () => {
+    expect(resolveEnginesNode(">=24.14.1", "22", true)).toBe(">=22.18.0");
+  });
+});
+
+describe("updateNodeEngines", () => {
+  it("sets engines.node and @types/node from envs", () => {
+    const pkg = {
+      pob: { envs: [{ target: "node", version: "24" }] },
+      devDependencies: { "@types/node": "22.5.0" },
+    };
+    updateNodeEngines(pkg, {});
+    expect(pkg.engines.node).toBe(">=24.14.1");
+    expect(pkg.devDependencies["@types/node"]).toBe(">=24.0.0");
+  });
+
+  it("supports babelEnvs", () => {
+    const pkg = { pob: { babelEnvs: [{ target: "node", version: "24" }] } };
+    updateNodeEngines(pkg, {});
+    expect(pkg.engines.node).toBe(">=24.14.1");
+  });
+
+  it("uses the maintenance LTS without envs", () => {
+    const pkg = {};
+    updateNodeEngines(pkg, {});
+    expect(pkg.engines.node).toBe(">=22.18.0");
+  });
+
+  it("uses the latest LTS without envs when onlyLatestLTS", () => {
+    const pkg = {};
+    updateNodeEngines(pkg, { onlyLatestLTS: true });
+    expect(pkg.engines.node).toBe(">=24.14.1");
+  });
+
+  it("removes @types/node when there is no node target", () => {
+    const pkg = {
+      pob: { envs: [{ target: "browser" }] },
+      dependencies: { "@types/node": ">=22.0.0" },
+      devDependencies: { "@types/node": "24.13.3", typescript: "6.0.0" },
+    };
+    updateNodeEngines(pkg, {});
+    expect(pkg.dependencies).toBeUndefined();
+    expect(pkg.devDependencies["@types/node"]).toBeUndefined();
+    expect(pkg.engines.node).toBe(">=22.18.0");
+  });
+
+  it("keeps a higher engines.node when there is no node target", () => {
+    const pkg = {
+      pob: { envs: [{ target: "browser" }] },
+      engines: { node: ">=24.14.1" },
+    };
+    updateNodeEngines(pkg, {});
+    expect(pkg.engines.node).toBe(">=24.14.1");
+  });
+});

package/lib/utils/packageManagerUtils.js

@@ -34,6 +34,23 @@ export const packageManagerExec = (packageManager, command) => {
   }
 };
 
+// `pnpm run` and `npm run` only resolve package.json scripts, not binaries
+export const packageManagerExecWithCwd = (packageManager, cwd, command) => {
+  switch (packageManager) {
+    case undefined:
+    case "yarn":
+      return `yarn ${quoteArg(cwd)} run ${command}`;
+    case "npm":
+      return `cd ${quoteArg(cwd)} && npx ${command}`;
+    case "bun":
+      return `bun run --cwd ${quoteArg(cwd)} ${command}`;
+    case "pnpm":
+      return `pnpm --dir ${quoteArg(cwd)} exec ${command}`;
+    default:
+      throw new Error(`Unsupported package manager: ${packageManager}`);
+  }
+};
+
 export const packageManagerRunWithCwd = (packageManager, cwd, script) => {
   switch (packageManager) {
     case undefined:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "38.4.0",
+  "version": "38.6.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/vitest",
   "keywords": [
     "skeleton"
@@ -30,7 +30,7 @@
   "dependencies": {
     "@types/inquirer": "9.0.10",
     "@yeoman/adapter": "4.0.2",
-    "eslint": "10.8.0",
+    "eslint": "10.8.1",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^9.0.0",
@@ -48,17 +48,17 @@
     "validate-npm-package-name": "^8.0.0",
     "yeoman-environment": "6.1.0",
     "yeoman-generator": "8.2.2",
-    "@pob/eslint-config-typescript-react": "67.3.0",
-    "pob-dependencies": "27.3.0",
-    "@pob/sort-object": "11.1.1",
-    "@pob/sort-pkg": "13.1.2",
-    "@pob/eslint-config": "67.3.0"
+    "@pob/eslint-config": "67.5.0",
+    "@pob/sort-object": "11.1.2",
+    "@pob/eslint-config-typescript-react": "67.5.0",
+    "@pob/sort-pkg": "13.1.3",
+    "pob-dependencies": "27.5.0"
   },
   "devDependencies": {
     "@types/node": "24.13.3",
     "@typescript/native": "npm:typescript@7.0.2",
     "@yeoman/types": "1.11.1",
-    "@pob/root": "27.4.0"
+    "@pob/root": "27.6.0"
   },
   "engines": {
     "node": ">=22.18.0"
@@ -69,8 +69,9 @@
   "scripts": {
     "build": "pnpm run build:definitions",
     "build:definitions": "tsc -p tsconfig.json",
-    "lint": "pnpm run lint:eslint",
-    "lint:eslint": "pnpm run --dir '../..' eslint --quiet 'packages/pob'",
+    "lint": "pnpm run lint:oxlint && pnpm run lint:eslint",
+    "lint:eslint": "pnpm --dir '../..' exec eslint --quiet 'packages/pob'",
+    "lint:oxlint": "pnpm --dir '../..' exec oxlint 'packages/pob'",
     "tsc": "tsc"
   },
   "bin": {