pob 38.1.0 → 38.2.1

package/lib/generators/app/PobAppGenerator.js

@@ -414,6 +414,16 @@ export default class PobAppGenerator extends Generator {
       }
     }
 
+    if (this.appConfig.type === "expo") {
+      pkg.expo = { install: { exclude: ["typescript"] } };
+    } else if (pkg.expo) {
+      delete pkg.expo;
+    }
+
+    packageUtils.addOrRemoveScripts(pkg, this.appConfig.type === "expo", {
+      "upgrade-expo": "expo install expo@57 --fix",
+    });
+
     this.fs.writeJSON(this.destinationPath("package.json"), pkg);
 
     this.composeWith("pob:core:sort-package");

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -264,8 +264,7 @@ export default class CommonTestingGenerator extends Generator {
           if (!workspacesPattern && this.options.monorepo) {
             throw new Error("Invalid workspacesPattern");
           }
-          const experimentalTestCoverage =
-            pkg.name === "check-package-dependencies";
+          const experimentalTestCoverage = true;
           return [
             experimentalTestCoverage && coverage === "generate"
               ? "mkdir -p docs && "
@@ -274,7 +273,7 @@ export default class CommonTestingGenerator extends Generator {
               coverage && !experimentalTestCoverage
                 ? `npx c8${
                     coverage === "generate"
-                      ? ` --reporter=${coverage === "generate" ? "json" : "lcov"}`
+                      ? ` --reporter=${coverage === "generate" ? "lcov" : "lcov"}`
                       : ""
                   } --all --src ./${this.options.srcDirectory} `
                 : ""

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -54,18 +54,6 @@ jobs:
         run: <%= packageManager %> typedoc --tsconfig tsconfig.doc.json
 <% } -%>
 
-<% if (testing) { -%>
-<% if (testRunner === 'node') { -%>
-
-      - name: Generate Coverage
-        run: NODE_V8_COVERAGE=./docs/coverage <%= packageManagerRun("test:coverage:generate") %>
-<% } else {-%>
-
-      - name: Generate Coverage
-        run: <%= packageManagerRun("test:coverage:generate") %>
-<% } -%>
-<% } -%>
-
       - name: Create nojekyll
         run: touch docs/.nojekyll
 

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -89,7 +89,7 @@ jobs:
 <% if (codecov) { -%>
 
       - name: Generate Test Coverage
-        run: <%= packageManagerRun("test:coverage:generate) %>
+        run: <%= packageManagerRun("test:coverage:generate") %>
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
         env:
           CI: true
@@ -99,7 +99,7 @@ jobs:
         with:
           fail_ci_if_error: true
           token: ${{ secrets.CODECOV_TOKEN }}
-          files: ./coverage/coverage-final.json
+          files: ./docs/coverage.lcov
           disable_search: true
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.') && github.actor != 'dependabot[bot]'
 <% } else if (testing) { -%>

package/lib/generators/core/package/CorePackageGenerator.js

@@ -233,25 +233,33 @@ export default class CorePackageGenerator extends Generator {
 
     if (this.options.inMonorepo && !this.options.isRoot) {
       packageUtils.removeScripts(pkg, ["checks"]);
-    } else if (this.options.isRoot) {
-      const checksScript = pkg.scripts?.checks;
-      if (checksScript && checksScript.includes("node scripts/check-package")) {
-        pkg.scripts.checks = checksScript.replace(
-          /( && )?node scripts\/check-package\.(mjs|js)( && )?/,
-          "",
-        );
-        if (pkg.scripts.checks === "") {
-          delete pkg.scripts.checks;
-        }
-      }
-    } else if (inMonorepo && !inMonorepo.root) {
+    } else {
       if (this.fs.exists("scripts/check-package.js")) {
         this.fs.delete("scripts/check-package.js");
       }
       if (this.fs.exists("scripts/check-package.mjs")) {
         this.fs.delete("scripts/check-package.mjs");
       }
-      packageUtils.removeScripts(pkg, ["checks"]);
+      if (this.fs.exists("scripts/check-package.ts")) {
+        this.fs.delete("scripts/check-package.ts");
+      }
+      if (this.options.isRoot) {
+        const checksScript = pkg.scripts?.checks;
+        if (
+          checksScript &&
+          checksScript.includes("node scripts/check-package")
+        ) {
+          pkg.scripts.checks = checksScript.replace(
+            /( && )?node scripts\/check-packages?\.(mjs|js|ts)( && )?/,
+            "",
+          );
+          if (pkg.scripts.checks === "") {
+            delete pkg.scripts.checks;
+          }
+        }
+      } else if (inMonorepo && !inMonorepo.root) {
+        packageUtils.removeScripts(pkg, ["checks"]);
+      }
     }
 
     if (!pkg.authors) {

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -4,7 +4,10 @@ import { platform } from "node:process";
 import Generator from "yeoman-generator";
 import * as packageUtils from "../../utils/package.js";
 import { packageManagerRun } from "../../utils/packageManagerUtils.js";
-import { workspacesRun } from "../../utils/packageManagerWorkspacesUtils.js";
+import {
+  workspacesRun,
+  workspacesRunSequential,
+} from "../../utils/packageManagerWorkspacesUtils.js";
 import {
   buildDependenciesMaps,
   buildTopologicalOrderBatches,
@@ -421,6 +424,16 @@ export default class PobMonorepoGenerator extends Generator {
         watch: `${packageManagerRun(this.options.packageManager, "clean:build")} && rollup --config rollup.config.mjs --watch`,
       });
 
+      const hasExpoApp = this.packageConfigs.some(
+        (config) => config?.app?.type === "expo",
+      );
+      packageUtils.addOrRemoveScripts(pkg, hasExpoApp, {
+        "upgrade-expo": workspacesRunSequential(
+          this.options.packageManager,
+          "upgrade-expo",
+        ),
+      });
+
       packageUtils.addOrRemoveDevDependencies(pkg, rollupKinds.has("esbuild"), [
         "@pob/rollup-esbuild",
       ]);

package/lib/utils/packageManagerWorkspacesUtils.js

@@ -38,6 +38,26 @@ export const workspacesRunTopological = (packageManager, script) => {
   }
 };
 
+/**
+ * Run a script sequentially in every workspace that defines it.
+ * Use when parallel execution is unsafe (e.g. package manager upgrades).
+ */
+export const workspacesRunSequential = (packageManager, script) => {
+  switch (packageManager) {
+    case undefined:
+    case "yarn":
+      return `yarn workspaces foreach -Av run ${script}`;
+    case "pnpm":
+      return `pnpm -r --sequential run ${script}`;
+    case "npm":
+      return `npm run ${script} --workspaces --if-present`;
+    case "bun":
+      return `bun --filter '*' run ${script}`;
+    default:
+      throw new Error(`Unsupported package manager: ${packageManager}`);
+  }
+};
+
 /**
  * Run a script in all workspaces in parallel, excluding packages matching the given patterns.
  * Use for watch commands where example/demo packages should be skipped.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "38.1.0",
+  "version": "38.2.1",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/vitest",
   "keywords": [
     "skeleton"
@@ -48,17 +48,17 @@
     "validate-npm-package-name": "^8.0.0",
     "yeoman-environment": "6.1.0",
     "yeoman-generator": "8.2.2",
-    "@pob/eslint-config": "67.1.0",
-    "@pob/eslint-config-typescript-react": "67.1.0",
-    "@pob/sort-object": "11.1.1",
-    "pob-dependencies": "27.1.0",
-    "@pob/sort-pkg": "13.1.2"
+    "@pob/eslint-config": "67.1.1",
+    "@pob/eslint-config-typescript-react": "67.1.1",
+    "@pob/sort-pkg": "13.1.2",
+    "pob-dependencies": "27.1.1",
+    "@pob/sort-object": "11.1.1"
   },
   "devDependencies": {
     "@types/node": "24.13.3",
     "@typescript/native": "npm:typescript@7.0.2",
     "@yeoman/types": "1.11.1",
-    "@pob/root": "27.1.0"
+    "@pob/root": "27.2.1"
   },
   "engines": {
     "node": ">=22.18.0"