pob 35.7.0 → 36.0.0

package/lib/generators/app/ignorePaths.js

@@ -20,10 +20,10 @@ export const appIgnorePaths = {
   storybook: (config) => ["/.storybook/storybook.requires.ts"],
   expo: (config) => [
     "/.expo/",
-    "/src/tamagui-web.css",
     "/android/",
     "/ios/",
     "/dist/",
+    "/dist-native/",
     "*.jks",
     "*.p8",
     "*.p12",

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -409,6 +409,12 @@ export default class CommonFormatLintGenerator extends Generator {
       };
     })();
 
+    const isMonorepoRoot =
+      this.options.monorepo || Boolean(inMonorepo && inMonorepo.root);
+    if (isMonorepoRoot && useTypescript) {
+      flatCascade.push("...pobConfig(import.meta.url).configs.monorepo");
+    }
+
     const eslintrcBadPath = this.destinationPath(".eslintrc");
     this.fs.delete(eslintrcBadPath);
     this.fs.delete(`${eslintrcBadPath}.yml`);

package/lib/generators/common/release/templates/workflow-release.yml.ejs

@@ -55,7 +55,7 @@ jobs:
           version: 11
 <% } -%>
 
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: <%= nodeLatestMajorVersion %>
           registry-url: "https://registry.npmjs.org"

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -259,21 +259,28 @@ export default class CommonTestingGenerator extends Generator {
           }
           const experimentalTestCoverage =
             pkg.name === "check-package-dependencies";
-          return `TZ=UTC ${
-            coverage && !experimentalTestCoverage
-              ? `npx c8${
-                  coverage === "generate"
-                    ? ` --reporter=${coverage === "generate" ? "json" : "lcov"}`
-                    : ""
-                } --all --src ./${this.options.srcDirectory} `
-              : ""
-          }node ${
-            this.options.typescript
-              ? `${tsTestLoaderOption ? `${tsTestLoaderOption} ` : ""}`
-              : ""
-          }${this.fs.exists("src/test-setup.ts") ? "--import ./src/test-setup.ts " : ""}--test${experimentalTestCoverage && coverage ? ` --experimental-test-coverage${coverage === "generate" ? " --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=docs/coverage.lcov" : ""} --test-coverage-include="${this.options.srcDirectory}/**/*.ts"` : ""} '${this.options.monorepo ? `${workspacesPattern}/*/` : ""}${`${
-            hasTestFolder ? "test/*" : `${this.options.srcDirectory}/**/*.test`
-          }.${this.options.typescript ? "ts" : "js"}`}'`;
+          return [
+            experimentalTestCoverage && coverage === "generate"
+              ? "mkdir -p docs && "
+              : "",
+            `TZ=UTC ${
+              coverage && !experimentalTestCoverage
+                ? `npx c8${
+                    coverage === "generate"
+                      ? ` --reporter=${coverage === "generate" ? "json" : "lcov"}`
+                      : ""
+                  } --all --src ./${this.options.srcDirectory} `
+                : ""
+            }node ${
+              this.options.typescript
+                ? `${tsTestLoaderOption ? `${tsTestLoaderOption} ` : ""}`
+                : ""
+            }${this.fs.exists("src/test-setup.ts") ? "--import ./src/test-setup.ts " : ""}--test${experimentalTestCoverage && coverage ? ` --experimental-test-coverage${coverage === "generate" ? " --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=docs/coverage.lcov" : ""} --test-coverage-include="${this.options.srcDirectory}/**/*.ts"` : ""} '${this.options.monorepo ? `${workspacesPattern}/*/` : ""}${`${
+              hasTestFolder
+                ? "test/*"
+                : `${this.options.srcDirectory}/**/*.test`
+            }.${this.options.typescript ? "ts" : "js"}`}'`,
+          ].join("");
         }
         case "bun": {
           if (this.options.packageManager !== "bun") {

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -27,7 +27,7 @@ jobs:
           version: 11
 
 <% } -%>
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: <%= nodeLatestMajorVersion %>
 

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -28,7 +28,7 @@ jobs:
           version: 11
 
 <% } -%>
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: <%= nodeLatestMajorVersion %>
 
@@ -73,7 +73,7 @@ jobs:
           version: 11
 
 <% } -%>
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: <%= nodeLatestMajorVersion %>
 
@@ -120,7 +120,7 @@ jobs:
           version: 11
 
 <% } -%>
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: <%= nodeLatestMajorVersion %>
 
@@ -178,7 +178,7 @@ jobs:
           version: 11
 
 <% } -%>
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: ${{ matrix.node-version }}
 
@@ -249,7 +249,7 @@ jobs:
           version: 11
 
 <% } -%>
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: ${{ matrix.node-version }}
 
@@ -280,7 +280,7 @@ jobs:
     steps:
       - uses: actions/checkout@v7
 
-      - uses: actions/setup-node@v6
+      - uses: actions/setup-node@v7
         with:
           node-version: <%= nodeLatestMajorVersion %>
 

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -32,7 +32,7 @@ jobs:
 
 <% } -%>
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v6
+        uses: actions/setup-node@v7
         with:
           node-version: ${{ matrix.node-version }}
           registry-url: 'https://registry.npmjs.org'

package/lib/generators/core/claude/CoreClaudeGenerator.js

@@ -1,11 +1,6 @@
 import Generator from "yeoman-generator";
 import { writeAndFormatJson } from "../../../utils/writeAndFormat.js";
 
-const claudePostToolUseHook = {
-  matcher: "Edit|Write|MultiEdit",
-  hooks: [{ type: "command", command: "pob-claude-run-lint-staged" }],
-};
-
 export default class CoreClaudeGenerator extends Generator {
   constructor(args, opts) {
     super(args, opts);
@@ -34,22 +29,19 @@ export default class CoreClaudeGenerator extends Generator {
       "/settings.local.json\n/skills/local.*\n",
     );
 
+    const command =
+      pkg.name === "pob-monorepo"
+        ? "node ./@pob/root/bin/pob-claude-run-lint-staged.js"
+        : "./node_modules/.bin/pob-claude-run-lint-staged";
+
+    const claudePostToolUseHook = {
+      matcher: "Edit|Write|MultiEdit",
+      hooks: [{ type: "command", command }],
+    };
+
     const existing = this.fs.readJSON(claudeSettingsPath, {
       hooks: {
-        PostToolUse: [
-          {
-            matcher: "Edit|Write|MultiEdit",
-            hooks: [
-              {
-                type: "command",
-                command:
-                  pkg.name === "pob-monorepo"
-                    ? "node ./@pob/root/bin/pob-claude-run-lint-staged.js"
-                    : "./node_modules/.bin/pob-claude-run-lint-staged",
-              },
-            ],
-          },
-        ],
+        PostToolUse: [claudePostToolUseHook],
       },
     });
 

package/lib/generators/core/package/CorePackageGenerator.js

@@ -221,28 +221,29 @@ export default class CorePackageGenerator extends Generator {
       fs.unlinkSync(this.destinationPath("yarn-error.log"));
     }
 
-    if (this.options.inMonorepo && !this.options.isRoot) {
-      packageUtils.removeScripts(pkg, ["checks"]);
+    if (pkg.name !== "@pob/root") {
       packageUtils.removeDevDependencies(pkg, ["check-package-dependencies"]);
-    } else if (this.options.isMonorepo && this.options.isRoot) {
-      const doesMjsCheckPackagesExists = this.fs.exists(
-        this.destinationPath("scripts/check-packages.mjs"),
-      );
-      const doesJsCheckPackagesExists = this.fs.exists(
-        this.destinationPath("scripts/check-packages.js"),
-      );
+    }
+    if (this.fs.exists(this.destinationPath("scripts/check-packages.mjs"))) {
+      this.fs.delete(this.destinationPath("scripts/check-packages.mjs"));
+    }
+    if (this.fs.exists(this.destinationPath("scripts/check-packages.js"))) {
+      this.fs.delete(this.destinationPath("scripts/check-packages.js"));
+    }
 
-      if (doesJsCheckPackagesExists || doesMjsCheckPackagesExists) {
-        packageUtils.addDevDependencies(pkg, ["check-package-dependencies"]);
+    if (this.options.inMonorepo && !this.options.isRoot) {
+      packageUtils.removeScripts(pkg, ["checks"]);
+    } else if (this.options.isRoot) {
+      const checksScript = pkg.scripts?.checks;
+      if (checksScript && checksScript.includes("node scripts/check-package")) {
+        pkg.scripts.checks = checksScript.replace(
+          /( && )?node scripts\/check-package\.(mjs|js)( && )?/,
+          "",
+        );
+        if (pkg.scripts.checks === "") {
+          delete pkg.scripts.checks;
+        }
       }
-
-      packageUtils.addOrRemoveScripts(
-        pkg,
-        doesMjsCheckPackagesExists || doesJsCheckPackagesExists,
-        {
-          checks: `node scripts/check-packages.${doesMjsCheckPackagesExists ? "mjs" : "js"}`,
-        },
-      );
     } else if (inMonorepo && !inMonorepo.root) {
       if (this.fs.exists("scripts/check-package.js")) {
         this.fs.delete("scripts/check-package.js");
@@ -251,50 +252,6 @@ export default class CorePackageGenerator extends Generator {
         this.fs.delete("scripts/check-package.mjs");
       }
       packageUtils.removeScripts(pkg, ["checks"]);
-    } else {
-      const doesMjsCheckPackageExists = this.fs.exists(
-        this.destinationPath("scripts/check-package.mjs"),
-      );
-      let doesJsCheckPackageExists = this.fs.exists(
-        this.destinationPath("scripts/check-package.js"),
-      );
-      const doesTsCheckPackageExists = this.fs.exists(
-        this.destinationPath("scripts/check-package.ts"),
-      );
-
-      if (pkg.type === "module") {
-        if (!doesJsCheckPackageExists && !doesTsCheckPackageExists) {
-          doesJsCheckPackageExists = true;
-          this.fs.copyTpl(
-            this.templatePath("check-package.js.ejs"),
-            this.destinationPath("scripts/check-package.ts"),
-            {
-              isLibrary: pkg.private !== true,
-            },
-          );
-        }
-      }
-      if (
-        doesJsCheckPackageExists ||
-        doesMjsCheckPackageExists ||
-        doesTsCheckPackageExists
-      ) {
-        packageUtils.addDevDependencies(pkg, ["check-package-dependencies"]);
-      }
-
-      packageUtils.addOrRemoveScripts(
-        pkg,
-        doesMjsCheckPackageExists ||
-          doesJsCheckPackageExists ||
-          doesTsCheckPackageExists,
-        {
-          checks: `node scripts/check-package.${(() => {
-            if (doesMjsCheckPackageExists) return "mjs";
-            if (doesTsCheckPackageExists) return "ts";
-            return "js";
-          })()}`,
-        },
-      );
     }
 
     if (!pkg.authors) {

package/lib/generators/core/pnpm/CorePnpmGenerator.js

@@ -1,5 +1,5 @@
 import sortObject from "@pob/sort-object";
-import yml from "js-yaml";
+import { FAILSAFE_SCHEMA, dump, loadAll } from "js-yaml";
 import { lt } from "semver";
 import Generator from "yeoman-generator";
 import { writeAndFormat } from "../../../utils/writeAndFormat.js";
@@ -47,10 +47,10 @@ export default class CorePnpmGenerator extends Generator {
         this.destinationPath("pnpm-workspace.yaml"),
         { defaults: "" },
       );
-      const config =
-        yml.load(configString, {
-          schema: yml.FAILSAFE_SCHEMA,
-        }) || {};
+      const [loadedConfig] = loadAll(configString, {
+        schema: FAILSAFE_SCHEMA,
+      });
+      const config = loadedConfig ?? {};
 
       if (config.allowBuilds) {
         config.allowBuilds = Object.fromEntries(
@@ -70,11 +70,12 @@ export default class CorePnpmGenerator extends Generator {
       config.minimumReleaseAge = 1440 * 3; // 3 days in minutes
       config.minimumReleaseAgeExclude = minimumReleaseAgeExcludePackages;
       config.dedupePeerDependents = true;
+      config.nodeLinker = "hoisted";
 
       await writeAndFormat(
         this.fs,
         this.destinationPath("pnpm-workspace.yaml"),
-        yml.dump(sortObject(config), { lineWidth: 9999, noCompatMode: true }),
+        dump(sortObject(config), { lineWidth: 9999 }),
       );
     } else {
       if (pkg.packageManager?.startsWith("pnpm@")) {

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -1,7 +1,7 @@
 import fs from "node:fs";
 import { isDeepStrictEqual } from "node:util";
 import sortObject from "@pob/sort-object";
-import yml from "js-yaml";
+import { FAILSAFE_SCHEMA, dump, loadAll } from "js-yaml";
 import { lt } from "semver";
 import Generator from "yeoman-generator";
 import { ensureJsonFileFormatted } from "../../../utils/ensureJsonFileFormatted.js";
@@ -154,11 +154,11 @@ export default class CoreYarnGenerator extends Generator {
 
       // must be done after plugins installed
       const configString = this.fs.read(".yarnrc.yml", { defaults: "" });
-      const config =
-        yml.load(configString, {
-          schema: yml.FAILSAFE_SCHEMA,
-          json: true,
-        }) || {};
+      const [loadedConfig] = loadAll(configString, {
+        schema: FAILSAFE_SCHEMA,
+        json: true,
+      });
+      const config = loadedConfig ?? {};
       if (config.enableScripts === "true") {
         config.enableScripts = true;
       }
@@ -204,7 +204,7 @@ export default class CoreYarnGenerator extends Generator {
         await writeAndFormat(
           this.fs,
           ".yarnrc.yml",
-          yml.dump(sortObject(config), {
+          dump(sortObject(config), {
             lineWidth: 9999,
           }),
         );

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -61,11 +61,7 @@ const hasData = (packages, configs) =>
 const hasTamagui = (packages, configs) =>
   packages.some(
     (pkg) =>
-      !!(
-        pkg.dependencies?.tamagui ||
-        pkg.dependencies?.["@tamagui/core"] ||
-        pkg.dependencies?.alouette
-      ),
+      !!(pkg.dependencies?.tamagui || pkg.dependencies?.["@tamagui/core"]),
   );
 
 export default class PobMonorepoGenerator extends Generator {
@@ -269,9 +265,13 @@ export default class PobMonorepoGenerator extends Generator {
         `${this.pobLernaConfig.e2eTesting === "." || this.pobLernaConfig.e2eTesting === true ? "" : `/${this.pobLernaConfig.e2eTesting}`}/test-results/`,
     ].filter(Boolean);
 
-    const gitignorePaths = [
-      hasTamagui(this.packages, this.packageConfigs) && ".tamagui",
-    ].filter(Boolean);
+    if (hasTamagui(this.packages, this.packageConfigs)) {
+      throw new Error(
+        "Tamagui is no longer supported. Please migrate to native-wind.",
+      );
+    }
+
+    const gitignorePaths = [].filter(Boolean);
 
     this.composeWith("pob:common:format-lint", {
       monorepo: true,

package/lib/generators/monorepo/typescript/MonorepoTypescriptGenerator.js

@@ -1,8 +1,22 @@
+import { readdirSync } from "node:fs";
 import Generator from "yeoman-generator";
+import { latestLTS } from "../../../utils/nodeVersions.js";
 import * as packageUtils from "../../../utils/package.js";
 import { packageManagerRun } from "../../../utils/packageManagerUtils.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
 
+const rootConfigExtensionsRegex = /\.config\.(?:ts|mts|cts)$/;
+
+const hasRootConfigFiles = (rootPath) => {
+  try {
+    return readdirSync(rootPath).some((name) =>
+      rootConfigExtensionsRegex.test(name),
+    );
+  } catch {
+    return false;
+  }
+};
+
 export default class MonorepoTypescriptGenerator extends Generator {
   constructor(args, opts) {
     super(args, opts);
@@ -121,15 +135,36 @@ export default class MonorepoTypescriptGenerator extends Generator {
     const tsconfigCheckPath = this.destinationPath("tsconfig.check.json");
     const tsconfigBuildPath = this.destinationPath("tsconfig.build.json");
     const tsconfigTestPath = this.destinationPath("tsconfig.test.json");
+    const tsconfigRootConfigsPath = this.destinationPath(
+      "tsconfig.root-configs.json",
+    );
     this.fs.delete(tsconfigTestPath);
 
     if (!this.options.enable) {
       this.fs.delete(tsconfigPath);
       this.fs.delete(tsconfigCheckPath);
       this.fs.delete(tsconfigBuildPath);
+      this.fs.delete(tsconfigRootConfigsPath);
     } else {
       const packagePaths = JSON.parse(this.options.packagePaths);
 
+      // root config files written in typescript (e.g. vitest.config.ts) are not
+      // part of any package tsconfig, so they need a dedicated project for
+      // type-aware linting and tsc -b
+      const hasRootConfigs = hasRootConfigFiles(this.destinationPath());
+      if (hasRootConfigs) {
+        await copyAndFormatTpl(
+          this.fs,
+          this.templatePath("tsconfig.root-configs.json.ejs"),
+          tsconfigRootConfigsPath,
+          {
+            nodeVersion: latestLTS,
+          },
+        );
+      } else {
+        this.fs.delete(tsconfigRootConfigsPath);
+      }
+
       await copyAndFormatTpl(
         this.fs,
         this.templatePath("tsconfig.json.ejs"),
@@ -137,6 +172,7 @@ export default class MonorepoTypescriptGenerator extends Generator {
         {
           packagePaths,
           tsConfigSuffix: false,
+          hasRootConfigs,
         },
       );
 

package/lib/generators/monorepo/typescript/templates/tsconfig.json.ejs

@@ -1,6 +1,9 @@
 {
   "files": [],
   "references": [
+<% if (hasRootConfigs) { -%>
+    { "path": "tsconfig.root-configs.json" }<%= packagePaths.length > 0 ? ',' : '' %>
+<% } -%>
 <% packagePaths.forEach((packagePath, index) => { -%>
     { "path": "<%= packagePath %>/tsconfig<%= tsConfigSuffix ? `.${tsConfigSuffix}` : '' %>.json" }<%= index === packagePaths.length -1 ? '' : ',' %>
 <% }) -%>

package/lib/generators/monorepo/typescript/templates/tsconfig.root-configs.json.ejs

@@ -0,0 +1,13 @@
+{
+  "extends": [
+    "@pob/root/tsconfigs/strict.json",
+    "@pob/root/tsconfigs/targets/node-<%= nodeVersion %>.json"
+  ],
+  "include": ["*.config.ts", "*.config.mts", "*.config.cts"],
+  "compilerOptions": {
+    "noEmit": true,
+    "tsBuildInfoFile": "node_modules/.cache/tsc/tsbuildinfo-root-configs",
+    "incremental": true,
+    "resolveJsonModule": true
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "35.7.0",
+  "version": "36.0.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/vitest",
   "keywords": [
     "skeleton"
@@ -28,16 +28,13 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@pob/eslint-config": "65.6.0",
-    "@pob/eslint-config-typescript-react": "65.6.0",
     "@types/inquirer": "9.0.10",
     "@yeoman/adapter": "4.0.2",
-    "@yeoman/types": "1.11.1",
     "eslint": "10.7.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^9.0.0",
-    "js-yaml": "^4.1.1",
+    "js-yaml": "^5.2.1",
     "json5": "^2.2.3",
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
@@ -51,13 +48,16 @@
     "validate-npm-package-name": "^8.0.0",
     "yeoman-environment": "6.1.0",
     "yeoman-generator": "8.2.2",
+    "@pob/eslint-config": "65.7.0",
     "@pob/sort-object": "11.1.1",
-    "pob-dependencies": "24.4.0",
-    "@pob/sort-pkg": "13.1.2"
+    "@pob/sort-pkg": "13.1.2",
+    "pob-dependencies": "25.0.0",
+    "@pob/eslint-config-typescript-react": "65.7.0"
   },
   "devDependencies": {
     "@types/node": "24.13.3",
-    "@pob/root": "24.7.0"
+    "@yeoman/types": "1.11.1",
+    "@pob/root": "25.0.0"
   },
   "engines": {
     "node": ">=22.18.0"

package/lib/generators/core/package/templates/check-package.js.ejs

@@ -1,3 +0,0 @@
-import { createCheckPackage } from 'check-package-dependencies';
-
-await createCheckPackage({ isLibrary: <%= isLibrary ? 'true' : 'false' %> }).checkRecommended({}).run();

package/lib/generators/core/package/templates/check-packages.js.ejs

@@ -1,7 +0,0 @@
-import { createCheckPackageWithWorkspaces } from 'check-package-dependencies';
-
-await createCheckPackageWithWorkspaces({
-    isLibrary: () => true,
-  })
-  .checkRecommended()
-  .run();