pob 35.4.1 → 35.6.0

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -322,8 +322,7 @@ export default class CommonBabelGenerator extends Generator {
     }
 
     if (pkg.dependencies && pkg.dependencies["pob-babel"]) {
-      // update pob-babel in alp-dev
-      packageUtils.addDependencies(pkg, ["pob-babel"], "^");
+      throw new Error("pob-babel is deprecated.");
     }
     if (pkg.dependencies && pkg.dependencies["@babel/runtime"]) {
       // update pob-babel in alp-dev

package/lib/generators/common/release/CommonReleaseGenerator.js

@@ -1,5 +1,6 @@
 import Generator from "yeoman-generator";
 // import { latestLTS } from "../../../utils/nodeVersions.js";
+import { latestLTS } from "../../../utils/nodeVersions.js";
 import * as packageUtils from "../../../utils/package.js";
 import {
   packageManagerExec,
@@ -86,7 +87,7 @@ export default class CommonReleaseGenerator extends Generator {
           isMonorepoIndependent:
             this.options.isMonorepo &&
             (!pkg.version || pkg.version === "0.0.0"),
-          nodeLatestMajorVersion: 24, // TODO use latestLTS, when latest is updated to 24
+          nodeLatestMajorVersion: latestLTS,
           packageManagerExec,
         },
       );

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -243,9 +243,7 @@ export default class CommonTestingGenerator extends Generator {
 
     const createTestCommand = ({
       coverage,
-      coverageJson,
       watch,
-
       workspacesPattern,
       hasReact,
     }) => {
@@ -259,12 +257,13 @@ export default class CommonTestingGenerator extends Generator {
           if (!workspacesPattern && this.options.monorepo) {
             throw new Error("Invalid workspacesPattern");
           }
-          const experimentalTestCoverage = false; // todo configure src directory and remove test files
+          const experimentalTestCoverage =
+            pkg.name === "check-package-dependencies";
           return `TZ=UTC ${
-            coverage || coverageJson
+            coverage && !experimentalTestCoverage
               ? `npx c8${
-                  coverageJson
-                    ? ` --reporter=${coverageJson ? "json" : "lcov"}`
+                  coverage === "generate"
+                    ? ` --reporter=${coverage === "generate" ? "json" : "lcov"}`
                     : ""
                 } --all --src ./${this.options.srcDirectory} `
               : ""
@@ -272,9 +271,9 @@ export default class CommonTestingGenerator extends Generator {
             this.options.typescript
               ? `${tsTestLoaderOption ? `${tsTestLoaderOption} ` : ""}`
               : ""
-          }${this.fs.exists("src/test-setup.ts") ? "--import ./src/test-setup.ts " : ""}--test${experimentalTestCoverage && (coverage || coverageJson) ? " --experimental-test-coverage" : ""} ${this.options.monorepo ? `${workspacesPattern}/*/` : ""}${`${
+          }${this.fs.exists("src/test-setup.ts") ? "--import ./src/test-setup.ts " : ""}--test${experimentalTestCoverage && coverage ? ` --experimental-test-coverage${coverage === "generate" ? " --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=docs/coverage.lcov" : ""} --test-coverage-include="${this.options.srcDirectory}/**/*.ts"` : ""} '${this.options.monorepo ? `${workspacesPattern}/*/` : ""}${`${
             hasTestFolder ? "test/*" : `${this.options.srcDirectory}/**/*.test`
-          }.${this.options.typescript ? "ts" : "js"}`}`;
+          }.${this.options.typescript ? "ts" : "js"}`}'`;
         }
         case "bun": {
           if (this.options.packageManager !== "bun") {
@@ -284,17 +283,17 @@ export default class CommonTestingGenerator extends Generator {
           }
 
           return `TZ=UTC bun test${watch ? " --watch" : ""}${
-            coverage || coverageJson
-              ? ` --coverage ${coverageJson ? "--coverage-report=json" : ""}`
+            coverage
+              ? ` --coverage ${coverage === "generate" ? "--coverage-report=json" : ""}`
               : ""
           }`;
         }
         case "vitest": {
           return `TZ=UTC ${
-            coverage || coverageJson
-              ? `POB_VITEST_COVERAGE=${`json${coverageJson ? "" : ",text"} `}`
+            coverage
+              ? `POB_VITEST_COVERAGE=${`json${coverage === "generate" ? "" : ",text"} `}`
               : ""
-          }vitest${watch ? " --watch" : ""}${coverage || coverageJson ? " run --coverage" : ""}`;
+          }vitest${watch ? " --watch" : ""}${coverage ? " run --coverage" : ""}`;
         }
         default: {
           throw new Error(`Invalid runner: "${testRunner}"`);
@@ -370,8 +369,12 @@ export default class CommonTestingGenerator extends Generator {
           );
         }
 
+        packageUtils.removeScripts(pkg, [
+          "test:coverage:lcov",
+          "test:coverage:json",
+        ]);
+
         if (this.options.monorepo) {
-          packageUtils.removeScripts(pkg, ["test:coverage:lcov"]);
           packageUtils.addScripts(pkg, {
             test: createTestCommand({
               workspacesPattern,
@@ -384,7 +387,7 @@ export default class CommonTestingGenerator extends Generator {
               workspacesPattern,
               coverage: true,
             }),
-            "test:coverage:json": createTestCommand({
+            "test:coverage:generate": createTestCommand({
               workspacesPattern,
               coverageJson: true,
             }),
@@ -420,8 +423,8 @@ export default class CommonTestingGenerator extends Generator {
               "test:coverage": createTestCommand({
                 coverage: true,
               }),
-              "test:coverage:json": createTestCommand({
-                coverageJson: true,
+              "test:coverage:generate": createTestCommand({
+                coverage: "generate",
               }),
             });
 

package/lib/generators/common/testing/templates/vite.config.js.ejs

@@ -6,7 +6,7 @@ export default defineConfig({
     include: ["<%= srcDirectory %>/**/__tests__/**/*.ts?(x)", "<%= srcDirectory %>/**/*.test.ts?(x)"],
     coverage: {
       include: ["<%= srcDirectory %>/**/*.ts?(x)"],
-      reportsDirectory: "docs/coverage",
+      reportsDirectory: "coverage",
       reporter: (process.env.POB_VITEST_COVERAGE || "json,text").split(","),
     },
   },

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -524,6 +524,7 @@ export default class CommonTranspilerGenerator extends Generator {
             if (extraEntryConfig.name.endsWith(".css")) {
               return {
                 style: `./${extraEntryConfig.name}`,
+                import: `./${extraEntryConfig.name}`,
                 default: `./${extraEntryConfig.name}`,
               };
             }
@@ -610,7 +611,7 @@ export default class CommonTranspilerGenerator extends Generator {
         envs.some(
           (env) =>
             env.target === "node" &&
-            (["8", "6", "10", "12", "14", "16", "18", "20"].includes(
+            (["4", "6", "8", "10", "12", "14", "16", "18", "20"].includes(
               String(env.version),
             ) ||
               (this.options.onlyLatestLTS &&
@@ -667,6 +668,9 @@ export default class CommonTranspilerGenerator extends Generator {
               : `${maintenanceLTS}`)();
 
       switch (String(minNodeVersion)) {
+        case "4":
+        case "6":
+        case "8":
         case "10":
         case "12":
         case "14":

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -58,11 +58,11 @@ jobs:
 <% if (testRunner === 'node') { -%>
 
       - name: Generate Coverage
-        run: NODE_V8_COVERAGE=./docs/coverage <%= packageManager %> run test:coverage
+        run: NODE_V8_COVERAGE=./docs/coverage <%= packageManager %> run test:coverage:generate
 <% } else {-%>
 
       - name: Generate Coverage
-        run: <%= packageManager %> run test:coverage:json<%- testRunner === 'jest' ? " --coverageDirectory=docs/coverage/" : "" %>
+        run: <%= packageManager %> run test:coverage:generate
 <% } -%>
 <% } -%>
 

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -203,7 +203,7 @@ jobs:
         if: matrix.node-version != <%= nodeLatestMajorVersion %>
 
       - name: Generate Test Coverage
-        run: <%= packageManager %> run test:coverage:json
+        run: <%= packageManager %> run test:coverage:generate
         if: matrix.node-version == <%= nodeLatestMajorVersion %>
         env:
           CI: true

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -89,7 +89,7 @@ jobs:
 <% if (codecov) { -%>
 
       - name: Generate Test Coverage
-        run: <%= packageManager %> run test:coverage:json
+        run: <%= packageManager %> run test:coverage:generate
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
         env:
           CI: true

package/lib/generators/monorepo/workspaces/templates/README.md.ejs

@@ -10,7 +10,7 @@
 
 <h3>📦 Packages</h3>
 
-This repository is a monorepo that we manage using [Yarn Workspaces](https://yarnpkg.com/features/workspaces).
+This repository is a monorepo using workspaces.
 
 | Package | Version | Description |
 |---------|---------|-------------|

package/lib/utils/package.js

@@ -116,11 +116,20 @@ const getVersionFromDependencyName = (dependency) => {
     value = pobPkg.devDependencies[dependency];
   }
 
-  if (value === "workspace:*") {
+  if (
+    value === "workspace:*" ||
+    value === "workspace:^" ||
+    value === "workspace:~"
+  ) {
     const pkgJson = JSON.parse(
       fs.readFileSync(
         fileURLToPath(
-          import.meta.resolve(`${dependency}/package.json`, import.meta.url),
+          import.meta.resolve(
+            `../../../../${dependency.startsWith("@") ? `${dependency}` : `packages/${dependency}`}/package.json`,
+            import.meta.url,
+          ),
+          // import.meta
+          //   .resolve(`${dependency}/package.json`, import.meta.url)
         ),
       ),
     );
@@ -168,7 +177,11 @@ const internalAddDependencies = (pkg, type, dependencies, cleaned, prefix) => {
           ? `${prefix || ""}${potentialNewVersionCleaned}`
           : potentialNewVersion;
       try {
-        if (currentVersion === "workspace:*") {
+        if (
+          currentVersion === "workspace:*" ||
+          currentVersion === "workspace:^" ||
+          currentVersion === "workspace:~"
+        ) {
           // the package is in the monorepo
         } else if (
           !currentVersion ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "35.4.1",
+  "version": "35.6.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -28,9 +28,9 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@pob/eslint-config": "65.5.0",
-    "@pob/eslint-config-typescript-react": "65.5.0",
-    "@types/inquirer": "9.0.9",
+    "@pob/eslint-config": "65.6.0",
+    "@pob/eslint-config-typescript-react": "65.6.0",
+    "@types/inquirer": "9.0.10",
     "@yeoman/adapter": "4.0.2",
     "@yeoman/types": "1.11.1",
     "eslint": "10.4.0",
@@ -51,13 +51,13 @@
     "validate-npm-package-name": "^8.0.0",
     "yeoman-environment": "6.1.0",
     "yeoman-generator": "8.2.2",
+    "@pob/sort-object": "11.1.1",
     "@pob/sort-pkg": "13.1.1",
-    "pob-dependencies": "24.2.0",
-    "@pob/sort-object": "11.1.1"
+    "pob-dependencies": "24.3.0"
   },
   "devDependencies": {
-    "@types/node": "24.12.4",
-    "@pob/root": "24.4.1"
+    "@types/node": "24.13.3",
+    "@pob/root": "24.6.0"
   },
   "engines": {
     "node": ">=22.18.0"