pob 34.1.0 → 35.0.0

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -107,23 +107,11 @@ export default class CommonTestingGenerator extends Generator {
     });
   }
 
-  async prompting() {
+  prompting() {
     if (this.options.enable && this.options.runner === "jest") {
-      const { confirm } = await this.prompt([
-        {
-          type: "confirm",
-          name: "confirm",
-          message:
-            "jest will soon be deprecated. Are you sure you want to continue using jest?",
-          default: false,
-        },
-      ]);
-
-      if (!confirm) {
-        throw new Error(
-          "Jest is deprecated. Please consider using an alternative test runner.",
-        );
-      }
+      throw new Error(
+        "Jest is deprecated. Please consider using an alternative test runner.",
+      );
     }
   }
 
@@ -151,7 +139,7 @@ export default class CommonTestingGenerator extends Generator {
     }
   }
 
-  writing() {
+  async writing() {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
 
     packageUtils.removeDevDependencies(pkg, [
@@ -180,22 +168,20 @@ export default class CommonTestingGenerator extends Generator {
       transpileWithBabel ||
       pkg.pob?.bundler === "tsc" ||
       (pkg.pob?.typescript && pkg.pob.typescript !== "check-only");
-    let hasReact =
+    const hasReact =
       withTypescript &&
       (this.options.monorepo
         ? (yoConfigPobMonorepo.react ?? packageUtils.hasReact(pkg))
         : packageUtils.hasReact(pkg));
     const testRunner = globalTesting
-      ? inMonorepo.pobConfig.monorepo.testRunner || "jest"
+      ? inMonorepo.pobConfig.monorepo.testRunner
       : this.options.runner;
 
-    const isJestRunner = testRunner === "jest";
-
     const tsTestUtil = (() => {
       if (testRunner === "vitest") return undefined;
       if (!withTypescript) return undefined;
-      if (isJestRunner && !transpileWithBabel && withTypescript) {
-        throw new Error("SWC is no longer supported. Migrate to vitest.");
+      if (testRunner === "jest") {
+        throw new Error("jest is no longer supported. Migrate to vitest.");
       }
       return "node";
     })();
@@ -203,14 +189,7 @@ export default class CommonTestingGenerator extends Generator {
     const dependenciesForTestUtil = {};
 
     Object.entries(dependenciesForTestUtil).forEach(
-      ([
-        key,
-        {
-          devDependenciesShared,
-          devDependenciesWithJest,
-          devDependenciesWithNode,
-        },
-      ]) => {
+      ([key, { devDependenciesShared, devDependenciesWithNode }]) => {
         const sharedCondition =
           this.options.enable &&
           (!inMonorepo || inMonorepo.root) &&
@@ -222,16 +201,6 @@ export default class CommonTestingGenerator extends Generator {
             (testRunner === "node" || (withTypescript && !transpileWithBabel)),
           devDependenciesShared,
         );
-        if (devDependenciesWithJest) {
-          packageUtils.addOrRemoveDevDependencies(
-            pkg,
-            sharedCondition &&
-              withTypescript &&
-              !transpileWithBabel &&
-              testRunner === "jest",
-            devDependenciesWithJest,
-          );
-        }
         if (devDependenciesWithNode) {
           packageUtils.addOrRemoveDevDependencies(
             pkg,
@@ -245,11 +214,7 @@ export default class CommonTestingGenerator extends Generator {
       },
     );
 
-    if (
-      !this.options.enable ||
-      !isJestRunner ||
-      (globalTesting && !enableForMonorepo)
-    ) {
+    if (!this.options.enable || (globalTesting && !enableForMonorepo)) {
       packageUtils.removeDevDependencies(pkg, [
         "jest",
         "@types/jest",
@@ -279,24 +244,11 @@ export default class CommonTestingGenerator extends Generator {
       coverage,
       coverageJson,
       watch,
-      shouldUseExperimentalVmModules,
+
       workspacesPattern,
       hasReact,
     }) => {
       switch (testRunner) {
-        case "jest": {
-          return `TZ=UTC ${
-            shouldUseExperimentalVmModules
-              ? "NODE_OPTIONS=--experimental-vm-modules "
-              : ""
-          }jest${watch ? " --watch" : ""}${
-            coverage || coverageJson
-              ? ` --coverage ${`--coverageReporters=json${
-                  coverageJson ? "" : " --coverageReporters=text"
-                }`}`
-              : ""
-          }`;
-        }
         case "node": {
           if (this.options.packageManager === "bun") {
             throw new Error(
@@ -341,9 +293,7 @@ export default class CommonTestingGenerator extends Generator {
             coverage || coverageJson
               ? `POB_VITEST_COVERAGE=${`json${coverageJson ? "" : ",text"} `}`
               : ""
-          }vitest${watch ? " --watch" : ""}${
-            coverage || coverageJson ? " run --coverage" : ""
-          }`;
+          }vitest${watch ? " --watch" : ""}${coverage || coverageJson ? " run --coverage" : ""}`;
         }
         default: {
           throw new Error(`Invalid runner: "${testRunner}"`);
@@ -353,13 +303,6 @@ export default class CommonTestingGenerator extends Generator {
 
     const jestConfigPath = this.destinationPath("jest.config.json");
     const vitestConfigPath = this.destinationPath("vite.config.js");
-    packageUtils.addOrRemoveDevDependencies(
-      pkg,
-      this.options.enable &&
-        (enableForMonorepo || !globalTesting) &&
-        testRunner === "jest",
-      ["jest", "@types/jest"],
-    );
 
     packageUtils.addOrRemoveDevDependencies(
       pkg,
@@ -386,7 +329,11 @@ export default class CommonTestingGenerator extends Generator {
         "test:coverage:lcov",
       ]);
 
-      writeAndFormatJson(this.fs, this.destinationPath("package.json"), pkg);
+      await writeAndFormatJson(
+        this.fs,
+        this.destinationPath("package.json"),
+        pkg,
+      );
     } else {
       let workspacesPattern;
       if (this.options.monorepo) {
@@ -408,7 +355,7 @@ export default class CommonTestingGenerator extends Generator {
         });
       } else {
         if (this.testRunner === "vitest") {
-          copyAndFormatTpl(
+          await copyAndFormatTpl(
             this.fs,
             this.templatePath("vite.config.js.ejs"),
             vitestConfigPath,
@@ -419,64 +366,24 @@ export default class CommonTestingGenerator extends Generator {
         }
 
         if (this.options.monorepo) {
-          const shouldUseExperimentalVmModules = pkg.type === "module";
-
           packageUtils.removeScripts(pkg, ["test:coverage:lcov"]);
           packageUtils.addScripts(pkg, {
             test: createTestCommand({
               workspacesPattern,
-              shouldUseExperimentalVmModules,
             }),
             "test:watch": createTestCommand({
               workspacesPattern,
-              shouldUseExperimentalVmModules,
               watch: true,
             }),
             "test:coverage": createTestCommand({
               workspacesPattern,
-              shouldUseExperimentalVmModules,
               coverage: true,
             }),
             "test:coverage:json": createTestCommand({
               workspacesPattern,
-              shouldUseExperimentalVmModules,
               coverageJson: true,
             }),
           });
-
-          if (isJestRunner) {
-            hasReact = yoConfigPobMonorepo.packageNames.some((pkgName) =>
-              pkgName.startsWith("react-"),
-            );
-
-            const jestConfig = this.fs.readJSON(jestConfigPath, pkg.jest ?? {});
-            delete pkg.jest;
-
-            const srcDirectory = this.options.srcDirectory;
-            Object.assign(jestConfig, {
-              cacheDirectory: "./node_modules/.cache/jest",
-              testEnvironment: "node",
-              testMatch: [
-                `<rootDir>/${workspacesPattern}/*/@(${srcDirectory}|lib)/**/__tests__/**/*.${
-                  transpileWithBabel ? "(ts|js|cjs|mjs)" : "(js|cjs|mjs)"
-                }${hasReact ? "?(x)" : ""}`,
-                `<rootDir>/${workspacesPattern}/*/@(${srcDirectory}|lib)/**/*.test.${
-                  transpileWithBabel ? "(ts|js|cjs|mjs)" : "(js|cjs|mjs)"
-                }${hasReact ? "?(x)" : ""}`,
-              ],
-            });
-
-            if (shouldUseExperimentalVmModules) {
-              jestConfig.extensionsToTreatAsEsm = [
-                transpileWithBabel && ".ts",
-                transpileWithBabel && hasReact && ".tsx",
-              ].filter(Boolean);
-            } else {
-              delete jestConfig.extensionsToTreatAsEsm;
-            }
-
-            writeAndFormatJson(this.fs, jestConfigPath, jestConfig);
-          }
         } else {
           const tsconfigTestPath = this.destinationPath("tsconfig.test.json");
           this.fs.delete(tsconfigTestPath);
@@ -500,26 +407,21 @@ export default class CommonTestingGenerator extends Generator {
               pkg.pob?.bundler === "rollup-babel" ||
               pkg.pob?.typescript;
 
-            const shouldUseExperimentalVmModules =
-              pkg.type === "module" && !inMonorepo;
-
             packageUtils.removeScripts(pkg, ["test:coverage:lcov"]);
             packageUtils.addScripts(pkg, {
-              test: createTestCommand({ shouldUseExperimentalVmModules }),
+              test: createTestCommand({}),
               "test:watch": createTestCommand({
-                shouldUseExperimentalVmModules,
                 watch: true,
               }),
               "test:coverage": createTestCommand({
-                shouldUseExperimentalVmModules,
                 coverage: true,
               }),
               "test:coverage:json": createTestCommand({
-                shouldUseExperimentalVmModules,
                 coverageJson: true,
               }),
             });
 
+            // TODO migrate some config to vitest. Keeping this if until then.
             if (testRunner === "jest") {
               const srcDirectory = this.options.build
                 ? this.options.srcDirectory
@@ -561,7 +463,7 @@ export default class CommonTestingGenerator extends Generator {
                   [hasReact ? "^.+\\.tsx?$" : "^.+\\.ts$"]: [
                     "jest-esbuild",
                     {
-                      format: shouldUseExperimentalVmModules ? "esm" : "cjs",
+                      // format: shouldUseExperimentalVmModules ? "esm" : "cjs",
                     },
                   ],
                 };
@@ -583,15 +485,6 @@ export default class CommonTestingGenerator extends Generator {
                 }
               }
 
-              if (shouldUseExperimentalVmModules) {
-                jestConfig.extensionsToTreatAsEsm = [
-                  withTypescript && ".ts",
-                  withTypescript && hasReact && ".tsx",
-                ].filter(Boolean);
-              } else {
-                delete jestConfig.extensionsToTreatAsEsm;
-              }
-
               if (
                 !pkg.pob?.envs ||
                 pkg.pob?.envs.length === 0 ||
@@ -603,45 +496,20 @@ export default class CommonTestingGenerator extends Generator {
                 delete jestConfig.testEnvironment;
               }
 
-              writeAndFormatJson(this.fs, jestConfigPath, jestConfig);
+              await writeAndFormatJson(this.fs, jestConfigPath, jestConfig);
             }
           }
         }
       }
     }
 
-    if (
-      this.options.enable &&
-      transpileWithBabel &&
-      ((this.options.monorepo && globalTesting) || !globalTesting) &&
-      testRunner === "jest"
-    ) {
-      // cjs for jest compat
-      copyAndFormatTpl(
-        this.fs,
-        this.templatePath("babel.config.cjs.ejs"),
-        this.destinationPath("babel.config.cjs"),
-        {
-          only: !this.options.monorepo
-            ? `'${this.options.srcDirectory}'`
-            : pkg.workspaces
-                .flatMap((workspace) => [
-                  `'${workspace}/${this.options.srcDirectory}'`,
-                  `'${workspace}/lib'`,
-                ])
-                .join(", "),
-          hasReact,
-          hasLinaria:
-            !!pkg.devDependencies?.["@linaria/babel-preset"] ||
-            !!pkg.devDependencies?.["alp-dev"],
-          testing: this.options.testing,
-          jestExperimentalESM: pkg.type === "module",
-        },
-      );
-    } else {
-      this.fs.delete("babel.config.cjs");
-    }
+    // legacy jest babel config
+    this.fs.delete("babel.config.cjs");
 
-    writeAndFormatJson(this.fs, this.destinationPath("package.json"), pkg);
+    return writeAndFormatJson(
+      this.fs,
+      this.destinationPath("package.json"),
+      pkg,
+    );
   }
 }

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -623,7 +623,7 @@ export default class CommonTranspilerGenerator extends Generator {
     this.fs.writeJSON(this.destinationPath("package.json"), pkg);
   }
 
-  writing() {
+  async writing() {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const entries = pkg.pob.entries || ["index"];
     const envs = pkg.pob.envs || pkg.pob.babelEnvs;
@@ -715,7 +715,7 @@ export default class CommonTranspilerGenerator extends Generator {
         pkg.pob.bundler?.startsWith("rollup"))
     ) {
       if (this.options.isApp) {
-        copyAndFormatTpl(
+        await copyAndFormatTpl(
           this.fs,
           this.templatePath("app.rollup.config.mjs.ejs"),
           this.destinationPath("rollup.config.mjs"),
@@ -727,7 +727,7 @@ export default class CommonTranspilerGenerator extends Generator {
           },
         );
       } else {
-        copyAndFormatTpl(
+        await copyAndFormatTpl(
           this.fs,
           this.templatePath("lib.rollup.config.mjs.ejs"),
           this.destinationPath("rollup.config.mjs"),

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -115,15 +115,37 @@ export default class CommonTypescriptGenerator extends Generator {
       default: false,
       description: "only check js",
     });
+
+    this.option("enableHashSlash", {
+      type: Boolean,
+      required: false,
+      default: false,
+      description: "enable #/ in paths",
+    });
   }
 
-  writing() {
+  default() {
+    if (this.options.baseUrl) {
+      throw new Error(
+        "baseUrl option is not longer supported. Use enableHashSlash instead.",
+      );
+    }
+  }
+
+  async writing() {
     if (this.fs.exists("flow-typed")) this.fs.delete("flow-typed");
     if (this.fs.exists(this.destinationPath(".flowconfig"))) {
       this.fs.delete(this.destinationPath(".flowconfig"));
     }
 
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
+    const envs = pkg.pob?.envs || [
+      {
+        target: "node",
+        version: `${maintenanceLTS}`,
+      },
+    ];
+    const withNode = envs.some((env) => env.target === "node");
 
     const presets = (() => {
       const babelEnvs =
@@ -144,12 +166,7 @@ export default class CommonTypescriptGenerator extends Generator {
         const nodeVersion = this.options.onlyLatestLTS
           ? `${latestLTS}`
           : `${maintenanceLTS}`;
-        const envs = pkg.pob?.envs || [
-          {
-            target: "node",
-            version: `${maintenanceLTS}`,
-          },
-        ];
+
         if (
           pkg.pob.rollup === false ||
           pkg.pob.bundler === false ||
@@ -177,6 +194,9 @@ export default class CommonTypescriptGenerator extends Generator {
       }
 
       if (this.options.dom) {
+        if (this.options.isApp && pkg.devDependencies?.vite) {
+          return ["@pob/root/tsconfigs/targets/vite.json"];
+        }
         return ["@pob/root/tsconfigs/targets/webpack.json"];
       }
       return [];
@@ -236,9 +256,7 @@ export default class CommonTypescriptGenerator extends Generator {
                   packageName[0] === "@"
                     ? // eslint-disable-next-line unicorn/no-nested-ternary
                       yoConfig.pob.project.type === "app"
-                      ? `packages/${packageName.slice(
-                          packageName.indexOf("/") + 1,
-                        )}`
+                      ? `packages/${packageName.slice(packageName.indexOf("/") + 1)}`
                       : packageName
                     : `packages/${packageName}`
                 }`,
@@ -259,9 +277,7 @@ export default class CommonTypescriptGenerator extends Generator {
           monorepoPackageSrcPaths = [...packageLocations.entries()].map(
             ([packageName, packageLocation]) => [
               packageName,
-              `${packageLocation}/${
-                isTypescriptPackageMap.get(packageName) ? "src" : "lib"
-              }`,
+              `${packageLocation}/${isTypescriptPackageMap.get(packageName) ? "src" : "lib"}`,
             ],
           );
           monorepoPackageReferences = yoConfig.pob.monorepo.packageNames
@@ -289,7 +305,7 @@ export default class CommonTypescriptGenerator extends Generator {
       - allows IDE and typedoc to behave correctly
       - generate useless definition files for not excluded tests files. However, it also use them for cache.
       */
-      copyAndFormatTpl(
+      await copyAndFormatTpl(
         this.fs,
         this.options.onlyCheck
           ? this.templatePath("tsconfig.check-js.json.ejs")
@@ -306,6 +322,7 @@ export default class CommonTypescriptGenerator extends Generator {
           monorepoPackageReferences,
           rootDir: this.options.rootDir,
           srcDirectory: this.options.srcDirectory || this.options.rootDir,
+          enableHashSlash: this.options.enableHashSlash,
           scriptsDirectory: this.fs.exists(this.destinationPath("scripts"))
             ? "scripts"
             : undefined,
@@ -319,7 +336,6 @@ export default class CommonTypescriptGenerator extends Generator {
             (!this.options.isApp || this.options.isAppLibrary),
           incremental: monorepoComposite,
           dom,
-          baseUrl: this.options.baseUrl,
           resolveJsonModule: this.options.resolveJsonModule,
           forceExcludeNodeModules: this.options.forceExcludeNodeModules,
           forceAllowJs: this.options.forceAllowJs,
@@ -327,6 +343,7 @@ export default class CommonTypescriptGenerator extends Generator {
           additionalIncludes: this.options.additionalIncludes
             .split(",")
             .filter(Boolean),
+          node: withNode,
           presets,
         },
       );
@@ -335,7 +352,7 @@ export default class CommonTypescriptGenerator extends Generator {
       //   this.options.builddefs // &&
       //   // (!composite || monorepoPackageNames.length !== 0)
       // ) {
-      //   copyAndFormatTpl(
+      //   await copyAndFormatTpl(
       //     this.fs,
       //     this.templatePath('tsconfig.build.json.ejs'),
       //     tsconfigBuildPath,

package/lib/generators/common/typescript/templates/tsconfig.check-js.json.ejs

@@ -10,6 +10,9 @@
     "tsBuildInfoFile": "node_modules/.cache/tsc/tsbuildinfo",
 <% if (composite) { -%>
     "composite": true,
+<% } -%>
+<% if (node) { -%>
+    "types": ["node"],
 <% } -%>
     "noEmit": true
   },

package/lib/generators/common/typescript/templates/tsconfig.json.ejs

@@ -17,9 +17,6 @@
 <% } -%>
   "compilerOptions": {
     "rootDir": "<%= rootDir %>",
-<% if (baseUrl !== 'none') { -%>
-    "baseUrl": "<%= baseUrl %>", /* Base directory to resolve non-absolute module names. */
-<% } -%>
 <% if (emitDefinitions || build) { -%>
     "outDir": "<%= build ? 'dist' : 'dist/definitions' %>",
     <% if (build) { -%>
@@ -87,12 +84,16 @@
     "esModuleInterop": true<% if (monorepoPackageSrcPaths) { %>,<% } %>                  /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
 <% } -%>
 
-    <% if (monorepoPackageSrcPaths && monorepoPackageSrcPaths.length !== 0) { -%>
+    <% if (monorepoPackageSrcPaths && monorepoPackageSrcPaths.length !== 0 || enableHashSlash) { -%>
     "paths": {
-      <% monorepoPackageSrcPaths.forEach(([packageName, packageLocation], index) => { %>
+      <% if (enableHashSlash) { -%>
+        "#/*": ["./<%= srcDirectory %>/*"]<% if (monorepoPackageSrcPaths && monorepoPackageSrcPaths.length !== 0) { -%>,<% } %>
+      <% }  if (monorepoPackageSrcPaths && monorepoPackageSrcPaths.length !== 0) { -%>
+      <% monorepoPackageSrcPaths.forEach(([packageName, packageLocation], index) => { -%>
       "<%= packageName %>": ["<%= packageLocation %>"],
       "<%= packageName %>/*": ["<%= packageLocation %>/*"]<%= index === monorepoPackageSrcPaths.length -1 ? '' : ',' -%>
       <% }) %>
+      <% } %>
     }<% } %>
   }<% if (monorepoPackageReferences && monorepoPackageReferences.length) { -%>,
   "references": [

package/lib/generators/core/bun/templates/bunfig.toml.ejs

@@ -1,4 +1,4 @@
 [install]
 # Only install package versions published at least 3 days ago
 minimumReleaseAge = 259200 # seconds - in #23162 it'll allow "3d" too
-minimumReleaseAgeExcludes = ["@pob/root", "@pob/esbuild", "@pob/pretty-pkg", "@pob/rollup", "@pob/rollup-esbuild", "@pob/rollup-typescript", "@pob/sort-object", "@pob/sort-pkg", "@pob/version", "pob-dependencies", "pob-dependencies", "alouette", "alouette-icons", "nightingale", "nightingale-logger"]
+minimumReleaseAgeExcludes = ["@pob/root", "@pob/esbuild", "@pob/rollup", "@pob/rollup-esbuild", "@pob/rollup-typescript", "@pob/sort-object", "@pob/sort-pkg", "@pob/version", "pob-dependencies", "pob-dependencies", "alouette", "alouette-icons", "nightingale", "nightingale-logger"]

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -2,7 +2,6 @@ import fs from "node:fs";
 import Generator from "yeoman-generator";
 import inMonorepo from "../../../utils/inMonorepo.js";
 import { latestLTS, maintenanceLTS } from "../../../utils/nodeVersions.js";
-import * as packageUtils from "../../../utils/package.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
 
 export const ciContexts = [];
@@ -37,8 +36,7 @@ export default class CoreCIGenerator extends Generator {
     this.option("testRunner", {
       type: String,
       required: false,
-      default: "jest",
-      description: "test runner: jest | node",
+      description: "test runner: vitest | node",
     });
 
     this.option("e2eTesting", {
@@ -98,7 +96,7 @@ export default class CoreCIGenerator extends Generator {
     });
   }
 
-  default() {
+  async default() {
     if (fs.existsSync(this.destinationPath(".circleci"))) {
       fs.rmdirSync(this.destinationPath(".circleci"), { recursive: true });
     }
@@ -111,7 +109,7 @@ export default class CoreCIGenerator extends Generator {
         this.options.testing && !!pkg.scripts && !!pkg.scripts.test;
       const build = this.options.build;
 
-      copyAndFormatTpl(
+      await copyAndFormatTpl(
         this.fs,
         this.templatePath(
           this.options.splitJobs
@@ -169,7 +167,7 @@ export default class CoreCIGenerator extends Generator {
       !this.options.isApp &&
       this.options.documentation
     ) {
-      copyAndFormatTpl(
+      await copyAndFormatTpl(
         this.fs,
         this.templatePath("github-action-documentation-workflow.yml.ejs"),
         this.destinationPath(".github/workflows/gh-pages.yml"),
@@ -193,12 +191,6 @@ export default class CoreCIGenerator extends Generator {
     this.fs.delete(this.destinationPath(".travis.yml"));
     this.fs.delete(this.destinationPath("circle.yml"));
 
-    if (!this.options.enable) {
-      packageUtils.removeDevDependencies(pkg, ["jest-junit-reporter"]);
-    } else {
-      packageUtils.removeDevDependencies(pkg, ["jest-junit-reporter"]);
-    }
-
     this.fs.writeJSON(this.destinationPath("package.json"), pkg);
   }
 }

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -85,8 +85,8 @@ jobs:
         run: yarn install --immutable --immutable-cache
 <% } -%>
 
-      - name: Prettier
-        run: <%= packageManager %> run lint:prettier
+      - name: Format
+        run: <%= packageManager %> run format:check
 <% if (typescript) { -%>
 
       - name: Typescript

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -58,8 +58,8 @@ jobs:
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
 
 <% } -%>
-      - name: Prettier
-        run: <%= packageManager %> run lint:prettier
+      - name: Format
+        run: <%= packageManager %> run format:check
         if: startsWith(matrix.node-version, '<%= nodeLatestMajorVersion %>.')
 <% if (typescript) { -%>
 

package/lib/generators/core/package/CorePackageGenerator.js

@@ -234,9 +234,7 @@ export default class CorePackageGenerator extends Generator {
         pkg,
         doesMjsCheckPackagesExists || doesJsCheckPackagesExists,
         {
-          checks: `node scripts/check-packages.${
-            doesMjsCheckPackagesExists ? "mjs" : "js"
-          }`,
+          checks: `node scripts/check-packages.${doesMjsCheckPackagesExists ? "mjs" : "js"}`,
         },
       );
     } else if (inMonorepo && !inMonorepo.root) {
@@ -300,9 +298,7 @@ export default class CorePackageGenerator extends Generator {
         url: props.authorUrl || (author && author.url),
       };
 
-      pkg.author = `${author.name} <${author.email}>${
-        author.url ? ` (${author.url})` : ""
-      }`;
+      pkg.author = `${author.name} <${author.email}>${author.url ? ` (${author.url})` : ""}`;
     }
 
     if (!pkg.license) {

package/lib/generators/core/renovate/CoreRenovateGenerator.js

@@ -81,7 +81,7 @@ export default class CoreRenovateGenerator extends Generator {
         ].filter(Boolean);
       }
 
-      writeAndFormatJson(
+      return writeAndFormatJson(
         this.fs,
         this.destinationPath("renovate.json"),
         renovateConfig,

package/lib/generators/core/sort-package/CoreSortPackageGenerator.js

@@ -5,7 +5,7 @@ import { writeAndFormatJson } from "../../../utils/writeAndFormat.js";
 export default class CoreSortPackageGenerator extends Generator {
   writing() {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
-    writeAndFormatJson(
+    return writeAndFormatJson(
       this.fs,
       this.destinationPath("package.json"),
       // eslint-disable-next-line unicorn/no-array-sort