pob 29.7.0 → 29.9.0

package/CHANGELOG.md

@@ -3,6 +3,30 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [29.9.0](https://github.com/christophehurpeau/pob/compare/pob@29.8.0...pob@29.9.0) (2025-11-18)
+
+### Features
+
+* **deps:** update yarn monorepo ([#2631](https://github.com/christophehurpeau/pob/issues/2631))
+* improve config for expo/storybook/e2e
+
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: @pob/root
+
+
+## [29.8.0](https://github.com/christophehurpeau/pob/compare/pob@29.7.0...pob@29.8.0) (2025-11-04)
+
+### Features
+
+* add ios and android folder in gitignore for expo project
+
+### Bug Fixes
+
+* **deps:** update dependency eslint to v9.39.1 ([#2626](https://github.com/christophehurpeau/pob/issues/2626))
+
+Version bump for dependency: @pob/root
+
+
 ## [29.7.0](https://github.com/christophehurpeau/pob/compare/pob@29.6.0...pob@29.7.0) (2025-11-02)
 
 ### Features

package/lib/generators/app/PobAppGenerator.js

@@ -128,6 +128,13 @@ export default class PobAppGenerator extends Generator {
         default: !config || false,
         when: (values) => values.testing,
       },
+      {
+        type: "confirm",
+        name: "storybook",
+        message: "Do you want storybook ?",
+        default: (config && config.storybook) || false,
+        when: (values) => values.type === "expo",
+      },
     ]);
 
     this.config.set("app", this.appConfig);
@@ -235,7 +242,8 @@ export default class PobAppGenerator extends Generator {
           this.appConfig.type === "alp" ||
           this.appConfig.type === "vite" ||
           this.appConfig.type === "alp-node" ||
-          this.appConfig.type === "next.js"
+          this.appConfig.type === "next.js" ||
+          this.appConfig.type === "expo"
         ) {
           return `./${srcDirectory}`;
         }
@@ -260,14 +268,10 @@ export default class PobAppGenerator extends Generator {
 
     this.composeWith("pob:common:remove-old-dependencies");
 
-    const enableReleasePlease =
-      !inMonorepo && this.appConfig.testing && this.options.ci;
-
     if (this.appConfig.type !== "remix") {
       this.composeWith("pob:common:testing", {
         enable: this.appConfig.testing,
         disableYarnGitCache: this.options.disableYarnGitCache,
-        enableReleasePlease,
         testing: this.appConfig.testing,
         runner: this.appConfig.testing
           ? (inMonorepo
@@ -294,6 +298,7 @@ export default class PobAppGenerator extends Generator {
       this.composeWith("pob:common:format-lint", {
         isApp: true,
         documentation: false,
+        storybook: pkg?.devDependencies?.storybook,
         testing: this.appConfig.testing,
         testRunner: this.appConfig.testRunner,
         babel,
@@ -318,7 +323,6 @@ export default class PobAppGenerator extends Generator {
         enablePublish: false,
         withBabel: babel,
         isMonorepo: false,
-        enableYarnVersion: true,
         ci: this.options.ci,
         disableYarnGitCache: this.options.disableYarnGitCache,
         updateOnly: this.options.updateOnly,

package/lib/generators/app/ignorePaths.js

@@ -17,10 +17,12 @@ export const appIgnorePaths = {
   "untranspiled-library": (config) => [],
   "alp-node": (config) => ["/build"],
   other: (config) => [],
-  storybook: (config) => [],
+  storybook: (config) => ["/.storybook/storybook.requires.ts"],
   expo: (config) => [
     "/.expo/",
     "/src/tamagui-web.css",
+    "/android/",
+    "/ios/",
     "/dist/",
     "*.jks",
     "*.p8",
@@ -28,6 +30,7 @@ export const appIgnorePaths = {
     "*.key",
     "*.mobileprovision",
     "*.orig.*",
+    "*.icon/",
 
     // only if option is enabled which is not by default
     // '# Temporary files created by Metro to check the health of the file watcher',

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -5,7 +5,7 @@ import * as packageUtils from "../../../utils/package.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
 import { appIgnorePaths } from "../../app/ignorePaths.js";
 
-export default class CommonLintGenerator extends Generator {
+export default class CommonFormatLintGenerator extends Generator {
   constructor(args, opts) {
     super(args, opts);
 
@@ -69,6 +69,13 @@ export default class CommonLintGenerator extends Generator {
       description: "Enable resolving from src directory",
     });
 
+    this.option("storybook", {
+      type: Boolean,
+      required: false,
+      default: false,
+      description: "Enable storybook",
+    });
+
     this.option("rootAsSrc", {
       type: Boolean,
       required: false,
@@ -203,7 +210,7 @@ export default class CommonLintGenerator extends Generator {
           hasApp: this.options.hasApp,
           rootIgnorePatterns: [...rootIgnorePatterns],
           ignorePatterns: [...ignorePatterns],
-          storybook: !!pkg.devDependencies?.storybook,
+          storybook: this.options.storybook,
         },
       );
     } else if (this.fs.exists(this.destinationPath(".prettierignore"))) {
@@ -438,6 +445,9 @@ export default class CommonLintGenerator extends Generator {
     this.fs.delete(invalidEslintConfigPath);
 
     if (!inMonorepo || inMonorepo.root) {
+      const rootIgnorePaths = this.options.rootIgnorePaths
+        .split("\n")
+        .filter(Boolean);
       const getRootIgnorePatterns = () => {
         const ignorePatterns = new Set();
 
@@ -451,10 +461,7 @@ export default class CommonLintGenerator extends Generator {
 
         if ((!inMonorepo || !inMonorepo.root) && useTypescript) {
           const buildPath = `/${this.options.buildDirectory}`;
-          if (
-            !this.options.rootIgnorePaths ||
-            !this.options.rootIgnorePaths.includes(buildPath)
-          ) {
+          if (!rootIgnorePaths.includes(buildPath)) {
             ignorePatterns.add(buildPath);
           }
         }
@@ -462,14 +469,11 @@ export default class CommonLintGenerator extends Generator {
           ignorePatterns.add("/rollup.config.mjs");
         }
 
-        if (this.options.rootIgnorePaths) {
-          this.options.rootIgnorePaths
-            .split("\n")
-            .filter(Boolean)
-            .forEach((ignorePath) => {
-              if (ignorePath.startsWith("#")) return;
-              ignorePatterns.add(ignorePath);
-            });
+        if (rootIgnorePaths) {
+          rootIgnorePaths.forEach((ignorePath) => {
+            if (ignorePath.startsWith("#")) return;
+            ignorePatterns.add(ignorePath);
+          });
         }
 
         return ignorePatterns;

package/lib/generators/common/format-lint/templates/prettierignore.ejs

@@ -3,9 +3,6 @@ CHANGELOG.md
 <% if (documentation) { -%>
 /docs
 <% } -%>
-<% if (storybook) { -%>
-storybook.requires.ts
-<% } -%>
 <% if (packageManager === 'yarn' && inRoot) { -%>
 /.yarn/**/*
 <% if (yarnNodeLinker === 'pnp') { -%>

package/lib/generators/common/release/CommonReleaseGenerator.js

@@ -37,12 +37,6 @@ export default class CommonReleaseGenerator extends Generator {
       description: "is monorepo",
     });
 
-    this.option("enableYarnVersion", {
-      type: Boolean,
-      default: true,
-      description: "enable yarn version conventional commits",
-    });
-
     this.option("ci", {
       type: Boolean,
       required: true,
@@ -88,7 +82,6 @@ export default class CommonReleaseGenerator extends Generator {
         {
           packageManager: this.options.packageManager,
           enablePublish: this.options.enablePublish,
-          enableYarnVersion: this.options.enableYarnVersion,
           disableYarnGitCache: this.options.disableYarnGitCache,
           isMonorepo: this.options.isMonorepo,
           isMonorepoIndependent:

package/lib/generators/common/release/templates/workflow-release.yml.ejs

@@ -12,7 +12,7 @@ on:
         required: false
         type: boolean
         default: false
-<% if (enableYarnVersion && isMonorepo && isMonorepoIndependent) { -%>
+<% if (isMonorepo && isMonorepoIndependent) { -%>
       bump-dependents-highest-as:
         description: "Bump dependents highest as"
         required: false
@@ -70,11 +70,8 @@ jobs:
 
       - name: New version (dry run)
         if: github.ref == 'refs/heads/main' && inputs.dry-run
-<% if (enableYarnVersion) { -%>
         run: yarn yarn-version version --dry-run<% if (isMonorepo && isMonorepoIndependent) { %> --bump-dependents-highest-as=${{ inputs.bump-dependents-highest-as }}<% } %>
-<% } else { -%>
-        run: yarn lerna version --yes --no-push --exact --conventional-commits --conventional-graduate --changelog-preset conventional-changelog-conventionalcommits --no-git-tag-version --loglevel=verbose
-<% } -%>
+
       - name: Configure Git user
         if: github.ref == 'refs/heads/main' && !inputs.dry-run
         run: |
@@ -84,11 +81,7 @@ jobs:
       - name: New version
         if: github.ref == 'refs/heads/main' && !inputs.dry-run
         run: |
-<% if (enableYarnVersion) { -%>
           yarn yarn-version version --create-release=github <% if (isMonorepo && isMonorepoIndependent) { %> --bump-dependents-highest-as=${{ inputs.bump-dependents-highest-as }}<% } %> -m 'chore: release <%- isMonorepoIndependent ? '' : '%v ' %>[skip ci]<%- isMonorepoIndependent ? '\\n\\n%t' : '' %>'
-<% } else { -%>
-          yarn lerna version --yes --push --exact --conventional-commits --conventional-graduate --changelog-preset conventional-changelog-conventionalcommits --create-release=github -m 'chore: release [skip ci]'
-<% } -%>
         env:
           HUSKY: 0
           GH_TOKEN: ${{ secrets.GH_TOKEN }}

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -30,18 +30,6 @@ export default class CommonTestingGenerator extends Generator {
       description: "test runner (jest or node)",
     });
 
-    this.option("enableReleasePlease", {
-      type: Boolean,
-      default: true,
-      description: "enable release-please",
-    });
-
-    this.option("enableYarnVersion", {
-      type: Boolean,
-      default: true,
-      description: "enable yarn version conventional commits",
-    });
-
     this.option("ci", {
       type: Boolean,
       required: true,
@@ -128,8 +116,6 @@ export default class CommonTestingGenerator extends Generator {
     if (!inMonorepo || inMonorepo.root) {
       this.composeWith("pob:core:ci", {
         enable: this.options.ci,
-        enableReleasePlease: this.options.enableReleasePlease,
-        enableYarnVersion: this.options.enableYarnVersion,
         disableYarnGitCache: this.options.disableYarnGitCache,
         testing: this.options.enable,
         testRunner: this.options.runner,

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -171,7 +171,7 @@ export default class CommonTypescriptGenerator extends Generator {
         return ["@pob/root/tsconfigs/targets/rollup-es2015.json"];
       }
 
-      if (this.options.isApp && pkg.devDependencies?.expo) {
+      if (this.options.isApp && pkg.dependencies?.expo) {
         return ["@pob/root/tsconfigs/targets/expo.json"];
       }
 

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -17,18 +17,6 @@ export default class CoreCIGenerator extends Generator {
       description: "enable ci",
     });
 
-    this.option("enableReleasePlease", {
-      type: Boolean,
-      default: true,
-      description: "enable release-please",
-    });
-
-    this.option("enableYarnVersion", {
-      type: Boolean,
-      default: true,
-      description: "enable yarn version conventional commits",
-    });
-
     this.option("build", {
       type: Boolean,
       default: true,
@@ -104,30 +92,6 @@ export default class CoreCIGenerator extends Generator {
     });
   }
 
-  async prompting() {
-    const pkg = this.fs.readJSON(this.destinationPath("package.json"));
-
-    this.isReleasePleaseEnabled =
-      this.options.enableReleasePlease &&
-      !this.options.enableYarnVersion &&
-      !pkg.devDependencies?.["standard-version"];
-
-    if (
-      this.options.enableReleasePlease &&
-      !process.env.CI &&
-      !this.isReleasePleaseEnabled &&
-      !this.options.enableYarnVersion
-    ) {
-      const { enableReleasePlease } = await this.prompt({
-        type: "confirm",
-        name: "enableReleasePlease",
-        message: "Would you like to enable release please ?",
-        default: true,
-      });
-      this.isReleasePleaseEnabled = enableReleasePlease;
-    }
-  }
-
   default() {
     if (fs.existsSync(this.destinationPath(".circleci"))) {
       fs.rmdirSync(this.destinationPath(".circleci"), { recursive: true });

package/lib/generators/lib/PobLibGenerator.js

@@ -304,12 +304,9 @@ export default class PobLibGenerator extends Generator {
 
     this.composeWith("pob:common:remove-old-dependencies");
 
-    const enableReleasePlease = !inMonorepo && this.options.ci;
-
     this.composeWith("pob:common:testing", {
       enable: this.pobjson.testing,
       disableYarnGitCache: this.options.disableYarnGitCache,
-      enableReleasePlease,
       testing: this.pobjson.testing,
       e2eTesting: false,
       runner: this.pobjson.testing
@@ -336,6 +333,7 @@ export default class PobLibGenerator extends Generator {
       documentation:
         !!this.pobjson.documentation ||
         !!(this.pobjson.testing && this.pobjson.testing.codecov),
+      storybook: pkg?.devDependencies?.storybook,
       testing: !!this.pobjson.testing,
       testRunner: inMonorepo
         ? inMonorepo.pobMonorepoConfig.testRunner
@@ -365,7 +363,6 @@ export default class PobLibGenerator extends Generator {
       withBabel,
       withTypescript,
       isMonorepo: false,
-      enableYarnVersion: true,
       ci: this.options.ci,
       disableYarnGitCache: this.options.disableYarnGitCache,
       updateOnly: this.options.updateOnly,

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -60,6 +60,17 @@ const hasBuild = (packages, configs) =>
       ),
   );
 
+const hasData = (packages, configs) =>
+  configs.some(
+    (config, index) =>
+      !!(
+        config &&
+        config.project &&
+        config.project.type === "app" &&
+        config.app.type === "alp-node"
+      ),
+  );
+
 const hasTamagui = (packages, configs) =>
   packages.some(
     (pkg) =>
@@ -180,6 +191,13 @@ export default class PobMonorepoGenerator extends Generator {
         when: (answers) => answers.ci,
         default: config ? config.testing : true,
       },
+      {
+        type: "confirm",
+        name: "e2eTesting",
+        message: "Would you like e2e testing ?",
+        when: (answers) => answers.ci,
+        default: config ? config.e2eTesting : true,
+      },
       {
         type: "confirm",
         name: "codecov",
@@ -229,8 +247,6 @@ export default class PobMonorepoGenerator extends Generator {
 
     this.composeWith("pob:common:husky", {});
 
-    const isYarnVersionEnabled = this.pobLernaConfig.ci;
-
     const splitCIJobs = this.packageNames.length > 8;
 
     this.composeWith("pob:common:testing", {
@@ -238,8 +254,6 @@ export default class PobMonorepoGenerator extends Generator {
       enable: this.pobLernaConfig.testing,
       runner: this.pobLernaConfig.testRunner || "jest",
       disableYarnGitCache: this.options.disableYarnGitCache,
-      enableReleasePlease: false,
-      enableYarnVersion: isYarnVersionEnabled,
       testing: this.pobLernaConfig.testing,
       e2eTesting: this.pobLernaConfig.e2eTesting,
       build: this.pobLernaConfig.typescript === true,
@@ -253,6 +267,11 @@ export default class PobMonorepoGenerator extends Generator {
       splitCIJobs,
     });
 
+    const rootIgnorePaths = [
+      this.pobLernaConfig.e2eTesting && "/playwright-report/",
+      this.pobLernaConfig.e2eTesting && "/test-results/",
+    ].filter(Boolean);
+
     const gitignorePaths = [
       hasTamagui(this.packages, this.packageConfigs) && ".tamagui",
     ].filter(Boolean);
@@ -260,6 +279,7 @@ export default class PobMonorepoGenerator extends Generator {
     this.composeWith("pob:common:format-lint", {
       monorepo: true,
       documentation: this.pobLernaConfig.documentation,
+      storybook: pkg?.devDependencies?.storybook,
       typescript: this.pobLernaConfig.typescript,
       build: this.pobLernaConfig.typescript === true,
       testing: this.pobLernaConfig.testing,
@@ -271,10 +291,11 @@ export default class PobMonorepoGenerator extends Generator {
         ...gitignorePaths.map((path) => `/${path}`),
         hasDist(this.packages, this.packageConfigs) && "/dist",
         hasBuild(this.packages, this.packageConfigs) && "/build",
+        hasData(this.packages, this.packageConfigs) && "/data",
       ]
         .filter(Boolean)
         .join("\n"),
-      rootIgnorePaths: [],
+      rootIgnorePaths: rootIgnorePaths.join("\n"),
     });
 
     this.composeWith("pob:lib:doc", {
@@ -304,7 +325,11 @@ export default class PobMonorepoGenerator extends Generator {
       documentation: this.pobLernaConfig.documentation,
       testing: this.pobLernaConfig.testing,
       // TODO add workspaces paths like we do in format-lint
-      paths: gitignorePaths.join("\n"),
+      paths: [
+        // TODO remove gitignorePaths
+        ...gitignorePaths,
+        ...rootIgnorePaths,
+      ].join("\n"),
       // todo: fix this using workspaces
       // buildDirectory: this.pobLernaConfig.typescript ? `/*/build` : "",
     });
@@ -317,7 +342,6 @@ export default class PobMonorepoGenerator extends Generator {
       enablePublish: !this.options.isAppProject,
       withBabel: this.pobLernaConfig.typescript,
       isMonorepo: true,
-      enableYarnVersion: isYarnVersionEnabled,
       ci: this.pobLernaConfig.ci,
       disableYarnGitCache: this.options.disableYarnGitCache,
       updateOnly: this.options.updateOnly,

package/lib/generators/monorepo/lerna/MonorepoLernaGenerator.js

@@ -100,9 +100,6 @@ export default class MonorepoLernaGenerator extends Generator {
     packageUtils.removeDependencies(pkg, ["lerna"]);
     packageUtils.removeDevDependencies(pkg, ["lerna"]);
 
-    // TODO remove lerna completely
-    const isYarnVersionEnabled = true;
-
     const getPackagePobConfig = (config) => ({
       babelEnvs: [],
       ...(config && config.pob),
@@ -130,35 +127,25 @@ export default class MonorepoLernaGenerator extends Generator {
       lernaConfig.command.publish.ignoreChanges.push("**/tsconfig.json");
     }
 
-    if (isYarnVersionEnabled) {
-      if (pkg.version === "0.0.0" && lernaConfig && lernaConfig.version) {
-        if (lernaConfig.version === "independent") {
-          delete pkg.version;
-        } else {
-          pkg.version = lernaConfig.version;
-        }
+    if (pkg.version === "0.0.0" && lernaConfig && lernaConfig.version) {
+      if (lernaConfig.version === "independent") {
+        delete pkg.version;
+      } else {
+        pkg.version = lernaConfig.version;
       }
-      this.fs.delete(this.destinationPath("lerna.json"));
-    } else {
-      writeAndFormatJson(
-        this.fs,
-        this.destinationPath("lerna.json"),
-        lernaConfig,
-      );
     }
+    this.fs.delete(this.destinationPath("lerna.json"));
 
     if (this.fs.exists(this.destinationPath("lerna-debug.log"))) {
       this.fs.delete(this.destinationPath("lerna-debug.log"));
     }
 
-    packageUtils.addOrRemoveScripts(
-      pkg,
-      this.options.packageManager === "yarn" && !isYarnVersionEnabled,
-      {
-        version:
-          "YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn && git add yarn.lock",
-      },
-    );
+    if (
+      pkg.scripts?.version ===
+      "YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn && git add yarn.lock"
+    ) {
+      delete pkg.scripts.version;
+    }
 
     this.fs.writeJSON(this.destinationPath("package.json"), pkg);
   }

package/lib/generators/monorepo/workspaces/MonorepoWorkspacesGenerator.js

@@ -81,8 +81,6 @@ export default class MonorepoWorkspacesGenerator extends Generator {
       delete pkg.engines.yarn;
     }
 
-    const isYarnVersionEnabled = true;
-
     if (pkg.name !== "pob-monorepo") {
       packageUtils.addDevDependencies(pkg, ["repository-check-dirty"]);
     }
@@ -111,14 +109,12 @@ export default class MonorepoWorkspacesGenerator extends Generator {
             : "npm run lint:eslint --workspaces",
     });
 
-    packageUtils.addOrRemoveScripts(
-      pkg,
-      this.options.packageManager === "yarn" && !isYarnVersionEnabled,
-      {
-        version:
-          "YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn && git add yarn.lock",
-      },
-    );
+    if (
+      pkg.scripts?.version ===
+      "YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn && git add yarn.lock"
+    ) {
+      delete pkg.scripts.version;
+    }
 
     if (this.options.isAppProject) {
       packageUtils.addOrRemoveScripts(pkg, withBundler, {

package/lib/generators/pob/PobBaseGenerator.js

@@ -291,7 +291,7 @@ export default class PobBaseGenerator extends Generator {
 
   end() {
     if (this.isMonorepo && !this.options.updateOnly) {
-      console.log("To create a new lerna package: ");
+      console.log("To create a new monorepo package: ");
       console.log(" pob add <packageName>");
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "29.7.0",
+  "version": "29.9.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -50,12 +50,12 @@
     "@pob/sort-pkg": "12.1.0",
     "@prettier/sync": "0.6.1",
     "@types/inquirer": "9.0.9",
-    "@yarnpkg/cli": "4.10.3",
-    "@yarnpkg/core": "4.4.4",
-    "@yarnpkg/fslib": "3.1.3",
+    "@yarnpkg/cli": "4.11.0",
+    "@yarnpkg/core": "4.5.0",
+    "@yarnpkg/fslib": "3.1.4",
     "@yeoman/adapter": "3.1.0",
     "@yeoman/types": "1.8.0",
-    "eslint": "9.39.0",
+    "eslint": "9.39.1",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^9.0.0",
@@ -67,17 +67,17 @@
     "mem-fs-editor": "11.1.4",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "20.5.0",
+    "pob-dependencies": "20.6.0",
     "prettier": "3.6.2",
     "semver": "7.7.3",
     "typescript": "5.9.3",
     "validate-npm-package-name": "^6.0.2",
-    "yarn-workspace-utils": "9.4.1",
+    "yarn-workspace-utils": "9.5.0",
     "yeoman-environment": "5.0.0",
     "yeoman-generator": "7.5.1"
   },
   "devDependencies": {
-    "@pob/root": "19.7.0",
-    "@types/node": "22.18.13"
+    "@pob/root": "19.8.0",
+    "@types/node": "22.19.1"
   }
 }