pob 26.8.0 → 26.9.0

package/CHANGELOG.md

@@ -3,6 +3,20 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [26.9.0](https://github.com/christophehurpeau/pob/compare/pob@26.8.0...pob@26.9.0) (2025-02-22)
+
+### Features
+
+* use option check-latest: true in setup-node ci action ([63bdec9](https://github.com/christophehurpeau/pob/commit/63bdec956723a872f0bde486a9212c4cf60d2de0))
+
+### Reverts
+
+* Revert "feat: update node ci usage to 22.14" ([dab8648](https://github.com/christophehurpeau/pob/commit/dab86485e6eb0d833521660943b0db37aaa3d9f8))
+
+Version bump for dependency: @pob/sort-pkg
+Version bump for dependency: @pob/root
+
+
 ## [26.8.0](https://github.com/christophehurpeau/pob/compare/pob@26.7.0...pob@26.8.0) (2025-02-17)
 
 ### Features

package/lib/generators/common/release/templates/workflow-release.yml.ejs

@@ -36,7 +36,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 22.14
+          node-version: 22
+          check-latest: true
 
       - name: Check git tags
         if: github.ref == 'refs/heads/main' && !inputs.allow-no-tags

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -12,7 +12,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 22.14
+          node-version: 22
+          check-latest: true
 
 <% if (packageManager === 'yarn') { -%>
       - name: Enable Corepack

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -12,7 +12,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 22.14
+          node-version: 22
+          check-latest: true
 
       - name: Enable Corepack
         run: corepack enable
@@ -41,7 +42,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 22.14
+          node-version: 22
+          check-latest: true
 
       - name: Enable Corepack
         run: corepack enable
@@ -72,7 +74,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 22.14
+          node-version: 22
+          check-latest: true
 
       - name: Enable Corepack
         run: corepack enable
@@ -101,7 +104,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [20, 22.14]
+        node-version: [20, 22]
 
     steps:
       - uses: actions/checkout@v4
@@ -109,6 +112,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
+          check-latest: true
 
 <% if (packageManager === 'yarn') { -%>
       - name: Enable Corepack
@@ -131,17 +135,17 @@ jobs:
 <% if (codecov) { -%>
       - name: Test
         run: <%= packageManager %> run test
-        if: matrix.node-version != '22.14'
+        if: matrix.node-version != 22
 
       - name: Generate Test Coverage
         run: <%= packageManager %> run test:coverage:json
-        if: matrix.node-version == '22.14'
+        if: matrix.node-version == 22
         env:
           CI: true
 
       - name: Send results to codecov
         uses: codecov/codecov-action@v5
-        if: matrix.node-version == '22.14' && github.actor != 'dependabot[bot]'
+        if: matrix.node-version == 22 && github.actor != 'dependabot[bot]'
         with:
           fail_ci_if_error: true
           token: ${{ secrets.CODECOV_TOKEN }}
@@ -158,7 +162,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [22.14]
+        node-version: [22]
 
     steps:
       - uses: actions/checkout@v4
@@ -166,6 +170,7 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
+          check-latest: true
 
       - name: Enable Corepack
         run: corepack enable
@@ -191,7 +196,8 @@ jobs:
 
       - uses: actions/setup-node@v4
         with:
-          node-version: 22.14
+          node-version: 22
+          check-latest: true
 
       - uses: GoogleCloudPlatform/release-please-action@v3
         if: ${{ github.ref == 'refs/heads/main' }}

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [<% if (!onlyLatestLTS) { -%>20.x, <% } -%>22.14]
+        node-version: [<% if (!onlyLatestLTS) { -%>20.x, <% } -%>22.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -17,6 +17,7 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
+          check-latest: true
           registry-url: 'https://registry.npmjs.org'
 
 <% if (packageManager === 'yarn') { -%>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "26.8.0",
+  "version": "26.9.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -44,9 +44,8 @@
     "@pob/eslint-config": "59.7.0",
     "@pob/eslint-config-typescript": "59.7.0",
     "@pob/eslint-config-typescript-react": "59.7.0",
-    "@pob/sort-eslint-config": "8.0.0",
     "@pob/sort-object": "9.0.0",
-    "@pob/sort-pkg": "11.0.0",
+    "@pob/sort-pkg": "11.0.1",
     "@prettier/sync": "0.5.2",
     "@types/inquirer": "9.0.7",
     "@yarnpkg/cli": "4.6.0",
@@ -65,8 +64,8 @@
     "mem-fs-editor": "11.1.4",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "17.6.0",
-    "prettier": "3.5.1",
+    "pob-dependencies": "17.7.0",
+    "prettier": "3.5.2",
     "semver": "7.7.1",
     "typescript": "5.7.3",
     "validate-npm-package-name": "^6.0.0",
@@ -75,7 +74,7 @@
     "yeoman-generator": "7.4.0"
   },
   "devDependencies": {
-    "@pob/root": "16.6.0",
-    "@types/node": "22.13.4"
+    "@pob/root": "16.7.0",
+    "@types/node": "22.13.5"
   }
 }

package/lib/generators/common/format-lint/updateEslintConfig.js

@@ -1,155 +0,0 @@
-import sortConfig from "@pob/sort-eslint-config";
-
-function updateOverrides(config, testsOverride) {
-  const existingTestsOverrideIndex = !config.overrides
-    ? -1
-    : config.overrides.findIndex(
-        testsOverride.env?.jest
-          ? (override) => override.env && override.env.jest
-          : (override) =>
-              override?.env?.jest ||
-              override.extends?.includes(testsOverride.extends[0]),
-      );
-  if (!testsOverride) {
-    if (existingTestsOverrideIndex !== -1) {
-      config.overrides.splice(existingTestsOverrideIndex, 1);
-      if (config.overrides.length === 0) {
-        delete config.overrides;
-      }
-    }
-  } else {
-    if (testsOverride.rules && Object.keys(testsOverride.rules).length === 0) {
-      delete testsOverride.rules;
-    }
-
-    if (existingTestsOverrideIndex !== -1) {
-      const existingTestsOverride =
-        config.overrides[existingTestsOverrideIndex];
-      Object.assign(existingTestsOverride, testsOverride);
-
-      if (
-        existingTestsOverride.rules &&
-        Object.keys(existingTestsOverride.rules).length === 0
-      ) {
-        delete existingTestsOverride.rules;
-      }
-    } else {
-      if (!config.overrides) config.overrides = [];
-      config.overrides.push(testsOverride);
-    }
-  }
-  return config;
-}
-
-function updateParserAndPlugins(
-  config,
-  useTypescript,
-  globalEslint,
-  relativePath,
-) {
-  if (useTypescript) {
-    // webstorm uses this to detect eslint .ts compat
-    config.parser = "@typescript-eslint/parser";
-    config.plugins = ["@typescript-eslint"];
-
-    if (!globalEslint) {
-      config.parserOptions = {
-        project: "./tsconfig.json",
-        createDefaultProgram: true, // fix for lint-staged
-      };
-    } else {
-      config.parserOptions = {
-        // EXPERIMENTAL_useProjectService: true,
-        project: `${relativePath}/tsconfig.json`,
-      };
-    }
-  } else {
-    if (
-      config.parser === "typescript-eslint-parser" ||
-      config.parser === "@typescript-eslint/parser"
-    ) {
-      delete config.parser;
-    }
-    if (config.parserOptions && config.parserOptions.project) {
-      delete config.parserOptions;
-    }
-    if (
-      config.plugins &&
-      (config.plugins[0] === "typescript" ||
-        config.plugins[0] === "@typescript-eslint")
-    ) {
-      config.plugins.splice(0, 1);
-    }
-    if (config.plugins && config.plugins.length === 0) {
-      delete config.plugins;
-    }
-  }
-
-  return config;
-}
-
-function updateSettings(config, settings) {
-  Object.entries(settings).forEach(([key, value]) => {
-    if (value === false) {
-      if (config.settings) {
-        delete config.settings[key];
-      }
-    } else {
-      if (!config.settings) config.settings = {};
-      config.settings[key] = value;
-    }
-  });
-
-  if (config.settings && Object.keys(config.settings) === 0) {
-    delete config.settings;
-  }
-
-  return config;
-}
-
-function updateIgnorePatterns(config, ignorePatterns) {
-  if (!ignorePatterns) {
-    delete config.ignorePatterns;
-  } else {
-    config.ignorePatterns = ignorePatterns;
-  }
-  return config;
-}
-
-export default function updateEslintConfig(
-  config,
-  {
-    extendsConfig,
-    testsOverride,
-    useTypescript,
-    globalEslint,
-    settings,
-    ignorePatterns,
-    relativePath,
-  },
-) {
-  config.root = true;
-  config.extends = [
-    ...extendsConfig,
-    ...(config?.extends && Array.isArray(config.extends)
-      ? config.extends.filter(
-          (extendsValue) =>
-            extendsValue === "@pob/eslint-config-typescript/allow-unsafe",
-        )
-      : []),
-  ];
-
-  config = updateParserAndPlugins(
-    config,
-    useTypescript,
-    globalEslint,
-    relativePath,
-  );
-  config = updateOverrides(config, testsOverride);
-  if (settings) {
-    config = updateSettings(config, settings);
-  }
-  config = updateIgnorePatterns(config, ignorePatterns);
-
-  return sortConfig(config);
-}