pob 26.10.0 → 27.0.0

package/CHANGELOG.md

@@ -3,6 +3,34 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [27.0.0](https://github.com/christophehurpeau/pob/compare/pob@26.11.0...pob@27.0.0) (2025-04-27)
+
+### ⚠ BREAKING CHANGES
+
+* remove postinstallDev plugin
+
+### Features
+
+* remove postinstallDev plugin ([a0ddde0](https://github.com/christophehurpeau/pob/commit/a0ddde0cbd970bf7e4b698f735b849ca5440607e))
+
+Version bump for dependency: @pob/root
+
+
+## [26.11.0](https://github.com/christophehurpeau/pob/compare/pob@26.10.0...pob@26.11.0) (2025-03-15)
+
+### Features
+
+* **deps:** update yarn monorepo ([#2478](https://github.com/christophehurpeau/pob/issues/2478)) ([8b2de64](https://github.com/christophehurpeau/pob/commit/8b2de64cb6899a76ea716963911644a7b08182ae))
+* yarn 4.7 ([c9fcb63](https://github.com/christophehurpeau/pob/commit/c9fcb6322b8c14393c7632b501f2c48c80c308e9))
+
+### Bug Fixes
+
+* fix configure protection rule ([78c4ad3](https://github.com/christophehurpeau/pob/commit/78c4ad331cc820616246cc87374a27cdb0aecc8d))
+
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: @pob/root
+
+
 ## [26.10.0](https://github.com/christophehurpeau/pob/compare/pob@26.9.0...pob@26.10.0) (2025-03-14)
 
 ### Features

package/lib/generators/core/git/generators/github/CoreGitGithubGenerator.js

@@ -24,27 +24,45 @@ const putJson = (url, jsonBody) =>
     },
   }).then((res) => (res.ok ? res.json() : null));
 
-const configureProtectionRule = async (owner, repo, onlyLatestLTS) => {
+const configureProtectionRule = async (
+  owner,
+  repo,
+  onlyLatestLTS,
+  spawnCommandSync,
+) => {
   if (!ciContexts || ciContexts.length === 0) {
     throw new Error("Invalid ciContexts: []");
   }
 
   for (const branch of ["main", "master"]) {
     try {
-      await putJson(`repos/${owner}/${repo}/branches/${branch}/protection`, {
-        required_status_checks: {
-          strict: false,
-          contexts: ciContexts,
-        },
-        enforce_admins: false, // true,
-        required_pull_request_reviews: null,
-        restrictions: null,
-        required_linear_history: true,
-        allow_force_pushes: true, // false
-        allow_deletions: false,
-      });
-      if (branch === "master") {
-        console.warn('You should rename your "master" branch to "main"');
+      const result = spawnCommandSync(
+        "git",
+        ["ls-remote", "--heads", `git@github.com:${owner}/${repo}.git`, branch],
+        { stdio: "pipe" },
+      );
+
+      const isBranchExists =
+        result.exitCode === 0 && result.stdout.toString().trim() !== "";
+
+      if (isBranchExists) {
+        await putJson(`repos/${owner}/${repo}/branches/${branch}/protection`, {
+          required_status_checks: {
+            strict: false,
+            contexts: ciContexts,
+          },
+          enforce_admins: false, // true,
+          required_pull_request_reviews: null,
+          restrictions: null,
+          required_linear_history: true,
+          allow_force_pushes: true, // false
+          allow_deletions: false,
+        });
+        if (branch === "master") {
+          console.warn('You should rename your "master" branch to "main"');
+        }
+      } else if (branch === "main") {
+        throw new Error(`Branch ${branch} does not exist`);
       }
     } catch (error) {
       if (branch === "main") {
@@ -167,7 +185,12 @@ export default class CoreGitGithubGenerator extends Generator {
           cwd,
         });
 
-        configureProtectionRule(owner, repo, this.options.onlyLatestLTS);
+        await configureProtectionRule(
+          owner,
+          repo,
+          this.options.onlyLatestLTS,
+          this.spawnCommandSync.bind(this),
+        );
 
         // await gh.put(`/repos/${owner}/${repo}/topics`, {
         //   names: pkg.keywords,
@@ -189,7 +212,12 @@ export default class CoreGitGithubGenerator extends Generator {
         ...githubRepoConfig,
       });
 
-      configureProtectionRule(owner, repo, this.options.onlyLatestLTS);
+      await configureProtectionRule(
+        owner,
+        repo,
+        this.options.onlyLatestLTS,
+        this.spawnCommandSync.bind(this),
+      );
     }
   }
 }

package/lib/generators/core/package/CorePackageGenerator.js

@@ -368,8 +368,8 @@ export default class CorePackageGenerator extends Generator {
         uninstallPostinstallScript("postinstall");
       }
     } else if (this.options.packageManager === "yarn") {
-      uninstallPostinstallScript("postinstall");
-      installPostinstallScript("postinstallDev");
+      uninstallPostinstallScript("postinstallDev");
+      installPostinstallScript("postinstall");
     } else {
       uninstallPostinstallScript("postinstallDev");
       installPostinstallScript("postinstall");

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -80,24 +80,24 @@ export default class CoreYarnGenerator extends Generator {
       const isPluginInstalled = (name) =>
         installedPlugins.some((plugin) => plugin.name === name);
 
-      const installPlugin = (nameOrUrl) => {
-        this.spawnSync("yarn", ["plugin", "import", nameOrUrl]);
-      };
+      // const installPlugin = (nameOrUrl) => {
+      //   this.spawnSync("yarn", ["plugin", "import", nameOrUrl]);
+      // };
       const removePlugin = (name) => {
         this.spawnSync("yarn", ["plugin", "remove", name]);
       };
 
-      const installPluginIfNotInstalled = (
-        name,
-        nameOrUrl = name,
-        forceInstallIfInstalled = () => false,
-      ) => {
-        if (!isPluginInstalled(name)) {
-          installPlugin(nameOrUrl);
-        } else if (forceInstallIfInstalled()) {
-          installPlugin(nameOrUrl);
-        }
-      };
+      // const installPluginIfNotInstalled = (
+      //   name,
+      //   nameOrUrl = name,
+      //   forceInstallIfInstalled = () => false,
+      // ) => {
+      //   if (!isPluginInstalled(name)) {
+      //     installPlugin(nameOrUrl);
+      //   } else if (forceInstallIfInstalled()) {
+      //     installPlugin(nameOrUrl);
+      //   }
+      // };
 
       const removePluginIfInstalled = (name) => {
         if (isPluginInstalled(name)) {
@@ -108,13 +108,20 @@ export default class CoreYarnGenerator extends Generator {
       const postinstallDevPluginName = "@yarnpkg/plugin-postinstall-dev";
       const legacyVersionPluginName = "@yarnpkg/plugin-conventional-version";
 
+      removePluginIfInstalled(postinstallDevPluginName);
       if (!inMonorepo && !pkg.private) {
-        installPluginIfNotInstalled(
-          postinstallDevPluginName,
-          "https://raw.githubusercontent.com/sachinraja/yarn-plugin-postinstall-dev/main/bundles/%40yarnpkg/plugin-postinstall-dev.js",
-        );
+        packageUtils.addDevDependencies(pkg, ["pinst"]);
+        packageUtils.addScripts(pkg, {
+          prepack: "pinst --disable",
+          postpack: "pinst --enable",
+        });
       } else {
-        removePluginIfInstalled(postinstallDevPluginName);
+        if (pkg.scripts.prepack === "pinst --disable") {
+          delete pkg.scripts.prepack;
+        }
+        if (pkg.scripts.postpack === "pinst --enable") {
+          delete pkg.scripts.postpack;
+        }
       }
 
       if (pkg.name !== "yarn-plugin-conventional-version") {
@@ -135,9 +142,9 @@ export default class CoreYarnGenerator extends Generator {
       if (
         !pkg.packageManager ||
         !pkg.packageManager.startsWith("yarn@") ||
-        lt(pkg.packageManager.slice("yarn@".length), "4.6.0")
+        lt(pkg.packageManager.slice("yarn@".length), "4.7.0")
       ) {
-        pkg.packageManager = "yarn@4.6.0";
+        pkg.packageManager = "yarn@4.7.0";
       }
 
       // must be done after plugins installed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "26.10.0",
+  "version": "27.0.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -48,9 +48,9 @@
     "@pob/sort-pkg": "11.0.1",
     "@prettier/sync": "0.5.2",
     "@types/inquirer": "9.0.7",
-    "@yarnpkg/cli": "4.6.0",
-    "@yarnpkg/core": "4.2.0",
-    "@yarnpkg/fslib": "3.1.1",
+    "@yarnpkg/cli": "4.7.0",
+    "@yarnpkg/core": "4.2.1",
+    "@yarnpkg/fslib": "3.1.2",
     "@yeoman/types": "1.5.0",
     "eslint": "9.22.0",
     "findup-sync": "^5.0.0",
@@ -64,17 +64,17 @@
     "mem-fs-editor": "11.1.4",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "17.8.0",
+    "pob-dependencies": "18.0.0",
     "prettier": "3.5.3",
     "semver": "7.7.1",
     "typescript": "5.8.2",
     "validate-npm-package-name": "^6.0.0",
-    "yarn-workspace-utils": "8.4.0",
+    "yarn-workspace-utils": "8.5.0",
     "yeoman-environment": "4.4.3",
     "yeoman-generator": "7.5.0"
   },
   "devDependencies": {
-    "@pob/root": "16.8.0",
+    "@pob/root": "17.0.0",
     "@types/node": "22.13.10"
   }
 }