pob 26.1.1 → 26.3.0

package/CHANGELOG.md

@@ -3,6 +3,27 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [26.3.0](https://github.com/christophehurpeau/pob/compare/pob@26.2.0...pob@26.3.0) (2025-02-02)
+
+### Features
+
+* add mjs and cjs to checkonly ([2666924](https://github.com/christophehurpeau/pob/commit/2666924e72980b7c9a5c1315ff7f8680642171ff))
+* improve typescript checkonly support ([3355104](https://github.com/christophehurpeau/pob/commit/3355104897428d9014b11402ed771a10b1b94064))
+
+### Bug Fixes
+
+* avoid deleting @babel/core ([022d74d](https://github.com/christophehurpeau/pob/commit/022d74d8e462962432cf0bc53d5f3b0d79f86769))
+
+## [26.2.0](https://github.com/christophehurpeau/pob/compare/pob@26.1.1...pob@26.2.0) (2025-02-02)
+
+### Features
+
+* better tamagui support ([7af3a16](https://github.com/christophehurpeau/pob/commit/7af3a161ed462135bb562fff46ad0ca8d606faf1))
+* support react-native target ([7e374f8](https://github.com/christophehurpeau/pob/commit/7e374f842c5aaf78f886722c305ac52f9a6aa5db))
+
+Version bump for dependency: @pob/root
+
+
 ## [26.1.1](https://github.com/christophehurpeau/pob/compare/pob@26.1.0...pob@26.1.1) (2025-02-02)
 
 Version bump for dependency: @pob/root

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -241,7 +241,7 @@ export default class CommonBabelGenerator extends Generator {
         pkg.pob.bundler === "rollup-babel"
       ) {
         delete pkg.pob.babelEnvs;
-        if (pkg.pob.typescript !== true) {
+        if (!pkg.pob.typescript) {
           delete pkg.pob.envs;
           delete pkg.pob.entries;
           delete pkg.pob.jsx;
@@ -304,11 +304,14 @@ export default class CommonBabelGenerator extends Generator {
 
     /* dependencies */
 
-    packageUtils.addOrRemoveDevDependencies(
-      pkg,
-      useBabel || (pkg.peerDependencies && pkg.peerDependencies["@babel/core"]),
-      ["@babel/core"],
-    );
+    if (
+      useBabel ||
+      (pkg.peerDependencies && pkg.peerDependencies["@babel/core"])
+    ) {
+      packageUtils.addDevDependencies(pkg, ["@babel/core"]);
+    } else if (pkg.dependencies && pkg.dependencies["pob-babel"] && !useBabel) {
+      packageUtils.removeDevDependencies(pkg, ["@babel/core"]);
+    }
     packageUtils.addOrRemoveDevDependencies(pkg, useBabel, ["pob-babel"]);
 
     if (pkg.dependencies && pkg.dependencies["pob-babel"]) {
@@ -325,7 +328,8 @@ export default class CommonBabelGenerator extends Generator {
     packageUtils.addOrRemoveDevDependencies(
       pkg,
       (useBabel && pkg.pob.jsx) ||
-        (pkg.devDependencies?.["@babel/preset-react"] && isLibraryRollupPlugin),
+        (pkg.devDependencies?.["@babel/preset-react"] &&
+          (isLibraryRollupPlugin || pkg.name === "alouette-icons")),
       ["@babel/preset-react"],
     );
 

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -136,10 +136,10 @@ export default class CommonTranspilerGenerator extends Generator {
   default() {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const withBabel = this.babelEnvs && this.babelEnvs.length > 0;
-    const withTypescript =
-      pkg.pob.typescript === true || withBabel || !!pkg.pob.bundler;
+    const withTypescript = pkg.pob.typescript || withBabel || !!pkg.pob.bundler;
     const bundler =
       withTypescript &&
+      pkg.pob?.typescript !== "check-only" &&
       (pkg.pob.rollup === false ||
       pkg.pob.bundler === "tsc" ||
       (!pkg.pob.bundler && !pkg.pob.typescript === true)
@@ -202,7 +202,11 @@ export default class CommonTranspilerGenerator extends Generator {
     });
 
     if (shouldBuildDefinitions) {
-      pkg.scripts.build += " && yarn run build:definitions";
+      if (pkg.scripts.build) {
+        pkg.scripts.build += " && yarn run build:definitions";
+      } else {
+        pkg.scripts.build = "yarn run build:definitions";
+      }
     } else if (!this.options.isApp && !bundler && !withTypescript) {
       // check definitions, but also force lerna to execute build:definitions in right order
       // example: nightingale-types depends on nightingale-levels
@@ -238,17 +242,23 @@ export default class CommonTranspilerGenerator extends Generator {
     );
     packageUtils.addOrRemoveDevDependencies(
       pkg,
-      bundler === "esbuild" && withTypescript,
+      bundler === "esbuild" &&
+        withTypescript &&
+        pkg.pob?.typescript !== "check-only",
       ["@pob/esbuild"],
     );
     packageUtils.addOrRemoveDevDependencies(
       pkg,
-      bundler === "rollup-esbuild" && withTypescript,
+      bundler === "rollup-esbuild" &&
+        withTypescript &&
+        pkg.pob?.typescript !== "check-only",
       ["@pob/rollup-esbuild"],
     );
     packageUtils.addOrRemoveDependencies(
       pkg,
-      (bundler === "tsc" || bundler === "rollup-typescript") && withTypescript,
+      (bundler === "tsc" || bundler === "rollup-typescript") &&
+        withTypescript &&
+        pkg.pob?.typescript !== "check-only",
       ["tslib"],
       "^",
     );
@@ -289,7 +299,7 @@ export default class CommonTranspilerGenerator extends Generator {
     }
 
     // if (!pkg.main || pkg.main.startsWith('./lib/')) {
-    if (bundler || withTypescript) {
+    if (bundler || (withTypescript && pkg.pob?.typescript !== "check-only")) {
       // see pkg.exports instead.
       delete pkg.main;
       if (!this.options.isApp) {
@@ -298,12 +308,12 @@ export default class CommonTranspilerGenerator extends Generator {
         pkg.types = `./${this.options.srcDirectory}/index.ts`;
       }
     } else {
-      if (!pkg.main) {
+      if (!pkg.main && !pkg.pob.entries) {
         pkg.exports = "./lib/index.js";
       }
       if (pkg.type === "module" && this.fs.exists("./lib/index.cjs")) {
         pkg.main = "./lib/index.cjs";
-      } else {
+      } else if (!pkg.pob?.entries || pkg.pob.entries.includes("index")) {
         pkg.main = "./lib/index.js";
       }
       if (!this.options.isApp || this.options.isAppLibrary) {
@@ -351,7 +361,7 @@ export default class CommonTranspilerGenerator extends Generator {
     }
 
     /* webpack 5 and node with ESM support */
-    if (bundler || withTypescript) {
+    if (bundler || (withTypescript && pkg.pob?.typescript !== "check-only")) {
       const omitTarget = bundler === "esbuild" || bundler === "tsc";
       pkg.exports = {
         "./package.json": "./package.json",
@@ -375,7 +385,7 @@ export default class CommonTranspilerGenerator extends Generator {
         };
 
         const defaultNodeEnv =
-          withBabel || withTypescript
+          withBabel || (withTypescript && pkg.pob?.typescript !== "check-only")
             ? envs.find((env) => env.target === "node")
             : undefined;
 
@@ -392,48 +402,73 @@ export default class CommonTranspilerGenerator extends Generator {
 
             const exportTarget = {};
 
-            if (target === "node") {
-              const cjsExt = pkg.type === "module" ? "cjs" : "cjs.js";
-              const filenameWithoutExt = `${entryDistName}${
-                omitTarget
-                  ? ""
-                  : `-${target}${omitVersionInFileName ? "" : version}`
-              }`;
-              if (bundler === "tsc") {
-                if (formats) {
-                  throw new Error("tsc does not support formats");
+            switch (target) {
+              case "node": {
+                const cjsExt = pkg.type === "module" ? "cjs" : "cjs.js";
+                const filenameWithoutExt = `${entryDistName}${
+                  omitTarget
+                    ? ""
+                    : `-${target}${omitVersionInFileName ? "" : version}`
+                }`;
+                if (bundler === "tsc") {
+                  if (formats) {
+                    throw new Error("tsc does not support formats");
+                  }
+                  exportTarget.import = `./${this.options.buildDirectory}/${filenameWithoutExt}.js`;
+                } else if (!formats || formats.includes("es")) {
+                  exportTarget.import = `./${this.options.buildDirectory}/${filenameWithoutExt}.mjs`;
+
+                  if (formats && formats.includes("cjs")) {
+                    exportTarget.require = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
+                  }
+                } else if (formats && formats.includes("cjs")) {
+                  exportTarget.default = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
+                }
+                // eslint: https://github.com/benmosher/eslint-plugin-import/issues/2132
+                // jest: https://github.com/facebook/jest/issues/9771
+                if (!pkg.main && exportName === ".") {
+                  pkg.main =
+                    pkg.type === "module"
+                      ? exportTarget.import
+                      : exportTarget.default ||
+                        exportTarget.require ||
+                        exportTarget.import;
+                }
+
+                break;
+              }
+              case "browser": {
+                if (!formats || formats.includes("es")) {
+                  exportTarget.import = `./${
+                    this.options.buildDirectory
+                  }/${entryDistName}-${target}${version || ""}.es.js`;
                 }
-                exportTarget.import = `./${this.options.buildDirectory}/${filenameWithoutExt}.js`;
-              } else if (!formats || formats.includes("es")) {
-                exportTarget.import = `./${this.options.buildDirectory}/${filenameWithoutExt}.mjs`;
 
                 if (formats && formats.includes("cjs")) {
-                  exportTarget.require = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
+                  exportTarget.require = `./${
+                    this.options.buildDirectory
+                  }/${entryDistName}-${target}${version || ""}.cjs.js`;
                 }
-              } else if (formats && formats.includes("cjs")) {
-                exportTarget.default = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
-              }
-              // eslint: https://github.com/benmosher/eslint-plugin-import/issues/2132
-              // jest: https://github.com/facebook/jest/issues/9771
-              if (!pkg.main && exportName === ".") {
-                pkg.main =
-                  pkg.type === "module"
-                    ? exportTarget.import
-                    : exportTarget.default ||
-                      exportTarget.require ||
-                      exportTarget.import;
-              }
-            } else if (target === "browser") {
-              if (!formats || formats.includes("es")) {
-                exportTarget.import = `./${
-                  this.options.buildDirectory
-                }/${entryDistName}-${target}${version || ""}.es.js`;
+
+                break;
               }
+              case "react-native": {
+                if (!formats || formats.includes("es")) {
+                  exportTarget.import = `./${
+                    this.options.buildDirectory
+                  }/${entryDistName}-${target}.es.js`;
+                }
 
-              if (formats && formats.includes("cjs")) {
-                exportTarget.require = `./${
-                  this.options.buildDirectory
-                }/${entryDistName}-${target}${version || ""}.cjs.js`;
+                if (formats && formats.includes("cjs")) {
+                  exportTarget.require = `./${
+                    this.options.buildDirectory
+                  }/${entryDistName}-${target}.cjs.js`;
+                }
+
+                break;
+              }
+              default: {
+                throw new Error(`Invalid target: ${target}`);
               }
             }
 

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -237,20 +237,27 @@ export default class CommonTypescriptGenerator extends Generator {
               ]),
           );
 
+          const isTypescriptPackageMap = new Map(
+            [...packageLocations.entries()].map(
+              ([packageName, packageLocation]) => [
+                packageName,
+                existsSync(
+                  `${packageLocations.get(packageName)}/tsconfig.json`,
+                ) && existsSync(`${packageLocations.get(packageName)}/src`),
+              ],
+            ),
+          );
+
           monorepoPackageSrcPaths = [...packageLocations.entries()].map(
             ([packageName, packageLocation]) => [
               packageName,
               `${packageLocation}/${
-                existsSync(`${packageLocations.get(packageName)}/tsconfig.json`)
-                  ? "src"
-                  : "lib"
+                isTypescriptPackageMap.get(packageName) ? "src" : "lib"
               }`,
             ],
           );
           monorepoPackageReferences = yoConfig.pob.monorepo.packageNames
-            .filter((packageName) =>
-              existsSync(`${packageLocations.get(packageName)}/tsconfig.json`),
-            )
+            .filter((packageName) => isTypescriptPackageMap.get(packageName))
             .map((packageName) => packageLocations.get(packageName));
           // monorepoPackageBuildReferences = yoConfig.pob.monorepo.packageNames
           //   .filter((packageName) =>

package/lib/generators/common/typescript/templates/tsconfig.check-js.json.ejs

@@ -12,5 +12,5 @@
 <% } -%>
     "noEmit": true
   },
-  "include": ["<%= srcDirectory %>/**/*.js"]
+  "include": ["<%= srcDirectory %>/**/*.js","<%= srcDirectory %>/**/*.mjs","<%= srcDirectory %>/**/*.cjs", "<%= srcDirectory %>/**/*.d.ts"]
 }

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -135,9 +135,9 @@ export default class CoreYarnGenerator extends Generator {
       if (
         !pkg.packageManager ||
         !pkg.packageManager.startsWith("yarn@") ||
-        lt(pkg.packageManager.slice("yarn@".length), "4.0.2")
+        lt(pkg.packageManager.slice("yarn@".length), "4.6.0")
       ) {
-        pkg.packageManager = "yarn@4.0.2";
+        pkg.packageManager = "yarn@4.6.0";
       }
 
       // must be done after plugins installed

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -61,13 +61,12 @@ const hasBuild = (packages, configs) =>
   );
 
 const hasTamagui = (packages, configs) =>
-  configs.some(
-    (config, index) =>
+  packages.some(
+    (pkg) =>
       !!(
-        config &&
-        config.project &&
-        config.project.type === "app" &&
-        ["storybook"].includes(config.app.type)
+        pkg.dependencies?.tamagui ||
+        pkg.dependencies?.["@tamagui/core"] ||
+        pkg.dependencies?.alouette
       ),
   );
 
@@ -254,6 +253,10 @@ export default class PobMonorepoGenerator extends Generator {
       splitCIJobs,
     });
 
+    const gitignorePaths = [
+      hasTamagui(this.packages, this.packageConfigs) && ".tamagui",
+    ].filter(Boolean);
+
     this.composeWith("pob:common:format-lint", {
       monorepo: true,
       documentation: this.pobLernaConfig.documentation,
@@ -265,9 +268,9 @@ export default class PobMonorepoGenerator extends Generator {
       yarnNodeLinker: this.options.yarnNodeLinker,
       appTypes: JSON.stringify(getAppTypes(this.packageConfigs)),
       ignorePaths: [
+        ...gitignorePaths.map((path) => `/${path}`),
         hasDist(this.packages, this.packageConfigs) && "/dist",
         hasBuild(this.packages, this.packageConfigs) && "/build",
-        hasTamagui(this.packages, this.packageConfigs) && "/.tamagui",
       ]
         .filter(Boolean)
         .join("\n"),
@@ -300,6 +303,8 @@ export default class PobMonorepoGenerator extends Generator {
       typescript: this.pobLernaConfig.typescript,
       documentation: this.pobLernaConfig.documentation,
       testing: this.pobLernaConfig.testing,
+      // TODO add workspaces paths like we do in format-lint
+      paths: gitignorePaths.join("\n"),
       // todo: fix this using workspaces
       // buildDirectory: this.pobLernaConfig.typescript ? `/*/build` : "",
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "26.1.1",
+  "version": "26.3.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -65,7 +65,7 @@
     "mem-fs-editor": "11.1.4",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "17.1.0",
+    "pob-dependencies": "17.2.0",
     "prettier": "3.4.2",
     "semver": "7.7.0",
     "typescript": "5.7.3",
@@ -75,7 +75,7 @@
     "yeoman-generator": "7.4.0"
   },
   "devDependencies": {
-    "@pob/root": "16.1.1",
+    "@pob/root": "16.2.0",
     "@types/node": "22.13.0"
   }
 }