pob 24.5.0 → 25.0.0

package/CHANGELOG.md

@@ -3,6 +3,36 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [25.0.0](https://github.com/christophehurpeau/pob/compare/pob@24.5.0...pob@25.0.0) (2024-12-10)
+
+### ⚠ BREAKING CHANGES
+
+* drop legacy module/browser/react-native replaced by exports
+
+### Features
+
+* add src/test-setup.ts support ([d469e23](https://github.com/christophehurpeau/pob/commit/d469e23a31b2ebd0477daf06a01e1c95b1809c9d))
+* **deps:** update @pob/eslint-config to v59 (major) ([#2329](https://github.com/christophehurpeau/pob/issues/2329)) ([5019b13](https://github.com/christophehurpeau/pob/commit/5019b13dba092342eee72f0d6d766cf2de864555))
+* **deps:** update dependency eslint to v9.16.0 ([#2308](https://github.com/christophehurpeau/pob/issues/2308)) ([78afd96](https://github.com/christophehurpeau/pob/commit/78afd962ab7d5ed1d735d6a90097f8b010c1621d))
+* drop legacy module/browser/react-native replaced by exports ([b1363ca](https://github.com/christophehurpeau/pob/commit/b1363ca254fb08179a019d2b2f329936cb7dae2d))
+* start preparing cursorignore ([6cec7ef](https://github.com/christophehurpeau/pob/commit/6cec7ef24ef29074b447eb33d3a27951f0a14237))
+* support files lib/index.js rollup-plugin-svgr ([e7c3348](https://github.com/christophehurpeau/pob/commit/e7c3348daf1585ea467e29a6b460c97c280904c2))
+
+### Bug Fixes
+
+* fix entryDistName ([1e3d4e4](https://github.com/christophehurpeau/pob/commit/1e3d4e46ceb7afa7bc4b3683b788cbbf5d0816ae))
+* fix github ci required check for node 22.x ([4852f1b](https://github.com/christophehurpeau/pob/commit/4852f1b6ea097e156e27606b09e7bf17c6da44a8))
+* only run checks on latest lts version ([1b5ff47](https://github.com/christophehurpeau/pob/commit/1b5ff47050eed0f6e200120a321167c647f70e03))
+
+### Reverts
+
+* Revert "feat!: drop legacy module/browser/react-native replaced by exports" ([5971c66](https://github.com/christophehurpeau/pob/commit/5971c669ffd534843a3ea9979a70a0cb1d3d51f8))
+
+Version bump for dependency: @pob/sort-pkg
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: @pob/root
+
+
 ## [24.5.0](https://github.com/christophehurpeau/pob/compare/pob@24.4.0...pob@24.5.0) (2024-12-05)
 
 ### Bug Fixes

package/lib/generators/app/PobAppGenerator.js

@@ -338,6 +338,7 @@ export default class PobAppGenerator extends Generator {
       withBabel: babel,
       paths: ignorePaths.join("\n"),
       buildInGit: false,
+      buildDirectory,
     });
 
     this.composeWith("pob:core:npm", { enable: false });

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -327,7 +327,7 @@ export default class CommonTestingGenerator extends Generator {
               : ""
           }node ${
             this.options.typescript ? `${tsTestLoaderOption} ` : ""
-          }--test${experimentalTestCoverage && (coverage || coverageJson) ? " --experimental-test-coverage" : ""} ${this.options.monorepo ? `${workspacesPattern}/` : ""}${`${
+          }${this.fs.exists("src/test-setup.ts") ? "--import ./src/test-setup.ts " : ""}--test${experimentalTestCoverage && (coverage || coverageJson) ? " --experimental-test-coverage" : ""} ${this.options.monorepo ? `${workspacesPattern}/` : ""}${`${
             hasTestFolder ? "test/*" : `${this.options.srcDirectory}/**/*.test`
           }.${this.options.typescript ? "ts" : "js"}`}`;
         }

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -433,7 +433,7 @@ export default class CommonTranspilerGenerator extends Generator {
               if (formats && formats.includes("cjs")) {
                 exportTarget.require = `./${
                   this.options.buildDirectory
-                }/index-${target}${version || ""}.cjs.js`;
+                }/${entryDistName}-${target}${version || ""}.cjs.js`;
               }
             }
 

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -184,7 +184,7 @@ export default class CoreCIGenerator extends Generator {
               testing && `test (${maintenanceLTS})`,
             ].filter(Boolean)
           : [
-              !this.options.onlyLatestLTS && `build (${maintenanceLTS}.x)`,
+              !this.options.onlyLatestLTS && `build (${latestLTS}.x)`,
               `build (${maintenanceLTS}.x)`,
             ].filter(Boolean)),
       );

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -37,6 +37,7 @@ jobs:
 <% if (checks) { -%>
       - name: Checks
         run: <%= packageManager %> run checks
+        if: startsWith(matrix.node-version, '22.')
 
 <% } -%>
 <% if (build) { -%>

package/lib/generators/core/gitignore/CoreGitignoreGenerator.js

@@ -52,10 +52,18 @@ export default class CoreGitignoreGenerator extends Generator {
       default: true,
       description: "Build is saved in git.",
     });
+
+    this.option("buildDirectory", {
+      type: String,
+      required: false,
+      default: "",
+      description: "Build directory.",
+    });
   }
 
   writing() {
-    const dest = this.destinationPath(".gitignore");
+    const gitignorePath = this.destinationPath(".gitignore");
+    const cursorignorePath = this.destinationPath(".cursorignore");
     const withBabel = this.options.withBabel;
 
     if (
@@ -64,9 +72,9 @@ export default class CoreGitignoreGenerator extends Generator {
       !this.options.paths &&
       !withBabel
     ) {
-      this.fs.delete(dest);
+      this.fs.delete(gitignorePath);
     } else {
-      this.fs.copyTpl(this.templatePath("gitignore.ejs"), dest, {
+      this.fs.copyTpl(this.templatePath("gitignore.ejs"), gitignorePath, {
         root: this.options.root,
         documentation: this.options.documentation,
         testing: this.options.testing,
@@ -77,5 +85,14 @@ export default class CoreGitignoreGenerator extends Generator {
         buildInGit: this.options.buildInGit,
       });
     }
+
+    // if (!this.options.root) {
+    this.fs.delete(cursorignorePath);
+    // } else {
+    //   this.fs.write(
+    //     cursorignorePath,
+    //     `${["/.yarn", this.options.buildDirectory].join("\n")}\n`,
+    //   );
+    // }
   }
 }

package/lib/generators/core/npm/CoreNpmGenerator.js

@@ -39,39 +39,43 @@ export default class CoreNpmGenerator extends Generator {
     }
 
     if (!pkg.private && this.options.enable) {
-      const files = new Set([
-        this.options.srcDirectory,
-        this.options.distDirectory,
-      ]);
+      if (pkg.files.length === 1 && pkg.files[0] === "lib/index.js") {
+        // see rollup-plugin-svgr
+      } else {
+        const files = new Set([
+          this.options.srcDirectory,
+          this.options.distDirectory,
+        ]);
 
-      if (pkg.bin) {
-        files.add("bin");
-      }
+        if (pkg.bin) {
+          files.add("bin");
+        }
 
-      if (pkg.exports) {
-        Object.values(pkg.exports).forEach((value) => {
-          if (typeof value === "string" && value.startsWith("./tsconfigs/")) {
-            files.add("tsconfigs");
-          }
-          if (
-            typeof value === "string" &&
-            value.startsWith("./") &&
-            value !== "./package.json" &&
-            ![...files].some((file) => value.startsWith(`./${file}/`))
-          ) {
-            files.add(value.slice("./".length));
-          }
-        });
-      }
-      if (pkg.pob?.extraEntries) {
-        pkg.pob?.extraEntries.forEach((extraEntry) => {
-          if (extraEntry.directory) {
-            files.add(extraEntry.directory);
-          }
-        });
-      }
+        if (pkg.exports) {
+          Object.values(pkg.exports).forEach((value) => {
+            if (typeof value === "string" && value.startsWith("./tsconfigs/")) {
+              files.add("tsconfigs");
+            }
+            if (
+              typeof value === "string" &&
+              value.startsWith("./") &&
+              value !== "./package.json" &&
+              ![...files].some((file) => value.startsWith(`./${file}/`))
+            ) {
+              files.add(value.slice("./".length));
+            }
+          });
+        }
+        if (pkg.pob?.extraEntries) {
+          pkg.pob?.extraEntries.forEach((extraEntry) => {
+            if (extraEntry.directory) {
+              files.add(extraEntry.directory);
+            }
+          });
+        }
 
-      pkg.files = [...files].filter(Boolean);
+        pkg.files = [...files].filter(Boolean);
+      }
     } else {
       delete pkg.files;
     }

package/lib/generators/lib/PobLibGenerator.js

@@ -379,6 +379,8 @@ export default class PobLibGenerator extends Generator {
       testRunner: this.pobjson.testRunner,
     });
 
+    const buildDirectory = withBabel || withTypescript ? "dist" : "";
+
     // must be after doc, testing
     this.composeWith("pob:core:gitignore", {
       root: !inMonorepo,
@@ -386,12 +388,13 @@ export default class PobLibGenerator extends Generator {
       typescript: withTypescript,
       documentation: this.pobjson.documentation,
       testing: !!this.pobjson.testing,
+      buildDirectory,
     });
 
     this.composeWith("pob:core:npm", {
       enable: !pkg.private,
       srcDirectory: withBabel || withTypescript ? "src" : "lib",
-      distDirectory: withBabel || withTypescript ? "dist" : "",
+      distDirectory: buildDirectory,
     });
   }
 

package/lib/generators/lib/readme/LibReadmeGenerator.js

@@ -1,3 +1,5 @@
+/* eslint-disable regexp/match-any */
+/* eslint-disable regexp/no-super-linear-backtracking */
 import camelCase from "lodash.camelcase";
 import Generator from "yeoman-generator";
 import inMonorepo from "../../../utils/inMonorepo.js";
@@ -47,16 +49,16 @@ export default class LibReadmeGenerator extends Generator {
 
     if (this.fs.exists(readmePath)) {
       const readmeFullContent = this.fs.read(readmePath);
-      content = readmeFullContent.match(/^<h3[^#*]+([^]+)\[npm-image]:/);
+      content = readmeFullContent.match(/^<h3[^#*]+([^]+)\[npm-image\]:/);
       if (!content) {
-        content = readmeFullContent.match(/^<h3[^#*]+([^]+)\[daviddm-image]:/);
+        content = readmeFullContent.match(/^<h3[^#*]+([^]+)\[daviddm-image\]:/);
       }
       if (!content) content = readmeFullContent.match(/^<h3[^#*]+([^]+)$/);
       if (!content) {
-        content = readmeFullContent.match(/^#[^#*]+([^]+)\[npm-image]:/);
+        content = readmeFullContent.match(/^#[^#*]+([^]+)\[npm-image\]:/);
       }
       if (!content) {
-        content = readmeFullContent.match(/^#[^#*]+([^]+)\[daviddm-image]:/);
+        content = readmeFullContent.match(/^#[^#*]+([^]+)\[daviddm-image\]:/);
       }
       if (!content) content = readmeFullContent.match(/^#[^#*]+([^]+)$/);
       content = content ? content[1].trim() : readmeFullContent;

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -5,8 +5,8 @@ import { getPluginConfiguration } from "@yarnpkg/cli";
 import { Configuration, Project } from "@yarnpkg/core";
 import { ppath } from "@yarnpkg/fslib";
 import {
-  buildTopologicalOrderBatches,
   buildDependenciesMaps,
+  buildTopologicalOrderBatches,
   getWorkspaceName,
 } from "yarn-workspace-utils";
 import Generator from "yeoman-generator";
@@ -288,6 +288,8 @@ export default class PobMonorepoGenerator extends Generator {
       typescript: this.pobLernaConfig.typescript,
       documentation: this.pobLernaConfig.documentation,
       testing: this.pobLernaConfig.testing,
+      // todo: fix this using workspaces
+      // buildDirectory: this.pobLernaConfig.typescript ? `/*/build` : "",
     });
 
     this.composeWith("pob:common:remove-old-dependencies");

package/lib/generators/monorepo/lerna/MonorepoLernaGenerator.js

@@ -1,4 +1,4 @@
-import { readdirSync, existsSync } from "node:fs";
+import { existsSync, readdirSync } from "node:fs";
 import Generator from "yeoman-generator";
 import * as packageUtils from "../../../utils/package.js";
 import { writeAndFormatJson } from "../../../utils/writeAndFormat.js";

package/lib/generators/monorepo/workspaces/MonorepoWorkspacesGenerator.js

@@ -1,5 +1,5 @@
 import { spawnSync } from "node:child_process";
-import { readdirSync, existsSync } from "node:fs";
+import { existsSync, readdirSync } from "node:fs";
 import Generator from "yeoman-generator";
 import * as packageUtils from "../../../utils/package.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
@@ -159,7 +159,9 @@ export default class MonorepoWorkspacesGenerator extends Generator {
 
     if (this.fs.exists(readmePath)) {
       const readmeFullContent = this.fs.read(readmePath);
+      // eslint-disable-next-line regexp/no-super-linear-backtracking, regexp/match-any
       content = readmeFullContent.match(/^<h3[^#*]+([^]+)$/);
+      // eslint-disable-next-line regexp/no-super-linear-backtracking, regexp/match-any
       if (!content) content = readmeFullContent.match(/^#[^#*]+([^]+)$/);
       content = content ? content[1].trim() : readmeFullContent;
     }

package/lib/pob.js

@@ -3,10 +3,10 @@
 import { execSync, spawnSync } from "node:child_process";
 import fs, {
   existsSync,
-  writeFileSync,
-  readFileSync,
   mkdirSync,
+  readFileSync,
   readdirSync,
+  writeFileSync,
 } from "node:fs";
 import path from "node:path";
 import minimist from "minimist";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "24.5.0",
+  "version": "25.0.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -41,19 +41,19 @@
   },
   "prettier": "@pob/root/prettier-config",
   "dependencies": {
-    "@pob/eslint-config": "58.1.0",
-    "@pob/eslint-config-typescript": "58.1.0",
-    "@pob/eslint-config-typescript-react": "58.1.0",
+    "@pob/eslint-config": "59.0.0",
+    "@pob/eslint-config-typescript": "59.1.2",
+    "@pob/eslint-config-typescript-react": "59.1.2",
     "@pob/sort-eslint-config": "7.0.0",
     "@pob/sort-object": "8.0.0",
-    "@pob/sort-pkg": "9.0.0",
+    "@pob/sort-pkg": "10.0.0",
     "@prettier/sync": "0.5.2",
     "@types/inquirer": "9.0.7",
     "@yarnpkg/cli": "4.5.3",
     "@yarnpkg/core": "4.1.6",
     "@yarnpkg/fslib": "3.1.1",
     "@yeoman/types": "1.5.0",
-    "eslint": "9.14.0",
+    "eslint": "9.16.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^7.0.0",
@@ -65,16 +65,16 @@
     "mem-fs-editor": "11.1.3",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "15.4.0",
+    "pob-dependencies": "16.0.0",
     "prettier": "3.4.2",
     "semver": "7.6.3",
     "validate-npm-package-name": "^6.0.0",
-    "yarn-workspace-utils": "7.0.2",
+    "yarn-workspace-utils": "7.1.0",
     "yeoman-environment": "4.4.3",
     "yeoman-generator": "7.3.3"
   },
   "devDependencies": {
-    "@pob/root": "14.4.0",
+    "@pob/root": "15.0.0",
     "@types/node": "22.10.1",
     "typescript": "5.7.2"
   }