pob 24.1.0 → 24.3.0

package/CHANGELOG.md

@@ -3,6 +3,37 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [24.3.0](https://github.com/christophehurpeau/pob/compare/pob@24.2.0...pob@24.3.0) (2024-12-01)
+
+### Features
+
+* allow lib to use latest lts ([2c7d51f](https://github.com/christophehurpeau/pob/commit/2c7d51f4bab9e64af469afc1c2b59b74c7c7a8fa))
+* bundler tsc using experimental-strip-types ([98002f8](https://github.com/christophehurpeau/pob/commit/98002f832c1869e23c5c93c3f5e61b4915e1263b))
+* **deps:** update dependency prettier to v3.4.0 ([#2325](https://github.com/christophehurpeau/pob/issues/2325)) ([367f1dc](https://github.com/christophehurpeau/pob/commit/367f1dcebf3b47b61c024380b6358894dcb6514a))
+
+### Bug Fixes
+
+* **deps:** update dependency prettier to v3.4.1 ([#2328](https://github.com/christophehurpeau/pob/issues/2328)) ([cf236ba](https://github.com/christophehurpeau/pob/commit/cf236bac297964115e0b7bb463f923ea78c51ca8))
+* **deps:** update yarn monorepo ([#2314](https://github.com/christophehurpeau/pob/issues/2314)) ([a175402](https://github.com/christophehurpeau/pob/commit/a17540280c524ceeed748625c94b7b4c717e0ba2))
+* **deps:** update yarn monorepo ([#2322](https://github.com/christophehurpeau/pob/issues/2322)) ([ec71e81](https://github.com/christophehurpeau/pob/commit/ec71e8101df4a3bace9ec3c02874165af7580df6))
+
+### Reverts
+
+* Revert "refactor: properly import generators" ([e1e2d46](https://github.com/christophehurpeau/pob/commit/e1e2d468729e3cae03637e8f7169c65e3ba85d4b))
+
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: @pob/root
+
+
+## [24.2.0](https://github.com/christophehurpeau/pob/compare/pob@24.1.0...pob@24.2.0) (2024-11-17)
+
+### Bug Fixes
+
+* update codecov-action to v5 ([ff8610c](https://github.com/christophehurpeau/pob/commit/ff8610cfcc65aa5b19dc259b347d6b6b8fe821c3))
+
+Version bump for dependency: @pob/root
+
+
 ## [24.1.0](https://github.com/christophehurpeau/pob/compare/pob@24.0.0...pob@24.1.0) (2024-11-12)
 
 ### Features

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -178,6 +178,7 @@ export default class CommonTestingGenerator extends Generator {
         : packageUtils.transpileWithBabel(pkg);
     const withTypescript =
       transpileWithBabel ||
+      pkg.pob?.bundler === "tsc" ||
       (pkg.pob?.typescript && pkg.pob.typescript !== "check-only");
     let hasReact =
       withTypescript &&
@@ -194,6 +195,7 @@ export default class CommonTestingGenerator extends Generator {
       if (testRunner === "vitest") return undefined;
       if (!withTypescript) return undefined;
       if (this.options.swc || isJestRunner) return "swc";
+      if (this.options.onlyLatestLTS) return "node";
       return "ts-node";
     })();
 
@@ -270,6 +272,8 @@ export default class CommonTestingGenerator extends Generator {
 
     const tsTestLoaderOption = (() => {
       switch (tsTestUtil) {
+        case "node":
+          return "--disable-warning=ExperimentalWarning --experimental-strip-types";
         case "ts-node":
           return "--loader=ts-node/esm --experimental-specifier-resolution=node";
         case "swc":

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -121,7 +121,11 @@ export default class CommonTranspilerGenerator extends Generator {
     this.entries = pkg.pob.entries;
     this.babelEnvs = pkg.pob.babelEnvs || [];
 
-    if (this.babelEnvs.length > 0 || pkg.pob.typescript === true) {
+    if (
+      this.babelEnvs.length > 0 ||
+      pkg.pob.typescript === true ||
+      pkg.pob.bundler
+    ) {
       fs.mkdirSync(this.destinationPath("src"), { recursive: true });
     } else {
       // recursive does not throw if directory already exists
@@ -137,6 +141,7 @@ export default class CommonTranspilerGenerator extends Generator {
     const bundler =
       withTypescript &&
       (pkg.pob.rollup === false ||
+      pkg.pob.bundler === "tsc" ||
       (!pkg.pob.bundler && !pkg.pob.typescript === true)
         ? "tsc"
         : (pkg.pob.bundler ??
@@ -150,7 +155,8 @@ export default class CommonTranspilerGenerator extends Generator {
       if (bundler === "rollup-esbuild") return "pob-esbuild-clean-out";
       if (bundler === "rollup-babel") return "pob-babel-clean-out";
       if (bundler === "esbuild") return "pob-esbuild-clean-out";
-      return null;
+      if (bundler === "tsc") return "rm -Rf";
+      if (bundler) throw new Error(`Invalid bundler: ${bundler}`);
     })();
 
     /* scripts */
@@ -346,7 +352,7 @@ export default class CommonTranspilerGenerator extends Generator {
 
     /* webpack 5 and node with ESM support */
     if (bundler || withTypescript) {
-      const omitTarget = bundler === "esbuild";
+      const omitTarget = bundler === "esbuild" || bundler === "tsc";
       pkg.exports = {
         "./package.json": "./package.json",
       };
@@ -365,9 +371,7 @@ export default class CommonTranspilerGenerator extends Generator {
           types:
             pkg.private || this.options.isAppLibrary
               ? `./src/${entryDistName}.ts`
-              : `./${this.options.buildDirectory}/${
-                  bundler !== "tsc" ? "definitions/" : ""
-                }${entryDistName}.d.ts`,
+              : `./${this.options.buildDirectory}/definitions/${entryDistName}.d.ts`,
         };
 
         const defaultNodeEnv =
@@ -377,66 +381,78 @@ export default class CommonTranspilerGenerator extends Generator {
 
         const defaultNodeEnvVersion = defaultNodeEnv && defaultNodeEnv.version;
 
-        envs.forEach(({ target, version, formats, omitVersionInFileName }) => {
-          if (target === "node" && entry === "browser") return;
-
-          const exportTarget = {};
-
-          if (target === "node") {
-            const cjsExt = pkg.type === "module" ? "cjs" : "cjs.js";
-            const filenameWithoutExt = `${entryDistName}${
-              omitTarget
-                ? ""
-                : `-${target}${omitVersionInFileName ? "" : version}`
-            }`;
-            if (!formats || formats.includes("es")) {
-              exportTarget.import = `./${this.options.buildDirectory}/${filenameWithoutExt}.mjs`;
+        envs.forEach(
+          ({
+            target,
+            version,
+            formats,
+            omitVersionInFileName = bundler === "tsc",
+          }) => {
+            if (target === "node" && entry === "browser") return;
+
+            const exportTarget = {};
+
+            if (target === "node") {
+              const cjsExt = pkg.type === "module" ? "cjs" : "cjs.js";
+              const filenameWithoutExt = `${entryDistName}${
+                omitTarget
+                  ? ""
+                  : `-${target}${omitVersionInFileName ? "" : version}`
+              }`;
+              if (bundler === "tsc") {
+                if (formats) {
+                  throw new Error("tsc does not support formats");
+                }
+                exportTarget.import = `./${this.options.buildDirectory}/${filenameWithoutExt}.js`;
+              } else if (!formats || formats.includes("es")) {
+                exportTarget.import = `./${this.options.buildDirectory}/${filenameWithoutExt}.mjs`;
+
+                if (formats && formats.includes("cjs")) {
+                  exportTarget.require = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
+                }
+              } else if (formats && formats.includes("cjs")) {
+                exportTarget.default = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
+              }
+              // eslint: https://github.com/benmosher/eslint-plugin-import/issues/2132
+              // jest: https://github.com/facebook/jest/issues/9771
+              if (!pkg.main && exportName === ".") {
+                pkg.main =
+                  pkg.type === "module"
+                    ? exportTarget.import
+                    : exportTarget.default ||
+                      exportTarget.require ||
+                      exportTarget.import;
+              }
+            } else if (target === "browser") {
+              if (!formats || formats.includes("es")) {
+                exportTarget.import = `./${
+                  this.options.buildDirectory
+                }/${entryDistName}-${target}${version || ""}.es.js`;
+              }
 
               if (formats && formats.includes("cjs")) {
-                exportTarget.require = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
+                exportTarget.require = `./${
+                  this.options.buildDirectory
+                }/index-${target}${version || ""}.cjs.js`;
               }
-            } else if (formats && formats.includes("cjs")) {
-              exportTarget.default = `./${this.options.buildDirectory}/${filenameWithoutExt}.${cjsExt}`;
-            }
-            // eslint: https://github.com/benmosher/eslint-plugin-import/issues/2132
-            // jest: https://github.com/facebook/jest/issues/9771
-            if (!pkg.main && exportName === ".") {
-              pkg.main =
-                pkg.type === "module"
-                  ? exportTarget.import
-                  : exportTarget.default ||
-                    exportTarget.require ||
-                    exportTarget.import;
-            }
-          } else if (target === "browser") {
-            if (!formats || formats.includes("es")) {
-              exportTarget.import = `./${
-                this.options.buildDirectory
-              }/${entryDistName}-${target}${version || ""}.es.js`;
             }
 
-            if (formats && formats.includes("cjs")) {
-              exportTarget.require = `./${
-                this.options.buildDirectory
-              }/index-${target}${version || ""}.cjs.js`;
+            if (
+              !version ||
+              (target === "node" && version === defaultNodeEnvVersion)
+            ) {
+              targets[target] = {
+                ...targets[target],
+                ...exportTarget,
+              };
+            } else {
+              targets[target] = {
+                [`${target}:${version}`]: exportTarget,
+                ...targets[target],
+              };
             }
-          }
-
-          if (
-            !version ||
-            (target === "node" && version === defaultNodeEnvVersion)
-          ) {
-            targets[target] = {
-              ...targets[target],
-              ...exportTarget,
-            };
-          } else {
-            targets[target] = {
-              [`${target}:${version}`]: exportTarget,
-              ...targets[target],
-            };
-          }
-        });
+          },
+        );
 
         pkg.exports[exportName] = targets;
       });
@@ -656,7 +672,12 @@ export default class CommonTranspilerGenerator extends Generator {
           },
         );
       }
-    } else if (!envs || envs.length === 0 || pkg.pob?.bundler === "esbuild") {
+    } else if (
+      !envs ||
+      envs.length === 0 ||
+      pkg.pob?.bundler === "esbuild" ||
+      pkg.pob?.bundler === "tsc"
+    ) {
       this.fs.delete("rollup.config.mjs");
     }
 

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -149,7 +149,11 @@ export default class CommonTypescriptGenerator extends Generator {
             version: `${maintenanceLTS}`,
           },
         ];
-        if (pkg.pob.rollup === false || pkg.pob.bundler === false) {
+        if (
+          pkg.pob.rollup === false ||
+          pkg.pob.bundler === false ||
+          pkg.pob.bundler === "tsc"
+        ) {
           return [`@pob/root/tsconfigs/targets/node-${nodeVersion}.json`];
         }
         if (envs && envs.every((env) => env.target === "node")) {
@@ -278,7 +282,10 @@ export default class CommonTypescriptGenerator extends Generator {
         tsconfigPath,
         {
           emitDefinitions: this.options.builddefs,
-          build: pkg.pob?.rollup === false || pkg.pob?.bundler === false,
+          build:
+            pkg.pob?.rollup === false ||
+            pkg.pob?.bundler === false ||
+            pkg.pob?.bundler === "tsc",
           cacheEnabled: !this.options.isApp || this.options.isAppLibrary,
           monorepoPackageSrcPaths,
           monorepoPackageReferences,

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -124,7 +124,7 @@ jobs:
           CI: true
 
       - name: Send results to codecov
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@v5
         if: matrix.node-version == 18
         with:
           fail_ci_if_error: true

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -58,6 +58,12 @@ jobs:
       - name: Eslint
         run: <%= packageManager %> run lint:eslint
         if: startsWith(matrix.node-version, '22.')
+<% if (true) { -%>
+
+      - name: Check nothing was forgotten before commit
+        if: startsWith(matrix.node-version, '22.')
+        run: <%= packageManager === 'npm' ? 'npx' : 'yarn run' %> repository-check-dirty
+<% } -%>
 <% if (codecov) { -%>
 
       - name: Generate Test Coverage
@@ -67,7 +73,7 @@ jobs:
           CI: true
 
       - name: Send results to codecov
-        uses: codecov/codecov-action@v4
+        uses: codecov/codecov-action@v5
         with:
           fail_ci_if_error: true
           token: ${{ secrets.CODECOV_TOKEN }}
@@ -84,14 +90,8 @@ jobs:
       - name: E2E testing
         run: <%= packageManager %> <%= e2eTesting %> run test:e2e
 <% } -%>
-<% if (true) { -%>
-
-      - name: Check nothing was forgotten before commit
-        if: startsWith(matrix.node-version, '22.')
-        run: <%= packageManager === 'npm' ? 'npx' : 'yarn run' %> repository-check-dirty
-<% } -%>
-
 <% if (isReleasePleaseEnabled) { -%>
+
       - uses: GoogleCloudPlatform/release-please-action@v3
         if: ${{ startsWith(matrix.node-version, '22.') && github.ref == 'refs/heads/main' }}
         id: release

package/lib/generators/lib/PobLibGenerator.js

@@ -1,6 +1,7 @@
 import { rmSync } from "node:fs";
 import Generator from "yeoman-generator";
 import inMonorepo from "../../utils/inMonorepo.js";
+import { latestLTS } from "../../utils/node.js";
 import * as packageUtils from "../../utils/package.js";
 
 export default class PobLibGenerator extends Generator {
@@ -160,6 +161,12 @@ export default class PobLibGenerator extends Generator {
       pkg.pob.jsx = jsx;
     }
 
+    this.onlyLatestLTS = pkg.pob.envs
+      ? pkg.pob.envs
+          .filter((env) => env.target === "node")
+          .every((env) => env.version === latestLTS)
+      : false;
+
     this.fs.writeJSON(this.destinationPath("package.json"), pkg);
   }
 
@@ -245,14 +252,14 @@ export default class PobLibGenerator extends Generator {
       testing: !!this.pobjson.testing,
       documentation: !!this.pobjson.documentation,
       fromPob: this.options.fromPob,
-      onlyLatestLTS: false,
+      onlyLatestLTS: this.onlyLatestLTS,
     });
     this.composeWith("pob:common:transpiler", {
       updateOnly: this.options.updateOnly,
       testing: !!this.pobjson.testing,
       documentation: !!this.pobjson.documentation,
       fromPob: this.options.fromPob,
-      onlyLatestLTS: false,
+      onlyLatestLTS: this.onlyLatestLTS,
     });
   }
 
@@ -266,7 +273,8 @@ export default class PobLibGenerator extends Generator {
       [];
 
     const withBabel = babelEnvs.length > 0;
-    const withTypescript = withBabel || pkg.pob.typescript === true;
+    const withTypescript =
+      withBabel || pkg.pob.typescript === true || pkg.pob.bundler === "tsc";
     const jsx = (withBabel || withTypescript) && pkg.pob.jsx === true;
     const browser = pkg.pob.envs?.some((env) => env.target === "browser");
 
@@ -286,7 +294,7 @@ export default class PobLibGenerator extends Generator {
       updateOnly: this.options.updateOnly,
       baseUrl: "none", // causes issues on dist definition files
       builddefs: true,
-      onlyLatestLTS: false,
+      onlyLatestLTS: this.onlyLatestLTS,
       srcDirectory: withTypescript ? "src" : "lib",
     });
 
@@ -317,6 +325,7 @@ export default class PobLibGenerator extends Generator {
       isApp: false,
       splitCIJobs: false,
       srcDirectory: withBabel || withTypescript ? "src" : "lib",
+      onlyLatestLTS: this.onlyLatestLTS,
     });
 
     // must be after testing
@@ -403,7 +412,8 @@ export default class PobLibGenerator extends Generator {
         (!pkg.pob.bundler && pkg.pob.typescript !== true && pkg.pob.envs) ||
         pkg.pob.bundler === "rollup-babel",
     );
-    const withTypescript = withBabel || pkg.pob.typescript === true;
+    const withTypescript =
+      withBabel || pkg.pob.typescript === true || pkg.pob.bundler === "tsc";
 
     packageUtils.removeDevDependencies(pkg, ["lerna", "@pob/lerna-light"]);
     if (inMonorepo) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "24.1.0",
+  "version": "24.3.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -49,9 +49,9 @@
     "@pob/sort-pkg": "9.0.0",
     "@prettier/sync": "0.5.2",
     "@types/inquirer": "9.0.7",
-    "@yarnpkg/cli": "4.5.1",
-    "@yarnpkg/core": "4.1.4",
-    "@yarnpkg/fslib": "3.1.0",
+    "@yarnpkg/cli": "4.5.3",
+    "@yarnpkg/core": "4.1.6",
+    "@yarnpkg/fslib": "3.1.1",
     "@yeoman/types": "1.5.0",
     "eslint": "9.14.0",
     "findup-sync": "^5.0.0",
@@ -65,17 +65,17 @@
     "mem-fs-editor": "11.1.3",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "15.1.0",
-    "prettier": "3.3.3",
+    "pob-dependencies": "15.2.0",
+    "prettier": "3.4.1",
     "semver": "7.6.3",
     "validate-npm-package-name": "^6.0.0",
-    "yarn-workspace-utils": "7.0.0",
+    "yarn-workspace-utils": "7.0.1",
     "yeoman-environment": "4.4.3",
     "yeoman-generator": "7.3.3"
   },
   "devDependencies": {
-    "@pob/root": "14.0.1",
-    "@types/node": "22.9.0",
-    "typescript": "5.6.3"
+    "@pob/root": "14.2.0",
+    "@types/node": "22.10.1",
+    "typescript": "5.7.2"
   }
 }