pob 23.1.0 → 23.2.1

package/CHANGELOG.md

@@ -3,6 +3,27 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [23.2.1](https://github.com/christophehurpeau/pob/compare/pob@23.2.0...pob@23.2.1) (2024-08-15)
+
+Version bump for dependency: yarn-workspace-utils
+
+
+## [23.2.0](https://github.com/christophehurpeau/pob/compare/pob@23.1.0...pob@23.2.0) (2024-08-15)
+
+### Features
+
+* codecov fail_ci_if_error: true ([0dc2f0d](https://github.com/christophehurpeau/pob/commit/0dc2f0d6f87e1871c65fa36be7a33df2c9bf3dae))
+* fail ci if codecov token is missing ([40725d6](https://github.com/christophehurpeau/pob/commit/40725d6dd9c82cfe666006b8d21f641617ca8d59))
+* typescript check-only ([688fe59](https://github.com/christophehurpeau/pob/commit/688fe59d8a857e8b94a7af78349f909f7ed4d6e7))
+
+### Bug Fixes
+
+* disable ts test util config when no ts is used ([d5cf807](https://github.com/christophehurpeau/pob/commit/d5cf807fb7604cf1e0d4355ebe069323156ce0ef))
+* fix coverage config ([3621c92](https://github.com/christophehurpeau/pob/commit/3621c9246d44219c6d64f34079b254074181d782))
+
+Version bump for dependency: @pob/root
+
+
 ## [23.1.0](https://github.com/christophehurpeau/pob/compare/pob@23.0.1...pob@23.1.0) (2024-08-14)
 
 ### Features

package/lib/generators/app/PobAppGenerator.js

@@ -196,7 +196,15 @@ export default class PobAppGenerator extends Generator {
     ).filter(Boolean);
 
     this.composeWith("pob:common:typescript", {
-      enable: typescript,
+      enable:
+        typescript ||
+        pkg.pob?.typescript === "check-only" ||
+        (inMonorepo &&
+          inMonorepo.pobMonorepoConfig?.typescript === "check-only"),
+      onlyCheck:
+        pkg.pob?.typescript === "check-only" ||
+        (inMonorepo &&
+          inMonorepo.pobMonorepoConfig?.typescript === "check-only"),
       isApp: true,
       isAppLibrary,
       nextConfig: this.appConfig.type === "next.js",
@@ -258,7 +266,7 @@ export default class PobAppGenerator extends Generator {
           : undefined,
         e2eTesting: this.appConfig.e2e ? "." : "",
         typescript,
-        build: typescript && this.appConfig.type !== "expo",
+        build: typescript === true && this.appConfig.type !== "expo",
         documentation: false,
         codecov: this.appConfig.codecov,
         ci: this.appConfig.ci,
@@ -280,6 +288,7 @@ export default class PobAppGenerator extends Generator {
         testRunner: this.appConfig.testRunner,
         babel,
         typescript,
+        build: typescript === true,
         node,
         browser,
         // nextjs now supports src rootAsSrc: this.appConfig.type === 'next.js',

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -65,7 +65,9 @@ export default class CommonBabelGenerator extends Generator {
     if (
       pkg.pob &&
       (pkg.pob.babelEnvs ||
-        (pkg.pob.envs && pkg.pob.bundler === "rollup-babel"))
+        (pkg.pob.envs &&
+          ((!pkg.pob.bundler && pkg.pob.typescript !== true) ||
+            pkg.pob.bundler === "rollup-babel")))
     ) {
       let babelEnvs = pkg.pob.babelEnvs || pkg.pob.envs;
       if (
@@ -108,7 +110,10 @@ export default class CommonBabelGenerator extends Generator {
 
     const babelEnvs =
       pkg.pob.babelEnvs ||
-      (pkg.pob.bundler === "rollup-babel" && pkg.pob.envs) ||
+      ((!pkg.pob.bundler && pkg.pob.typescript !== true) ||
+      pkg.pob.bundler === "rollup-babel"
+        ? pkg.pob.envs
+        : []) ||
       [];
 
     const targets = [
@@ -248,10 +253,13 @@ export default class CommonBabelGenerator extends Generator {
     ];
 
     if (newBabelEnvs.length === 0) {
-      if (!pkg.pob.bundler || pkg.pob.bundler === "rollup-babel") {
-        delete pkg.pob.envs;
+      if (
+        (!pkg.pob.bundler && pkg.pob.typescript !== true) ||
+        pkg.pob.bundler === "rollup-babel"
+      ) {
         delete pkg.pob.babelEnvs;
-        if (!pkg.pob.typescript) {
+        if (pkg.pob.typescript !== true) {
+          delete pkg.pob.envs;
           delete pkg.pob.entries;
           delete pkg.pob.jsx;
         }
@@ -275,7 +283,9 @@ export default class CommonBabelGenerator extends Generator {
     this.entries = pkg.pob.entries;
     this.babelEnvs =
       pkg.pob.babelEnvs ||
-      (pkg.pob.bundler === "rollup-babel" && pkg.pob.envs) ||
+      (((!pkg.pob.bundler && pkg.pob.typescript !== true) ||
+        pkg.pob.bundler === "rollup-babel") &&
+        pkg.pob.envs) ||
       [];
 
     if (this.entries) {
@@ -428,7 +438,7 @@ export default class CommonBabelGenerator extends Generator {
           },
         );
       }
-    } else if (!pkg.pob.typescript && pkg.pob.rollup !== false) {
+    } else if (pkg.pob.typescript !== true && pkg.pob.rollup !== false) {
       this.fs.delete("rollup.config.mjs");
     }
 

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -172,9 +172,12 @@ export default class CommonTestingGenerator extends Generator {
       ? false
       : // eslint-disable-next-line unicorn/no-nested-ternary
         this.options.monorepo
-        ? yoConfigPobMonorepo.typescript
+        ? yoConfigPobMonorepo.typescript &&
+          yoConfigPobMonorepo.typescript !== "check-only"
         : packageUtils.transpileWithBabel(pkg);
-    const withTypescript = transpileWithBabel || pkg.pob?.typescript;
+    const withTypescript =
+      transpileWithBabel ||
+      (pkg.pob?.typescript && pkg.pob.typescript !== "check-only");
     let hasReact =
       withTypescript &&
       (this.options.monorepo
@@ -188,6 +191,7 @@ export default class CommonTestingGenerator extends Generator {
 
     const tsTestUtil = (() => {
       if (testRunner === "vitest") return undefined;
+      if (!withTypescript) return undefined;
       if (this.options.swc || isJestRunner) return "swc";
       return "ts-node";
     })();
@@ -279,7 +283,6 @@ export default class CommonTestingGenerator extends Generator {
 
     const createTestCommand = ({
       coverage,
-      coverageLcov,
       coverageJson,
       watch,
       shouldUseExperimentalVmModules,
@@ -293,14 +296,10 @@ export default class CommonTestingGenerator extends Generator {
               ? "NODE_OPTIONS=--experimental-vm-modules "
               : ""
           }jest${watch ? " --watch" : ""}${
-            coverage || coverageJson || coverageLcov
-              ? ` --coverage ${
-                  coverageLcov
-                    ? "--coverageReporters=lcov"
-                    : `--coverageReporters=json${
-                        coverageJson ? "" : " --coverageReporters=text"
-                      }`
-                }`
+            coverage || coverageJson
+              ? ` --coverage ${`--coverageReporters=json${
+                  coverageJson ? "" : " --coverageReporters=text"
+                }`}`
               : ""
           }`;
         }
@@ -308,33 +307,32 @@ export default class CommonTestingGenerator extends Generator {
           if (!workspacesPattern && this.options.monorepo) {
             throw new Error("Invalid workspacesPattern");
           }
+          const experimentalTestCoverage = false; // todo configure src directory and remove test files
           return `${
             tsTestUtil === "ts-node"
               ? "TS_NODE_PROJECT=tsconfig.test.json "
               : ""
           }${
-            coverage || coverageJson || coverageLcov
+            coverage || coverageJson
               ? `npx c8${
-                  coverageLcov || coverageJson
+                  coverageJson
                     ? ` --reporter=${coverageJson ? "json" : "lcov"}`
                     : ""
-                } --src ./${this.options.srcDirectory} `
+                } --all --src ./${this.options.srcDirectory} `
               : ""
           }node ${
             this.options.typescript ? `${tsTestLoaderOption} ` : ""
-          }--test ${this.options.monorepo ? `${workspacesPattern}/` : ""}${`${
+          }--test${experimentalTestCoverage && (coverage || coverageJson) ? " --experimental-test-coverage" : ""} ${this.options.monorepo ? `${workspacesPattern}/` : ""}${`${
             hasTestFolder ? "test/*" : `${this.options.srcDirectory}/**/*.test`
           }.${this.options.typescript ? "ts" : "js"}`}`;
         }
         case "vitest": {
           return `${
-            coverage || coverageJson || coverageLcov
-              ? `POB_VITEST_COVERAGE=${
-                  coverageLcov ? "lcov" : `json${coverageJson ? "" : ",text"} `
-                }`
+            coverage || coverageJson
+              ? `POB_VITEST_COVERAGE=${`json${coverageJson ? "" : ",text"} `}`
               : ""
           }vitest${watch ? " --watch" : ""}${
-            coverage || coverageJson || coverageLcov ? " run --coverage" : ""
+            coverage || coverageJson ? " run --coverage" : ""
           }`;
         }
         default: {
@@ -413,6 +411,7 @@ export default class CommonTestingGenerator extends Generator {
         if (this.options.monorepo) {
           const shouldUseExperimentalVmModules = pkg.type === "module";
 
+          packageUtils.removeScripts(["test:coverage:lcov"]);
           packageUtils.addScripts(pkg, {
             test: createTestCommand({
               workspacesPattern,
@@ -428,11 +427,6 @@ export default class CommonTestingGenerator extends Generator {
               shouldUseExperimentalVmModules,
               coverage: true,
             }),
-            "test:coverage:lcov": createTestCommand({
-              workspacesPattern,
-              shouldUseExperimentalVmModules,
-              coverageLcov: true,
-            }),
             "test:coverage:json": createTestCommand({
               workspacesPattern,
               shouldUseExperimentalVmModules,
@@ -526,6 +520,7 @@ export default class CommonTestingGenerator extends Generator {
             const shouldUseExperimentalVmModules =
               pkg.type === "module" && !inMonorepo;
 
+            packageUtils.removeScripts(["test:coverage:lcov"]);
             packageUtils.addScripts(pkg, {
               test: createTestCommand({ shouldUseExperimentalVmModules }),
               "test:watch": createTestCommand({
@@ -536,10 +531,6 @@ export default class CommonTestingGenerator extends Generator {
                 shouldUseExperimentalVmModules,
                 coverage: true,
               }),
-              "test:coverage:lcov": createTestCommand({
-                shouldUseExperimentalVmModules,
-                coverageLcov: true,
-              }),
               "test:coverage:json": createTestCommand({
                 shouldUseExperimentalVmModules,
                 coverageJson: true,

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -120,7 +120,7 @@ export default class CommonTranspilerGenerator extends Generator {
     this.entries = pkg.pob.entries;
     this.babelEnvs = pkg.pob.babelEnvs || [];
 
-    if (this.babelEnvs.length > 0 || pkg.pob.typescript) {
+    if (this.babelEnvs.length > 0 || pkg.pob.typescript === true) {
       fs.mkdirSync(this.destinationPath("src"), { recursive: true });
     } else {
       // recursive does not throw if directory already exists
@@ -131,13 +131,17 @@ export default class CommonTranspilerGenerator extends Generator {
   default() {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const withBabel = this.babelEnvs && this.babelEnvs.length > 0;
-    const withTypescript = pkg.pob.typescript || withBabel || !!pkg.pob.bundler;
+    const withTypescript =
+      pkg.pob.typescript === true || withBabel || !!pkg.pob.bundler;
     const bundler =
       withTypescript &&
-      (pkg.pob.rollup === false
+      (pkg.pob.rollup === false ||
+      (!pkg.pob.bundler && !pkg.pob.typescript === true)
         ? "tsc"
         : (pkg.pob.bundler ??
-          (pkg.pob.typescript ? "rollup-typescript" : "rollup-babel")));
+          (pkg.pob.typescript === true
+            ? "rollup-typescript"
+            : "rollup-babel")));
     this.bundler = bundler;
 
     const cleanCommand = (() => {
@@ -572,9 +576,10 @@ export default class CommonTranspilerGenerator extends Generator {
 
     this.fs.delete("rollup.config.js");
     if (
-      pkg.pob.typescript &&
+      pkg.pob.typescript === true &&
       pkg.pob.rollup !== false &&
-      (!pkg.pob.bundler || pkg.pob.bundler.startsWith("rollup"))
+      ((!pkg.pob.bundler && pkg.pob.typescript !== true) ||
+        pkg.pob.bundler?.startsWith("rollup"))
     ) {
       if (this.options.isApp) {
         copyAndFormatTpl(

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -107,6 +107,13 @@ export default class CommonTypescriptGenerator extends Generator {
       default: false,
       description: "only latest lts",
     });
+
+    this.option("onlyCheck", {
+      type: Boolean,
+      required: false,
+      default: false,
+      description: "only check js",
+    });
   }
 
   writing() {
@@ -262,7 +269,9 @@ export default class CommonTypescriptGenerator extends Generator {
       */
       copyAndFormatTpl(
         this.fs,
-        this.templatePath("tsconfig.json.ejs"),
+        this.options.onlyCheck
+          ? this.templatePath("tsconfig.check-js.json.ejs")
+          : this.templatePath("tsconfig.json.ejs"),
         tsconfigPath,
         {
           emitDefinitions: this.options.builddefs,

package/lib/generators/common/typescript/templates/{tsconfig.js.json.ejs → tsconfig.check-js.json.ejs}

@@ -8,5 +8,5 @@
     "checkJs": true,
     "noEmit": true
   },
-  "include": ["lib/**/*.js"]
+  "include": ["<%= srcDirectory %>/**/*.js"]
 }

package/lib/generators/core/ci/templates/github-action-documentation-workflow.yml.ejs

@@ -32,10 +32,16 @@ jobs:
         run: yarn typedoc --tsconfig tsconfig.doc.json
 <% } -%>
 
-<% if (testing && testRunner === 'jest') { -%>
+<% if (testing) { -%>
+<% if (testRunner === 'node') { -%>
 
       - name: Generate Coverage
-        run: yarn test:coverage:lcov --coverageDirectory=docs/coverage/
+        run: NODE_V8_COVERAGE=./docs/coverage yarn test:coverage
+<% } else {-%>
+
+      - name: Generate Coverage
+        run: yarn test:coverage:json<%- testRunner === 'jest' ? " --coverageDirectory=docs/coverage/" : "" %>
+<% } -%>
 <% } -%>
 
       - name: Create nojekyll

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -118,13 +118,16 @@ jobs:
         if: matrix.node-version != 18
 
       - name: Generate Test Coverage
-        run: <%= packageManager %> run test:coverage
+        run: <%= packageManager %> run test:coverage:json
         if: matrix.node-version == 18
+        env:
+          CI: true
 
       - name: Send results to codecov
         uses: codecov/codecov-action@v4
         if: matrix.node-version == 18
         with:
+          fail_ci_if_error: true
           token: ${{ secrets.CODECOV_TOKEN }}
 <% } else { -%>
 

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -65,11 +65,11 @@ jobs:
         if: startsWith(matrix.node-version, '20.')
         env:
           CI: true
-          NODE_V8_COVERAGE: coverage/
 
       - name: Send results to codecov
         uses: codecov/codecov-action@v4
         with:
+          fail_ci_if_error: true
           token: ${{ secrets.CODECOV_TOKEN }}
         if: startsWith(matrix.node-version, '20.')
 <% } else if (testing) { -%>

package/lib/generators/lib/PobLibGenerator.js

@@ -260,7 +260,9 @@ export default class PobLibGenerator extends Generator {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const babelEnvs =
       pkg.pob.babelEnvs ||
-      (pkg.pob.bundler === "rollup-babel" && pkg.pob.envs) ||
+      (((!pkg.pob.bundler && pkg.pob.typescript !== true) ||
+        pkg.pob.bundler === "rollup-babel") &&
+        pkg.pob.envs) ||
       [];
 
     const withBabel = babelEnvs.length > 0;
@@ -269,7 +271,15 @@ export default class PobLibGenerator extends Generator {
     const browser = pkg.pob.envs?.some((env) => env.target === "browser");
 
     this.composeWith("pob:common:typescript", {
-      enable: withTypescript,
+      enable:
+        withTypescript ||
+        pkg.pob.typescript === "check-only" ||
+        (inMonorepo &&
+          inMonorepo.pobMonorepoConfig.typescript === "check-only"),
+      onlyCheck:
+        pkg.pob.typescript === "check-only" ||
+        (inMonorepo &&
+          inMonorepo.pobMonorepoConfig.typescript === "check-only"),
       isApp: false,
       dom: browser,
       jsx,
@@ -277,6 +287,7 @@ export default class PobLibGenerator extends Generator {
       baseUrl: "none", // causes issues on dist definition files
       builddefs: true,
       onlyLatestLTS: false,
+      srcDirectory: withTypescript ? "src" : "lib",
     });
 
     this.composeWith("pob:common:husky", {});
@@ -311,6 +322,7 @@ export default class PobLibGenerator extends Generator {
     // must be after testing
     this.composeWith("pob:common:format-lint", {
       typescript: withTypescript,
+      build: withTypescript,
       documentation:
         !!this.pobjson.documentation ||
         !!(this.pobjson.testing && this.pobjson.testing.codecov),
@@ -387,9 +399,11 @@ export default class PobLibGenerator extends Generator {
     }
 
     const withBabel = Boolean(
-      pkg.pob.babelEnvs || pkg.pob.bundler === "rollup-babel",
+      pkg.pob.babelEnvs ||
+        (!pkg.pob.bundler && pkg.pob.typescript !== true && pkg.pob.envs) ||
+        pkg.pob.bundler === "rollup-babel",
     );
-    const withTypescript = pkg.pob.typescript === true;
+    const withTypescript = withBabel || pkg.pob.typescript === true;
 
     packageUtils.removeDevDependencies(pkg, ["lerna", "@pob/lerna-light"]);
     if (inMonorepo) {

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -232,7 +232,7 @@ export default class PobMonorepoGenerator extends Generator {
       enableYarnVersion: isYarnVersionEnabled,
       testing: this.pobLernaConfig.testing,
       e2eTesting: this.pobLernaConfig.e2eTesting,
-      build: this.pobLernaConfig.typescript,
+      build: this.pobLernaConfig.typescript === true,
       typescript: this.pobLernaConfig.typescript,
       documentation: !!this.pobLernaConfig.documentation,
       codecov: this.pobLernaConfig.testing && this.pobLernaConfig.codecov,
@@ -247,6 +247,7 @@ export default class PobMonorepoGenerator extends Generator {
       monorepo: true,
       documentation: this.pobLernaConfig.documentation,
       typescript: this.pobLernaConfig.typescript,
+      build: this.pobLernaConfig.typescript === true,
       testing: this.pobLernaConfig.testing,
       testRunner: this.pobLernaConfig.testRunner,
       packageManager: this.options.packageManager,
@@ -304,6 +305,7 @@ export default class PobMonorepoGenerator extends Generator {
 
     this.composeWith("pob:monorepo:typescript", {
       enable: this.pobLernaConfig.typescript,
+      checkOnly: this.pobLernaConfig.typescript === "check-only",
       isAppProject: this.options.isAppProject,
       packageNames: JSON.stringify(packageNames),
       packagePaths: JSON.stringify(packagePaths),

package/lib/generators/monorepo/typescript/MonorepoTypescriptGenerator.js

@@ -34,6 +34,12 @@ export default class MonorepoTypescriptGenerator extends Generator {
       required: false,
       default: "jest",
     });
+
+    this.option("checkOnly", {
+      type: Boolean,
+      required: false,
+      default: false,
+    });
   }
 
   writing() {
@@ -60,13 +66,17 @@ export default class MonorepoTypescriptGenerator extends Generator {
       packageUtils.addScripts(pkg, {
         tsc: "tsc -b",
       });
-      packageUtils.addOrRemoveScripts(pkg, !this.options.isAppProject, {
-        "build:definitions": "tsc -b",
-      });
+      packageUtils.addOrRemoveScripts(
+        pkg,
+        !this.options.isAppProject && !this.options.checkOnly,
+        {
+          "build:definitions": "tsc -b",
+        },
+      );
 
       delete pkg.scripts.postbuild;
 
-      if (!this.options.isAppProject) {
+      if (!this.options.isAppProject && !this.options.checkOnly) {
         pkg.scripts.build += " && yarn run build:definitions";
       }
     } else if (pkg.scripts) {

package/lib/generators/monorepo/workspaces/MonorepoWorkspacesGenerator.js

@@ -61,7 +61,7 @@ export default class MonorepoWorkspacesGenerator extends Generator {
       babelEnvs: [],
       ...(config && config.pob),
     });
-    const withBabel = this.packages.some((config) => {
+    const withBundler = this.packages.some((config) => {
       const pobConfig = getPackagePobConfig(config);
       return (
         pobConfig.babelEnvs.length > 0 || pobConfig.bundler === "rollup-babel"
@@ -120,12 +120,14 @@ export default class MonorepoWorkspacesGenerator extends Generator {
       },
     );
 
-    packageUtils.addOrRemoveScripts(pkg, withBabel, {
-      build:
-        "yarn workspaces foreach --parallel --topological-dev -Av run build",
-      watch:
-        'yarn workspaces foreach --parallel --jobs unlimited --interlaced --exclude "*-example" -Av run watch',
-    });
+    if (this.options.isAppProject) {
+      packageUtils.addOrRemoveScripts(pkg, withBundler, {
+        build:
+          "yarn workspaces foreach --parallel --topological-dev -Av run build",
+        watch:
+          'yarn workspaces foreach --parallel --jobs unlimited --interlaced --exclude "*-example" -Av run watch',
+      });
+    }
 
     // packageUtils.addOrRemoveScripts(pkg, withTypescript, {
     //   'build:definitions': `${

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "23.1.0",
+  "version": "23.2.1",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -65,16 +65,16 @@
     "mem-fs-editor": "11.0.1",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "14.1.0",
+    "pob-dependencies": "14.1.1",
     "prettier": "3.3.3",
     "semver": "7.6.3",
     "validate-npm-package-name": "^5.0.0",
-    "yarn-workspace-utils": "6.0.2",
+    "yarn-workspace-utils": "6.0.3",
     "yeoman-environment": "4.4.1",
     "yeoman-generator": "7.3.2"
   },
   "devDependencies": {
-    "@pob/root": "13.1.0",
+    "@pob/root": "13.2.0",
     "@types/node": "20.14.15",
     "typescript": "5.5.4"
   }