pob 22.2.0 → 22.3.0

package/CHANGELOG.md

@@ -3,6 +3,21 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [22.3.0](https://github.com/christophehurpeau/pob/compare/pob@22.2.0...pob@22.3.0) (2024-07-30)
+
+### Features
+
+* **deps:** update @pob/eslint-config to v56.1.0 ([#2149](https://github.com/christophehurpeau/pob/issues/2149)) ([061b9d7](https://github.com/christophehurpeau/pob/commit/061b9d7d43bc1826e1d7fdbebd0c812f37d2c91b))
+* **pob:** move more stuff from commonbabel to commontranspiler ([fad5d29](https://github.com/christophehurpeau/pob/commit/fad5d2902ea91370af3a4218b0624c34e691bad3))
+
+### Bug Fixes
+
+* **pob:** fix template ([035eff7](https://github.com/christophehurpeau/pob/commit/035eff78368cca1e3c60be4ddf44b16eae8b28c2))
+
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: @pob/root
+
+
 ## [22.2.0](https://github.com/christophehurpeau/pob/compare/pob@22.1.1...pob@22.2.0) (2024-07-27)
 
 ### Features

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -1,4 +1,3 @@
-import semver from "semver";
 import Generator from "yeoman-generator";
 import * as packageUtils from "../../../utils/package.js";
 import { copyAndFormatTpl } from "../../../utils/writeAndFormat.js";
@@ -220,18 +219,6 @@ export default class CommonBabelGenerator extends Generator {
       babelConfig.browserVersions = ["supported"];
     }
 
-    if (hasInitialPkgPob && pkg.main && !pkg.exports) {
-      const result = await this.prompt({
-        type: "confirm",
-        name: "setupExports",
-        message: 'Setup package.json "exports" field based on "main" ?',
-      });
-
-      if (result.setupExports) {
-        pkg.exports = pkg.main;
-      }
-    }
-
     const newBabelEnvs = [
       ...(babelConfig.nodeVersions || []).map((version) => ({
         target: "node",
@@ -260,7 +247,6 @@ export default class CommonBabelGenerator extends Generator {
       })),
     ];
 
-    delete pkg.pob.withReact;
     if (newBabelEnvs.length === 0) {
       if (!pkg.pob.bundler || pkg.pob.bundler === "rollup-babel") {
         delete pkg.pob.envs;
@@ -319,10 +305,6 @@ export default class CommonBabelGenerator extends Generator {
   default() {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const useBabel = this.babelEnvs && this.babelEnvs.length > 0;
-    const useTypescript = useBabel || pkg.pob?.typescript;
-    const hasTargetNode = useBabel
-      ? this.babelEnvs.find((env) => env.target === "node")
-      : useTypescript; // todo pkg.pob.typescriptTargets
     const hasTargetBrowser = this.babelEnvs.find(
       (env) => env.target === "browser",
     );
@@ -370,57 +352,6 @@ export default class CommonBabelGenerator extends Generator {
       ["@babel/preset-env"],
     );
 
-    /* engines */
-
-    if (hasTargetNode) {
-      if (!pkg.engines) pkg.engines = {};
-      const minNodeVersion = useBabel
-        ? Math.min(
-            ...this.babelEnvs
-              .filter((env) => env.target === "node")
-              .map((env) => env.version),
-          )
-        : // eslint-disable-next-line unicorn/no-unreadable-iife
-          (() => (this.options.onlyLatestLTS ? "20" : "18"))();
-      switch (String(minNodeVersion)) {
-        case "10":
-        case "12":
-        case "14":
-        case "16":
-        case "18":
-          pkg.engines.node = ">=18.12.0";
-          break;
-        case "20":
-          pkg.engines.node = ">=20.9.0";
-          break;
-        default:
-          throw new Error(`Invalid min node version: ${minNodeVersion}`);
-      }
-
-      if (pkg.dependencies && pkg.dependencies["@types/node"]) {
-        pkg.dependencies["@types/node"] = `>=${minNodeVersion}.0.0`;
-      }
-      if (
-        pkg.devDependencies &&
-        pkg.devDependencies["@types/node"] &&
-        !semver.satisfies(
-          pkg.devDependencies["@types/node"],
-          `>=${minNodeVersion}.0.0`,
-        )
-      ) {
-        pkg.devDependencies["@types/node"] = `>=${minNodeVersion}.0.0`;
-      }
-    } else {
-      packageUtils.removeDependencies(pkg, ["@types/node"]);
-      packageUtils.removeDevDependencies(pkg, ["@types/node"]);
-      // Supports oldest current or active LTS version of node
-      if (this.options.onlyLatestLTS) {
-        pkg.engines.node = ">=20.9.0";
-      } else {
-        pkg.engines.node = ">=18.12.0";
-      }
-    }
-
     /* browserslist */
 
     if (hasTargetBrowser) {

package/lib/generators/common/husky/templates/lint-staged.config.cjs.txt

@@ -1,5 +1,5 @@
-'use strict';
+"use strict";
 
-const createLintStagedConfig = require('@pob/root/createLintStagedConfig.cjs');
+const createLintStagedConfig = require("@pob/root/createLintStagedConfig.cjs");
 
 module.exports = createLintStagedConfig();

package/lib/generators/common/transpiler/CommonTranspilerGenerator.js

@@ -302,13 +302,6 @@ export default class CommonTranspilerGenerator extends Generator {
           pkg.types = "./lib/index.d.ts";
         }
       }
-      if (!pkg.engines) pkg.engines = {};
-      if (
-        !pkg.engines.node ||
-        semver.lt(semver.minVersion(pkg.engines.node), "18.0.0")
-      ) {
-        pkg.engines.node = ">=18.0.0";
-      }
     }
 
     delete pkg["browser-dev"];
@@ -518,6 +511,64 @@ export default class CommonTranspilerGenerator extends Generator {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const entries = pkg.pob.entries || ["index"];
     const envs = pkg.pob.envs || pkg.pob.babelEnvs;
+    delete pkg.pob.withReact;
+
+    const hasTargetNode = envs && envs.some((env) => env.target === "node");
+
+    if (!pkg.engines) pkg.engines = {};
+
+    if (hasTargetNode || !envs) {
+      const minNodeVersion = envs
+        ? Math.min(
+            ...envs
+              .filter((env) => env.target === "node")
+              .map((env) => env.version),
+          )
+        : // eslint-disable-next-line unicorn/no-unreadable-iife
+          (() => (this.options.onlyLatestLTS ? "20" : "18"))();
+
+      switch (String(minNodeVersion)) {
+        case "10":
+        case "12":
+        case "14":
+        case "16":
+        case "18":
+          pkg.engines.node = ">=18.12.0";
+          break;
+        case "20":
+          pkg.engines.node = ">=20.9.0";
+          break;
+        default:
+          throw new Error(`Invalid min node version: ${minNodeVersion}`);
+      }
+
+      if (pkg.dependencies && pkg.dependencies["@types/node"]) {
+        pkg.dependencies["@types/node"] = `>=${minNodeVersion}.0.0`;
+      }
+      if (
+        pkg.devDependencies &&
+        pkg.devDependencies["@types/node"] &&
+        !semver.satisfies(
+          pkg.devDependencies["@types/node"],
+          `>=${minNodeVersion}.0.0`,
+        )
+      ) {
+        pkg.devDependencies["@types/node"] = `>=${minNodeVersion}.0.0`;
+      }
+    } else {
+      packageUtils.removeDependencies(pkg, ["@types/node"]);
+      packageUtils.removeDevDependencies(pkg, ["@types/node"]);
+
+      // Supports oldest current or active LTS version of node
+      const minVersion = this.options.onlyLatestLTS ? "20.9.0" : "18.12.0";
+
+      if (
+        !pkg.engines.node ||
+        semver.lt(semver.minVersion(pkg.engines.node), minVersion)
+      ) {
+        pkg.engines.node = `>=${minVersion}`;
+      }
+    }
 
     this.fs.delete("rollup.config.js");
     if (

package/lib/generators/core/package/CorePackageGenerator.js

@@ -66,6 +66,18 @@ export default class CorePackageGenerator extends Generator {
       delete pkg.packageManager;
     }
 
+    if (pkg.pob && pkg.main && !pkg.exports) {
+      const result = await this.prompt({
+        type: "confirm",
+        name: "setupExports",
+        message: 'Setup package.json "exports" field based on "main" ?',
+      });
+
+      if (result.setupExports) {
+        pkg.exports = pkg.main;
+      }
+    }
+
     if (!this.options.updateOnly) {
       if (this.options.isMonorepo && this.options.isRoot) {
         pkg.private = true;

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -322,6 +322,13 @@ export default class PobMonorepoGenerator extends Generator {
   writing() {
     if (!this.options.isAppProject) {
       const pkg = this.fs.readJSON(this.destinationPath("package.json"), {});
+      const rollupKinds = new Set();
+
+      this.packages.forEach((pkg) => {
+        if (pkg.pob?.bundler && pkg.pob.bundler.startsWith("rollup-")) {
+          rollupKinds.add(pkg.pob.bundler.slice("rollup-".length));
+        }
+      });
 
       const rollupConfigs = [];
       this.packageLocations.forEach((location) => {
@@ -351,10 +358,12 @@ export default class PobMonorepoGenerator extends Generator {
         build: "yarn clean:build && rollup --config rollup.config.mjs",
         watch: "yarn clean:build && rollup --config rollup.config.mjs --watch",
       });
-      packageUtils.addOrRemoveDevDependencies(pkg, rollupConfigs.length, [
-        "@babel/core",
-        "pob-babel",
-      ]);
+      packageUtils.addOrRemoveDevDependencies(
+        pkg,
+        rollupConfigs.length > 0 &&
+          (rollupKinds.size === 0 || rollupKinds.has("babel")),
+        ["@babel/core", "pob-babel"],
+      );
       this.fs.writeJSON(this.destinationPath("package.json"), pkg);
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "22.2.0",
+  "version": "22.3.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -40,9 +40,9 @@
   "pob": {},
   "prettier": "@pob/root/prettier-config",
   "dependencies": {
-    "@pob/eslint-config": "56.0.0",
-    "@pob/eslint-config-typescript": "56.0.0",
-    "@pob/eslint-config-typescript-react": "56.0.0",
+    "@pob/eslint-config": "56.1.0",
+    "@pob/eslint-config-typescript": "56.1.0",
+    "@pob/eslint-config-typescript-react": "56.1.0",
     "@pob/sort-eslint-config": "5.3.1",
     "@pob/sort-object": "6.3.1",
     "@pob/sort-pkg": "7.3.0",
@@ -64,17 +64,17 @@
     "mem-fs-editor": "11.0.1",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "13.2.0",
+    "pob-dependencies": "13.3.0",
     "prettier": "3.3.3",
     "semver": "7.6.3",
     "validate-npm-package-name": "^5.0.0",
-    "yarn-workspace-utils": "5.1.0",
+    "yarn-workspace-utils": "5.1.1",
     "yeoman-environment": "4.4.1",
     "yeoman-generator": "7.3.2"
   },
   "devDependencies": {
-    "@pob/root": "12.2.0",
-    "@types/node": "20.14.12",
-    "typescript": "5.4.5"
+    "@pob/root": "12.2.1",
+    "@types/node": "20.14.13",
+    "typescript": "5.5.4"
   }
 }