pob 20.0.0 → 21.1.0

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -11,13 +11,13 @@ export default class CommonTypescriptGenerator extends Generator {
     this.option("enable", {
       type: Boolean,
       default: true,
-      desc: "enable typescript",
+      description: "enable typescript",
     });
 
     this.option("isApp", {
       type: Boolean,
       required: true,
-      desc: "is app",
+      description: "is app",
     });
 
     this.option("isAppLibrary", {
@@ -29,66 +29,67 @@ export default class CommonTypescriptGenerator extends Generator {
     this.option("rootDir", {
       type: String,
       default: "src",
-      desc: "customize rootDir",
+      description: "customize rootDir",
     });
 
     this.option("srcDirectory", {
       type: String,
       default: "src",
-      desc: "customize srcDirectory, if different than rootDir",
+      description: "customize srcDirectory, if different than rootDir",
     });
 
     this.option("jsx", {
       type: Boolean,
       default: true,
-      desc: "enable jsx with typescript",
+      description: "enable jsx with typescript",
     });
 
     this.option("jsxPreserve", {
       type: Boolean,
       default: false,
-      desc: "force jsx preserve in tsconfig for legacy apps (nextjs, CRA)",
+      description:
+        "force jsx preserve in tsconfig for legacy apps (nextjs, CRA)",
     });
 
     this.option("forceExcludeNodeModules", {
       type: Boolean,
       default: false,
-      desc: "force exclude node_modules for legacy apps (nextjs, CRA)",
+      description: "force exclude node_modules for legacy apps (nextjs, CRA)",
     });
 
     this.option("forceAllowJs", {
       type: Boolean,
       default: false,
-      desc: "force allow js for legacy apps (nextjs, CRA)",
+      description: "force allow js for legacy apps (nextjs, CRA)",
     });
 
     this.option("dom", {
       type: Boolean,
       default: true,
-      desc: "enable dom with typescript",
+      description: "enable dom with typescript",
     });
 
     this.option("baseUrl", {
       type: String,
       default: "",
-      desc: "baseUrl option",
+      description: "baseUrl option",
     });
 
     this.option("resolveJsonModule", {
       type: Boolean,
       default: false,
-      desc: "resolveJsonModule option",
+      description: "resolveJsonModule option",
     });
 
     this.option("builddefs", {
       type: Boolean,
       default: true,
-      desc: "build .d.ts option",
+      description: "build .d.ts option",
     });
     this.option("plugins", {
       type: String,
       default: "",
-      desc: "typescript plugins",
+      description: "typescript plugins",
     });
     this.option("nextConfig", {
       type: Boolean,
@@ -97,14 +98,14 @@ export default class CommonTypescriptGenerator extends Generator {
     this.option("additionalIncludes", {
       type: String,
       default: "",
-      desc: "typescript additional includes",
+      description: "typescript additional includes",
     });
 
     this.option("onlyLatestLTS", {
       type: Boolean,
       required: false,
       default: false,
-      desc: "only latest lts",
+      description: "only latest lts",
     });
   }
 
@@ -117,7 +118,10 @@ export default class CommonTypescriptGenerator extends Generator {
     const pkg = this.fs.readJSON(this.destinationPath("package.json"));
 
     const presets = (() => {
-      const babelEnvs = pkg.pob?.babelEnvs || [];
+      const babelEnvs =
+        pkg.pob?.babelEnvs ||
+        (pkg.pob?.bundler === "rollup-babel" && pkg.pob.envs) ||
+        [];
       const withBabel = babelEnvs.length > 0;
       const withTypescript = withBabel || pkg.pob?.typescript === true;
       const jsx = (withBabel || withTypescript) && pkg.pob.jsx === true;
@@ -166,7 +170,7 @@ export default class CommonTypescriptGenerator extends Generator {
       pkg,
       this.options.enable ||
         this.fs.exists(this.destinationPath("lib/index.d.ts")),
-      ["typescript"]
+      ["typescript"],
     );
 
     const tsconfigPath = this.destinationPath("tsconfig.json");
@@ -193,7 +197,7 @@ export default class CommonTypescriptGenerator extends Generator {
           packageUtils.addOrRemoveDevDependencies(
             pkg,
             inMonorepo.rootPackageManager === "yarn",
-            ["typescript"]
+            ["typescript"],
           );
 
           const packageLocations = new Map(
@@ -202,7 +206,7 @@ export default class CommonTypescriptGenerator extends Generator {
                 (packageName) =>
                   (pkg.dependencies && pkg.dependencies[packageName]) ||
                   (pkg.devDependencies && pkg.devDependencies[packageName]) ||
-                  (pkg.peerDependencies && pkg.peerDependencies[packageName])
+                  (pkg.peerDependencies && pkg.peerDependencies[packageName]),
               )
               .map((packageName) => [
                 packageName,
@@ -211,12 +215,12 @@ export default class CommonTypescriptGenerator extends Generator {
                     ? // eslint-disable-next-line unicorn/no-nested-ternary
                       yoConfig.pob.project.type === "app"
                       ? `packages/${packageName.slice(
-                          packageName.indexOf("/") + 1
+                          packageName.indexOf("/") + 1,
                         )}`
                       : packageName
                     : `packages/${packageName}`
                 }`,
-              ])
+              ]),
           );
 
           monorepoPackageSrcPaths = [...packageLocations.entries()].map(
@@ -227,11 +231,11 @@ export default class CommonTypescriptGenerator extends Generator {
                   ? "src"
                   : "lib"
               }`,
-            ]
+            ],
           );
           monorepoPackageReferences = yoConfig.pob.monorepo.packageNames
             .filter((packageName) =>
-              existsSync(`${packageLocations.get(packageName)}/tsconfig.json`)
+              existsSync(`${packageLocations.get(packageName)}/tsconfig.json`),
             )
             .map((packageName) => packageLocations.get(packageName));
           // monorepoPackageBuildReferences = yoConfig.pob.monorepo.packageNames
@@ -282,7 +286,7 @@ export default class CommonTypescriptGenerator extends Generator {
             .split(",")
             .filter(Boolean),
           presets,
-        }
+        },
       );
 
       // if (

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -13,98 +13,93 @@ export default class CoreCIGenerator extends Generator {
     this.option("enable", {
       type: Boolean,
       default: true,
-      desc: "enable ci",
+      description: "enable ci",
     });
 
     this.option("enableReleasePlease", {
       type: Boolean,
       default: true,
-      desc: "enable release-please",
+      description: "enable release-please",
     });
 
     this.option("enableYarnVersion", {
       type: Boolean,
       default: true,
-      desc: "enable yarn version conventional commits",
+      description: "enable yarn version conventional commits",
     });
 
     this.option("build", {
       type: Boolean,
       default: true,
-      desc: "enable build",
+      description: "enable build",
     });
 
     this.option("typescript", {
       type: Boolean,
       default: true,
-      desc: "enable typescript",
+      description: "enable typescript",
     });
 
     this.option("testing", {
       type: Boolean,
       default: true,
-      desc: "enable testing",
+      description: "enable testing",
     });
     this.option("testRunner", {
       type: String,
       required: false,
       default: "jest",
-      desc: "test runner: jest | node",
+      description: "test runner: jest | node",
     });
 
     this.option("e2eTesting", {
       type: String,
       default: "",
-      desc: "e2e testing package path",
+      description: "e2e testing package path",
     });
 
-    // this.option('babelEnvs', {
-    //   type: String,
-    //   required: true,
-    //   desc: 'Babel Envs',
-    // });
-
     this.option("ci", {
       type: Boolean,
       required: true,
-      desc: "ci with github actions",
+      description: "ci with github actions",
     });
 
     this.option("codecov", {
       type: Boolean,
       required: true,
-      desc: "Include codecov report",
+      description: "Include codecov report",
     });
 
     this.option("documentation", {
       type: Boolean,
       required: true,
-      desc: "Include documentation generation",
+      description: "Include documentation generation",
     });
 
     this.option("isApp", {
       type: Boolean,
       required: true,
-      desc: "is app",
+      description: "is app",
     });
 
     this.option("onlyLatestLTS", {
       type: Boolean,
       required: true,
-      desc: "only latest lts",
+      description: "only latest lts",
     });
 
     this.option("splitJobs", {
       type: Boolean,
       required: true,
-      desc: "split CI jobs for faster result",
+      description: "split CI jobs for faster result",
     });
 
     this.option("disableYarnGitCache", {
       type: Boolean,
       required: false,
       default: false,
-      desc: "Disable git cache. See https://yarnpkg.com/features/caching#offline-mirror.",
+      description:
+        "Disable git cache. See https://yarnpkg.com/features/caching#offline-mirror.",
     });
   }
 
@@ -150,7 +145,7 @@ export default class CoreCIGenerator extends Generator {
         this.templatePath(
           this.options.splitJobs
             ? "github-action-push-workflow-split.yml.ejs"
-            : "github-action-push-workflow.yml.ejs"
+            : "github-action-push-workflow.yml.ejs",
         ),
         this.destinationPath(".github/workflows/push.yml"),
         {
@@ -174,7 +169,7 @@ export default class CoreCIGenerator extends Generator {
             inMonorepo &&
             inMonorepo.root &&
             inMonorepo.pobConfig?.project?.type === "lib",
-        }
+        },
       );
 
       ciContexts.push(
@@ -190,7 +185,7 @@ export default class CoreCIGenerator extends Generator {
           : [
               !this.options.onlyLatestLTS && "build (18.x)",
               "build (20.x)",
-            ].filter(Boolean))
+            ].filter(Boolean)),
       );
     } else {
       this.fs.delete(this.destinationPath(".github/workflows/push.yml"));
@@ -212,7 +207,7 @@ export default class CoreCIGenerator extends Generator {
           testing: this.options.testing,
           testRunner: this.options.testRunner,
           typedoc: this.options.documentation && this.options.typescript,
-        }
+        },
       );
     } else {
       this.fs.delete(this.destinationPath(".github/workflows/gh-pages.yml"));

package/lib/generators/core/clean/CoreCleanGenerator.js

@@ -8,7 +8,7 @@ export default class CoreCleanGenerator extends Generator {
       type: Boolean,
       required: false,
       default: true,
-      desc: "Root package.",
+      description: "Root package.",
     });
   }
 

package/lib/generators/core/editorconfig/CoreEditorConfigGenerator.js

@@ -4,7 +4,7 @@ export default class CoreEditorConfigGenerator extends Generator {
   writing() {
     this.fs.copy(
       this.templatePath("editorconfig"),
-      this.destinationPath(".editorconfig")
+      this.destinationPath(".editorconfig"),
     );
   }
 }

package/lib/generators/core/git/CoreGitGenerator.js

@@ -11,25 +11,25 @@ export default class CoreGitGenerator extends Generator {
       type: Boolean,
       required: false,
       default: "",
-      desc: "Should create the repo on github",
+      description: "Should create the repo on github",
     });
 
     this.option("onlyLatestLTS", {
       type: Boolean,
       required: true,
-      desc: "only latest lts",
+      description: "only latest lts",
     });
 
     this.option("splitCIJobs", {
       type: Boolean,
       required: true,
-      desc: "split CI jobs for faster result",
+      description: "split CI jobs for faster result",
     });
   }
 
   async initializing() {
     let originUrl = await remoteUrl(this.destinationPath(), "origin").catch(
-      () => ""
+      () => "",
     );
 
     if (!originUrl) {
@@ -42,7 +42,7 @@ export default class CoreGitGenerator extends Generator {
       originUrl &&
       typeof originUrl === "string" &&
       originUrl.match(
-        /^(?:git@|https?:\/\/)(?:([^./:]+)(?:\.com)?[/:])?([^/:]+)\/([^./:]+)(?:.git)?/
+        /^(?:git@|https?:\/\/)(?:([^./:]+)(?:\.com)?[/:])?([^/:]+)\/([^./:]+)(?:.git)?/,
       );
     if (!match) return;
     const [, gitHost, gitAccount, repoName] = match;
@@ -83,7 +83,7 @@ export default class CoreGitGenerator extends Generator {
         const pkg = this.fs.readJSON(this.destinationPath("package.json"), {});
         const author = packageUtils.parsePkgAuthor(pkg);
         this.gitHostAccount = await githubUsername(author.email).catch(
-          () => ""
+          () => "",
         );
       }
     }

package/lib/generators/core/git/generators/github/CoreGitGithubGenerator.js

@@ -70,36 +70,36 @@ export default class CoreGitGithubGenerator extends Generator {
       type: Boolean,
       required: false,
       default: "",
-      desc: "Should create the repo on github",
+      description: "Should create the repo on github",
     });
 
     this.option("gitHostAccount", {
       type: String,
       required: true,
-      desc: "host account",
+      description: "host account",
     });
 
     this.option("repoName", {
       type: String,
       required: true,
-      desc: "repo name",
+      description: "repo name",
     });
 
     this.option("onlyLatestLTS", {
       type: Boolean,
       required: true,
-      desc: "only latest lts",
+      description: "only latest lts",
     });
 
     this.option("splitCIJobs", {
       type: Boolean,
       required: true,
-      desc: "split CI jobs for faster result",
+      description: "split CI jobs for faster result",
     });
 
     if (!GITHUB_TOKEN && process.env.CI !== "true") {
       throw new Error(
-        "Missing POB_GITHUB_TOKEN. Create one with https://github.com/settings/tokens/new?scopes=repo&description=POB%20Generator and add it in your env variables."
+        "Missing POB_GITHUB_TOKEN. Create one with https://github.com/settings/tokens/new?scopes=repo&description=POB%20Generator and add it in your env variables.",
       );
     }
   }
@@ -146,7 +146,7 @@ export default class CoreGitGithubGenerator extends Generator {
               "origin",
               `git@github.com:christophehurpeau/${name}.git`,
             ],
-            { cwd }
+            { cwd },
           );
           console.error("Failed to create repository");
           console.error(error.stack || error.message || error);
@@ -154,7 +154,7 @@ export default class CoreGitGithubGenerator extends Generator {
         this.spawnCommandSync(
           "git",
           ["commit", "-m", "chore: initial commit [skip ci]"],
-          { cwd }
+          { cwd },
         );
         this.spawnCommandSync("git", ["branch", "-M", "main"], {
           cwd,

package/lib/generators/core/gitignore/CoreGitignoreGenerator.js

@@ -8,59 +8,55 @@ export default class CoreGitignoreGenerator extends Generator {
       type: Boolean,
       required: false,
       default: true,
-      desc: "Root package.",
+      description: "Root package.",
     });
 
     this.option("documentation", {
       type: Boolean,
       required: false,
       default: false,
-      desc: "Documentation enabled.",
+      description: "Documentation enabled.",
     });
 
     this.option("testing", {
       type: Boolean,
       required: false,
       default: false,
-      desc: "Testing enabled.",
+      description: "Testing enabled.",
     });
 
     this.option("withBabel", {
       type: Boolean,
       required: false,
       default: undefined,
-      desc: "Babel enabled.",
+      description: "Babel enabled.",
     });
 
     this.option("paths", {
       type: String,
       required: false,
       default: "",
-      desc: "Paths ignored.",
+      description: "Paths ignored.",
     });
 
     this.option("typescript", {
       type: Boolean,
       required: false,
       default: true,
-      desc: "Typescript use.",
+      description: "Typescript use.",
     });
 
     this.option("buildInGit", {
       type: Boolean,
       required: false,
       default: true,
-      desc: "Build is saved in git.",
+      description: "Build is saved in git.",
     });
   }
 
   writing() {
     const dest = this.destinationPath(".gitignore");
     const withBabel = this.options.withBabel;
-    // if (withBabel === undefined) {
-    //   const babelEnvs = (pkg.pob && pkg.pob.babelEnvs) || [];
-    //   withBabel = babelEnvs.length !== 0;
-    // }
 
     if (
       !this.options.root &&

package/lib/generators/core/npm/CoreNpmGenerator.js

@@ -8,20 +8,20 @@ export default class CoreNpmGenerator extends Generator {
       type: Boolean,
       required: false,
       default: true,
-      desc: "Enable npm",
+      description: "Enable npm",
     });
 
     this.option("srcDirectory", {
       type: String,
       required: true,
       default: "lib",
-      desc: "src directory to include in published files",
+      description: "src directory to include in published files",
     });
 
     this.option("distDirectory", {
       type: String,
       required: false,
-      desc: "dist directory to include in published files",
+      description: "dist directory to include in published files",
     });
   }
 
@@ -32,7 +32,7 @@ export default class CoreNpmGenerator extends Generator {
       this.fs.copyTpl(
         this.templatePath("npmignore.ejs"),
         this.destinationPath(".npmignore"),
-        {}
+        {},
       );
     } else if (this.fs.exists(this.destinationPath(".npmignore"))) {
       this.fs.delete(this.destinationPath(".npmignore"));