pob 19.2.0 → 21.0.0

package/lib/generators/lib/PobLibGenerator.js

@@ -1,66 +1,68 @@
-import { rmSync } from 'node:fs';
-import Generator from 'yeoman-generator';
-import inMonorepo from '../../utils/inMonorepo.js';
-import * as packageUtils from '../../utils/package.js';
+import { rmSync } from "node:fs";
+import Generator from "yeoman-generator";
+import inMonorepo from "../../utils/inMonorepo.js";
+import * as packageUtils from "../../utils/package.js";
 
 export default class PobLibGenerator extends Generator {
   constructor(args, opts) {
     super(args, opts);
 
-    this.option('updateOnly', {
+    this.option("updateOnly", {
       type: Boolean,
       required: false,
       default: false,
-      desc: 'Avoid asking questions',
+      description: "Avoid asking questions",
     });
 
-    this.option('fromPob', {
+    this.option("fromPob", {
       type: Boolean,
       required: false,
       default: false,
     });
 
-    this.option('packageManager', {
+    this.option("packageManager", {
       type: String,
-      default: 'yarn',
-      desc: 'yarn or npm',
+      default: "yarn",
+      description: "yarn or npm",
     });
 
-    this.option('yarnNodeLinker', {
+    this.option("yarnNodeLinker", {
       type: String,
       required: false,
-      default: 'node-modules',
-      desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
+      default: "node-modules",
+      description:
+        "Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.",
     });
 
-    this.option('disableYarnGitCache', {
+    this.option("disableYarnGitCache", {
       type: Boolean,
       required: false,
       default: false,
-      desc: 'Disable git cache. See https://yarnpkg.com/features/caching#offline-mirror.',
+      description:
+        "Disable git cache. See https://yarnpkg.com/features/caching#offline-mirror.",
     });
   }
 
   initializing() {
     this.pobjson =
-      this.config.get('lib') ||
-      this.config.get('pob') ||
-      this.config.get('pob-config') ||
-      this.config.get('pob-lib-config');
+      this.config.get("lib") ||
+      this.config.get("pob") ||
+      this.config.get("pob-config") ||
+      this.config.get("pob-lib-config");
 
     if (!this.pobjson) {
-      this.pobjson = this.fs.readJSON(this.destinationPath('.pob.json'), null);
+      this.pobjson = this.fs.readJSON(this.destinationPath(".pob.json"), null);
       if (this.pobjson) {
-        this.config.set('lib', this.pobjson);
+        this.config.set("lib", this.pobjson);
       }
     }
 
-    this.config.delete('libtest'); // deprecated
-    this.config.delete('pob'); // deprecated
-    this.config.delete('pob-config'); // deprecated
-    this.config.delete('pob-lib-config'); // deprecated
+    this.config.delete("libtest"); // deprecated
+    this.config.delete("pob"); // deprecated
+    this.config.delete("pob-config"); // deprecated
+    this.config.delete("pob-lib-config"); // deprecated
     this.config.save();
-    this.fs.delete('.pob.json'); // deprecated
+    this.fs.delete(".pob.json"); // deprecated
 
     if (!this.pobjson || this.pobjson.babelEnvs) {
       this.pobjson = {};
@@ -69,50 +71,53 @@ export default class PobLibGenerator extends Generator {
       this.updateOnly = this.options.updateOnly;
     }
 
-    const pkg = this.fs.readJSON(this.destinationPath('package.json'));
+    const pkg = this.fs.readJSON(this.destinationPath("package.json"));
     const pobPkgConfig = pkg.pob || {};
 
-    let babelEnvs = this.pobjson.envs || pobPkgConfig.babelEnvs;
+    let babelEnvs =
+      this.pobjson.envs ||
+      pobPkgConfig.babelEnvs ||
+      (pobPkgConfig.bundler === "rollup-babel" && pobPkgConfig.envs);
     const entries = this.pobjson.entries || pobPkgConfig.entries;
     const jsx =
       this.pobjson.withReact || pobPkgConfig.withReact || pobPkgConfig.jsx;
 
-    if (babelEnvs && typeof babelEnvs[0] === 'string') {
+    if (babelEnvs && typeof babelEnvs[0] === "string") {
       babelEnvs = babelEnvs.map((env) => {
         switch (env) {
-          case 'node6':
-          case 'node7':
-          case 'node8':
-          case 'node10':
+          case "node6":
+          case "node7":
+          case "node8":
+          case "node10":
             return {
-              target: 'node',
+              target: "node",
               version: 14,
-              formats: ['cjs'],
+              formats: ["cjs"],
             };
 
-          case 'webpack-node7':
-          case 'module-node7':
-          case 'module-node8':
+          case "webpack-node7":
+          case "module-node7":
+          case "module-node8":
             return {
-              target: 'node',
+              target: "node",
               version: 14,
-              formats: ['es'],
+              formats: ["es"],
             };
 
-          case 'module':
-          case 'webpack':
-            return { target: 'browser', formats: ['es'] };
+          case "module":
+          case "webpack":
+            return { target: "browser", formats: ["es"] };
 
-          case 'module-modern-browsers':
-          case 'webpack-modern-browsers':
+          case "module-modern-browsers":
+          case "webpack-modern-browsers":
             return {
-              target: 'browser',
-              version: 'modern',
-              formats: ['es'],
+              target: "browser",
+              version: "modern",
+              formats: ["es"],
             };
 
-          case 'browsers':
-            return { target: 'browser', formats: ['cjs'] };
+          case "browsers":
+            return { target: "browser", formats: ["cjs"] };
 
           default:
             throw new Error(`Unsupported env ${env}`);
@@ -127,13 +132,13 @@ export default class PobLibGenerator extends Generator {
       };
     } else if (this.pobjson.testing) {
       delete this.pobjson.testing.travisci;
-      if ('circleci' in this.pobjson.testing) {
+      if ("circleci" in this.pobjson.testing) {
         this.pobjson.testing.ci = this.pobjson.testing.circleci;
         delete this.pobjson.testing.circleci;
       }
     }
 
-    if (typeof this.pobjson.documentation === 'object') {
+    if (typeof this.pobjson.documentation === "object") {
       this.pobjson.documentation = true;
     }
 
@@ -148,16 +153,18 @@ export default class PobLibGenerator extends Generator {
 
     delete pkg.pob.withReact;
     if (babelEnvs && babelEnvs.length > 0) {
-      pkg.pob.babelEnvs = babelEnvs;
+      delete pkg.pob.babelEnvs;
+      pkg.pob.bundler = "rollup-babel";
+      pkg.pob.envs = babelEnvs;
       pkg.pob.entries = entries;
       pkg.pob.jsx = jsx;
     }
 
-    this.fs.writeJSON(this.destinationPath('package.json'), pkg);
+    this.fs.writeJSON(this.destinationPath("package.json"), pkg);
   }
 
   async prompting() {
-    const pkg = this.fs.readJSON(this.destinationPath('package.json'));
+    const pkg = this.fs.readJSON(this.destinationPath("package.json"));
 
     // documentation
     if (inMonorepo && !inMonorepo.root) {
@@ -165,9 +172,9 @@ export default class PobLibGenerator extends Generator {
     } else {
       const answers = await this.prompt([
         {
-          type: 'confirm',
-          name: 'documentation',
-          message: 'Would you like documentation (manually generated) ?',
+          type: "confirm",
+          name: "documentation",
+          message: "Would you like documentation (manually generated) ?",
           when: !this.updateOnly || this.pobjson.documentation === undefined,
           default:
             this.pobjson.documentation != null
@@ -182,9 +189,9 @@ export default class PobLibGenerator extends Generator {
     // testing
     if (!this.updateOnly || this.pobjson.testing === undefined) {
       const { testing } = await this.prompt({
-        type: 'confirm',
-        name: 'testing',
-        message: 'Would you like testing ?',
+        type: "confirm",
+        name: "testing",
+        message: "Would you like testing ?",
         default: this.pobjson.testing || false,
       });
       this.pobjson.testing = !testing ? false : this.pobjson.testing || {};
@@ -193,33 +200,33 @@ export default class PobLibGenerator extends Generator {
     if (this.pobjson.testing && !(inMonorepo || inMonorepo.root)) {
       const testingPrompts = await this.prompt([
         {
-          type: 'confirm',
-          name: 'ci',
-          message: 'Would you like ci with github actions ?',
+          type: "confirm",
+          name: "ci",
+          message: "Would you like ci with github actions ?",
           when: !this.updateOnly || this.pobjson.testing?.ci === undefined,
           default: this.pobjson.testing.ci !== false,
         },
         {
-          type: 'list',
-          name: 'runner',
-          message: 'Testing runner ?',
+          type: "list",
+          name: "runner",
+          message: "Testing runner ?",
           when: !this.updateOnly || this.pobjson.testing?.runner === undefined,
-          default: this.pobjson.testing?.runner || 'jest',
+          default: this.pobjson.testing?.runner || "jest",
           choices: [
             {
-              name: 'Jest',
-              value: 'jest',
+              name: "Jest",
+              value: "jest",
             },
             {
-              name: 'node:test',
-              value: 'node',
+              name: "node:test",
+              value: "node",
             },
           ],
         },
         {
-          type: 'confirm',
-          name: 'codecov',
-          message: 'Would you like codecov ?',
+          type: "confirm",
+          name: "codecov",
+          message: "Would you like codecov ?",
           when: !this.updateOnly || this.pobjson.testing?.codecov === undefined,
           default: this.pobjson.testing.codecov === true,
         },
@@ -227,16 +234,16 @@ export default class PobLibGenerator extends Generator {
       Object.assign(this.pobjson.testing, testingPrompts);
     }
 
-    this.fs.writeJSON(this.destinationPath('package.json'), pkg);
+    this.fs.writeJSON(this.destinationPath("package.json"), pkg);
 
-    this.composeWith('pob:common:babel', {
+    this.composeWith("pob:common:babel", {
       updateOnly: this.options.updateOnly,
       testing: !!this.pobjson.testing,
       documentation: !!this.pobjson.documentation,
       fromPob: this.options.fromPob,
       onlyLatestLTS: false,
     });
-    this.composeWith('pob:common:transpiler', {
+    this.composeWith("pob:common:transpiler", {
       updateOnly: this.options.updateOnly,
       testing: !!this.pobjson.testing,
       documentation: !!this.pobjson.documentation,
@@ -246,34 +253,36 @@ export default class PobLibGenerator extends Generator {
   }
 
   default() {
-    const pkg = this.fs.readJSON(this.destinationPath('package.json'));
-    const babelEnvs = pkg.pob.babelEnvs || [];
+    const pkg = this.fs.readJSON(this.destinationPath("package.json"));
+    const babelEnvs =
+      pkg.pob.babelEnvs ||
+      (pkg.pob.bundler === "rollup-babel" && pkg.pob.envs) ||
+      [];
 
     const withBabel = babelEnvs.length > 0;
     const withTypescript = withBabel || pkg.pob.typescript === true;
     const jsx = (withBabel || withTypescript) && pkg.pob.jsx === true;
-    const browser =
-      withBabel && babelEnvs.some((env) => env.target === 'browser');
+    const browser = pkg.pob.envs?.some((env) => env.target === "browser");
 
-    this.composeWith('pob:common:typescript', {
+    this.composeWith("pob:common:typescript", {
       enable: withTypescript,
       isApp: false,
       dom: browser,
       jsx,
       updateOnly: this.options.updateOnly,
-      baseUrl: 'none', // causes issues on dist definition files
+      baseUrl: "none", // causes issues on dist definition files
       builddefs: true,
       onlyLatestLTS: false,
     });
 
-    this.composeWith('pob:common:husky', {});
+    this.composeWith("pob:common:husky", {});
 
-    this.composeWith('pob:common:remove-old-dependencies');
+    this.composeWith("pob:common:remove-old-dependencies");
 
     const enableReleasePlease =
       !inMonorepo && this.pobjson.testing && this.pobjson.testing.ci;
 
-    this.composeWith('pob:common:testing', {
+    this.composeWith("pob:common:testing", {
       enable: this.pobjson.testing,
       disableYarnGitCache: this.options.disableYarnGitCache,
       enableReleasePlease,
@@ -282,7 +291,7 @@ export default class PobLibGenerator extends Generator {
       runner: this.pobjson.testing
         ? (inMonorepo
             ? inMonorepo.pobMonorepoConfig.testRunner
-            : this.pobjson.testing.runner) || 'jest'
+            : this.pobjson.testing.runner) || "jest"
         : undefined,
       build: withBabel || withTypescript,
       typescript: withTypescript,
@@ -292,11 +301,11 @@ export default class PobLibGenerator extends Generator {
       packageManager: this.options.packageManager,
       isApp: false,
       splitCIJobs: false,
-      srcDirectory: withBabel || withTypescript ? 'src' : 'lib',
+      srcDirectory: withBabel || withTypescript ? "src" : "lib",
     });
 
     // must be after testing
-    this.composeWith('pob:common:format-lint', {
+    this.composeWith("pob:common:format-lint", {
       typescript: withTypescript,
       documentation:
         !!this.pobjson.documentation ||
@@ -307,23 +316,23 @@ export default class PobLibGenerator extends Generator {
         : this.pobjson.testing?.runner,
       packageManager: this.options.packageManager,
       yarnNodeLinker: this.options.yarnNodeLinker,
-      ignorePaths: withBabel || withTypescript ? '/dist' : '',
+      ignorePaths: withBabel || withTypescript ? "/dist" : "",
     });
 
-    this.composeWith('pob:lib:doc', {
+    this.composeWith("pob:lib:doc", {
       enabled: this.pobjson.documentation,
       testing: this.pobjson.testing,
     });
 
     // must be after doc, testing
-    this.composeWith('pob:lib:readme', {
+    this.composeWith("pob:lib:readme", {
       documentation: !!this.pobjson.documentation,
       testing: !!this.pobjson.testing,
       ci: this.pobjson.testing && this.pobjson.testing.ci,
       codecov: this.pobjson.testing && this.pobjson.testing.codecov,
     });
 
-    this.composeWith('pob:common:release', {
+    this.composeWith("pob:common:release", {
       enable: !inMonorepo && this.pobjson.testing,
       enablePublish: true,
       withBabel,
@@ -335,7 +344,7 @@ export default class PobLibGenerator extends Generator {
       updateOnly: this.options.updateOnly,
     });
 
-    this.composeWith('pob:core:vscode', {
+    this.composeWith("pob:core:vscode", {
       root: !inMonorepo,
       monorepo: false,
       packageManager: this.options.packageManager,
@@ -346,7 +355,7 @@ export default class PobLibGenerator extends Generator {
     });
 
     // must be after doc, testing
-    this.composeWith('pob:core:gitignore', {
+    this.composeWith("pob:core:gitignore", {
       root: !inMonorepo,
       withBabel: babelEnvs.length > 0,
       typescript: withTypescript,
@@ -354,32 +363,34 @@ export default class PobLibGenerator extends Generator {
       testing: !!this.pobjson.testing,
     });
 
-    this.composeWith('pob:core:npm', {
+    this.composeWith("pob:core:npm", {
       enable: !pkg.private,
-      srcDirectory: withBabel || withTypescript ? 'src' : 'lib',
-      distDirectory: withBabel || withTypescript ? 'dist' : '',
+      srcDirectory: withBabel || withTypescript ? "src" : "lib",
+      distDirectory: withBabel || withTypescript ? "dist" : "",
     });
   }
 
   writing() {
     // Re-read the content at this point because a composed generator might modify it.
-    const pkg = this.fs.readJSON(this.destinationPath('package.json'));
+    const pkg = this.fs.readJSON(this.destinationPath("package.json"));
 
     if (pkg.engines) {
       delete pkg.engines.yarn;
     }
 
-    if ('sideEffects' in pkg) {
+    if ("sideEffects" in pkg) {
       pkg.sideEffects = false;
     }
 
-    const withBabel = Boolean(pkg.pob.babelEnvs);
+    const withBabel = Boolean(
+      pkg.pob.babelEnvs || pkg.pob.bundler === "rollup-babel",
+    );
     const withTypescript = pkg.pob.typescript === true;
 
-    packageUtils.removeDevDependencies(pkg, ['lerna', '@pob/lerna-light']);
+    packageUtils.removeDevDependencies(pkg, ["lerna", "@pob/lerna-light"]);
     if (inMonorepo) {
       if (pkg.scripts) {
-        if (pkg.name !== 'pob-dependencies') {
+        if (pkg.name !== "pob-dependencies") {
           delete pkg.scripts.preversion;
         }
         delete pkg.scripts.release;
@@ -389,23 +400,23 @@ export default class PobLibGenerator extends Generator {
 
     if (!withBabel && !withTypescript) {
       if (
-        !this.fs.exists(this.destinationPath('lib/index.js')) &&
-        this.fs.exists(this.destinationPath('index.js'))
+        !this.fs.exists(this.destinationPath("lib/index.js")) &&
+        this.fs.exists(this.destinationPath("index.js"))
       ) {
         this.fs.move(
-          this.destinationPath('index.js'),
-          this.destinationPath('lib/index.js'),
+          this.destinationPath("index.js"),
+          this.destinationPath("lib/index.js"),
         );
       }
     }
 
-    this.fs.writeJSON(this.destinationPath('package.json'), pkg);
+    this.fs.writeJSON(this.destinationPath("package.json"), pkg);
     [
-      'lib-node14',
-      'lib-node16',
-      'coverage',
-      this.pobjson.documentation && 'docs',
-      !(withBabel || withTypescript) && 'dist',
+      "lib-node14",
+      "lib-node16",
+      "coverage",
+      this.pobjson.documentation && "docs",
+      !(withBabel || withTypescript) && "dist",
     ]
       .filter(Boolean)
       .forEach((path) => {
@@ -414,18 +425,9 @@ export default class PobLibGenerator extends Generator {
 
     const { pobjson } = this;
 
-    // .includes('node6') && 'node6',
-    //   this.babelEnvs.includes('node8') && 'node8',
-    //   this.babelEnvs.includes('olderNode') && 'older-node',
-    //   this.babelEnvs.includes('moduleModernBrowsers') && 'module-modern-browsers',
-    //   this.babelEnvs.includes('moduleAllBrowsers') && 'module',
-    //   this.babelEnvs.includes('moduleNode8') && 'module-node8',
-    //   this.babelEnvs.includes('browsers') && 'browsers',
-    // ].filter(Boolean);
-
-    this.config.set('lib', pobjson);
+    this.config.set("lib", pobjson);
     this.config.save();
 
-    this.composeWith('pob:core:sort-package');
+    this.composeWith("pob:core:sort-package");
   }
 }