pob 18.4.2 → 19.0.1

package/CHANGELOG.md

@@ -3,6 +3,37 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [19.0.1](https://github.com/christophehurpeau/pob/compare/pob@19.0.0...pob@19.0.1) (2024-05-04)
+
+Note: no notable changes
+
+
+
+
+## [19.0.0](https://github.com/christophehurpeau/pob/compare/pob@18.4.2...pob@19.0.0) (2024-05-04)
+
+
+### ⚠ BREAKING CHANGES
+
+* enable "disableYarnGitCache" by default
+
+### Features
+
+* **deps:** update yarn monorepo ([#2032](https://github.com/christophehurpeau/pob/issues/2032)) ([d2b7b8a](https://github.com/christophehurpeau/pob/commit/d2b7b8adc11a13f4b4d96cdd08851ad66f3c83a0))
+* enable "disableYarnGitCache" by default ([b7ce323](https://github.com/christophehurpeau/pob/commit/b7ce323c51e0e875228478d708f27511325b844c))
+* **pob:** remove metro-health-check in gitignore as I dont use them ([dc09df0](https://github.com/christophehurpeau/pob/commit/dc09df0ae0600294ae4ecdc0fb571797f5cc7b43))
+* use codecov-action v4 ([73174bd](https://github.com/christophehurpeau/pob/commit/73174bd93ce1b0b9f93e360a7ea29478d7550400))
+
+
+### Bug Fixes
+
+* **pob:** fix vitest coverage commands ([770f995](https://github.com/christophehurpeau/pob/commit/770f995a2f679e63771ca5b1d30a386a66fd2f05))
+* run tsc with typescript and no babel ([96d1283](https://github.com/christophehurpeau/pob/commit/96d1283d2f79dfdeabc1c39ad57d299419ec44ed))
+
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: root
+
+
 ## [18.4.2](https://github.com/christophehurpeau/pob/compare/pob@18.4.1...pob@18.4.2) (2024-04-24)
 
 Note: no notable changes

package/lib/generators/app/ignorePaths.js

@@ -27,8 +27,9 @@ export const appIgnorePaths = {
     '*.orig.*',
     '/web-build/',
 
-    '# Temporary files created by Metro to check the health of the file watcher',
-    '/.metro-health-check*',
+    // only if option is enabled which is not by default
+    // '# Temporary files created by Metro to check the health of the file watcher',
+    // '/.metro-health-check*',
   ],
   'yarn-plugin': (config) => [],
 };

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -587,7 +587,9 @@ export default class CommonLintGenerator extends Generator {
               .relative('../..', '.')
               .replace('\\', '/')}`
           : `eslint ${args} ${lintPaths.join(' ')}`,
-        lint: `${useBabel && !composite ? 'tsc && ' : ''}yarn run lint:eslint`,
+        lint: `${
+          useTypescript && !composite ? 'tsc && ' : ''
+        }yarn run lint:eslint`,
       });
 
       if (!inMonorepo) {

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -327,7 +327,9 @@ export default class CommonTestingGenerator extends Generator {
                   coverageLcov ? 'lcov' : `json${coverageJson ? '' : ',text'} `
                 }`
               : ''
-          }vitest${watch ? ' --watch' : ''}`;
+          }vitest${watch ? ' --watch' : ''}${
+            coverage || coverageJson || coverageLcov ? ' run --coverage' : ''
+          }`;
         }
         default: {
           throw new Error(`Invalid runner: "${testRunner}"`);

package/lib/generators/core/ci/templates/github-action-push-workflow-split.yml.ejs

@@ -122,7 +122,7 @@ jobs:
         if: matrix.node-version == 18
 
       - name: Send results to codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         if: matrix.node-version == 18
         with:
           token: ${{ secrets.CODECOV_TOKEN }}

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -68,7 +68,7 @@ jobs:
           NODE_V8_COVERAGE: coverage/
 
       - name: Send results to codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
         if: startsWith(matrix.node-version, '20.')

package/lib/generators/pob/PobBaseGenerator.js

@@ -125,7 +125,7 @@ export default class PobBaseGenerator extends Generator {
       type: this.projectConfig.type,
       enable: this.isRoot && this.projectConfig.packageManager === 'yarn',
       yarnNodeLinker: this.projectConfig.yarnNodeLinker,
-      disableYarnGitCache: this.projectConfig.disableYarnGitCache,
+      disableYarnGitCache: this.projectConfig.disableYarnGitCache !== false,
     });
 
     this.composeWith('pob:core:package', {
@@ -142,13 +142,13 @@ export default class PobBaseGenerator extends Generator {
         force: this.options.force,
         isAppProject: this.projectConfig.type === 'app',
         packageManager: this.projectConfig.packageManager,
-        disableYarnGitCache: this.projectConfig.disableYarnGitCache,
+        disableYarnGitCache: this.projectConfig.disableYarnGitCache !== false,
       });
       this.composeWith('pob:monorepo:lerna', {
         force: this.options.force,
         isAppProject: this.projectConfig.type === 'app',
         packageManager: this.projectConfig.packageManager,
-        disableYarnGitCache: this.projectConfig.disableYarnGitCache,
+        disableYarnGitCache: this.projectConfig.disableYarnGitCache !== false,
       });
     }
 
@@ -207,7 +207,7 @@ export default class PobBaseGenerator extends Generator {
         ),
         {
           updateOnly: this.options.updateOnly,
-          disableYarnGitCache: this.projectConfig.disableYarnGitCache,
+          disableYarnGitCache: this.projectConfig.disableYarnGitCache !== false,
           isAppProject: this.projectConfig.type === 'app',
           packageManager: this.projectConfig.packageManager,
           yarnNodeLinker: this.projectConfig.yarnNodeLinker,
@@ -220,7 +220,8 @@ export default class PobBaseGenerator extends Generator {
           this.composeWith('pob:lib', {
             monorepo: this.isMonorepo,
             isRoot: this.isRoot,
-            disableYarnGitCache: this.projectConfig.disableYarnGitCache,
+            disableYarnGitCache:
+              this.projectConfig.disableYarnGitCache !== false,
             updateOnly: this.options.updateOnly,
             fromPob: this.options.fromPob,
             packageManager: this.projectConfig.packageManager,
@@ -231,7 +232,8 @@ export default class PobBaseGenerator extends Generator {
           this.composeWith('pob:app', {
             monorepo: this.isMonorepo,
             isRoot: this.isRoot,
-            disableYarnGitCache: this.projectConfig.disableYarnGitCache,
+            disableYarnGitCache:
+              this.projectConfig.disableYarnGitCache !== false,
             updateOnly: this.options.updateOnly,
             fromPob: this.options.fromPob,
             packageManager: this.projectConfig.packageManager,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "18.4.2",
+  "version": "19.0.1",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -46,8 +46,8 @@
     "@pob/sort-object": "6.3.0",
     "@pob/sort-pkg": "7.1.0",
     "@types/inquirer": "9.0.7",
-    "@yarnpkg/cli": "4.1.1",
-    "@yarnpkg/core": "4.0.3",
+    "@yarnpkg/cli": "4.2.1",
+    "@yarnpkg/core": "4.0.5",
     "@yarnpkg/fslib": "3.0.2",
     "@yeoman/types": "1.2.0",
     "eslint": "8.57.0",
@@ -62,15 +62,15 @@
     "mem-fs-editor": "11.0.0",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "11.2.2",
+    "pob-dependencies": "11.2.3",
     "prettier": "2.8.8",
     "semver": "7.6.0",
     "validate-npm-package-name": "^5.0.0",
-    "yarn-workspace-utils": "3.3.0",
+    "yarn-workspace-utils": "3.4.0",
     "yeoman-environment": "4.4.0",
     "yeoman-generator": "7.1.1"
   },
   "devDependencies": {
-    "@pob/root": "9.3.2"
+    "@pob/root": "9.4.1"
   }
 }