pob 17.0.0 → 17.2.0

package/CHANGELOG.md

@@ -3,6 +3,28 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [17.2.0](https://github.com/christophehurpeau/pob/compare/pob@17.1.0...pob@17.2.0) (2023-12-27)
+
+
+### Features
+
+* improve experimental typescript compiler ([c46d8f2](https://github.com/christophehurpeau/pob/commit/c46d8f2ea003fd1721ba481cfb42bc35e22e7537))
+
+Version bump for dependency: root
+
+
+## [17.1.0](https://github.com/christophehurpeau/pob/compare/pob@17.0.0...pob@17.1.0) (2023-12-26)
+
+
+### Bug Fixes
+
+* delete config.supportedArchitectures if option disableYarnGitCache is true ([9905b3b](https://github.com/christophehurpeau/pob/commit/9905b3bef1feb10f6867d2f2625480aaee63b56f))
+* fix tsconfig when presets is empty ([63ce876](https://github.com/christophehurpeau/pob/commit/63ce8762ac960d89cbdff9970dbc34670c0cd365))
+* **pob:** correctly detects if build is required ([d3e13e6](https://github.com/christophehurpeau/pob/commit/d3e13e6d052ecaed070a93c3f45ca83622750643))
+
+Version bump for dependency: root
+
+
 ## [17.0.0](https://github.com/christophehurpeau/pob/compare/pob@16.1.0...pob@17.0.0) (2023-12-25)
 
 

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -125,7 +125,14 @@ export default class CommonLintGenerator extends Generator {
     const hasReact = useTypescript && packageUtils.hasReact(pkg);
     const useNode = !useBabel || babelEnvs.some((env) => env.target === 'node');
     const useNodeOnly =
-      !useBabel ||
+      (!useBabel && !useTypescript) ||
+      (useTypescript &&
+        pkg.pob?.envs?.every((env) => env.target === 'node') &&
+        pkg.pob?.entries.every(
+          (entry) =>
+            typeof entry === 'string' ||
+            (entry.target && entry.target !== 'node'),
+        )) ||
       (babelEnvs.length > 0 && babelEnvs.every((env) => env.target === 'node'));
 
     if (this.fs.exists(this.destinationPath('.eslintignore'))) {

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -186,6 +186,14 @@ export default class CommonTestingGenerator extends Generator {
       this.fs.delete(this.destinationPath('jest.config.json'));
     }
 
+    packageUtils.addOrRemoveDevDependencies(
+      pkg,
+      this.options.enable &&
+        this.options.runner === 'node' &&
+        this.options.typescript,
+      ['tsimp'],
+    );
+
     if (!this.options.enable) {
       // if (inMonorepo) {
       //   if (pkg.scripts.test === 'echo "No tests"') {
@@ -226,7 +234,11 @@ export default class CommonTestingGenerator extends Generator {
                   ? 'NODE_OPTIONS=--experimental-vm-modules '
                   : ''
               }jest`
-            : 'node --test';
+            : `node ${
+                this.options.typescript ? '--import=tsimp/import ' : ''
+              }--test ${
+                this.options.typescript ? '**/*.test.ts' : '**/*.test.js'
+              }`;
 
         packageUtils.addScripts(pkg, {
           test: testCommand,
@@ -305,7 +317,11 @@ export default class CommonTestingGenerator extends Generator {
                   ? 'NODE_OPTIONS=--experimental-vm-modules '
                   : ''
               }jest`
-            : 'node --test';
+            : `node ${
+                this.options.typescript ? '--import=tsimp/import ' : ''
+              }--test ${
+                this.options.typescript ? '**/*.test.ts' : '**/*.test.js'
+              }`;
 
         packageUtils.addScripts(pkg, {
           test: testCommand,

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -125,9 +125,16 @@ export default class CommonTypescriptGenerator extends Generator {
       }
       if (withTypescript) {
         const nodeVersion = this.options.onlyLatestLTS ? '20' : '18';
-        return pkg.pob.rollup === false
-          ? [`@pob/root/tsconfigs/targets/node-${nodeVersion}.json`]
-          : [`@pob/root/tsconfigs/targets/rollup-node-${nodeVersion}.json`];
+        const envs = pkg.pob?.envs;
+        if (pkg.pob.rollup === false) {
+          return [`@pob/root/tsconfigs/targets/node-${nodeVersion}.json`];
+        }
+        if (envs && envs.every((env) => env.target === 'node')) {
+          return [
+            `@pob/root/tsconfigs/targets/rollup-node-${nodeVersion}.json`,
+          ];
+        }
+        return ['@pob/root/tsconfigs/targets/rollup-es2015.json'];
       }
       return [];
     })();

package/lib/generators/common/typescript/templates/tsconfig.json.ejs

@@ -47,7 +47,7 @@
     "composite": true,
 <% } -%>
 
-<% if(!presets) { -%>
+<% if(!presets || presets.length === 0) { -%>
     "target": "esnext",                       /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */
     "module": "esnext",                       /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
     "lib": [<%- dom ? '"dom", ' : '' %>"esnext"],                 /* Polyfills are imported either by babel or with polyfill.io */
@@ -63,7 +63,7 @@
     "plugins": [<%- plugins.map((pluginName) => `{"name": "${pluginName}"}`).join(', ') %>],
 <% } -%>
 
-<% if(!presets) { -%>
+<% if(!presets || presets.length === 0) { -%>
     /* Module Resolution Options */
     "moduleResolution": "bundler" /* Specify module resolution strategy. */,
   <% if (resolveJsonModule) { -%>

package/lib/generators/core/package/CorePackageGenerator.js

@@ -119,19 +119,19 @@ export default class CorePackageGenerator extends Generator {
         {
           name: 'authorName',
           message: "Author's Name",
-          when: !author || !author.name,
+          when: !pkg.authors && (!author || !author.name),
           default: this.git.name(),
         },
         {
           name: 'authorEmail',
           message: "Author's Email",
-          when: !author || !author.email,
+          when: !pkg.authors && (!author || !author.email),
           default: this.git.email(),
         },
         {
           name: 'authorUrl',
           message: "Author's Homepage",
-          when: !author || !author.url,
+          when: !pkg.authors && (!author || !author.url),
         },
         {
           name: 'type',
@@ -260,15 +260,17 @@ export default class CorePackageGenerator extends Generator {
       );
     }
 
-    author = {
-      name: props.authorName || author.name,
-      email: props.authorEmail || author.email,
-      url: props.authorUrl || (author && author.url),
-    };
+    if (!pkg.authors) {
+      author = {
+        name: props.authorName || author.name,
+        email: props.authorEmail || author.email,
+        url: props.authorUrl || (author && author.url),
+      };
 
-    pkg.author = `${author.name} <${author.email}>${
-      author.url ? ` (${author.url})` : ''
-    }`;
+      pkg.author = `${author.name} <${author.email}>${
+        author.url ? ` (${author.url})` : ''
+      }`;
+    }
 
     if (!pkg.license) {
       pkg.license = props.license;

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -145,6 +145,7 @@ export default class CoreYarnGenerator extends Generator {
       if (this.options.disableYarnGitCache) {
         config.compressionLevel = 'mixed'; // optimized for size
         config.enableGlobalCache = true;
+        delete config.supportedArchitectures;
       } else {
         config.compressionLevel = 0; // optimized for github config
         config.enableGlobalCache = false;

package/lib/generators/lib/PobLibGenerator.js

@@ -279,7 +279,7 @@ export default class PobLibGenerator extends Generator {
       runner: this.pobjson.testing
         ? this.pobjson.testing.runner || 'jest'
         : undefined,
-      build: withBabel,
+      build: withBabel || withTypescript,
       typescript: withTypescript,
       documentation: !!this.pobjson.documentation,
       codecov: this.pobjson.testing && this.pobjson.testing.codecov,
@@ -331,7 +331,7 @@ export default class PobLibGenerator extends Generator {
       monorepo: false,
       packageManager: this.options.packageManager,
       yarnNodeLinker: this.options.yarnNodeLinker,
-      typescript: withBabel,
+      typescript: withBabel || withTypescript,
       testing: this.pobjson.testing,
     });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "17.0.0",
+  "version": "17.2.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -62,7 +62,7 @@
     "mem-fs-editor": "11.0.0",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "10.0.0",
+    "pob-dependencies": "10.2.0",
     "prettier": "2.8.8",
     "semver": "7.5.4",
     "validate-npm-package-name": "^5.0.0",
@@ -71,6 +71,6 @@
     "yeoman-generator": "7.1.1"
   },
   "devDependencies": {
-    "@pob/root": "8.9.1"
+    "@pob/root": "8.11.0"
   }
 }