pob 16.0.0 → 17.0.0

package/CHANGELOG.md

@@ -3,6 +3,38 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [17.0.0](https://github.com/christophehurpeau/pob/compare/pob@16.1.0...pob@17.0.0) (2023-12-25)
+
+
+### ⚠ BREAKING CHANGES
+
+* drop browser modern version
+
+### Features
+
+* drop browser modern version ([99ee1d3](https://github.com/christophehurpeau/pob/commit/99ee1d392fa035773a559c6a81515b1731f70e29))
+
+Version bump for dependency: yarn-workspace-utils
+
+
+## [16.1.0](https://github.com/christophehurpeau/pob/compare/pob@16.0.0...pob@16.1.0) (2023-12-25)
+
+
+### Features
+
+* **deps:** update dependency eslint to v8.56.0 ([#1883](https://github.com/christophehurpeau/pob/issues/1883)) ([8c81687](https://github.com/christophehurpeau/pob/commit/8c81687ffbc7bb3b0b3bcf277c0d2db853ff637c))
+* update to yarn 4.0.2 ([57bb760](https://github.com/christophehurpeau/pob/commit/57bb7608ed2b18d3a7e125f12590d1df787df2db))
+
+
+### Bug Fixes
+
+* fix option e2eTesting false ([6411c73](https://github.com/christophehurpeau/pob/commit/6411c73e45c67ddc4bade92b19242c630fa5f972))
+* **pob:** fix browser and jsx detection ([dfa0c81](https://github.com/christophehurpeau/pob/commit/dfa0c8133d36f0144d55c0f44f8a1d321468b26a))
+* **pob:** use 20.x by default ([412eb85](https://github.com/christophehurpeau/pob/commit/412eb85c4670bc5744e34c5f831544a2b6bc7a90))
+
+Version bump for dependency: yarn-workspace-utils
+
+
 ## [16.0.0](https://github.com/christophehurpeau/pob/compare/pob@15.4.1...pob@16.0.0) (2023-12-14)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -172,7 +172,9 @@ export default class PobAppGenerator extends Generator {
       babelEnvs.length > 0 || appsWithTypescript.includes(this.appConfig.type);
     const typescript = babel || pkg.pob?.typescript;
     const node = true;
-    const browser = appsWithBrowser.includes(this.appConfig.type);
+    const browser =
+      appsWithBrowser.includes(this.appConfig.type) ||
+      (babel && babelEnvs.some((env) => env.target === 'browser'));
     const jsx =
       babelEnvs.length > 0 && pkg.pob.jsx !== undefined
         ? pkg.pob.jsx

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -178,24 +178,24 @@ export default class CommonBabelGenerator extends Generator {
           ],
         },
 
-        {
-          type: 'checkbox',
-          name: 'browserVersions',
-          message: 'Babel browser versions',
-          when: ({ targets = [] }) => targets.includes('browser'),
-          validate: (versions) => versions.length > 0,
-          default: browserVersions,
-          choices: [
-            {
-              name: 'Modern',
-              value: 'modern',
-            },
-            {
-              name: 'Supported',
-              value: 'supported',
-            },
-          ],
-        },
+        // {
+        //   type: 'checkbox',
+        //   name: 'browserVersions',
+        //   message: 'Babel browser versions',
+        //   when: ({ targets = [] }) => targets.includes('browser'),
+        //   validate: (versions) => versions.length > 0,
+        //   default: browserVersions,
+        //   choices: [
+        //     {
+        //       name: 'Modern',
+        //       value: 'modern',
+        //     },
+        //     {
+        //       name: 'Supported',
+        //       value: 'supported',
+        //     },
+        //   ],
+        // },
 
         {
           type: 'confirm',
@@ -207,6 +207,10 @@ export default class CommonBabelGenerator extends Generator {
       ]);
     }
 
+    if (babelConfig.targets.includes('browser')) {
+      babelConfig.browserVersions = ['supported'];
+    }
+
     if (hasInitialPkgPob && pkg.main && !pkg.exports) {
       const result = await this.prompt({
         type: 'confirm',

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -119,7 +119,7 @@ export default class CommonTypescriptGenerator extends Generator {
       const jsx = (withBabel || withTypescript) && pkg.pob.jsx === true;
 
       if (withBabel) {
-        return jsx
+        return jsx || this.options.dom
           ? ['@pob/root/tsconfigs/targets/rollup-babel-with-dom.json']
           : ['@pob/root/tsconfigs/targets/rollup-babel.json'];
       }

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -151,7 +151,10 @@ export default class CoreCIGenerator extends Generator {
           packageManager: this.options.packageManager,
           disableYarnGitCache: this.options.disableYarnGitCache,
           testing,
-          e2eTesting: this.options.e2eTesting,
+          e2eTesting:
+            this.options.e2eTesting && this.options.e2eTesting !== 'false'
+              ? this.options.e2eTesting
+              : false,
           checks,
           documentation: this.options.documentation,
           build,

package/lib/generators/core/ci/templates/github-action-push-workflow.yml.ejs

@@ -42,27 +42,27 @@ jobs:
 <% if (build) { -%>
       - name: Build
         run: yarn run build
-        if: startsWith(matrix.node-version, '18.')
+        if: startsWith(matrix.node-version, '20.')
 
 <% } -%>
       - name: Prettier
         run: <%= packageManager %> run lint:prettier
-        if: startsWith(matrix.node-version, '18.')
+        if: startsWith(matrix.node-version, '20.')
 <% if (typescript) { -%>
 
       - name: Typescript
         run: yarn run tsc
-        if: startsWith(matrix.node-version, '18.')
+        if: startsWith(matrix.node-version, '20.')
 <% } -%>
 
       - name: Eslint
         run: <%= packageManager %> run lint:eslint
-        if: startsWith(matrix.node-version, '18.')
+        if: startsWith(matrix.node-version, '20.')
 <% if (codecov) { -%>
 
       - name: Generate Test Coverage
         run: <%= packageManager %> run test:coverage
-        if: startsWith(matrix.node-version, '18.')
+        if: startsWith(matrix.node-version, '20.')
         env:
           CI: true
 
@@ -70,7 +70,7 @@ jobs:
         uses: codecov/codecov-action@v3
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
-        if: startsWith(matrix.node-version, '18.')
+        if: startsWith(matrix.node-version, '20.')
 <% } else if (testing) { -%>
 
       - name: Test
@@ -86,13 +86,13 @@ jobs:
 <% if (true) { -%>
 
       - name: Check nothing was forgotten before commit
-        if: startsWith(matrix.node-version, '18.')
+        if: startsWith(matrix.node-version, '20.')
         run: <%= packageManager === 'npm' ? 'npx' : 'yarn run' %> repository-check-dirty
 <% } -%>
 
 <% if (isReleasePleaseEnabled) { -%>
       - uses: GoogleCloudPlatform/release-please-action@v3
-        if: ${{ startsWith(matrix.node-version, '18.') && github.ref == 'refs/heads/main' }}
+        if: ${{ startsWith(matrix.node-version, '20.') && github.ref == 'refs/heads/main' }}
         id: release
         with:
           token: ${{ secrets.GH_TOKEN }}
@@ -102,7 +102,7 @@ jobs:
 
       # publish:
       - run: npm publish
-        if: ${{ startsWith(matrix.node-version, '18.') && github.ref == 'refs/heads/main' && steps.release.outputs.release_created }}
+        if: ${{ startsWith(matrix.node-version, '20.') && github.ref == 'refs/heads/main' && steps.release.outputs.release_created }}
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 <% } -%>

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -131,9 +131,9 @@ export default class CoreYarnGenerator extends Generator {
       if (
         !pkg.packageManager ||
         !pkg.packageManager.startsWith('yarn@') ||
-        lt(pkg.packageManager.slice('yarn@'.length), '4.0.1')
+        lt(pkg.packageManager.slice('yarn@'.length), '4.0.2')
       ) {
-        pkg.packageManager = 'yarn@4.0.1';
+        pkg.packageManager = 'yarn@4.0.2';
       }
 
       // must be done after plugins installed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "16.0.0",
+  "version": "17.0.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -50,7 +50,7 @@
     "@yarnpkg/core": "4.0.2",
     "@yarnpkg/fslib": "3.0.1",
     "@yeoman/types": "1.1.2",
-    "eslint": "8.55.0",
+    "eslint": "8.56.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^7.0.0",
@@ -62,11 +62,11 @@
     "mem-fs-editor": "11.0.0",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "9.0.0",
+    "pob-dependencies": "10.0.0",
     "prettier": "2.8.8",
     "semver": "7.5.4",
     "validate-npm-package-name": "^5.0.0",
-    "yarn-workspace-utils": "2.0.0",
+    "yarn-workspace-utils": "3.0.0",
     "yeoman-environment": "4.1.3",
     "yeoman-generator": "7.1.1"
   },