pob 15.1.0 → 15.2.1

package/CHANGELOG.md

@@ -3,6 +3,48 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [15.2.1](https://github.com/christophehurpeau/pob/compare/pob@15.2.0...pob@15.2.1) (2023-12-10)
+
+
+### Bug Fixes
+
+* add missing plugin-run ([15d3dac](https://github.com/christophehurpeau/pob/commit/15d3dac678cb3c0fa8021c14318257cd6792d5c2))
+
+
+
+
+## [15.2.0](https://github.com/christophehurpeau/pob/compare/pob@15.1.0...pob@15.2.0) (2023-12-10)
+
+
+### Features
+
+* **deps:** update @pob/eslint-config ([#1878](https://github.com/christophehurpeau/pob/issues/1878)) ([f5c1f83](https://github.com/christophehurpeau/pob/commit/f5c1f835fcf98dc963213c7e4620ce02d325d8db))
+* **deps:** update dependency eslint to v8.54.0 ([#1855](https://github.com/christophehurpeau/pob/issues/1855)) ([3baf9c6](https://github.com/christophehurpeau/pob/commit/3baf9c68b9b020f5d069021df8a501d97491250c))
+* **deps:** update dependency eslint to v8.55.0 ([#1872](https://github.com/christophehurpeau/pob/issues/1872)) ([ebee64a](https://github.com/christophehurpeau/pob/commit/ebee64abd61d9e40bd7dd507cd97505861a2496a))
+* **deps:** update dependency validate-npm-package-name to v5 ([#1844](https://github.com/christophehurpeau/pob/issues/1844)) ([6d66f31](https://github.com/christophehurpeau/pob/commit/6d66f317fb9ad82e6c41d190fb1c8dc35198ff3c))
+* **deps:** update dependency yeoman-environment to v4.1.1 ([#1849](https://github.com/christophehurpeau/pob/issues/1849)) ([bf6b70e](https://github.com/christophehurpeau/pob/commit/bf6b70e2b8f345190c03469b5b11417a02a6acdd))
+* experimental alternate ways to compile typescript without babel ([4391b03](https://github.com/christophehurpeau/pob/commit/4391b03c89d94ca00d2a54a4662d09a4b25c860d))
+* make sure check-package-dependencies is up-to-date ([7493e27](https://github.com/christophehurpeau/pob/commit/7493e2709a0a1eae062e3223b3eb64d918db87af))
+* support next ts plugin and latest next version ([095fcde](https://github.com/christophehurpeau/pob/commit/095fcde48d866ee146ac9550f04b8f3acea0e887))
+
+
+### Bug Fixes
+
+* add missing libc in supportedArchitectures ([514c66b](https://github.com/christophehurpeau/pob/commit/514c66bf11a36f503afb6df1a19198527328c6aa))
+* **deps:** update dependency @yeoman/types to v1.1.2 ([#1847](https://github.com/christophehurpeau/pob/issues/1847)) ([7479fe6](https://github.com/christophehurpeau/pob/commit/7479fe6b0d8087dd7318c98918f63d95a4ce851d))
+* **deps:** update dependency yeoman-environment to v4.1.2 ([#1850](https://github.com/christophehurpeau/pob/issues/1850)) ([02ed137](https://github.com/christophehurpeau/pob/commit/02ed13735fd697cfbbe1aee900396ec4b50d31f0))
+* **deps:** update dependency yeoman-environment to v4.1.3 ([#1851](https://github.com/christophehurpeau/pob/issues/1851)) ([06f8cc2](https://github.com/christophehurpeau/pob/commit/06f8cc270be64899f55f99c3584a3b6519a99bbe))
+* **deps:** update dependency yeoman-generator to v7.1.1 ([#1848](https://github.com/christophehurpeau/pob/issues/1848)) ([d176ea7](https://github.com/christophehurpeau/pob/commit/d176ea74f4ee6d885f7fd9c58664a7e2ef699932))
+* **deps:** update yarn monorepo to v4.0.2 ([#1846](https://github.com/christophehurpeau/pob/issues/1846)) ([1a61fa5](https://github.com/christophehurpeau/pob/commit/1a61fa51058c3a320d3c9e603376b2e189271ddd))
+* remove legacy lib inquirer-npm-name ([6aae255](https://github.com/christophehurpeau/pob/commit/6aae25583d5f88f61132144246f2031ccf001018))
+
+Version bump for dependency: sort-eslint-config
+Version bump for dependency: sort-object
+Version bump for dependency: sort-pkg
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: root
+
+
 ## [15.1.0](https://github.com/christophehurpeau/pob/compare/pob@15.0.3...pob@15.1.0) (2023-11-11)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -148,6 +148,17 @@ export default class PobAppGenerator extends Generator {
         fromPob: this.options.fromPob,
         buildDirectory: 'build',
       });
+      await this.composeWith('pob:common:transpiler', {
+        updateOnly: this.options.updateOnly,
+        onlyLatestLTS: true,
+        isApp: true,
+        isAppLibrary,
+        useAppConfig: this.appConfig.type === 'alp-node',
+        testing: this.appConfig.testing,
+        documentation: false,
+        fromPob: this.options.fromPob,
+        buildDirectory: 'build',
+      });
     }
 
     const pkg = this.fs.readJSON(this.destinationPath('package.json'));
@@ -159,6 +170,7 @@ export default class PobAppGenerator extends Generator {
     const babelEnvs = (pkg.pob && pkg.pob.babelEnvs) || [];
     const babel =
       babelEnvs.length > 0 || appsWithTypescript.includes(this.appConfig.type);
+    const typescript = babel || pkg.pob?.typescript;
     const node = true;
     const browser = appsWithBrowser.includes(this.appConfig.type);
     const jsx =
@@ -176,7 +188,7 @@ export default class PobAppGenerator extends Generator {
     ).filter(Boolean);
 
     await this.composeWith('pob:common:typescript', {
-      enable: babel,
+      enable: typescript,
       isApp: true,
       isAppLibrary,
       // nextjs now supports src
@@ -190,6 +202,7 @@ export default class PobAppGenerator extends Generator {
       forceAllowJs: this.appConfig.type === 'next.js',
       updateOnly: this.options.updateOnly,
       resolveJsonModule: true,
+      onlyLatestLTS: true,
       baseUrl: (() => {
         if (
           this.appConfig.type === 'alp' ||
@@ -204,6 +217,18 @@ export default class PobAppGenerator extends Generator {
         }
         return '';
       })(),
+      plugins: (() => {
+        if (this.appConfig.type === 'next.js') {
+          return 'next';
+        }
+        return '';
+      })(),
+      additionalIncludes: (() => {
+        if (this.appConfig.type === 'next.js') {
+          return '.next/types/**/*.ts';
+        }
+        return '';
+      })(),
     });
 
     await this.composeWith('pob:common:remove-old-dependencies');
@@ -217,8 +242,9 @@ export default class PobAppGenerator extends Generator {
         disableYarnGitCache: this.options.disableYarnGitCache,
         enableReleasePlease,
         testing: this.appConfig.testing,
-        typescript: babel,
-        build: babel && this.appConfig.type !== 'expo',
+        e2eTesting: this.appConfig.e2e ? '.' : '',
+        typescript,
+        build: typescript && this.appConfig.type !== 'expo',
         documentation: false,
         codecov: this.appConfig.codecov,
         ci: this.appConfig.ci,
@@ -229,11 +255,16 @@ export default class PobAppGenerator extends Generator {
         srcDirectory,
       });
 
+      await this.composeWith('pob:app:e2e-testing', {
+        enable: this.appConfig.e2e,
+      });
+
       await this.composeWith('pob:common:format-lint', {
         isApp: true,
         documentation: false,
         testing: this.appConfig.testing,
         babel,
+        typescript,
         node,
         browser,
         // nextjs now supports src rootAsSrc: this.appConfig.type === 'next.js',
@@ -265,7 +296,7 @@ export default class PobAppGenerator extends Generator {
       monorepo: false,
       packageManager: this.options.packageManager,
       yarnNodeLinker: this.options.yarnNodeLinker,
-      typescript: babel,
+      typescript,
       testing: this.appConfig.testing,
     });
 

package/lib/generators/app/e2e-testing/AppE2ETestingGenerator.js

@@ -0,0 +1,45 @@
+import Generator from 'yeoman-generator';
+import * as packageUtils from '../../../utils/package.js';
+// import * as templateUtils from '../../../utils/templateUtils.js';
+import { writeAndFormatJson } from '../../../utils/writeAndFormat.js';
+
+export default class AppE2ETestingGenerator extends Generator {
+  constructor(args, opts) {
+    super(args, opts);
+
+    this.option('enable', {
+      type: Boolean,
+      default: true,
+      desc: 'enable e2e testing',
+    });
+
+    this.option('ci', {
+      type: Boolean,
+      required: true,
+      desc: 'ci',
+    });
+  }
+
+  writing() {
+    const pkg = this.fs.readJSON(this.destinationPath('package.json'));
+
+    packageUtils.addOrRemoveDevDependencies(pkg, this.options.enable, [
+      '@playwright/test',
+    ]);
+
+    packageUtils.addOrRemoveScripts(pkg, this.options.enable, {
+      'test:e2e': 'playwright test',
+    });
+
+    // templateUtils.addOrRemoveTemplate(
+    //   this.fs,
+    //   this.options.enable && this.options.ci,
+    //   this.destinationPath('playwright.config.js'),
+    // );
+
+    if (this.options.enable) {
+    }
+
+    writeAndFormatJson(this.fs, this.destinationPath('package.json'), pkg);
+  }
+}

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -1,4 +1,3 @@
-import fs from 'node:fs';
 import semver from 'semver';
 import Generator from 'yeoman-generator';
 import * as packageUtils from '../../../utils/package.js';
@@ -251,8 +250,10 @@ export default class CommonBabelGenerator extends Generator {
     delete pkg.pob.withReact;
     if (newBabelEnvs.length === 0) {
       delete pkg.pob.babelEnvs;
-      delete pkg.pob.entries;
-      delete pkg.pob.jsx;
+      if (!pkg.pob.typescript) {
+        delete pkg.pob.entries;
+        delete pkg.pob.jsx;
+      }
     } else {
       pkg.pob.babelEnvs = newBabelEnvs;
       pkg.pob.entries = pkg.pob.entries || ['index'];
@@ -271,10 +272,6 @@ export default class CommonBabelGenerator extends Generator {
     this.entries = pkg.pob.entries;
     this.babelEnvs = pkg.pob.babelEnvs || [];
 
-    if (this.babelEnvs.length > 0) {
-      fs.mkdirSync(this.destinationPath('src'), { recursive: true });
-    }
-
     if (this.entries) {
       this.entries.forEach((entry) => {
         const entryDestPath = this.destinationPath(`${entry}.js`);
@@ -300,70 +297,16 @@ export default class CommonBabelGenerator extends Generator {
   }
 
   default() {
-    const useBabel = this.babelEnvs && this.babelEnvs.length > 0;
     const pkg = this.fs.readJSON(this.destinationPath('package.json'));
-    const hasTargetNode = this.babelEnvs.find((env) => env.target === 'node');
+    const useBabel = this.babelEnvs && this.babelEnvs.length > 0;
+    const useTypescript = useBabel || pkg.pob?.typescript;
+    const hasTargetNode = useBabel
+      ? this.babelEnvs.find((env) => env.target === 'node')
+      : useTypescript; // todo pkg.pob.typescriptTargets
     const hasTargetBrowser = this.babelEnvs.find(
       (env) => env.target === 'browser',
     );
 
-    /* scripts */
-
-    if (this.options.isApp) {
-      packageUtils.removeScripts(['watch']);
-      packageUtils.addOrRemoveScripts(pkg, useBabel, {
-        'clean:build': `pob-babel-clean-out ${this.options.buildDirectory}`,
-        build: 'yarn clean:build && rollup --config rollup.config.mjs',
-        start: 'yarn clean:build && rollup --config rollup.config.mjs --watch',
-        clean: 'yarn clean:build',
-      });
-    } else {
-      packageUtils.removeScripts(['start']);
-      packageUtils.addScripts(pkg, {
-        'clean:build': useBabel
-          ? `pob-babel-clean-out ${this.options.buildDirectory}`
-          : 'true',
-      });
-      packageUtils.addOrRemoveScripts(pkg, useBabel, {
-        build: 'yarn clean:build && rollup --config rollup.config.mjs',
-        watch: 'yarn clean:build && rollup --config rollup.config.mjs --watch',
-        clean: 'yarn clean:build',
-      });
-    }
-
-    const shouldBuildDefinitions = !this.options.isApp && useBabel;
-    packageUtils.addOrRemoveScripts(pkg, shouldBuildDefinitions, {
-      'build:definitions': 'tsc -p tsconfig.json',
-    });
-
-    if (shouldBuildDefinitions) {
-      pkg.scripts.build += ' && yarn run build:definitions';
-    } else if (!this.options.isApp && !useBabel) {
-      // check definitions, but also force lerna to execute build:definitions in right order
-      // example: nightingale-types depends on nightingale-levels
-      if (this.fs.exists(this.destinationPath('lib/index.d.ts'))) {
-        packageUtils.addScripts(pkg, {
-          'build:definitions':
-            'tsc --lib esnext --noEmit --skipLibCheck ./lib/index.d.ts',
-          build: 'yarn run build:definitions',
-        });
-      }
-
-      if (this.fs.exists(this.destinationPath('lib/index.ts'))) {
-        packageUtils.addScripts(pkg, {
-          'build:definitions':
-            'tsc --lib esnext --noEmit --skipLibCheck ./lib/index.ts',
-          build: 'yarn run build:definitions',
-        });
-      }
-    }
-
-    if (pkg.scripts) {
-      delete pkg.scripts.postbuild;
-      delete pkg.scripts['build:dev'];
-      delete pkg.scripts['watch:dev'];
-    }
-
     /* dependencies */
 
     packageUtils.addOrRemoveDevDependencies(
@@ -411,11 +354,14 @@ export default class CommonBabelGenerator extends Generator {
 
     if (hasTargetNode) {
       if (!pkg.engines) pkg.engines = {};
-      const minNodeVersion = Math.min(
-        ...this.babelEnvs
-          .filter((env) => env.target === 'node')
-          .map((env) => env.version),
-      );
+      const minNodeVersion = useBabel
+        ? Math.min(
+            ...this.babelEnvs
+              .filter((env) => env.target === 'node')
+              .map((env) => env.version),
+          )
+        : // eslint-disable-next-line unicorn/no-unreadable-iife
+          (() => (this.options.onlyLatestLTS ? '20' : '18'))();
       switch (String(minNodeVersion)) {
         case '10':
         case '12':
@@ -492,245 +438,6 @@ export default class CommonBabelGenerator extends Generator {
       delete pkg.browserslist;
     }
 
-    /* side effects */
-
-    if (this.options.isApp && !this.options.isAppLibrary) {
-      delete pkg.sideEffects;
-    } else if (!('sideEffects' in pkg)) {
-      pkg.sideEffects = true;
-      console.warn('Setting pkg.sideEffects to true, as it was not defined');
-    } else if (pkg.sideEffects) {
-      console.warn(
-        "pkg.sideEffects is true, are you sure you can't set it to false ?",
-      );
-    }
-
-    /* main / aliases / typing */
-
-    if (this.options.isApp) {
-      delete pkg.types;
-      delete pkg.typings;
-    } else if (pkg.typings) {
-      if (!pkg.types) pkg.types = pkg.typings;
-      delete pkg.typings;
-    }
-
-    // if (!pkg.main || pkg.main.startsWith('./lib/')) {
-    if (useBabel) {
-      // see pkg.exports instead.
-      delete pkg.main;
-      if (!this.options.isApp) {
-        pkg.types = `./${this.options.buildDirectory}/definitions/index.d.ts`;
-      }
-    } else {
-      if (!pkg.main) {
-        pkg.exports = './lib/index.js';
-      }
-      if (pkg.type === 'module' && this.fs.exists('./lib/index.cjs')) {
-        pkg.main = './lib/index.cjs';
-      } else {
-        pkg.main = './lib/index.js';
-      }
-      if (!this.options.isApp) {
-        if (this.fs.exists('./lib/index.ts')) {
-          pkg.types = './lib/index.ts';
-        } else if (this.fs.exists('./lib/index.d.ts') || pkg.types) {
-          pkg.types = './lib/index.d.ts';
-        }
-      }
-      if (!pkg.engines) pkg.engines = {};
-      if (
-        !pkg.engines.node ||
-        semver.lt(
-          semver.minVersion(pkg.engines.node),
-          // pkg.type === 'commonjs' ? '12.10.0' : '12.20.0',
-          '14.13.1',
-        )
-      ) {
-        pkg.engines.node = '>=16.0.0';
-      }
-    }
-
-    delete pkg['browser-dev'];
-    delete pkg['module-dev'];
-
-    const esAllBrowserEnv = this.babelEnvs.find(
-      (env) =>
-        env.target === 'browser' &&
-        env.version === undefined &&
-        (!env.formats || env.formats.includes('es')),
-    );
-
-    // Legacy "dev" builds
-    delete pkg['module:browser'];
-    delete pkg['module:browser-dev'];
-    delete pkg['module:modern-browsers'];
-    delete pkg['module:modern-browsers-dev'];
-    delete pkg['module:node'];
-    delete pkg['module:node-dev'];
-
-    /* webpack 4 */
-    if (esAllBrowserEnv) {
-      pkg.module = `./${this.options.buildDirectory}/index-browser.es.js`;
-      pkg.browser = `./${this.options.buildDirectory}/index-browser.es.js`;
-    } else {
-      delete pkg.module;
-      delete pkg.browser;
-    }
-
-    /* webpack 5 and node with ESM support */
-    if (useBabel) {
-      pkg.exports = {
-        './package.json': './package.json',
-      };
-
-      this.entries.forEach((entry) => {
-        const isBrowserOnly =
-          entry === 'browser' &&
-          (this.babelEnvs.every((env) => env.target === 'browser') ||
-            (this.entries.length === 2 && this.entries.includes('index')));
-        const entryDistName = isBrowserOnly ? 'index' : entry;
-        const exportName = entry === 'index' ? '.' : `./${entry}`;
-
-        const targets = {
-          types:
-            pkg.private || this.options.isAppLibrary
-              ? `./src/${entryDistName}.ts`
-              : `./${this.options.buildDirectory}/definitions/${entryDistName}.d.ts`,
-        };
-
-        const defaultNodeEnv = this.babelEnvs.find(
-          (env) => env.target === 'node',
-        );
-        const defaultNodeEnvVersion = defaultNodeEnv && defaultNodeEnv.version;
-
-        this.babelEnvs.forEach(({ target, version, formats }) => {
-          if (target === 'node' && entry === 'browser') return;
-
-          const exportTarget = {};
-
-          if (target === 'node') {
-            const cjsExt = pkg.type === 'module' ? 'cjs' : 'cjs.js';
-            if (!formats || formats.includes('es')) {
-              exportTarget.import = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.mjs`;
-
-              if (formats && formats.includes('cjs')) {
-                exportTarget.require = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.${cjsExt}`;
-              }
-            } else if (formats && formats.includes('cjs')) {
-              exportTarget.default = `./${this.options.buildDirectory}/${entryDistName}-${target}${version}.${cjsExt}`;
-            }
-            // eslint: https://github.com/benmosher/eslint-plugin-import/issues/2132
-            // jest: https://github.com/facebook/jest/issues/9771
-            if (!pkg.main && exportName === '.') {
-              pkg.main =
-                pkg.type === 'module'
-                  ? exportTarget.import
-                  : exportTarget.default ||
-                    exportTarget.require ||
-                    exportTarget.import;
-            }
-          } else if (target === 'browser') {
-            if (!formats || formats.includes('es')) {
-              exportTarget.import = `./${
-                this.options.buildDirectory
-              }/${entryDistName}-${target}${version || ''}.es.js`;
-            }
-
-            if (formats && formats.includes('cjs')) {
-              exportTarget.require = `./${
-                this.options.buildDirectory
-              }/index-${target}${version || ''}.cjs.js`;
-            }
-          }
-
-          if (
-            !version ||
-            (target === 'node' && version === defaultNodeEnvVersion)
-          ) {
-            targets[target] = {
-              ...targets[target],
-              ...exportTarget,
-            };
-          } else {
-            targets[target] = {
-              [`${target}:${version}`]: exportTarget,
-              ...targets[target],
-            };
-          }
-        });
-
-        pkg.exports[exportName] = targets;
-      });
-
-      if (pkg.pob.extraEntries) {
-        pkg.pob.extraEntries.forEach((extraEntryConfig) => {
-          if (typeof extraEntryConfig === 'string') {
-            extraEntryConfig = {
-              name: extraEntryConfig,
-            };
-          }
-
-          const calcExport = () => {
-            if (pkg.type === 'module') {
-              return extraEntryConfig.name.endsWith('.cjs') ||
-                extraEntryConfig.name.endsWith('.d.ts')
-                ? `./${extraEntryConfig.name}`
-                : `./${extraEntryConfig.name}.js`;
-            }
-
-            return {
-              import: `./${extraEntryConfig.name}.mjs`,
-              require: `./${extraEntryConfig.name}.js`,
-            };
-          };
-
-          let exportValue = calcExport();
-
-          if (extraEntryConfig.types) {
-            if (typeof exportValue === 'string') {
-              exportValue = {
-                types: `./${extraEntryConfig.types}`,
-                default: exportValue,
-              };
-            } else {
-              exportValue = {
-                types: `./${extraEntryConfig.types}`,
-                ...exportValue,
-              };
-            }
-          }
-
-          pkg.exports[`./${extraEntryConfig.name}`] = exportValue;
-        });
-      }
-    } else if (!pkg.exports) {
-      console.error('Please setup your package.exports manually.');
-    } else {
-      if (typeof pkg.exports === 'string') {
-        pkg.exports = {
-          '.': pkg.exports,
-        };
-      }
-      if (!pkg.exports['./package.json']) {
-        pkg.exports['./package.json'] = './package.json';
-      }
-
-      if (pkg.types && !pkg.exports['.'].types) {
-        if (typeof pkg.exports['.'] === 'string') {
-          pkg.exports['.'] = {
-            default: pkg.exports['.'],
-          };
-        }
-        pkg.exports['.'] = { types: pkg.types, ...pkg.exports['.'] };
-      }
-    }
-
-    Object.keys(pkg).forEach((key) => {
-      if (!key.startsWith('module:') && !key.startsWith('webpack:')) return;
-      delete pkg[key];
-    });
-
     this.fs.writeJSON(this.destinationPath('package.json'), pkg);
   }
 
@@ -778,7 +485,7 @@ export default class CommonBabelGenerator extends Generator {
           },
         );
       }
-    } else {
+    } else if (!pkg.pob.typescript && pkg.pob.rollup !== false) {
       this.fs.delete('rollup.config.mjs');
     }
 

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -116,11 +116,13 @@ export default class CommonLintGenerator extends Generator {
   writing() {
     const pkg = this.fs.readJSON(this.destinationPath('package.json'));
     const babelEnvs = (pkg.pob && pkg.pob.babelEnvs) || [];
+    // const typescriptTargets = (pkg.pob && pkg.pob.typescriptTargets) || [];
     const useBabel =
       this.options.babel !== 'undefined'
         ? this.options.babel === 'true'
         : babelEnvs.length > 0;
-    const hasReact = useBabel && packageUtils.hasReact(pkg);
+    const useTypescript = useBabel || pkg.pob?.typescript;
+    const hasReact = useTypescript && packageUtils.hasReact(pkg);
     const useNode = !useBabel || babelEnvs.some((env) => env.target === 'node');
     const useNodeOnly =
       !useBabel ||
@@ -310,12 +312,12 @@ export default class CommonLintGenerator extends Generator {
             ['@typescript-eslint/eslint-plugin', '@typescript-eslint/parser'],
           );
         } else {
-          packageUtils.addOrRemoveDevDependencies(pkg, useBabel, [
+          packageUtils.addOrRemoveDevDependencies(pkg, useTypescript, [
             '@pob/eslint-config-typescript',
           ]);
           packageUtils.addOrRemoveDevDependencies(
             pkg,
-            useBabel && shouldHavePluginsDependencies,
+            useTypescript && shouldHavePluginsDependencies,
             ['@typescript-eslint/eslint-plugin', '@typescript-eslint/parser'],
           );
 
@@ -363,10 +365,13 @@ export default class CommonLintGenerator extends Generator {
         ];
       }
 
-      if (useBabel) {
+      if (useTypescript) {
         return [
           '@pob/eslint-config-typescript',
           useNodeOnly && '@pob/eslint-config-typescript/node',
+          // useTypescript &&
+          //   pkg.pob?.rollup === false &&
+          //   '@pob/eslint-config-typescript/tsc-emit',
           this.options.isApp && '@pob/eslint-config-typescript/app',
           hasReact &&
             `@pob/eslint-config-typescript-react${
@@ -382,7 +387,7 @@ export default class CommonLintGenerator extends Generator {
       ];
     })();
 
-    const ext = !useBabel
+    const ext = !useTypescript
       ? `{${pkg.type === 'commonjs' ? 'mjs' : 'cjs'},js}`
       : `${hasReact ? '{ts,tsx}' : 'ts'}`;
 
@@ -405,7 +410,7 @@ export default class CommonLintGenerator extends Generator {
       //   testsOverride.extends = ['pob/babel'];
       // }
 
-      if (useBabel) {
+      if (useTypescript) {
         testsOverride.extends = ['@pob/eslint-config-typescript/test'];
       }
     }
@@ -423,19 +428,14 @@ export default class CommonLintGenerator extends Generator {
       ? this.destinationPath('.eslintrc.json')
       : this.destinationPath(
           `${
-            useBabel ? `${this.options.srcDirectory}/` : 'lib/'
+            useTypescript ? `${this.options.srcDirectory}/` : 'lib/'
           }.eslintrc.json`,
         );
 
-    const useTypescript = useBabel;
     const getRootIgnorePatterns = () => {
       const ignorePatterns = new Set();
 
-      if (
-        inMonorepo &&
-        !inMonorepo.root &&
-        (this.options.typescript || pkg.types)
-      ) {
+      if (inMonorepo && !inMonorepo.root && (useTypescript || pkg.types)) {
         ignorePatterns.add('*.d.ts');
       }
 
@@ -443,7 +443,7 @@ export default class CommonLintGenerator extends Generator {
         ignorePatterns.add('/docs');
       }
 
-      if ((!inMonorepo || !inMonorepo.root) && useBabel) {
+      if ((!inMonorepo || !inMonorepo.root) && useTypescript) {
         const buildPath = `/${this.options.buildDirectory}`;
         if (
           !this.options.rootIgnorePaths ||
@@ -517,7 +517,7 @@ export default class CommonLintGenerator extends Generator {
           {
             extendsConfig: extendsConfigSrc,
             testsOverride,
-            useTypescript: useBabel,
+            useTypescript,
             globalEslint,
             ignorePatterns:
               ignorePatterns.size === 0 ? undefined : [...ignorePatterns],