pob 15.0.3 → 15.1.0

package/CHANGELOG.md

@@ -3,6 +3,19 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [15.1.0](https://github.com/christophehurpeau/pob/compare/pob@15.0.3...pob@15.1.0) (2023-11-11)
+
+
+### Bug Fixes
+
+* **deps:** update dependency @types/inquirer to v9.0.7 ([#1839](https://github.com/christophehurpeau/pob/issues/1839)) ([0f2bfb3](https://github.com/christophehurpeau/pob/commit/0f2bfb3b020287c49aa6a0ee37254a11ed3089cd))
+* **deps:** update yeoman group ([#1810](https://github.com/christophehurpeau/pob/issues/1810)) ([cd69295](https://github.com/christophehurpeau/pob/commit/cd692950f15e4f64c8e392f282f6981c797773eb))
+* **pob:** add missing async/await with composeWith ([4b679d5](https://github.com/christophehurpeau/pob/commit/4b679d521430af32fcd6bf8f0fe5dce53c1e68e6))
+
+Version bump for dependency: yarn-workspace-utils
+Version bump for dependency: root
+
+
 ## [15.0.3](https://github.com/christophehurpeau/pob/compare/pob@15.0.2...pob@15.0.3) (2023-11-05)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -127,7 +127,7 @@ export default class PobAppGenerator extends Generator {
     this.config.save();
   }
 
-  default() {
+  async default() {
     const srcDirectory =
       this.appConfig.type === 'yarn-plugin' ? 'sources' : 'src';
     const isAppLibrary = this.appConfig.type === 'node-library';
@@ -137,7 +137,7 @@ export default class PobAppGenerator extends Generator {
       this.appConfig.type === 'node-library' ||
       this.appConfig.type === 'alp-node'
     ) {
-      this.composeWith('pob:common:babel', {
+      await this.composeWith('pob:common:babel', {
         updateOnly: this.options.updateOnly,
         onlyLatestLTS: true,
         isApp: true,
@@ -153,7 +153,7 @@ export default class PobAppGenerator extends Generator {
     const pkg = this.fs.readJSON(this.destinationPath('package.json'));
 
     if (!inMonorepo || inMonorepo.root) {
-      this.composeWith('pob:common:husky', {});
+      await this.composeWith('pob:common:husky', {});
     }
 
     const babelEnvs = (pkg.pob && pkg.pob.babelEnvs) || [];
@@ -175,7 +175,7 @@ export default class PobAppGenerator extends Generator {
       pkg,
     ).filter(Boolean);
 
-    this.composeWith('pob:common:typescript', {
+    await this.composeWith('pob:common:typescript', {
       enable: babel,
       isApp: true,
       isAppLibrary,
@@ -206,13 +206,13 @@ export default class PobAppGenerator extends Generator {
       })(),
     });
 
-    this.composeWith('pob:common:remove-old-dependencies');
+    await this.composeWith('pob:common:remove-old-dependencies');
 
     const enableReleasePlease =
       !inMonorepo && this.appConfig.testing && this.appConfig.ci;
 
     if (this.appConfig.type !== 'remix') {
-      this.composeWith('pob:common:testing', {
+      await this.composeWith('pob:common:testing', {
         enable: this.appConfig.testing,
         disableYarnGitCache: this.options.disableYarnGitCache,
         enableReleasePlease,
@@ -229,7 +229,7 @@ export default class PobAppGenerator extends Generator {
         srcDirectory,
       });
 
-      this.composeWith('pob:common:format-lint', {
+      await this.composeWith('pob:common:format-lint', {
         isApp: true,
         documentation: false,
         testing: this.appConfig.testing,
@@ -245,7 +245,7 @@ export default class PobAppGenerator extends Generator {
         buildDirectory: this.appConfig.type === 'expo' ? '.expo' : 'build',
       });
 
-      this.composeWith('pob:common:release', {
+      await this.composeWith('pob:common:release', {
         enable:
           !inMonorepo &&
           this.appConfig.testing &&
@@ -260,7 +260,7 @@ export default class PobAppGenerator extends Generator {
       });
     }
 
-    this.composeWith('pob:core:vscode', {
+    await this.composeWith('pob:core:vscode', {
       root: !inMonorepo,
       monorepo: false,
       packageManager: this.options.packageManager,
@@ -274,7 +274,7 @@ export default class PobAppGenerator extends Generator {
       ignorePaths.push('/.env*', '!/.env.example');
     }
 
-    this.composeWith('pob:core:gitignore', {
+    await this.composeWith('pob:core:gitignore', {
       root: !inMonorepo || inMonorepo.root,
       documentation: false,
       testing: this.appConfig.testing,
@@ -283,16 +283,16 @@ export default class PobAppGenerator extends Generator {
       buildInGit: false,
     });
 
-    this.composeWith('pob:core:npm', { enable: false });
+    await this.composeWith('pob:core:npm', { enable: false });
 
     switch (this.appConfig.type) {
       case 'next.js':
-        this.composeWith('pob:app:nextjs', {
+        await this.composeWith('pob:app:nextjs', {
           export: this.appConfig.export,
         });
         break;
       case 'remix':
-        this.composeWith('pob:app:remix', {});
+        await this.composeWith('pob:app:remix', {});
         break;
     }
 
@@ -305,7 +305,7 @@ export default class PobAppGenerator extends Generator {
     }
   }
 
-  writing() {
+  async writing() {
     // Re-read the content at this point because a composed generator might modify it.
     const pkg = this.fs.readJSON(this.destinationPath('package.json'));
 
@@ -319,6 +319,6 @@ export default class PobAppGenerator extends Generator {
 
     this.fs.writeJSON(this.destinationPath('package.json'), pkg);
 
-    this.composeWith('pob:core:sort-package');
+    await this.composeWith('pob:core:sort-package');
   }
 }

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -109,9 +109,9 @@ export default class CommonTestingGenerator extends Generator {
     });
   }
 
-  default() {
+  async default() {
     if (!inMonorepo || inMonorepo.root) {
-      this.composeWith('pob:core:ci', {
+      await this.composeWith('pob:core:ci', {
         enable: this.options.ci,
         enableReleasePlease: this.options.enableReleasePlease,
         enableYarnVersion: this.options.enableYarnVersion,
@@ -127,7 +127,7 @@ export default class CommonTestingGenerator extends Generator {
         onlyLatestLTS: this.options.onlyLatestLTS,
       });
     } else {
-      this.composeWith('pob:core:ci', {
+      await this.composeWith('pob:core:ci', {
         enable: false,
       });
     }

package/lib/generators/core/git/CoreGitGenerator.js

@@ -99,9 +99,9 @@ export default class CoreGitGenerator extends Generator {
     }
   }
 
-  default() {
+  async default() {
     if (this.gitHost === 'github') {
-      this.composeWith('pob:core:git:github', {
+      await this.composeWith('pob:core:git:github', {
         shouldCreate: !this.originUrl,
         gitHostAccount: this.gitHostAccount,
         repoName: this.repoName,

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -156,7 +156,7 @@ export default class CoreYarnGenerator extends Generator {
         };
       }
       config.defaultSemverRangePrefix = this.options.type === 'app' ? '' : '^';
-      config.enableMessageNames = false;
+      delete config.enableMessageNames; // was a config for yarn < 4
       config.nodeLinker = this.options.yarnNodeLinker;
 
       if (config.yarnPath) {

package/lib/generators/lib/PobLibGenerator.js

@@ -230,7 +230,7 @@ export default class PobLibGenerator extends Generator {
 
     this.fs.writeJSON(this.destinationPath('package.json'), pkg);
 
-    this.composeWith('pob:common:babel', {
+    await this.composeWith('pob:common:babel', {
       updateOnly: this.options.updateOnly,
       testing: !!this.pobjson.testing,
       documentation: !!this.pobjson.documentation,
@@ -239,7 +239,7 @@ export default class PobLibGenerator extends Generator {
     });
   }
 
-  default() {
+  async default() {
     const pkg = this.fs.readJSON(this.destinationPath('package.json'));
     const babelEnvs = pkg.pob.babelEnvs || [];
 
@@ -248,7 +248,7 @@ export default class PobLibGenerator extends Generator {
     const browser =
       withBabel && babelEnvs.some((env) => env.target === 'browser');
 
-    this.composeWith('pob:common:typescript', {
+    await this.composeWith('pob:common:typescript', {
       enable: withBabel,
       isApp: false,
       dom: browser,
@@ -263,14 +263,14 @@ export default class PobLibGenerator extends Generator {
       fs.mkdirSync(this.destinationPath('lib'), { recursive: true });
     }
 
-    this.composeWith('pob:common:husky', {});
+    await this.composeWith('pob:common:husky', {});
 
-    this.composeWith('pob:common:remove-old-dependencies');
+    await this.composeWith('pob:common:remove-old-dependencies');
 
     const enableReleasePlease =
       !inMonorepo && this.pobjson.testing && this.pobjson.testing.ci;
 
-    this.composeWith('pob:common:testing', {
+    await this.composeWith('pob:common:testing', {
       enable: this.pobjson.testing,
       disableYarnGitCache: this.options.disableYarnGitCache,
       enableReleasePlease,
@@ -289,7 +289,7 @@ export default class PobLibGenerator extends Generator {
     });
 
     // must be after testing
-    this.composeWith('pob:common:format-lint', {
+    await this.composeWith('pob:common:format-lint', {
       documentation:
         !!this.pobjson.documentation ||
         !!(this.pobjson.testing && this.pobjson.testing.codecov),
@@ -299,20 +299,20 @@ export default class PobLibGenerator extends Generator {
       ignorePaths: withBabel ? '/dist' : '',
     });
 
-    this.composeWith('pob:lib:doc', {
+    await this.composeWith('pob:lib:doc', {
       enabled: this.pobjson.documentation,
       testing: this.pobjson.testing,
     });
 
     // must be after doc, testing
-    this.composeWith('pob:lib:readme', {
+    await this.composeWith('pob:lib:readme', {
       documentation: !!this.pobjson.documentation,
       testing: !!this.pobjson.testing,
       ci: this.pobjson.testing && this.pobjson.testing.ci,
       codecov: this.pobjson.testing && this.pobjson.testing.codecov,
     });
 
-    this.composeWith('pob:common:release', {
+    await this.composeWith('pob:common:release', {
       enable: !inMonorepo && this.pobjson.testing,
       enablePublish: true,
       withBabel: babelEnvs.length > 0,
@@ -323,7 +323,7 @@ export default class PobLibGenerator extends Generator {
       updateOnly: this.options.updateOnly,
     });
 
-    this.composeWith('pob:core:vscode', {
+    await this.composeWith('pob:core:vscode', {
       root: !inMonorepo,
       monorepo: false,
       packageManager: this.options.packageManager,
@@ -333,7 +333,7 @@ export default class PobLibGenerator extends Generator {
     });
 
     // must be after doc, testing
-    this.composeWith('pob:core:gitignore', {
+    await this.composeWith('pob:core:gitignore', {
       root: !inMonorepo,
       withBabel: babelEnvs.length > 0,
       typescript: babelEnvs.length > 0,
@@ -341,14 +341,14 @@ export default class PobLibGenerator extends Generator {
       testing: !!this.pobjson.testing,
     });
 
-    this.composeWith('pob:core:npm', {
+    await this.composeWith('pob:core:npm', {
       enable: !pkg.private,
       srcDirectory: withBabel ? 'src' : 'lib',
       distDirectory: withBabel ? 'dist' : '',
     });
   }
 
-  writing() {
+  async writing() {
     // Re-read the content at this point because a composed generator might modify it.
     const pkg = this.fs.readJSON(this.destinationPath('package.json'));
 
@@ -412,6 +412,6 @@ export default class PobLibGenerator extends Generator {
     this.config.set('lib', pobjson);
     this.config.save();
 
-    this.composeWith('pob:core:sort-package');
+    await this.composeWith('pob:core:sort-package');
   }
 }

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -201,7 +201,7 @@ export default class PobMonorepoGenerator extends Generator {
     this.config.delete('pob-config');
   }
 
-  default() {
+  async default() {
     const pkg = this.fs.readJSON(this.destinationPath('package.json'), {});
 
     const packageNames = this.packageNames;
@@ -216,13 +216,13 @@ export default class PobMonorepoGenerator extends Generator {
       throw new Error('packages should not be empty');
     }
 
-    this.composeWith('pob:common:husky', {});
+    await this.composeWith('pob:common:husky', {});
 
     const isYarnVersionEnabled = this.pobLernaConfig.ci;
 
     const splitCIJobs = this.packageNames.length > 8;
 
-    this.composeWith('pob:common:testing', {
+    await this.composeWith('pob:common:testing', {
       monorepo: true,
       enable: this.pobLernaConfig.testing,
       disableYarnGitCache: this.options.disableYarnGitCache,
@@ -240,7 +240,7 @@ export default class PobMonorepoGenerator extends Generator {
       splitCIJobs,
     });
 
-    this.composeWith('pob:common:format-lint', {
+    await this.composeWith('pob:common:format-lint', {
       monorepo: true,
       documentation: this.pobLernaConfig.documentation,
       typescript: this.pobLernaConfig.typescript,
@@ -257,7 +257,7 @@ export default class PobMonorepoGenerator extends Generator {
       rootIgnorePaths: [],
     });
 
-    this.composeWith('pob:lib:doc', {
+    await this.composeWith('pob:lib:doc', {
       enabled: this.pobLernaConfig.documentation,
       testing: this.pobLernaConfig.testing,
       packageNames: JSON.stringify(packageNames),
@@ -265,7 +265,7 @@ export default class PobMonorepoGenerator extends Generator {
       packageManager: this.options.packageManager,
     });
 
-    this.composeWith('pob:core:vscode', {
+    await this.composeWith('pob:core:vscode', {
       root: true,
       monorepo: true,
       packageManager: this.options.packageManager,
@@ -277,16 +277,16 @@ export default class PobMonorepoGenerator extends Generator {
     });
 
     // Always add a gitignore, because npm publish uses it.
-    this.composeWith('pob:core:gitignore', {
+    await this.composeWith('pob:core:gitignore', {
       root: true,
       typescript: this.pobLernaConfig.typescript,
       documentation: this.pobLernaConfig.documentation,
       testing: this.pobLernaConfig.testing,
     });
 
-    this.composeWith('pob:common:remove-old-dependencies');
+    await this.composeWith('pob:common:remove-old-dependencies');
 
-    this.composeWith('pob:common:release', {
+    await this.composeWith('pob:common:release', {
       enable: true,
       enablePublish: !this.options.isAppProject,
       withBabel: this.pobLernaConfig.typescript,
@@ -297,7 +297,7 @@ export default class PobMonorepoGenerator extends Generator {
       updateOnly: this.options.updateOnly,
     });
 
-    this.composeWith('pob:monorepo:typescript', {
+    await this.composeWith('pob:monorepo:typescript', {
       enable: this.pobLernaConfig.typescript,
       isAppProject: this.options.isAppProject,
       packageNames: JSON.stringify(packageNames),
@@ -313,7 +313,7 @@ export default class PobMonorepoGenerator extends Generator {
     }
   }
 
-  writing() {
+  async writing() {
     if (!this.options.isAppProject) {
       const pkg = this.fs.readJSON(this.destinationPath('package.json'), {});
 
@@ -352,7 +352,7 @@ export default class PobMonorepoGenerator extends Generator {
       this.fs.writeJSON(this.destinationPath('package.json'), pkg);
     }
 
-    this.composeWith('pob:core:sort-package');
+    await this.composeWith('pob:core:sort-package');
   }
 
   end() {

package/lib/generators/pob/PobBaseGenerator.js

@@ -113,15 +113,15 @@ export default class PobBaseGenerator extends Generator {
     this.config.set('project', this.projectConfig);
   }
 
-  default() {
-    this.composeWith('pob:core:yarn', {
+  async default() {
+    await this.composeWith('pob:core:yarn', {
       type: this.projectConfig.type,
       enable: this.isRoot && this.projectConfig.packageManager === 'yarn',
       yarnNodeLinker: this.projectConfig.yarnNodeLinker,
       disableYarnGitCache: this.projectConfig.disableYarnGitCache,
     });
 
-    this.composeWith('pob:core:package', {
+    await this.composeWith('pob:core:package', {
       updateOnly: this.options.updateOnly,
       private: this.isMonorepo,
       isMonorepo: this.isMonorepo,
@@ -130,13 +130,13 @@ export default class PobBaseGenerator extends Generator {
     });
 
     if (this.isMonorepo) {
-      this.composeWith('pob:monorepo:workspaces', {
+      await this.composeWith('pob:monorepo:workspaces', {
         force: this.options.force,
         isAppProject: this.projectConfig.type === 'app',
         packageManager: this.projectConfig.packageManager,
         disableYarnGitCache: this.projectConfig.disableYarnGitCache,
       });
-      this.composeWith('pob:monorepo:lerna', {
+      await this.composeWith('pob:monorepo:lerna', {
         force: this.options.force,
         isAppProject: this.projectConfig.type === 'app',
         packageManager: this.projectConfig.packageManager,
@@ -147,13 +147,13 @@ export default class PobBaseGenerator extends Generator {
     this.fs.delete('Makefile');
     this.fs.delete(this.destinationPath('.commitrc.js'));
 
-    this.composeWith('pob:core:editorconfig');
+    await this.composeWith('pob:core:editorconfig');
 
-    this.composeWith('pob:core:clean', {
+    await this.composeWith('pob:core:clean', {
       root: this.isRoot,
     });
 
-    this.composeWith('pob:core:renovate', {
+    await this.composeWith('pob:core:renovate', {
       updateOnly: this.options.updateOnly,
       app: this.projectConfig.type === 'app',
     });
@@ -167,7 +167,7 @@ export default class PobBaseGenerator extends Generator {
     if (!this.hasAncestor) {
       const splitCIJobs =
         inMonorepo && inMonorepo.pobMonorepoConfig?.packageNames.length > 8;
-      this.composeWith('pob:core:git', {
+      await this.composeWith('pob:core:git', {
         onlyLatestLTS,
         splitCIJobs,
       });
@@ -192,7 +192,7 @@ export default class PobBaseGenerator extends Generator {
     }
 
     if (this.isMonorepo) {
-      this.composeWith(
+      await this.composeWith(
         // pob:monorepo <= for searching PobMonorepoGenerator.js
         fileURLToPath(
           new URL('../monorepo/PobMonorepoGenerator.js', import.meta.url),
@@ -209,7 +209,7 @@ export default class PobBaseGenerator extends Generator {
     } else {
       switch (this.projectConfig.type) {
         case 'lib':
-          this.composeWith('pob:lib', {
+          await this.composeWith('pob:lib', {
             monorepo: this.isMonorepo,
             isRoot: this.isRoot,
             disableYarnGitCache: this.projectConfig.disableYarnGitCache,
@@ -220,7 +220,7 @@ export default class PobBaseGenerator extends Generator {
           });
           break;
         case 'app':
-          this.composeWith('pob:app', {
+          await this.composeWith('pob:app', {
             monorepo: this.isMonorepo,
             isRoot: this.isRoot,
             disableYarnGitCache: this.projectConfig.disableYarnGitCache,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "15.0.3",
+  "version": "15.1.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -46,7 +46,7 @@
     "@pob/sort-eslint-config": "5.1.0",
     "@pob/sort-object": "6.1.0",
     "@pob/sort-pkg": "6.1.0",
-    "@types/inquirer": "9.0.6",
+    "@types/inquirer": "9.0.7",
     "@yarnpkg/cli": "4.0.1",
     "@yarnpkg/core": "4.0.1",
     "@yarnpkg/fslib": "3.0.1",
@@ -60,18 +60,18 @@
     "json5": "^2.2.2",
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
-    "mem-fs": "3.0.0",
-    "mem-fs-editor": "10.0.3",
+    "mem-fs": "4.0.0",
+    "mem-fs-editor": "11.0.0",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "8.9.2",
+    "pob-dependencies": "8.9.3",
     "prettier": "2.8.8",
     "semver": "7.5.4",
-    "yarn-workspace-utils": "1.2.2",
-    "yeoman-environment": "4.0.0-beta.5",
-    "yeoman-generator": "6.0.0-rc.6"
+    "yarn-workspace-utils": "1.2.3",
+    "yeoman-environment": "4.0.0",
+    "yeoman-generator": "7.1.0"
   },
   "devDependencies": {
-    "@pob/root": "8.6.0"
+    "@pob/root": "8.7.0"
   }
 }