pob 13.2.3 → 13.3.0

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.3.0](https://github.com/christophehurpeau/pob/compare/pob@13.2.3...pob@13.3.0) (2023-07-05)
+
+
+### Features
+
+* **deps:** update dependency eslint to v8.44.0 ([#1694](https://github.com/christophehurpeau/pob/issues/1694)) ([1b75923](https://github.com/christophehurpeau/pob/commit/1b75923242c12b624c7c74585d3484c191c913ec))
+* **pob:** add config for yarn-plugin app ([c18d783](https://github.com/christophehurpeau/pob/commit/c18d783621291bd22ea367bf6ca77b7cd84ec661))
+
+
+
 ## [13.2.3](https://github.com/christophehurpeau/pob/compare/pob@13.2.2...pob@13.2.3) (2023-06-30)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -5,7 +5,14 @@ import inLerna from '../../utils/inLerna.js';
 import * as packageUtils from '../../utils/package.js';
 import { appIgnorePaths } from './ignorePaths.js';
 
-const appsWithTypescript = ['alp', 'next.js', 'remix', 'pobpack', 'expo'];
+const appsWithTypescript = [
+  'alp',
+  'next.js',
+  'remix',
+  'pobpack',
+  'expo',
+  'yarn-plugin',
+];
 const appsWithBrowser = ['alp', 'next.js', 'remix'];
 
 export default class PobAppGenerator extends Generator {
@@ -114,6 +121,7 @@ export default class PobAppGenerator extends Generator {
   }
 
   default() {
+    const srcDir = this.appConfig.type === 'yarn-plugin' ? 'sources' : 'src';
     if (
       this.appConfig.type === 'node' ||
       this.appConfig.type === 'node-library' ||
@@ -146,6 +154,10 @@ export default class PobAppGenerator extends Generator {
         ? pkg.pob.jsx
         : packageUtils.hasReact(pkg);
 
+    if (!appIgnorePaths[this.appConfig.type]) {
+      throw new Error(`Unknown app type: ${this.appConfig.type}`);
+    }
+
     const ignorePaths = appIgnorePaths[this.appConfig.type](
       this.appConfig,
     ).filter(Boolean);
@@ -153,8 +165,8 @@ export default class PobAppGenerator extends Generator {
     this.composeWith('pob:common:typescript', {
       enable: babel,
       // nextjs now supports src
-      rootDir: this.appConfig.type === 'expo' ? '.' : 'src',
-      srcDir: 'src',
+      rootDir: this.appConfig.type === 'expo' ? '.' : srcDir,
+      srcDir,
       builddefs: false,
       dom: browser,
       jsx,
@@ -198,6 +210,7 @@ export default class PobAppGenerator extends Generator {
         isApp: true,
         splitCIJobs: false,
         onlyLatestLTS: true,
+        srcDir,
       });
 
       this.composeWith('pob:common:format-lint', {

package/lib/generators/app/ignorePaths.js

@@ -26,4 +26,5 @@ export const appIgnorePaths = {
     '# Temporary files created by Metro to check the health of the file watcher',
     '.metro-health-check*',
   ],
+  'yarn-plugin': (config) => [],
 };

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -85,6 +85,12 @@ export default class CommonTestingGenerator extends Generator {
       required: true,
       desc: 'only latest lts',
     });
+
+    this.option('srcDir', {
+      type: String,
+      default: 'src',
+      desc: 'customize srcDir, if different than rootDir',
+    });
   }
 
   default() {
@@ -207,14 +213,15 @@ export default class CommonTestingGenerator extends Generator {
           );
 
           if (!pkg.jest) pkg.jest = {};
+          const srcDir = this.options.srcDir;
           Object.assign(pkg.jest, {
             cacheDirectory: './node_modules/.cache/jest',
             testEnvironment: 'node',
             testMatch: [
-              `<rootDir>/${workspacesPattern}/*/@(src|lib)/**/__tests__/**/*.${
+              `<rootDir>/${workspacesPattern}/*/@(${srcDir}|lib)/**/__tests__/**/*.${
                 transpileWithBabel ? '(ts|js|cjs|mjs)' : '(js|cjs|mjs)'
               }${hasReact ? '?(x)' : ''}`,
-              `<rootDir>/${workspacesPattern}/*/@(src|lib)/**/*.test.${
+              `<rootDir>/${workspacesPattern}/*/@(${srcDir}|lib)/**/*.test.${
                 transpileWithBabel ? '(ts|js|cjs|mjs)' : '(js|cjs|mjs)'
               }${hasReact ? '?(x)' : ''}`,
             ],
@@ -242,7 +249,7 @@ export default class CommonTestingGenerator extends Generator {
             .replace('\\', '/')}`,
         });
       } else {
-        const babelEnvs = pkg.pob.babelEnvs || [];
+        const babelEnvs = pkg.pob?.babelEnvs || [];
         const transpileWithBabel = packageUtils.transpileWithBabel(pkg);
 
         const shouldUseExperimentalVmModules =
@@ -267,7 +274,7 @@ export default class CommonTestingGenerator extends Generator {
         });
 
         if (this.options.runner === 'jest') {
-          const srcDirectory = transpileWithBabel ? 'src' : 'lib';
+          const srcDirectory = transpileWithBabel ? this.options.srcDir : 'lib';
 
           if (!pkg.jest) pkg.jest = {};
           Object.assign(pkg.jest, {
@@ -334,10 +341,10 @@ export default class CommonTestingGenerator extends Generator {
         this.destinationPath('babel.config.cjs'),
         {
           only: !this.options.monorepo
-            ? "'src'"
+            ? `'${this.options.srcDir}'`
             : pkg.workspaces
                 .flatMap((workspace) => [
-                  `'${workspace}/src'`,
+                  `'${workspace}/${this.options.srcDir}'`,
                   `'${workspace}/lib'`,
                 ])
                 .join(', '),

package/lib/utils/package.js

@@ -29,6 +29,7 @@ export const transpileWithBabel = (pkg) =>
     (pkg.devDependencies &&
       (pkg.devDependencies['pob-babel'] ||
         pkg.devDependencies.next ||
+        pkg.devDependencies['@yarnpkg/builder'] ||
         pkg.devDependencies['alp-dev'])) ||
     // alp-dev has pob-babel in dependencies
     (pkg.dependencies &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "13.2.3",
+  "version": "13.3.0",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -46,7 +46,7 @@
     "@pob/sort-pkg": "6.0.1",
     "@types/inquirer": "9.0.3",
     "@yeoman/types": "1.0.1",
-    "eslint": "8.43.0",
+    "eslint": "8.44.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
     "github-username": "^7.0.0",
@@ -59,14 +59,14 @@
     "mem-fs-editor": "10.0.2",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "8.2.0",
+    "pob-dependencies": "8.3.0",
     "prettier": "2.8.8",
     "semver": "7.5.3",
     "yeoman-environment": "4.0.0-beta.3",
     "yeoman-generator": "6.0.0-rc.2"
   },
   "devDependencies": {
-    "@pob/root": "8.1.0"
+    "@pob/root": "8.1.1"
   },
-  "gitHead": "17a6cf5590bcbb5a177c743558e3f62e2ca2f28f"
+  "gitHead": "30355e11140d1c91a1cb5de451868a64b3d54227"
 }