pob 13.1.0 → 13.2.1

package/CHANGELOG.md

@@ -3,6 +3,32 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [13.2.1](https://github.com/christophehurpeau/pob/compare/pob@13.2.0...pob@13.2.1) (2023-06-30)
+
+
+### Bug Fixes
+
+* update template with node: prefix ([00514a7](https://github.com/christophehurpeau/pob/commit/00514a7b30c213b70bad5b77ef9145fcad85b09e))
+
+
+
+## [13.2.0](https://github.com/christophehurpeau/pob/compare/pob@13.1.0...pob@13.2.0) (2023-06-30)
+
+
+### Features
+
+* **deps:** update @pob/eslint-config to v51 (major) ([#1686](https://github.com/christophehurpeau/pob/issues/1686)) ([108057c](https://github.com/christophehurpeau/pob/commit/108057c620330ca0c86ffe4af49a25cddb571acf))
+* **deps:** update dependency eslint to v8.43.0 ([#1667](https://github.com/christophehurpeau/pob/issues/1667)) ([3b134d6](https://github.com/christophehurpeau/pob/commit/3b134d6a26ac43e55c05688eddc94dd32ba8feaf))
+* **deps:** update yeoman-generator ([#1609](https://github.com/christophehurpeau/pob/issues/1609)) ([18aedb1](https://github.com/christophehurpeau/pob/commit/18aedb1c3185b8410952fc382570df06d686bc80))
+
+
+### Bug Fixes
+
+* allow @babel/preset-env for rollup plugins ([272766e](https://github.com/christophehurpeau/pob/commit/272766e0d2083e6dc638bc630cd5e73e88a47095))
+* requires first node 18 lts version, 18.12 ([70c105a](https://github.com/christophehurpeau/pob/commit/70c105a72a328498dd20804ade6f1622b4430835))
+
+
+
 ## [13.1.0](https://github.com/christophehurpeau/pob/compare/pob@13.0.2...pob@13.1.0) (2023-06-27)
 
 

package/lib/generators/app/PobAppGenerator.js

@@ -1,5 +1,5 @@
-import { execSync } from 'child_process';
-import { platform } from 'process';
+import { execSync } from 'node:child_process';
+import { platform } from 'node:process';
 import Generator from 'yeoman-generator';
 import inLerna from '../../utils/inLerna.js';
 import * as packageUtils from '../../utils/package.js';
@@ -15,26 +15,26 @@ export default class PobAppGenerator extends Generator {
     this.option('updateOnly', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Avoid asking questions',
     });
 
     this.option('fromPob', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
     });
 
     this.option('packageManager', {
       type: String,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn or npm',
     });
 
     this.option('yarnNodeLinker', {
       type: String,
       required: false,
-      defaults: 'node-modules',
+      default: 'node-modules',
       desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
     });
   }
@@ -281,5 +281,7 @@ export default class PobAppGenerator extends Generator {
     }
 
     this.fs.writeJSON(this.destinationPath('package.json'), pkg);
+
+    this.composeWith('pob:core:sort-package');
   }
 }

package/lib/generators/app/nextjs/AppNextjsGenerator.js

@@ -8,7 +8,7 @@ export default class AppNextjsGenerator extends Generator {
     this.option('export', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Use next export.',
     });
   }

package/lib/generators/common/babel/CommonBabelGenerator.js

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import semver from 'semver';
 import Generator from 'yeoman-generator';
 import * as packageUtils from '../../../utils/package.js';
@@ -11,39 +11,39 @@ export default class CommonBabelGenerator extends Generator {
     this.option('updateOnly', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Avoid asking questions',
     });
 
     this.option('testing', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Has testing.',
     });
 
     this.option('fromPob', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
     });
 
     this.option('isApp', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
     });
 
     this.option('useAppConfig', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
     });
 
     this.option('buildDirectory', {
       type: String,
       required: false,
-      defaults: 'dist',
+      default: 'dist',
     });
   }
 
@@ -370,7 +370,9 @@ export default class CommonBabelGenerator extends Generator {
       pkg,
       this.babelEnvs.find(
         (env) => env.target === 'browser' && env.version === undefined,
-      ),
+      ) ||
+        (pkg.devDependencies?.['@babel/preset-env'] &&
+          pkg.name.includes('rollup-plugin')),
       ['@babel/preset-env'],
     );
 
@@ -388,10 +390,10 @@ export default class CommonBabelGenerator extends Generator {
         case '12':
         case '14':
         case '16':
-          pkg.engines.node = '>=16.0.0';
+          pkg.engines.node = '>=16.12.0';
           break;
         case '18':
-          pkg.engines.node = '>=18.0.0';
+          pkg.engines.node = '>=18.12.0';
           break;
         default:
           throw new Error(`Invalid min node version: ${minNodeVersion}`);
@@ -414,7 +416,7 @@ export default class CommonBabelGenerator extends Generator {
       packageUtils.removeDependencies(pkg, ['@types/node']);
       packageUtils.removeDevDependencies(pkg, ['@types/node']);
       // Supports oldest current or active LTS version of node
-      pkg.engines.node = '>=18.0.0';
+      pkg.engines.node = '>=18.12.0';
     }
 
     /* browserslist */

package/lib/generators/common/babel/templates/app.rollup.config.mjs.ejs

@@ -1,5 +1,5 @@
-import { dirname } from 'path';
-import { fileURLToPath } from 'url';
+import { dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
 <% if (config) { -%>
 import config from 'alp-rollup-plugin-config';
 <% } -%>

package/lib/generators/common/babel/templates/lib.rollup.config.mjs.ejs

@@ -1,5 +1,5 @@
-import { dirname } from 'path';
-import { fileURLToPath } from 'url';
+import { dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import createRollupConfig from 'pob-babel/createRollupConfig.js';
 
 export default createRollupConfig({

package/lib/generators/common/format-lint/CommonLintGenerator.js

@@ -1,5 +1,5 @@
-import fs from 'fs';
-import path from 'path';
+import fs from 'node:fs';
+import path from 'node:path';
 import Generator from 'yeoman-generator';
 import ensureJsonFileFormatted from '../../../utils/ensureJsonFileFormatted.js';
 import inLerna from '../../../utils/inLerna.js';
@@ -15,49 +15,49 @@ export default class CommonLintGenerator extends Generator {
     this.option('monorepo', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       description: 'Is root monorepo',
     });
 
     this.option('isApp', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       description: 'Is app',
     });
 
     this.option('babel', {
       type: String,
       required: false,
-      defaults: 'undefined',
+      default: 'undefined',
       desc: 'Use babel.',
     });
 
     this.option('documentation', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Documentation enabled',
     });
 
     this.option('typescript', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Typescript enabled',
     });
 
     this.option('enableSrcResolver', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Enable resolving from src directory',
     });
 
     this.option('rootAsSrc', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'src directory is root',
     });
 
@@ -70,34 +70,34 @@ export default class CommonLintGenerator extends Generator {
     this.option('rootIgnorePaths', {
       type: String,
       required: false,
-      defaults: '',
+      default: '',
       desc: 'list of ignore paths to add',
     });
 
     this.option('ignorePaths', {
       type: String,
       required: false,
-      defaults: '',
+      default: '',
       desc: 'list of ignore paths to add',
     });
 
     this.option('packageManager', {
       type: String,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn or npm',
     });
 
     this.option('yarnNodeLinker', {
       type: String,
       required: false,
-      defaults: 'node-modules',
+      default: 'node-modules',
       desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
     });
 
     this.option('buildDirectory', {
       type: String,
       required: false,
-      defaults: 'dist',
+      default: 'dist',
     });
   }
 
@@ -466,8 +466,8 @@ export default class CommonLintGenerator extends Generator {
         );
 
         writeAndFormatJson(this.fs, rootEslintrcPath, rootEslintrcConfig);
-      } catch (err) {
-        console.warn(`Could not parse/edit ${rootEslintrcPath}: `, err);
+      } catch (error) {
+        console.warn(`Could not parse/edit ${rootEslintrcPath}: `, error);
       }
     }
     // no else: dont delete root eslintrc, src is root
@@ -512,8 +512,8 @@ export default class CommonLintGenerator extends Generator {
         );
 
         writeAndFormatJson(this.fs, srcEslintrcPath, srcEslintrcConfig);
-      } catch (err) {
-        console.warn(`Could not parse/edit ${srcEslintrcPath}: `, err);
+      } catch (error) {
+        console.warn(`Could not parse/edit ${srcEslintrcPath}: `, error);
       }
     }
 

package/lib/generators/common/husky/CommonHuskyGenerator.js

@@ -1,4 +1,4 @@
-import { readlinkSync, rmSync } from 'fs';
+import { readlinkSync, rmSync } from 'node:fs';
 import Generator from 'yeoman-generator';
 import inLerna from '../../../utils/inLerna.js';
 import * as packageUtils from '../../../utils/package.js';
@@ -10,7 +10,7 @@ export default class CommonHuskyGenerator extends Generator {
     this.option('destination', {
       type: String,
       required: false,
-      defaults: '',
+      default: '',
       desc: 'Destination of the generated files.',
     });
   }

package/lib/generators/common/release/CommonReleaseGenerator.js

@@ -14,7 +14,7 @@ export default class CommonReleaseGenerator extends Generator {
     this.option('withBabel', {
       type: Boolean,
       required: false,
-      defaults: undefined,
+      default: undefined,
       desc: 'Babel enabled.',
     });
 
@@ -27,7 +27,7 @@ export default class CommonReleaseGenerator extends Generator {
     this.option('updateOnly', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Avoid asking questions',
     });
   }

package/lib/generators/common/testing/CommonTestingGenerator.js

@@ -10,25 +10,25 @@ export default class CommonTestingGenerator extends Generator {
 
     this.option('monorepo', {
       type: Boolean,
-      defaults: false,
+      default: false,
       desc: 'is root monorepo',
     });
 
     this.option('enable', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable testing',
     });
 
     this.option('runner', {
       type: String,
-      defaults: 'jest',
+      default: 'jest',
       desc: 'test runner (jest or node)',
     });
 
     this.option('enableReleasePlease', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable release-please',
     });
 
@@ -64,7 +64,7 @@ export default class CommonTestingGenerator extends Generator {
 
     this.option('packageManager', {
       type: String,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn or npm',
     });
 

package/lib/generators/common/typescript/CommonTypescriptGenerator.js

@@ -1,4 +1,4 @@
-import { existsSync } from 'fs';
+import { existsSync } from 'node:fs';
 import Generator from 'yeoman-generator';
 import inLerna from '../../../utils/inLerna.js';
 import * as packageUtils from '../../../utils/package.js';
@@ -10,67 +10,67 @@ export default class CommonTypescriptGenerator extends Generator {
 
     this.option('enable', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable typescript',
     });
 
     this.option('rootDir', {
       type: String,
-      defaults: 'src',
+      default: 'src',
       desc: 'customize rootDir',
     });
 
     this.option('srcDir', {
       type: String,
-      defaults: 'src',
+      default: 'src',
       desc: 'customize srcDir, if different than rootDir',
     });
 
     this.option('jsx', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable jsx with typescript',
     });
 
     this.option('jsxPreserve', {
       type: Boolean,
-      defaults: false,
+      default: false,
       desc: 'force jsx preserve in tsconfig for legacy apps (nextjs, CRA)',
     });
 
     this.option('forceExcludeNodeModules', {
       type: Boolean,
-      defaults: false,
+      default: false,
       desc: 'force exclude node_modules for legacy apps (nextjs, CRA)',
     });
 
     this.option('forceAllowJs', {
       type: Boolean,
-      defaults: false,
+      default: false,
       desc: 'force allow js for legacy apps (nextjs, CRA)',
     });
 
     this.option('dom', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable dom with typescript',
     });
 
     this.option('baseUrl', {
       type: String,
-      defaults: '',
+      default: '',
       desc: 'baseUrl option',
     });
 
     this.option('resolveJsonModule', {
       type: Boolean,
-      defaults: false,
+      default: false,
       desc: 'resolveJsonModule option',
     });
 
     this.option('builddefs', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'build .d.ts option',
     });
   }

package/lib/generators/core/ci/CoreCIGenerator.js

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import Generator from 'yeoman-generator';
 import inLerna from '../../../utils/inLerna.js';
 import * as packageUtils from '../../../utils/package.js';
@@ -12,31 +12,31 @@ export default class CoreCIGenerator extends Generator {
 
     this.option('enable', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable ci',
     });
 
     this.option('enableReleasePlease', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable release-please',
     });
 
     this.option('build', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable build',
     });
 
     this.option('typescript', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable typescript',
     });
 
     this.option('testing', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable testing',
     });
 

package/lib/generators/core/clean/CoreCleanGenerator.js

@@ -7,7 +7,7 @@ export default class CoreCleanGenerator extends Generator {
     this.option('root', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Root package.',
     });
   }

package/lib/generators/core/git/CoreGitGenerator.js

@@ -10,7 +10,7 @@ export default class CoreGitGenerator extends Generator {
     this.option('shouldCreate', {
       type: Boolean,
       required: false,
-      defaults: '',
+      default: '',
       desc: 'Should create the repo on github',
     });
 

package/lib/generators/core/git/generators/github/CoreGitGithubGenerator.js

@@ -42,10 +42,10 @@ const configureProtectionRule = async (owner, repo, onlyLatestLTS) => {
       if (branch === 'master') {
         console.warn('You should rename your "master" branch to "main"');
       }
-    } catch (err) {
+    } catch (error) {
       if (branch === 'main') {
         console.error(`Failed to configure ${branch} branch protection`);
-        console.error(err.stack || err.message || err);
+        console.error(error.stack || error.message || error);
       }
     }
   }
@@ -69,7 +69,7 @@ export default class CoreGitGithubGenerator extends Generator {
     this.option('shouldCreate', {
       type: Boolean,
       required: false,
-      defaults: '',
+      default: '',
       desc: 'Should create the repo on github',
     });
 
@@ -126,16 +126,16 @@ export default class CoreGitGithubGenerator extends Generator {
               auto_init: false,
               ...githubRepoConfig,
             });
-          } catch (err) {
+          } catch (error) {
             console.error('Failed to create repository');
-            console.error(err.stack || err.message || err);
+            console.error(error.stack || error.message || error);
           }
         }
 
         const cwd = this.destinationPath();
         try {
           this.spawnCommandSync('git', ['add', '--all', '.'], { cwd });
-        } catch (err) {
+        } catch (error) {
           this.spawnCommandSync('git', ['init'], { cwd });
           this.spawnCommandSync('git', ['add', '--all', '.'], { cwd });
           this.spawnCommandSync(
@@ -149,7 +149,7 @@ export default class CoreGitGithubGenerator extends Generator {
             { cwd },
           );
           console.error('Failed to create repository');
-          console.error(err.stack || err.message || err);
+          console.error(error.stack || error.message || error);
         }
         this.spawnCommandSync(
           'git',
@@ -168,9 +168,9 @@ export default class CoreGitGithubGenerator extends Generator {
         // await gh.put(`/repos/${owner}/${repo}/topics`, {
         //   names: pkg.keywords,
         // });
-      } catch (err) {
+      } catch (error) {
         console.error('Failed to create github repository');
-        console.error(err.stack || err.message || err);
+        console.error(error.stack || error.message || error);
       }
     } else {
       console.log('sync github info');

package/lib/generators/core/gitignore/CoreGitignoreGenerator.js

@@ -7,49 +7,49 @@ export default class CoreGitignoreGenerator extends Generator {
     this.option('root', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Root package.',
     });
 
     this.option('documentation', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Documentation enabled.',
     });
 
     this.option('testing', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Testing enabled.',
     });
 
     this.option('withBabel', {
       type: Boolean,
       required: false,
-      defaults: undefined,
+      default: undefined,
       desc: 'Babel enabled.',
     });
 
     this.option('paths', {
       type: String,
       required: false,
-      defaults: '',
+      default: '',
       desc: 'Paths ignored.',
     });
 
     this.option('typescript', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Typescript use.',
     });
 
     this.option('buildInGit', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Build is saved in git.',
     });
   }

package/lib/generators/core/npm/CoreNpmGenerator.js

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import Generator from 'yeoman-generator';
 import inLerna from '../../../utils/inLerna.js';
 
@@ -9,19 +9,19 @@ export default class CoreNpmGenerator extends Generator {
     this.option('enable', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Enable npm',
     });
     this.option('ci', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Enabled ci',
     });
     this.option('testing', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Enabled testing',
     });
   }

package/lib/generators/core/package/CorePackageGenerator.js

@@ -1,5 +1,5 @@
-import fs from 'fs';
-import path from 'path';
+import fs from 'node:fs';
+import path from 'node:path';
 import askName from 'inquirer-npm-name';
 import Generator from 'yeoman-generator';
 import inLerna from '../../../utils/inLerna.js';
@@ -12,21 +12,21 @@ export default class CorePackageGenerator extends Generator {
     this.option('monorepo', {
       type: Boolean,
       required: true,
-      defaults: false,
+      default: false,
       desc: 'is monorepo',
     });
 
     this.option('isRoot', {
       type: Boolean,
       required: true,
-      defaults: false,
+      default: false,
       desc: 'is root',
     });
 
     this.option('private', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'private package',
     });
   }
@@ -37,7 +37,10 @@ export default class CorePackageGenerator extends Generator {
     if (!pkg.engines) pkg.engines = {};
 
     // dont override engines if set to latest
-    if (!pkg.engines.node || !pkg.engines.node.startsWith('>=18.')) {
+    if (
+      !pkg.engines.node ||
+      !(pkg.engines.node.startsWith('>=18.') && pkg.engines.node !== '>=18.0.0')
+    ) {
       // this might be overridden by babel generator
       pkg.engines.node = '>=18.12.0'; // .12.0 is the first lts node 18 version
     }
@@ -102,13 +105,13 @@ export default class CorePackageGenerator extends Generator {
           name: 'authorName',
           message: "Author's Name",
           when: !author || !author.name,
-          default: this.user.git.name(),
+          default: this.git.name(),
         },
         {
           name: 'authorEmail',
           message: "Author's Email",
           when: !author || !author.email,
-          default: this.user.git.email(),
+          default: this.git.email(),
         },
         {
           name: 'authorUrl',

package/lib/generators/core/renovate/CoreRenovateGenerator.js

@@ -9,21 +9,21 @@ export default class CoreRenovateGenerator extends Generator {
     this.option('disable', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'disable',
     });
 
     this.option('app', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'is app (instead of lib)',
     });
 
     this.option('updateOnly', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Avoid asking questions',
     });
   }

package/lib/generators/core/sort-package/CoreSortPackageGenerator.js

@@ -11,13 +11,4 @@ export default class CoreSortPackageGenerator extends Generator {
       packageUtils.sort(pkg),
     );
   }
-
-  end() {
-    const pkg = this.fs.readJSON(this.destinationPath('package.json'));
-    writeAndFormatJson(
-      this.fs,
-      this.destinationPath('package.json'),
-      packageUtils.sort(pkg),
-    );
-  }
 }

package/lib/generators/core/vscode/CoreVSCodeGenerator.js

@@ -9,42 +9,42 @@ export default class CoreVSCodeGenerator extends Generator {
     this.option('root', {
       type: Boolean,
       required: false,
-      defaults: '',
+      default: '',
       desc: 'Is root',
     });
 
     this.option('packageManager', {
       type: String,
       required: false,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn|npm.',
     });
 
     this.option('monorepo', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'is monorepo',
     });
 
     this.option('testing', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Testing enabled',
     });
 
     this.option('yarnNodeLinker', {
       type: String,
       required: false,
-      defaults: 'node-modules',
+      default: 'node-modules',
       desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
     });
 
     this.option('typescript', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Typescript enabled',
     });
 

package/lib/generators/core/yarn/CoreYarnGenerator.js

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import yml from 'js-yaml';
 import Generator from 'yeoman-generator';
 import ensureJsonFileFormatted from '../../../utils/ensureJsonFileFormatted.js';
@@ -13,7 +13,7 @@ export default class CoreYarnGenerator extends Generator {
     this.option('type', {
       type: String,
       required: false,
-      defaults: 'app',
+      default: 'app',
       desc: 'Project type',
     });
 
@@ -26,7 +26,7 @@ export default class CoreYarnGenerator extends Generator {
     this.option('yarnNodeLinker', {
       type: String,
       required: false,
-      defaults: 'node-modules',
+      default: 'node-modules',
       desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
     });
   }

package/lib/generators/lib/PobLibGenerator.js

@@ -1,4 +1,4 @@
-import fs, { rmSync } from 'fs';
+import fs, { rmSync } from 'node:fs';
 import Generator from 'yeoman-generator';
 import inLerna from '../../utils/inLerna.js';
 import * as packageUtils from '../../utils/package.js';
@@ -10,26 +10,26 @@ export default class PobLibGenerator extends Generator {
     this.option('updateOnly', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Avoid asking questions',
     });
 
     this.option('fromPob', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
     });
 
     this.option('packageManager', {
       type: String,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn or npm',
     });
 
     this.option('yarnNodeLinker', {
       type: String,
       required: false,
-      defaults: 'node-modules',
+      default: 'node-modules',
       desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
     });
   }
@@ -397,5 +397,7 @@ export default class PobLibGenerator extends Generator {
 
     this.config.set('lib', pobjson);
     this.config.save();
+
+    this.composeWith('pob:core:sort-package');
   }
 }

package/lib/generators/lib/doc/LibDocGenerator.js

@@ -10,27 +10,27 @@ export default class LibDocGenerator extends Generator {
     this.option('enabled', {
       type: Boolean,
       required: false,
-      defaults: true,
+      default: true,
       desc: 'Enabled.',
     });
 
     this.option('testing', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Coverage.',
     });
 
     this.option('packageManager', {
       type: String,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn or npm',
     });
 
     this.option('packageNames', {
       type: String,
       required: false,
-      defaults: '{}',
+      default: '{}',
     });
   }
 

package/lib/generators/lib/readme/LibReadmeGenerator.js

@@ -101,9 +101,9 @@ export default class LibReadmeGenerator extends Generator {
           content,
         },
       );
-    } catch (err) {
-      console.log(err.stack || err.message || err);
-      throw err;
+    } catch (error) {
+      console.log(error.stack || error.message || error);
+      throw error;
     }
   }
 }

package/lib/generators/monorepo/PobMonorepoGenerator.js

@@ -1,7 +1,7 @@
-import { execSync } from 'child_process';
-import fs from 'fs';
-import path from 'path';
-import { platform } from 'process';
+import { execSync } from 'node:child_process';
+import fs from 'node:fs';
+import path from 'node:path';
+import { platform } from 'node:process';
 import { PackageGraph } from '@lerna/package-graph';
 import { Project as LernaProject } from '@lerna/project';
 import Generator from 'yeoman-generator';
@@ -50,27 +50,27 @@ export default class PobMonorepoGenerator extends Generator {
     this.option('updateOnly', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'Avoid asking questions',
     });
 
     this.option('isAppProject', {
       type: Boolean,
       required: false,
-      defaults: false,
+      default: false,
       desc: 'app project, no pusblishing on npm',
     });
 
     this.option('packageManager', {
       type: String,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn or npm',
     });
 
     this.option('yarnNodeLinker', {
       type: String,
       required: false,
-      defaults: 'pnp',
+      default: 'pnp',
       desc: 'Defines what linker should be used for installing Node packages (useful to enable the node-modules plugin), one of: pnp, node-modules.',
     });
 
@@ -134,6 +134,7 @@ export default class PobMonorepoGenerator extends Generator {
 
   async prompting() {
     const config = this.config.get('monorepo');
+
     if (this.options.updateOnly && config) {
       this.pobLernaConfig = config;
       this.pobLernaConfig.packageNames = this.packageNames;
@@ -342,6 +343,8 @@ export default class PobMonorepoGenerator extends Generator {
       ]);
       this.fs.writeJSON(this.destinationPath('package.json'), pkg);
     }
+
+    this.composeWith('pob:core:sort-package');
   }
 
   end() {

package/lib/generators/monorepo/lerna/MonorepoLernaGenerator.js

@@ -1,5 +1,5 @@
-import { spawnSync } from 'child_process';
-import { readdirSync, existsSync } from 'fs';
+import { spawnSync } from 'node:child_process';
+import { readdirSync, existsSync } from 'node:fs';
 import Generator from 'yeoman-generator';
 import * as packageUtils from '../../../utils/package.js';
 import {
@@ -13,13 +13,13 @@ export default class MonorepoLernaGenerator extends Generator {
 
     this.option('isAppProject', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'is app project',
     });
 
     this.option('packageManager', {
       type: String,
-      defaults: 'yarn',
+      default: 'yarn',
       desc: 'yarn or npm',
     });
   }

package/lib/generators/monorepo/typescript/MonorepoTypescriptGenerator.js

@@ -8,13 +8,13 @@ export default class MonorepoTypescriptGenerator extends Generator {
 
     this.option('enable', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'enable typescript',
     });
 
     this.option('isAppProject', {
       type: Boolean,
-      defaults: true,
+      default: true,
       desc: 'app project, no building definitions',
     });
 

package/lib/generators/pob/PobBaseGenerator.js

@@ -1,4 +1,4 @@
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 import Generator from 'yeoman-generator';
 import ensureJsonFileFormatted from '../../utils/ensureJsonFileFormatted.js';
 import inLerna from '../../utils/inLerna.js';
@@ -231,10 +231,6 @@ export default class PobBaseGenerator extends Generator {
     }
   }
 
-  writing() {
-    this.composeWith('pob:core:sort-package');
-  }
-
   install() {
     if (this.options.fromPob) return;
 

package/lib/pob.js

@@ -1,16 +1,16 @@
 #!/usr/bin/env node
 
-import { execSync, spawnSync } from 'child_process';
+import { execSync, spawnSync } from 'node:child_process';
 import fs, {
   existsSync,
   writeFileSync,
   readFileSync,
   mkdirSync,
   readdirSync,
-} from 'fs';
-import path from 'path';
+} from 'node:fs';
+import path from 'node:path';
 import minimist from 'minimist';
-import yeoman from 'yeoman-environment';
+import * as yeoman from 'yeoman-environment';
 import PobAppGenerator from './generators/app/PobAppGenerator.js';
 import AppNextjsGenerator from './generators/app/nextjs/AppNextjsGenerator.js';
 import AppRemixGenerator from './generators/app/remix/AppRemixGenerator.js';
@@ -330,9 +330,9 @@ const options = {
 
 try {
   await env.run('pob', options);
-} catch (err) {
-  if (err) {
-    console.error(err.stack || err.message || err);
+} catch (error) {
+  if (error) {
+    console.error(error.stack || error.message || error);
     process.exit(1);
   }
 }

package/lib/utils/ensureJsonFileFormatted.js

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import sortPkg from '@pob/sort-pkg';
 import prettier from 'prettier';
 

package/lib/utils/inLerna.js

@@ -1,5 +1,5 @@
-import fs from 'fs';
-import path from 'path';
+import fs from 'node:fs';
+import path from 'node:path';
 import findup from 'findup-sync';
 
 const lernaJsonPath = findup('lerna.json');

package/lib/utils/inNpmLerna.js

@@ -1,4 +1,4 @@
-import { readFileSync } from 'fs';
+import { readFileSync } from 'node:fs';
 import inLerna from './inLerna.js';
 
 export default inLerna &&

package/lib/utils/package.js

@@ -154,7 +154,6 @@ const internalAddDependencies = (pkg, type, dependencies, cleaned, prefix) => {
       try {
         if (currentVersion === 'workspace:*') {
           // the package is in the monorepo
-          return;
         } else if (
           !currentVersion ||
           semver.gt(potentialNewVersionCleaned, cleanVersion(currentVersion))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pob",
-  "version": "13.1.0",
+  "version": "13.2.1",
   "description": "Pile of bones, library generator with git/babel/typescript/typedoc/readme/jest",
   "keywords": [
     "skeleton"
@@ -18,7 +18,7 @@
   },
   "type": "module",
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.12.0"
   },
   "main": "./lib/index.js",
   "exports": {
@@ -38,33 +38,35 @@
   "dependencies": {
     "@lerna/package-graph": "5.5.4",
     "@lerna/project": "5.5.4",
-    "@pob/eslint-config": "50.0.5",
-    "@pob/eslint-config-typescript": "50.0.5",
-    "@pob/eslint-config-typescript-react": "50.0.5",
-    "@pob/sort-eslint-config": "5.0.0",
-    "@pob/sort-object": "6.0.0",
-    "@pob/sort-pkg": "6.0.0",
-    "eslint": "8.41.0",
+    "@pob/eslint-config": "51.0.0",
+    "@pob/eslint-config-typescript": "51.0.0",
+    "@pob/eslint-config-typescript-react": "51.0.0",
+    "@pob/sort-eslint-config": "5.0.1",
+    "@pob/sort-object": "6.0.1",
+    "@pob/sort-pkg": "6.0.1",
+    "@types/inquirer": "9.0.3",
+    "@yeoman/types": "1.0.1",
+    "eslint": "8.43.0",
     "findup-sync": "^5.0.0",
     "git-remote-url": "^1.0.1",
-    "github-username": "^6.0.0",
+    "github-username": "^7.0.0",
     "inquirer-npm-name": "^4.0.0",
     "js-yaml": "^4.1.0",
     "json5": "^2.2.2",
     "lodash.camelcase": "^4.3.0",
     "lodash.kebabcase": "^4.1.1",
-    "mem-fs": "2.3.0",
-    "mem-fs-editor": "9.7.0",
+    "mem-fs": "3.0.0",
+    "mem-fs-editor": "10.0.2",
     "minimist": "1.2.8",
     "parse-author": "2.0.0",
-    "pob-dependencies": "8.1.0",
+    "pob-dependencies": "8.2.0",
     "prettier": "2.8.8",
     "semver": "7.5.3",
-    "yeoman-environment": "3.19.3",
-    "yeoman-generator": "5.9.0"
+    "yeoman-environment": "4.0.0-beta.3",
+    "yeoman-generator": "6.0.0-rc.2"
   },
   "devDependencies": {
-    "@pob/root": "8.0.1"
+    "@pob/root": "8.1.0"
   },
-  "gitHead": "7632ede9dd93eeae6b75191c9a57ebbd5fe6d3d5"
+  "gitHead": "50ac1b294ff44983612066212dfe454c62e9467e"
 }